Cleanup TODOs in project
This commit is contained in:
parent
0dacbce6f2
commit
3033ef41c8
|
|
@ -15,7 +15,6 @@ use Illuminate\Support\Facades\DB;
|
||||||
|
|
||||||
class EnterScore
|
class EnterScore
|
||||||
{
|
{
|
||||||
// TODO implement this action every place that can save a score
|
|
||||||
/**
|
/**
|
||||||
* @param User $user A user acting as the judge for this sheet
|
* @param User $user A user acting as the judge for this sheet
|
||||||
* @param Entry $entry An entry to which this score should be assigned
|
* @param Entry $entry An entry to which this score should be assigned
|
||||||
|
|
|
||||||
|
|
@ -39,7 +39,6 @@ class DoublerService
|
||||||
*/
|
*/
|
||||||
protected function findDoublersForEvent(Event $event, string $mode = 'seating'): array
|
protected function findDoublersForEvent(Event $event, string $mode = 'seating'): array
|
||||||
{
|
{
|
||||||
// TODO add scoped entry queries to the event model
|
|
||||||
$this->validateEvent($event);
|
$this->validateEvent($event);
|
||||||
$entries = $event->entries()->with('audition')->with('student')->get();
|
$entries = $event->entries()->with('audition')->with('student')->get();
|
||||||
$entries = match ($mode) {
|
$entries = match ($mode) {
|
||||||
|
|
|
||||||
|
|
@ -3,7 +3,6 @@
|
||||||
namespace Database\Seeders;
|
namespace Database\Seeders;
|
||||||
|
|
||||||
use App\Models\Event;
|
use App\Models\Event;
|
||||||
use Illuminate\Database\Console\Seeds\WithoutModelEvents;
|
|
||||||
use Illuminate\Database\Seeder;
|
use Illuminate\Database\Seeder;
|
||||||
use Illuminate\Support\Facades\DB;
|
use Illuminate\Support\Facades\DB;
|
||||||
|
|
||||||
|
|
@ -13,9 +12,9 @@ class AuditionSeeder extends Seeder
|
||||||
* Run the database seeds.
|
* Run the database seeds.
|
||||||
*/
|
*/
|
||||||
public function run(): void
|
public function run(): void
|
||||||
{ //TODO: Seed scoring guides for the auditions - Probably need percussion and wind
|
{
|
||||||
$event = Event::factory()->create([
|
$event = Event::factory()->create([
|
||||||
'name' => 'Concert Band Auditions'
|
'name' => 'Concert Band Auditions',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
$instruments = [
|
$instruments = [
|
||||||
|
|
@ -34,7 +33,7 @@ class AuditionSeeder extends Seeder
|
||||||
'Euphonium',
|
'Euphonium',
|
||||||
'Tuba',
|
'Tuba',
|
||||||
'String Bass',
|
'String Bass',
|
||||||
'Percussion'
|
'Percussion',
|
||||||
];
|
];
|
||||||
$levels = ['HS', 'JH', '7th'];
|
$levels = ['HS', 'JH', '7th'];
|
||||||
$n = 1;
|
$n = 1;
|
||||||
|
|
@ -58,7 +57,7 @@ class AuditionSeeder extends Seeder
|
||||||
'entry_deadline' => '2040-12-31',
|
'entry_deadline' => '2040-12-31',
|
||||||
'entry_fee' => '1000',
|
'entry_fee' => '1000',
|
||||||
'minimum_grade' => $minGrade,
|
'minimum_grade' => $minGrade,
|
||||||
'maximum_grade' => $maxGrade
|
'maximum_grade' => $maxGrade,
|
||||||
]);
|
]);
|
||||||
$n++;
|
$n++;
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -10,7 +10,6 @@
|
||||||
</x-delete-resource-modal>
|
</x-delete-resource-modal>
|
||||||
@endif
|
@endif
|
||||||
</x-slot:right_side>
|
</x-slot:right_side>
|
||||||
{{-- TODO implement a way to update multiple auditions as once --}}
|
|
||||||
</x-card.heading>
|
</x-card.heading>
|
||||||
<x-form.form method="PATCH" action="/admin/auditions/{{ $audition->id }}">
|
<x-form.form method="PATCH" action="/admin/auditions/{{ $audition->id }}">
|
||||||
<x-form.body-grid columns="12" class="pb-1 pt-3">
|
<x-form.body-grid columns="12" class="pb-1 pt-3">
|
||||||
|
|
|
||||||
|
|
@ -94,4 +94,3 @@
|
||||||
|
|
||||||
|
|
||||||
</x-layout.app>
|
</x-layout.app>
|
||||||
{{--TODO add options to filter the page--}}
|
|
||||||
|
|
|
||||||
|
|
@ -104,4 +104,3 @@
|
||||||
{{ $entries->links('vendor.pagination.simple-audition') }}
|
{{ $entries->links('vendor.pagination.simple-audition') }}
|
||||||
</div>
|
</div>
|
||||||
</x-layout.app>
|
</x-layout.app>
|
||||||
{{--TODO add options to filter the page--}}
|
|
||||||
|
|
|
||||||
|
|
@ -28,4 +28,3 @@
|
||||||
</form>
|
</form>
|
||||||
</x-layout.app>
|
</x-layout.app>
|
||||||
|
|
||||||
{{--TODO when an entry is made anywhere in the system, there needs to be a check if a draw needs to be run--}}
|
|
||||||
|
|
|
||||||
|
|
@ -34,4 +34,3 @@
|
||||||
{{ $students->links('vendor.pagination.simple-audition') }}
|
{{ $students->links('vendor.pagination.simple-audition') }}
|
||||||
</div>
|
</div>
|
||||||
</x-layout.app>
|
</x-layout.app>
|
||||||
{{--TODO add options to filter the page--}}
|
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue