Cleanup TODOs in project

This commit is contained in:
Matt Young 2024-07-16 12:50:29 -05:00
parent 0dacbce6f2
commit 3033ef41c8
8 changed files with 9 additions and 17 deletions

View File

@ -15,7 +15,6 @@ use Illuminate\Support\Facades\DB;
class EnterScore
{
// TODO implement this action every place that can save a score
/**
* @param User $user A user acting as the judge for this sheet
* @param Entry $entry An entry to which this score should be assigned

View File

@ -39,7 +39,6 @@ class DoublerService
*/
protected function findDoublersForEvent(Event $event, string $mode = 'seating'): array
{
// TODO add scoped entry queries to the event model
$this->validateEvent($event);
$entries = $event->entries()->with('audition')->with('student')->get();
$entries = match ($mode) {

View File

@ -3,7 +3,6 @@
namespace Database\Seeders;
use App\Models\Event;
use Illuminate\Database\Console\Seeds\WithoutModelEvents;
use Illuminate\Database\Seeder;
use Illuminate\Support\Facades\DB;
@ -13,9 +12,9 @@ class AuditionSeeder extends Seeder
* Run the database seeds.
*/
public function run(): void
{ //TODO: Seed scoring guides for the auditions - Probably need percussion and wind
{
$event = Event::factory()->create([
'name' => 'Concert Band Auditions'
'name' => 'Concert Band Auditions',
]);
$instruments = [
@ -34,7 +33,7 @@ class AuditionSeeder extends Seeder
'Euphonium',
'Tuba',
'String Bass',
'Percussion'
'Percussion',
];
$levels = ['HS', 'JH', '7th'];
$n = 1;
@ -58,7 +57,7 @@ class AuditionSeeder extends Seeder
'entry_deadline' => '2040-12-31',
'entry_fee' => '1000',
'minimum_grade' => $minGrade,
'maximum_grade' => $maxGrade
'maximum_grade' => $maxGrade,
]);
$n++;
}

View File

@ -10,7 +10,6 @@
</x-delete-resource-modal>
@endif
</x-slot:right_side>
{{-- TODO implement a way to update multiple auditions as once --}}
</x-card.heading>
<x-form.form method="PATCH" action="/admin/auditions/{{ $audition->id }}">
<x-form.body-grid columns="12" class="pb-1 pt-3">

View File

@ -94,4 +94,3 @@
</x-layout.app>
{{--TODO add options to filter the page--}}

View File

@ -104,4 +104,3 @@
{{ $entries->links('vendor.pagination.simple-audition') }}
</div>
</x-layout.app>
{{--TODO add options to filter the page--}}

View File

@ -28,4 +28,3 @@
</form>
</x-layout.app>
{{--TODO when an entry is made anywhere in the system, there needs to be a check if a draw needs to be run--}}

View File

@ -34,4 +34,3 @@
{{ $students->links('vendor.pagination.simple-audition') }}
</div>
</x-layout.app>
{{--TODO add options to filter the page--}}