From 0de7edf6e99226bf4f5c4aaa81f1e205835b758e Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 03:17:46 -0500
Subject: [PATCH 01/61] Work on Audition model test and Student index page

---
 app/Http/Middleware/CheckIfHasSchool.php  | 20 ++++++
 database/seeders/SampleSettingsSeeder.php | 77 +++++++++++++++++++++++
 tests/Feature/Pages/DashbaordTest.php     |  5 ++
 tests/Feature/Pages/StudentsIndexTest.php |  5 ++
 4 files changed, 107 insertions(+)
 create mode 100644 app/Http/Middleware/CheckIfHasSchool.php
 create mode 100644 database/seeders/SampleSettingsSeeder.php
 create mode 100644 tests/Feature/Pages/DashbaordTest.php
 create mode 100644 tests/Feature/Pages/StudentsIndexTest.php

diff --git a/app/Http/Middleware/CheckIfHasSchool.php b/app/Http/Middleware/CheckIfHasSchool.php
new file mode 100644
index 0000000..cc8b2b1
--- /dev/null
+++ b/app/Http/Middleware/CheckIfHasSchool.php
@@ -0,0 +1,20 @@
+<?php
+
+namespace App\Http\Middleware;
+
+use Closure;
+use Illuminate\Http\Request;
+use Symfony\Component\HttpFoundation\Response;
+
+class CheckIfHasSchool
+{
+    /**
+     * Handle an incoming request.
+     *
+     * @param  \Closure(\Illuminate\Http\Request): (\Symfony\Component\HttpFoundation\Response)  $next
+     */
+    public function handle(Request $request, Closure $next): Response
+    {
+        return $next($request);
+    }
+}
diff --git a/database/seeders/SampleSettingsSeeder.php b/database/seeders/SampleSettingsSeeder.php
new file mode 100644
index 0000000..254eced
--- /dev/null
+++ b/database/seeders/SampleSettingsSeeder.php
@@ -0,0 +1,77 @@
+<?php
+
+namespace Database\Seeders;
+
+use App\Models\SiteSetting;
+use Illuminate\Database\Console\Seeds\WithoutModelEvents;
+use Illuminate\Database\Seeder;
+
+class SampleSettings extends Seeder
+{
+    /**
+     * Run the database seeds.
+     */
+    public function run(): void
+    {
+        SiteSetting::create([
+            'setting_key' => 'auditionName',
+            'setting_value' => 'Somewhere Band Directors Association',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'auditionAbbreviation',
+            'setting_value' => 'SBDA',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'registrationCode',
+            'setting_value' => 'secret',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'advanceTo',
+            'setting_value' => 'OMEA',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'judging_enabled',
+            'setting_value' => '1',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'organizerName',
+            'setting_value' => 'John Doe',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'organizerEmail',
+            'setting_value' => 'jdoe@sbda.null',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'olympic_scoring',
+            'setting_value' => '0',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'fee_structure',
+            'setting_value' => 'oneFeePerEntry',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'late_fee',
+            'setting_value' => '1000',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'school_fee',
+            'setting_value' => 'SBDA',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'auditionAbbreviation',
+            'setting_value' => '2500',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'payment_address',
+            'setting_value' => '143 Sousa Lane',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'auditionAbbreviation',
+            'setting_value' => 'SBDA',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'auditionAbbreviation',
+            'setting_value' => 'SBDA',
+        ]);
+    }
+}
diff --git a/tests/Feature/Pages/DashbaordTest.php b/tests/Feature/Pages/DashbaordTest.php
new file mode 100644
index 0000000..0b4b43e
--- /dev/null
+++ b/tests/Feature/Pages/DashbaordTest.php
@@ -0,0 +1,5 @@
+<?php
+
+it('', function () {
+
+});
diff --git a/tests/Feature/Pages/StudentsIndexTest.php b/tests/Feature/Pages/StudentsIndexTest.php
new file mode 100644
index 0000000..0b4b43e
--- /dev/null
+++ b/tests/Feature/Pages/StudentsIndexTest.php
@@ -0,0 +1,5 @@
+<?php
+
+it('', function () {
+
+});
-- 
2.39.5


From f400b2bda5189d91e7a4234a13f7b7005ec8cdb5 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 08:14:30 -0500
Subject: [PATCH 02/61] Finish Audition model test and student index. Finish
 AuditionFlag model test

---
 app/Http/Controllers/StudentController.php    |  44 ++++--
 app/Http/Middleware/CheckIfAdmin.php          |   2 +-
 app/Http/Middleware/CheckIfHasSchool.php      |  10 +-
 app/Models/Audition.php                       |   5 +-
 app/Policies/StudentPolicy.php                |  17 ++-
 app/Rules/UniqueFullNameAtSchool.php          |   6 +-
 database/factories/AuditionFactory.php        |   2 +-
 database/factories/RoomFactory.php            |   4 +-
 database/factories/ScoringGuideFactory.php    |   2 +-
 database/seeders/SampleSettingsSeeder.php     |  18 +--
 .../layout/navbar/menus/admin.blade.php       |   2 +-
 .../components/layout/navbar/navbar.blade.php |  11 +-
 resources/views/dashboard/dashboard.blade.php |   2 +-
 routes/user.php                               |  32 ++---
 tests/Feature/Models/AuditionFlagTest.php     |  21 +++
 tests/Feature/Models/AuditionTest.php         | 105 ++++++++++++++
 tests/Feature/Pages/DashbaordTest.php         |  53 ++++++-
 tests/Feature/Pages/StudentsIndexTest.php     | 131 +++++++++++++++++-
 tests/Feature/PagesResponseTest.php           |  15 ++
 19 files changed, 418 insertions(+), 64 deletions(-)
 create mode 100644 tests/Feature/Models/AuditionFlagTest.php

diff --git a/app/Http/Controllers/StudentController.php b/app/Http/Controllers/StudentController.php
index be1b021..f4d1186 100644
--- a/app/Http/Controllers/StudentController.php
+++ b/app/Http/Controllers/StudentController.php
@@ -5,10 +5,10 @@ namespace App\Http\Controllers;
 use App\Models\Audition;
 use App\Models\School;
 use App\Models\Student;
-use App\Models\User;
 use App\Rules\UniqueFullNameAtSchool;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
+
 use function abort;
 use function redirect;
 
@@ -20,9 +20,13 @@ class StudentController extends Controller
      */
     public function index()
     {
+        if (! Auth::user()->school_id) {
+            return redirect()->route('dashboard');
+        }
         $students = Auth::user()->students()->with('entries')->get();
         $auditions = Audition::all();
-        return view('students.index',['students' => $students, 'auditions' => $auditions]);
+
+        return view('students.index', ['students' => $students, 'auditions' => $auditions]);
     }
 
     /**
@@ -38,21 +42,26 @@ class StudentController extends Controller
      */
     public function store(Request $request)
     {
-        if ($request->user()->cannot('create', Student::class)) abort(403);
+        if ($request->user()->cannot('create', Student::class)) {
+            abort(403);
+        }
         $request->validate([
             'first_name' => ['required'],
-            'last_name'  => ['required', new UniqueFullNameAtSchool(request('first_name'),request('last_name'), Auth::user()->school_id)],
-            'grade'      => ['required', 'integer'],
+            'last_name' => [
+                'required',
+                new UniqueFullNameAtSchool(request('first_name'), request('last_name'), Auth::user()->school_id),
+            ],
+            'grade' => ['required', 'integer'],
         ]);
 
         $student = Student::create([
             'first_name' => request('first_name'),
             'last_name' => request('last_name'),
             'grade' => request('grade'),
-            'school_id' => Auth::user()->school_id
+            'school_id' => Auth::user()->school_id,
         ]);
 
-        $request->session()->put('auditionMessages',['success','I did it again ma']);
+        $request->session()->put('auditionMessages', ['success', 'I did it again ma']);
 
         return redirect('/students');
     }
@@ -70,7 +79,10 @@ class StudentController extends Controller
      */
     public function edit(Request $request, Student $student)
     {
-        if ($request->user()->cannot('update', $student)) abort(403);
+        if ($request->user()->cannot('update', $student)) {
+            abort(403);
+        }
+
         return view('students.edit', ['student' => $student]);
     }
 
@@ -79,22 +91,23 @@ class StudentController extends Controller
      */
     public function update(Request $request, Student $student)
     {
-        if ($request->user()->cannot('update', $student)) abort(403);
+        if ($request->user()->cannot('update', $student)) {
+            abort(403);
+        }
         request()->validate([
             'first_name' => ['required'],
-            'last_name'  => ['required'],
-            'grade'      => ['required', 'integer'],
+            'last_name' => ['required'],
+            'grade' => ['required', 'integer'],
         ]);
 
         $student->update([
             'first_name' => request('first_name'),
             'last_name' => request('last_name'),
-            'grade' => request('grade')
+            'grade' => request('grade'),
         ]);
 
         //        TODO if a students grade is changed, we need to be sure they are still eligible for the auditions in which they are entered.
 
-
         return redirect('/students');
     }
 
@@ -103,8 +116,11 @@ class StudentController extends Controller
      */
     public function destroy(Request $request, Student $student)
     {
-        if ($request->user()->cannot('delete', $student)) abort(403);
+        if ($request->user()->cannot('delete', $student)) {
+            abort(403);
+        }
         $student->delete();
+
         return redirect('/students');
     }
 }
diff --git a/app/Http/Middleware/CheckIfAdmin.php b/app/Http/Middleware/CheckIfAdmin.php
index 36baeb2..69b2a37 100644
--- a/app/Http/Middleware/CheckIfAdmin.php
+++ b/app/Http/Middleware/CheckIfAdmin.php
@@ -20,7 +20,7 @@ class CheckIfAdmin
             return $next($request);
         }
 
-        return redirect('/')->with('error', 'You do not have admin access.');
+        return redirect(route('home'))->with('error', 'You do not have admin access.');
 
     }
 }
diff --git a/app/Http/Middleware/CheckIfHasSchool.php b/app/Http/Middleware/CheckIfHasSchool.php
index cc8b2b1..c77dc33 100644
--- a/app/Http/Middleware/CheckIfHasSchool.php
+++ b/app/Http/Middleware/CheckIfHasSchool.php
@@ -4,7 +4,10 @@ namespace App\Http\Middleware;
 
 use Closure;
 use Illuminate\Http\Request;
+use Illuminate\Support\Facades\Auth;
 use Symfony\Component\HttpFoundation\Response;
+use function redirect;
+use function route;
 
 class CheckIfHasSchool
 {
@@ -15,6 +18,11 @@ class CheckIfHasSchool
      */
     public function handle(Request $request, Closure $next): Response
     {
-        return $next($request);
+        if (Auth::check() && Auth::user()->school_id) {
+            return $next($request);
+        }
+
+        return redirect(route('dashboard'))->with('error', 'You do not have a school to view students for.');
+
     }
 }
diff --git a/app/Models/Audition.php b/app/Models/Audition.php
index 66be60c..175c053 100644
--- a/app/Models/Audition.php
+++ b/app/Models/Audition.php
@@ -10,8 +10,6 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
 use Illuminate\Database\Eloquent\Relations\BelongsToMany;
 use Illuminate\Database\Eloquent\Relations\HasMany;
 
-use function now;
-
 class Audition extends Model
 {
     use HasFactory;
@@ -26,7 +24,6 @@ class Audition extends Model
 
     protected $scored_entries_count; //Set by TabulationService
 
-
     public function event(): BelongsTo
     {
         return $this->belongsTo(Event::class);
@@ -175,12 +172,14 @@ class Audition extends Model
         }
 
         $this->flags()->create(['flag_name' => $flag]);
+        $this->load('flags');
     }
 
     public function removeFlag($flag): void
     {
         // remove related auditionFlag where flag_name = $flag
         $this->flags()->where('flag_name', $flag)->delete();
+        $this->load('flags');
     }
 
     public function scopeOpen(Builder $query): void
diff --git a/app/Policies/StudentPolicy.php b/app/Policies/StudentPolicy.php
index ae8e619..5ac1cf4 100644
--- a/app/Policies/StudentPolicy.php
+++ b/app/Policies/StudentPolicy.php
@@ -5,7 +5,7 @@ namespace App\Policies;
 use App\Models\Entry;
 use App\Models\Student;
 use App\Models\User;
-use Illuminate\Auth\Access\Response;
+
 use function is_null;
 
 class StudentPolicy
@@ -31,7 +31,10 @@ class StudentPolicy
      */
     public function create(User $user): bool
     {
-        if($user->is_admin) return true;
+        if ($user->is_admin) {
+            return true;
+        }
+
         return ! is_null($user->school_id);
     }
 
@@ -41,7 +44,10 @@ class StudentPolicy
     public function update(User $user, Student $student): bool
     {
 
-        if($user->is_admin) return true;
+        if ($user->is_admin) {
+            return true;
+        }
+
         return $user->school_id == $student->school_id;
     }
 
@@ -50,7 +56,10 @@ class StudentPolicy
      */
     public function delete(User $user, Student $student): bool
     {
-        if (Entry::where('student_id','=',$student->id)->exists()) return false; // Don't allow deletion of a student with entries
+        if (Entry::where('student_id', '=', $student->id)->exists()) {
+            return false;
+        } // Don't allow deletion of a student with entries
+
         return $user->school_id == $student->school_id;
     }
 
diff --git a/app/Rules/UniqueFullNameAtSchool.php b/app/Rules/UniqueFullNameAtSchool.php
index f67a8aa..29e78ad 100644
--- a/app/Rules/UniqueFullNameAtSchool.php
+++ b/app/Rules/UniqueFullNameAtSchool.php
@@ -19,7 +19,7 @@ class UniqueFullNameAtSchool implements ValidationRule
         $this->school_id = $schoolID;
     }
 
-    public function passes($attributies, $value)
+    public function studentExists()
     {
         return Student::where('first_name', $this->first_name)
             ->where('last_name', $this->last_name)
@@ -38,6 +38,8 @@ class UniqueFullNameAtSchool implements ValidationRule
      */
     public function validate(string $attribute, mixed $value, Closure $fail): void
     {
-        //
+        if($this->studentExists()) {
+            $fail($this->message());
+        }
     }
 }
diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index 4cefeff..494a378 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -41,7 +41,7 @@ class AuditionFactory extends Factory
 
         return [
             'event_id' => $event->id,
-            'name' => $this->faker->randomElement($instruments).$this->faker->randomNumber(1),
+            'name' => $this->faker->randomElement($instruments).$this->faker->randomNumber(3),
             'score_order' => 1,
             'entry_deadline' => Carbon::tomorrow(),
             'entry_fee' => 1000,
diff --git a/database/factories/RoomFactory.php b/database/factories/RoomFactory.php
index de64aad..46acabf 100644
--- a/database/factories/RoomFactory.php
+++ b/database/factories/RoomFactory.php
@@ -17,8 +17,8 @@ class RoomFactory extends Factory
     public function definition(): array
     {
         return [
-            'name' => 'Room ' . fake()->numberBetween(7,500),
-            'description' => fake()->sentence()
+            'name' => 'Room '.fake()->numberBetween(7, 500),
+            'description' => fake()->sentence(),
         ];
     }
 }
diff --git a/database/factories/ScoringGuideFactory.php b/database/factories/ScoringGuideFactory.php
index 11339b3..9efa3d0 100644
--- a/database/factories/ScoringGuideFactory.php
+++ b/database/factories/ScoringGuideFactory.php
@@ -17,7 +17,7 @@ class ScoringGuideFactory extends Factory
     public function definition(): array
     {
         return [
-            //
+            'name' => $this->faker->sentence(3),
         ];
     }
 }
diff --git a/database/seeders/SampleSettingsSeeder.php b/database/seeders/SampleSettingsSeeder.php
index 254eced..26090a6 100644
--- a/database/seeders/SampleSettingsSeeder.php
+++ b/database/seeders/SampleSettingsSeeder.php
@@ -6,7 +6,7 @@ use App\Models\SiteSetting;
 use Illuminate\Database\Console\Seeds\WithoutModelEvents;
 use Illuminate\Database\Seeder;
 
-class SampleSettings extends Seeder
+class SampleSettingsSeeder extends Seeder
 {
     /**
      * Run the database seeds.
@@ -55,10 +55,6 @@ class SampleSettings extends Seeder
         ]);
         SiteSetting::create([
             'setting_key' => 'school_fee',
-            'setting_value' => 'SBDA',
-        ]);
-        SiteSetting::create([
-            'setting_key' => 'auditionAbbreviation',
             'setting_value' => '2500',
         ]);
         SiteSetting::create([
@@ -66,12 +62,16 @@ class SampleSettings extends Seeder
             'setting_value' => '143 Sousa Lane',
         ]);
         SiteSetting::create([
-            'setting_key' => 'auditionAbbreviation',
-            'setting_value' => 'SBDA',
+            'setting_key' => 'payment_city',
+            'setting_value' => 'Maud',
         ]);
         SiteSetting::create([
-            'setting_key' => 'auditionAbbreviation',
-            'setting_value' => 'SBDA',
+            'setting_key' => 'payment_state',
+            'setting_value' => 'OK',
+        ]);
+        SiteSetting::create([
+            'setting_key' => 'payment_zip',
+            'setting_value' => '77777',
         ]);
     }
 }
diff --git a/resources/views/components/layout/navbar/menus/admin.blade.php b/resources/views/components/layout/navbar/menus/admin.blade.php
index 21bc4b5..c0430d2 100644
--- a/resources/views/components/layout/navbar/menus/admin.blade.php
+++ b/resources/views/components/layout/navbar/menus/admin.blade.php
@@ -2,7 +2,7 @@
     {{--  <button type="button" class="inline-flex items-center gap-x-1 text-sm font-semibold leading-6 text-gray-900" aria-expanded="false" @on:click=" open = ! open">--}}
 
     <button type="button" class="inline-flex items-center gap-x-1 text-white rounded-md px-3 py-2 text-sm font-medium hover:bg-indigo-500 hover:bg-opacity-75" aria-expanded="false" @click=" open = ! open" @click.outside=" open = false">
-        <span>Admin</span>
+        <span>Administration</span>
         <svg class="h-5 w-5" viewBox="0 0 20 20" fill="currentColor" aria-hidden="true">
             <path fill-rule="evenodd" d="M5.23 7.21a.75.75 0 011.06.02L10 11.168l3.71-3.938a.75.75 0 111.08 1.04l-4.25 4.5a.75.75 0 01-1.08 0l-4.25-4.5a.75.75 0 01.02-1.06z" clip-rule="evenodd" />
         </svg>
diff --git a/resources/views/components/layout/navbar/navbar.blade.php b/resources/views/components/layout/navbar/navbar.blade.php
index 6cd7a36..95c3157 100644
--- a/resources/views/components/layout/navbar/navbar.blade.php
+++ b/resources/views/components/layout/navbar/navbar.blade.php
@@ -14,16 +14,16 @@
                 </div>
                 <div class="hidden md:block">
                     <div class="ml-10 flex items-baseline space-x-4">
-                        <x-layout.navbar.nav-link href="/dashboard" :active="request()->is('dashboard')">Dashboard
+                        <x-layout.navbar.nav-link href="{{ route('dashboard') }}" :active="request()->is('dashboard')">Dashboard
                         </x-layout.navbar.nav-link>
                         @if(Auth::user()->school_id)
-                            <x-layout.navbar.nav-link href="/students" :active="request()->is('students')">Students
+                            <x-layout.navbar.nav-link href="{{ route('students.index') }}" :active="request()->is('students')">Students
                             </x-layout.navbar.nav-link>
-                            <x-layout.navbar.nav-link href="/entries" :active="request()->is('entries')">Entries
+                            <x-layout.navbar.nav-link href="{{ route('entries.index') }}" :active="request()->is('entries')">Entries
                             </x-layout.navbar.nav-link>
                         @endif
                         @if(Auth::user()->isJudge() AND Settings::get('judging_enabled'))
-                            <x-layout.navbar.nav-link href="/judging" :active="request()->is('judging')">Judging
+                            <x-layout.navbar.nav-link href="{{ route('judging.index') }}" :active="request()->is('judging')">Judging
                             </x-layout.navbar.nav-link>
                         @endif
                         @if(Auth::user()->is_admin)
@@ -164,8 +164,7 @@
             <!-- Current: "bg-indigo-700 text-white", Default: "text-white hover:bg-indigo-500 hover:bg-opacity-75" -->
             <a href="/dashboard" class="bg-indigo-700 text-white block rounded-md px-3 py-2 text-base font-medium"
                aria-current="page">Dashboard</a>
-            <a href="/students"
-               class="text-white hover:bg-indigo-500 hover:bg-opacity-75 block rounded-md px-3 py-2 text-base font-medium">Students</a>
+
         </div>
         <div class="border-t border-indigo-700 pb-3 pt-4">
             <div class="flex items-center px-5">
diff --git a/resources/views/dashboard/dashboard.blade.php b/resources/views/dashboard/dashboard.blade.php
index 237d9f5..a75d84f 100644
--- a/resources/views/dashboard/dashboard.blade.php
+++ b/resources/views/dashboard/dashboard.blade.php
@@ -2,7 +2,7 @@
 <x-layout.app>
     <x-slot:page_title>Dashboard</x-slot:page_title>
     @if(! Auth::user()->school_id)
-        You aren't currently associated with a school. <a href="/my_school" class="text-blue-600">Click here to choose or create one.</a>
+        <p class="pb-5">You aren't currently associated with a school. <a href="/my_school" class="text-blue-600">Click here to choose or create one.</a></p>
     @endif
     <div class="grid sm:grid-cols-2 md:grid-cols-4">
         <div>{{-- Column 1 --}}
diff --git a/routes/user.php b/routes/user.php
index 708538a..ffeace0 100644
--- a/routes/user.php
+++ b/routes/user.php
@@ -19,32 +19,32 @@ Route::middleware(['auth', 'verified'])->group(function () {
 
 // Entry Related Routes
 Route::middleware(['auth', 'verified', 'can:create,App\Models\Entry'])->controller(EntryController::class)->group(function () {
-    Route::get('/entries', 'index');
-    Route::get('/entries/create', 'create');
-    Route::post('/entries', 'store');
-    Route::delete('/entries/{entry}', 'destroy');
+    Route::get('/entries', 'index')->name('entries.index');
+    Route::get('/entries/create', 'create')->name('entries.create');
+    Route::post('/entries', 'store')->name('entries.store');
+    Route::delete('/entries/{entry}', 'destroy')->name('entries.destroy');
 });
 
 // User Related Routes
 Route::middleware(['auth', 'verified'])->controller(UserController::class)->group(function () {
-    Route::patch('/users/{user}/set_school', 'set_school');
-    Route::patch('/users/{$user}', 'update');
+    Route::patch('/users/{user}/set_school', 'set_school')->name('users.set_school');
+    Route::patch('/users/{$user}', 'update')->name('users.update');
 });
 
 // Student Related Routes
 Route::middleware(['auth', 'verified', 'can:create,App\Models\Student'])->controller(StudentController::class)->group(function () {
-    Route::get('/students', 'index');
-    Route::post('students', 'store');
-    Route::get('/students/{student}/edit', 'edit');
-    Route::patch('/students/{student}', 'update');
-    Route::delete('/students/{student}', 'destroy');
+    Route::get('/students', 'index')->name('students.index');
+    Route::post('students', 'store')->name('students.store');
+    Route::get('/students/{student}/edit', 'edit')->name('students.edit');
+    Route::patch('/students/{student}', 'update')->name('students.update');
+    Route::delete('/students/{student}', 'destroy')->name('students.destroy');
 });
 
 // School Related Routes
 Route::middleware(['auth', 'verified'])->controller(SchoolController::class)->group(function () {
-    Route::get('/schools/create', 'create');
-    Route::post('/schools', 'store');
-    Route::get('/schools/{school}/edit', 'edit');
-    Route::get('/schools/{school}', 'show')->name('schools.show');
-    Route::patch('/schools/{school}', 'update');
+    Route::get('/schools/create', 'create')->name('schools.create');
+    Route::post('/schools', 'store')->name('schools.store');
+    Route::get('/schools/{school}/edit', 'edit')->name('schools.edit');
+    Route::get('/schools/{school}', 'show')->name('schools.show')->name('schools.show');
+    Route::patch('/schools/{school}', 'update')->name('schools.update');
 });
diff --git a/tests/Feature/Models/AuditionFlagTest.php b/tests/Feature/Models/AuditionFlagTest.php
new file mode 100644
index 0000000..67d2d35
--- /dev/null
+++ b/tests/Feature/Models/AuditionFlagTest.php
@@ -0,0 +1,21 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\AuditionFlag;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+test('has an audition', function () {
+
+    $audition = Audition::factory()->create();
+    // Arrange
+    $flag = AuditionFlag::create([
+        'audition_id' => $audition->id,
+        'flag_name' => 'Test Flag',
+    ]);
+
+    // Act and Assert
+    expect($flag->audition->name)->toBe($audition->name);
+
+});
diff --git a/tests/Feature/Models/AuditionTest.php b/tests/Feature/Models/AuditionTest.php
index 893d7ef..7c54eda 100644
--- a/tests/Feature/Models/AuditionTest.php
+++ b/tests/Feature/Models/AuditionTest.php
@@ -1,6 +1,12 @@
 <?php
 
 use App\Models\Audition;
+use App\Models\AuditionFlag;
+use App\Models\Entry;
+use App\Models\Event;
+use App\Models\Room;
+use App\Models\ScoringGuide;
+use App\Models\User;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 
 uses(RefreshDatabase::class);
@@ -63,3 +69,102 @@ it('only returns published advancement auditions for advancementPublished scope'
         ->first()->id->toEqual($published->id);
 
 });
+
+it('has an event', function () {
+    // Arrange
+    $event = Event::factory()->create(['name' => 'Symphonic Concert Wind Ensemble Band']);
+    $audition = Audition::factory()->create(['event_id' => $event->id]);
+    // Act & Assert
+    expect($audition->event->name)->toEqual('Symphonic Concert Wind Ensemble Band');
+
+});
+
+it('has entries', function () {
+    // Arrange
+    $audition = Audition::factory()->create();
+    Entry::factory()->count(10)->create(['audition_id' => $audition->id]);
+    // Act & Assert
+    expect($audition->entries->count())->toEqual(10);
+});
+
+it('has a room', function () {
+    // Arrange
+    $room = Room::factory()->create(['name' => 'Room 1']);
+    $audition = Audition::factory()->create(['room_id' => $room->id]);
+
+    // Act & Assert
+    expect($audition->room->name)->toEqual('Room 1');
+
+});
+
+it('has a scoring guide', function () {
+    // Arrange
+    $sg = ScoringGuide::factory()->create(['name' => 'Sight Reading']);
+    $audition = Audition::factory()->create(['scoring_guide_id' => $sg->id]);
+    // Act & Assert
+    expect($audition->scoringGuide->name)->toEqual('Sight Reading');
+
+});
+
+it('displays the entry fee', function () {
+    // Arrange
+    $audition = Audition::factory()->create(['entry_fee' => 1000]);
+    // Act & Assert
+    expect($audition->display_fee())->toEqual('$10.00');
+});
+
+it('has many judges', function () {
+    // Arrange
+    $room = Room::factory()->create();
+    $audition = Audition::factory()->create(['room_id' => $room->id]);
+    $judges = User::factory()->count(5)->create();
+    foreach ($judges as $judge) {
+        $room->addJudge($judge->id);
+    }
+    // Act & Assert
+    expect($audition->judges->count())->toEqual(5);
+});
+
+it('has a judges_count available', function () {
+    // Arrange
+    $room = Room::factory()->create();
+    $audition = Audition::factory()->create(['room_id' => $room->id]);
+    $judges = User::factory()->count(5)->create();
+    foreach ($judges as $judge) {
+        $room->addJudge($judge->id);
+    }
+    // Act & Assert
+    expect($audition->judges_count)->toEqual(5);
+});
+
+it('can have flags', function () {
+    // Arrange
+    $audition = Audition::factory()->create();
+    AuditionFlag::create(['audition_id' => $audition->id, 'flag_name' => 'seats_published']);
+    AuditionFlag::create(['audition_id' => $audition->id, 'flag_name' => 'advance_published']);
+    // Act
+    // Assert
+    expect($audition->hasFlag('seats_published'))->toBeTrue();
+    expect($audition->hasFlag('notaflag'))->toBeFalse();
+    expect($audition->flags->count())->toEqual(2);
+});
+
+it('can add flags', function () {
+    // Arrange
+    $audition = Audition::factory()->create();
+    // Act
+    $audition->addFlag('seats_published');
+    // Assert
+    expect($audition->hasFlag('seats_published'))->toBeTrue();
+});
+
+it('can remove flags', function () {
+    // Arrange
+    $audition = Audition::factory()->create();
+    AuditionFlag::create(['audition_id' => $audition->id, 'flag_name' => 'seats_published']);
+    // Act & Assert
+    $audition->addFlag('seats_published');
+    expect($audition->hasFlag('seats_published'))->toBeTrue();
+    $audition->removeFlag('seats_published');
+    expect($audition->hasFlag('seats_published'))->toBeFalse();
+});
diff --git a/tests/Feature/Pages/DashbaordTest.php b/tests/Feature/Pages/DashbaordTest.php
index 0b4b43e..d3eba19 100644
--- a/tests/Feature/Pages/DashbaordTest.php
+++ b/tests/Feature/Pages/DashbaordTest.php
@@ -1,5 +1,56 @@
 <?php
 
-it('', function () {
+use App\Models\School;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+it('only shows Students and Entries menu options if the user has a school', function () {
+    // Act & Assert
+    $user = User::factory()->create();
+    $this->actingAs($user);
+    get(route('dashboard'))
+        ->assertStatus(200)
+        ->assertSeeText('Dashboard')
+        ->assertDontSeeText('Students')
+        ->assertDontSeeText('Entries');
+
+    $school = School::factory()->create();
+    $user->school_id = $school->id;
+    $user->save();
+    get(route('dashboard'))
+        ->assertStatus(200)
+        ->assertSeeText('My School')
+        ->assertSeeText('Dashboard')
+        ->assertSeeText('Students')
+        ->assertSeeText('Entries');
+});
+
+it('only shows Admin menu if an administrator only shows Tabulation if admin or tabulator', function () {
+    // Arrange
+    $user = User::factory()->create();
+    $adminUser = User::factory()->admin()->create();
+    $tabUser = User::factory()->tab()->create();
+
+    // Act & Assert
+    $this->actingAs($user);
+    get(route('dashboard'))
+        ->assertStatus(200)
+        ->assertDontSeeText('Administration');
+
+    $this->actingAs($adminUser);
+    get(route('dashboard'))
+        ->assertStatus(200)
+        ->assertSeeText('Administration')
+        ->assertSeeText('Tabulation');
+
+    $this->actingAs($tabUser);
+    get(route('dashboard'))
+        ->assertStatus(200)
+        ->assertDontSeeText('Administration')
+        ->assertSeeText('Tabulation');
 
 });
diff --git a/tests/Feature/Pages/StudentsIndexTest.php b/tests/Feature/Pages/StudentsIndexTest.php
index 0b4b43e..9e8ab04 100644
--- a/tests/Feature/Pages/StudentsIndexTest.php
+++ b/tests/Feature/Pages/StudentsIndexTest.php
@@ -1,5 +1,134 @@
 <?php
 
-it('', function () {
+use App\Models\School;
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+it('cannot be accessed by a guest', function () {
+    // Act & Assert
+    get(route('students.index'))
+        ->assertStatus(302)
+        ->assertRedirect(route('home'));
+});
+
+it('cannot be accessed by a user without a school', function () {
+    // Arrange
+    $user = User::factory()->create();
+    $userWithSchool = User::factory()->create([
+        'school_id' => School::factory()->create()->id,
+    ]);
+    // Act & Assert
+    $this->actingAs($user);
+    get('/students')
+        ->assertStatus(403);
+
+    $this->actingAs($userWithSchool);
+    get('/students')
+        ->assertStatus(200);
+
+});
+
+it('Shows a student for the user', function () {
+    // Arrange
+    $school = School::factory()->create();
+    $user = User::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $student = Student::factory()->create([
+        'school_id' => $school->id,
+    ]);
+
+    $students = [
+        ['first_name' => 'John', 'last_name' => 'Lennon'],
+        ['first_name' => 'Paul', 'last_name' => 'McCartney'],
+        ['first_name' => 'George', 'last_name' => 'Harrison'],
+        ['first_name' => 'Ringo', 'last_name' => 'Starr'],
+    ];
+
+    foreach ($students as $s) {
+        Student::factory()->create([
+            'school_id' => $school->id,
+            'first_name' => $s['first_name'],
+            'last_name' => $s['last_name'],
+        ]);
+    }
+
+    // Act and Assert
+    $this->actingAs($user);
+    get(route('students.index'))
+        ->assertStatus(200)
+        ->assertSeeText($student->name)
+        ->assertSeeText(['Lennon, John', 'McCartney, Paul', 'Harrison, George', 'Starr, Ringo']);
+});
+
+it('does not show a student from another school', function () {
+    // Arrange
+    $school = School::factory()->create();
+    $user = User::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $student = Student::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $otherSchool = School::factory()->create();
+    $otherStudent = Student::factory()->create([
+        'school_id' => $otherSchool->id,
+    ]);
+    // Act & Assert
+    $this->actingAs($user);
+    get(route('students.index'))
+        ->assertStatus(200)
+        ->assertSeeText($student->name)
+        ->assertDontSeeText($otherStudent->name);
+
+    // Assert
+
+});
+
+it('can accept a new student entry', function () {
+    // Act and Assert
+    $school = School::factory()->create();
+    $user = User::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $this->actingAs($user);
+    post(route('students.store'), [
+        'first_name' => 'James',
+        'last_name' => 'Brown',
+        'grade' => 10,
+    ])
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('students.index'));
+
+    get(route('students.index'))
+        ->assertSeeText('Brown, James');
+
+    expect(Student::count())->toBe(1);
+
+});
+
+it('cannot have two students with identical names at a school', function () {
+    $school = School::factory()->create();
+    $user = User::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    Student::factory()->create([
+        'school_id' => $school->id,
+        'first_name' => 'James',
+        'last_name' => 'Brown',
+    ]);
+    $this->actingAs($user);
+    post(route('students.store'), [
+        'first_name' => 'James',
+        'last_name' => 'Brown',
+        'grade' => 10,
+    ])
+        ->assertSessionHasErrors('last_name');
 
 });
diff --git a/tests/Feature/PagesResponseTest.php b/tests/Feature/PagesResponseTest.php
index 2679461..6cfea8d 100644
--- a/tests/Feature/PagesResponseTest.php
+++ b/tests/Feature/PagesResponseTest.php
@@ -1,5 +1,6 @@
 <?php
 
+use App\Models\School;
 use App\Models\User;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 
@@ -57,3 +58,17 @@ it('shows dashboard only if logged in', function () {
         ->assertSeeText('My School')
         ->assertSeeText('Dashboard');
 });
+
+it('shows students index only for a user with a school', function () {
+    // Act & Assert
+    $user = User::factory()->create();
+    $this->actingAs($user);
+    get(route('students.index'))
+        ->assertStatus(403);
+
+    $school = School::factory()->create();
+    $user->school_id = $school->id;
+    get(route('students.index'))
+        ->assertStatus(200)
+        ->assertSeeText('Student Listing');
+});
-- 
2.39.5


From 8857cc69d6023d682283bebda0e53c6d02d4cd1d Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 09:08:02 -0500
Subject: [PATCH 03/61] Finished Ensemble Model Tests

---
 app/Models/Ensemble.php                | 13 ++++
 database/factories/AuditionFactory.php |  2 +-
 database/factories/EnsembleFactory.php | 26 ++++++++
 tests/Feature/Models/EnsembleTest.php  | 89 ++++++++++++++++++++++++++
 4 files changed, 129 insertions(+), 1 deletion(-)
 create mode 100644 database/factories/EnsembleFactory.php
 create mode 100644 tests/Feature/Models/EnsembleTest.php

diff --git a/app/Models/Ensemble.php b/app/Models/Ensemble.php
index 0024aa4..a616b05 100644
--- a/app/Models/Ensemble.php
+++ b/app/Models/Ensemble.php
@@ -2,6 +2,7 @@
 
 namespace App\Models;
 
+use Illuminate\Database\Eloquent\Builder;
 use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\BelongsTo;
@@ -40,4 +41,16 @@ class Ensemble extends Model
     {
         return $this->hasMany(Seat::class);
     }
+
+    public function scopeForAudition(Builder $query, $audition_id): Builder
+    {
+        $audition = Audition::find($audition_id);
+        // get instances of this class where the event_id is equal to the event_id of the audition with $audition_id
+        return $query->where('event_id', $audition->event_id);
+    }
+
+    public function scopeForEvent(Builder $query, $event_id): Builder
+    {
+        return $query->where('event_id', $event_id);
+    }
 }
diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index 494a378..9fe13e5 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -42,7 +42,7 @@ class AuditionFactory extends Factory
         return [
             'event_id' => $event->id,
             'name' => $this->faker->randomElement($instruments).$this->faker->randomNumber(3),
-            'score_order' => 1,
+            'score_order' => $this->faker->numberBetween(2, 50),
             'entry_deadline' => Carbon::tomorrow(),
             'entry_fee' => 1000,
             'minimum_grade' => 7,
diff --git a/database/factories/EnsembleFactory.php b/database/factories/EnsembleFactory.php
new file mode 100644
index 0000000..a0b950c
--- /dev/null
+++ b/database/factories/EnsembleFactory.php
@@ -0,0 +1,26 @@
+<?php
+
+namespace Database\Factories;
+
+use Illuminate\Database\Eloquent\Factories\Factory;
+
+/**
+ * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\Ensemble>
+ */
+class EnsembleFactory extends Factory
+{
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        return [
+            'name' => $this->faker->name,
+            'event_id' => \App\Models\Event::factory(),
+            'code' => $this->faker->randomLetter().$this->faker->randomLetter,
+            'rank' => $this->faker->numberBetween(1, 10),
+        ];
+    }
+}
diff --git a/tests/Feature/Models/EnsembleTest.php b/tests/Feature/Models/EnsembleTest.php
new file mode 100644
index 0000000..960ccf6
--- /dev/null
+++ b/tests/Feature/Models/EnsembleTest.php
@@ -0,0 +1,89 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Ensemble;
+use App\Models\Entry;
+use App\Models\Event;
+use App\Models\Seat;
+use App\Models\SeatingLimit;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+it('has an event', function () {
+    $event = Event::factory()->create();
+    $ensemble = Ensemble::factory()->create(['event_id' => $event->id]);
+    expect($ensemble->event)->toBeInstanceOf(Event::class)
+        ->and($ensemble->event->name)->toBe($event->name);
+});
+
+it('has auditions in score order', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    $oboe = Audition::factory()->create(['event_id' => $ensemble->event_id, 'name' => 'Oboe', 'score_order' => 2]);
+    $flute = Audition::factory()->create(['event_id' => $ensemble->event_id, 'name' => 'Flute', 'score_order' => 1]);
+    $clarinet = Audition::factory()->create(['event_id' => $ensemble->event_id, 'name' => 'Clarinet',
+        'score_order' => 3,
+    ]);
+    // Act & Assert
+    expect($ensemble->auditions)->toHaveCount(3)
+        ->sequence(
+            fn ($seatingLimit) => $seatingLimit->audition_id === $flute->id,
+            fn ($seatingLimit) => $seatingLimit->audition_id === $oboe->id,
+            fn ($seatingLimit) => $seatingLimit->audition_id === $clarinet->id,
+        );
+
+});
+
+it('has seating limits',
+    function () {
+        // Arrange
+        $ensemble = Ensemble::factory()->create();
+        $auditions = Audition::factory()->count(3)->create(['event_id' => $ensemble->event_id]);
+        foreach ($auditions as $audition) {
+            SeatingLimit::create([
+                'ensemble_id' => $ensemble->id, 'audition_id' => $audition->id,
+                'maximum_accepted' => fake()->numberBetween(1, 10),
+            ]);
+        }
+        // Act & Assert
+        expect($ensemble->seatingLimits)->toHaveCount(3);
+    });
+
+it('has seats', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    $audition = Audition::factory()->create(['event_id' => $ensemble->event_id]);
+    $entry = Entry::factory()->create(['audition_id' => $audition->id]);
+    $seat = Seat::create([
+        'ensemble_id' => $ensemble->id,
+        'audition_id' => $audition->id,
+        'seat' => 1,
+        'entry_id' => $entry->id,
+    ]);
+    // Act & Assert
+    expect($ensemble->seats)->toHaveCount(1)
+        ->and($ensemble->seats->first()->seat)->toBe(1);
+
+});
+
+it('returns only ensembles for a given audition in the audition scope', function () {
+    // Arrange
+    $audition = Audition::factory()->create();
+    $ensemble = Ensemble::factory()->create(['event_id' => $audition->event_id]);
+    $ensemble2 = Ensemble::factory()->create(['event_id' => $audition->event_id]);
+    $ensemble3 = Ensemble::factory()->create();
+    // Act & Assert
+    expect(Ensemble::forAudition($audition->id)->get())->toHaveCount(2);
+});
+
+it('returns only ensembles for a given event in the event scope', function () {
+    // Arrange
+    $event = Event::factory()->create();
+    $ensemble = Ensemble::factory()->create(['event_id' => $event->id]);
+    $ensemble2 = Ensemble::factory()->create(['event_id' => $event->id]);
+    $ensemble3 = Ensemble::factory()->create();
+    // Act & Assert
+    expect(Ensemble::forEvent($event->id)->get())->toHaveCount(2);
+
+});
-- 
2.39.5


From 07ff78f9a9b4c11746f2e53b61ac064fc0b17f64 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 10:07:03 -0500
Subject: [PATCH 04/61] Entry Models tests

---
 app/Models/Entry.php               |   3 +-
 tests/Feature/Models/EntryTest.php | 186 +++++++++++++++++++++++++++++
 2 files changed, 188 insertions(+), 1 deletion(-)
 create mode 100644 tests/Feature/Models/EntryTest.php

diff --git a/app/Models/Entry.php b/app/Models/Entry.php
index d48f760..9b08f7e 100644
--- a/app/Models/Entry.php
+++ b/app/Models/Entry.php
@@ -75,14 +75,15 @@ class Entry extends Model
         if ($this->hasFlag($flag)) {
             return;
         }
-
         $this->flags()->create(['flag_name' => $flag]);
+        $this->load('flags');
     }
 
     public function removeFlag($flag): void
     {
         // remove related auditionFlag where flag_name = $flag
         $this->flags()->where('flag_name', $flag)->delete();
+        $this->load('flags');
     }
 
     /**
diff --git a/tests/Feature/Models/EntryTest.php b/tests/Feature/Models/EntryTest.php
new file mode 100644
index 0000000..f0ba254
--- /dev/null
+++ b/tests/Feature/Models/EntryTest.php
@@ -0,0 +1,186 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Ensemble;
+use App\Models\Entry;
+use App\Models\EntryFlag;
+use App\Models\JudgeAdvancementVote;
+use App\Models\School;
+use App\Models\ScoreSheet;
+use App\Models\Seat;
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+test('has a student', function () {
+    // Arrange
+    $student = Student::factory()->create();
+    $entry = Entry::factory()->create(['student_id' => $student->id]);
+    // Act and Assert
+    expect($entry->student->first_name)->toBe($student->first_name)
+        ->and($entry->student)->toBeInstanceOf(Student::class);
+});
+
+test('has an audition', function () {
+    // Arrange
+    $audition = Audition::factory()->create();
+    $entry = Entry::factory()->create(['audition_id' => $audition->id]);
+    // Act and Assert
+    expect($entry->audition)->toBeInstanceOf(Audition::class)
+        ->and($entry->audition->name)->toBe($audition->name);
+
+});
+
+test('has a school', function () {
+    // Arrange
+    $student = Student::factory()->create();
+    $school = $student->school;
+    $entry = Entry::factory()->create(['student_id' => $student->id]);
+    // Act and Assert
+    expect($entry->school->name)->toBe($school->name)
+        ->and($entry->school)->toBeInstanceOf(School::class);
+});
+
+test('has score sheets', function () {
+    // Arrange
+    $judge = User::factory()->create();
+    $judge2 = User::factory()->create();
+    $entry = Entry::factory()->create();
+    $ss = ScoreSheet::create([
+        'entry_id' => $entry->id,
+        'user_id' => $judge->id,
+        'subscores' => json_encode(['subscore1' => 10, 'subscore2' => 20]),
+    ]);
+    $ss2 = ScoreSheet::create([
+        'entry_id' => $entry->id,
+        'user_id' => $judge2->id,
+        'subscores' => json_encode(['subscore1' => 10, 'subscore2' => 20]),
+    ]);
+    // Act and Assert
+    expect($entry->scoreSheets->count())->toBe(2)
+        ->and($entry->scoreSheets->first())->toBeInstanceOf(ScoreSheet::class);
+});
+
+test('has advancement votes', function () {
+    $entry = Entry::factory()->create();
+    $judge = User::factory()->create();
+    $judge2 = User::factory()->create();
+    JudgeAdvancementVote::create(['user_id' => $judge->id, 'entry_id' => $entry->id, 'vote' => 'yes']);
+    JudgeAdvancementVote::create(['user_id' => $judge2->id, 'entry_id' => $entry->id, 'vote' => 'no']);
+    // Act and Assert
+    expect($entry->advancementVotes->count())->toBe(2)
+        ->and($entry->advancementVotes->first())->toBeInstanceOf(JudgeAdvancementVote::class);
+});
+
+it('can have flags and can check for a specific flag', function () {
+    // Arrange
+    $entry = Entry::factory()->create();
+    EntryFlag::create(['entry_id' => $entry->id, 'flag_name' => 'declined']);
+    EntryFlag::create(['entry_id' => $entry->id, 'flag_name' => 'no-show']);
+    // Act & Assert
+    expect($entry->flags->count())->toBe(2)
+        ->and($entry->flags->first()->flag_name)->toBe('declined')
+        ->and($entry->hasFlag('declined'))->toBeTrue()
+        ->and($entry->hasFlag('random'))->toBeFalse();
+});
+
+it('can set and remove a flag', function () {
+    // Arrange
+    $entry = Entry::factory()->create();
+    // Act
+    $entry->addFlag('Test Flag');
+    $entry->addFlag('Second Flag');
+    // Assert
+    expect($entry->hasFlag('Test Flag'))->toBeTrue()
+        ->and($entry->hasFlag('Second Flag'))->toBeTrue()
+        ->and($entry->hasFlag('random'))->toBeFalse();
+    $entry->removeFlag('Test Flag');
+    expect($entry->hasFlag('Test Flag'))->toBeFalse()
+        ->and($entry->hasFlag('Second Flag'))->toBeTrue();
+});
+
+it('always has a score sheet count available', function () {
+    // Arrange
+    // Arrange
+    $judge = User::factory()->create();
+    $judge2 = User::factory()->create();
+    $entry = Entry::factory()->create();
+    $ss = ScoreSheet::create([
+        'entry_id' => $entry->id,
+        'user_id' => $judge->id,
+        'subscores' => json_encode(['subscore1' => 10, 'subscore2' => 20]),
+    ]);
+    $ss2 = ScoreSheet::create([
+        'entry_id' => $entry->id,
+        'user_id' => $judge2->id,
+        'subscores' => json_encode(['subscore1' => 10, 'subscore2' => 20]),
+    ]);
+    // Act & Assert
+    expect($entry->score_sheets_count)->toBe(2);
+});
+
+it('has a seat', function () {
+    // Arrange
+    $entry = Entry::factory()->create();
+    $ensemble = Ensemble::factory()->create();
+    $seat = Seat::create([
+        'ensemble_id' => $ensemble->id,
+        'audition_id' => $entry->audition_id,
+        'seat' => fake()->numberBetween(1, 15),
+        'entry_id' => $entry->id,
+    ]);
+    // Act & Assert
+    expect($entry->seat->seat)->toBe($seat->seat)
+        ->and($entry->seat->ensemble_id)->toBe($ensemble->id)
+        ->and($entry->seat->audition_id)->toBe($entry->audition_id)
+        ->and($entry->seat)->toBeInstanceOf(Seat::class);
+
+});
+
+it('has a forSeating scope that only returns those entries entered for seating', function () {
+    // Arrange
+    $noSeatStudent = Student::factory()->create(['first_name' => 'Advance Only']);
+    $noAdvanceStudent = Student::factory()->create(['first_name' => 'Seating Only']);
+    Entry::factory()->create(['student_id' => $noSeatStudent->id, 'for_seating' => false, 'for_advancement' => true]);
+    Entry::factory()->create([
+        'student_id' => $noAdvanceStudent->id, 'for_seating' => true,
+        'for_advancement' => false,
+    ]);
+    Entry::factory()->count(10)->create(['for_seating' => true, 'for_advancement' => true]);
+    Entry::factory()->count(5)->create(['for_seating' => false, 'for_advancement' => true]);
+    // Act & Assert
+    expect(Entry::forSeating()->count())->toBe(11)
+        ->and(Entry::forSeating()->get()->first())->toBeInstanceOf(Entry::class)
+        ->and(Entry::forSeating()->get()->first()->student->first_name)->toBe('Seating Only');
+});
+
+it('has a forAdvancement scope that only returns those entries entered for advancement', function () {
+    // Arrange
+    $noSeatStudent = Student::factory()->create(['first_name' => 'Advance Only']);
+    $noAdvanceStudent = Student::factory()->create(['first_name' => 'Seating Only']);
+    Entry::factory()->create(['student_id' => $noSeatStudent->id, 'for_seating' => false, 'for_advancement' => true]);
+    Entry::factory()->create([
+        'student_id' => $noAdvanceStudent->id, 'for_seating' => true,
+        'for_advancement' => false,
+    ]);
+    Entry::factory()->count(10)->create(['for_seating' => true, 'for_advancement' => true]);
+    Entry::factory()->count(5)->create(['for_seating' => false, 'for_advancement' => true]);
+    // Act & Assert
+    expect(Entry::forAdvancement()->count())->toBe(16)
+        ->and(Entry::forAdvancement()->get()->first())->toBeInstanceOf(Entry::class)
+        ->and(Entry::forAdvancement()->get()->first()->student->first_name)->toBe('Advance Only');
+});
+
+it('has an available scope that returns only auditions without a flag that would prevent seating', function () {
+    Entry::factory()->count(10)->create();
+    Entry::factory()->create()->addFlag('declined');
+    Entry::factory()->create()->addFlag('no-show');
+    Entry::factory()->create()->addFlag('failed-prelim');
+    // Act & Assert
+    expect(Entry::all()->count())->toBe(13)
+        ->and(Entry::available()->count())->toBe(10)
+        ->and(Entry::available()->get()->first())->toBeInstanceOf(Entry::class)
+        ->and(Entry::available()->get()->first()->flags->count())->toBe(0);
+});
-- 
2.39.5


From f95b89c7acbaafd8a8245b377ccf2992f8ecea38 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 10:11:34 -0500
Subject: [PATCH 05/61] Create EntryFlagTest.php

---
 tests/Feature/Models/EntryFlagTest.php | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 tests/Feature/Models/EntryFlagTest.php

diff --git a/tests/Feature/Models/EntryFlagTest.php b/tests/Feature/Models/EntryFlagTest.php
new file mode 100644
index 0000000..bad2e37
--- /dev/null
+++ b/tests/Feature/Models/EntryFlagTest.php
@@ -0,0 +1,16 @@
+<?php
+
+use App\Models\Entry;
+use App\Models\EntryFlag;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+it('has an entry', function () {
+    $entry = Entry::factory()->create();
+    $entryFlag = EntryFlag::create(['entry_id' => $entry->id, 'flag_name' => 'declined']);
+
+    // Act & Assert
+    expect($entryFlag->entry->id)->toBe($entry->id)
+        ->and($entryFlag->entry)->toBeInstanceOf(Entry::class);
+});
-- 
2.39.5


From 0c1a157a941940dc2e56d428410dd82bf74d396f Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 10:23:13 -0500
Subject: [PATCH 06/61] Create Model Event test

---
 tests/Feature/Models/EntryTest.phpTest.php | 46 ----------------------
 tests/Feature/Models/EventTest.php         | 28 +++++++++++++
 2 files changed, 28 insertions(+), 46 deletions(-)
 delete mode 100644 tests/Feature/Models/EntryTest.phpTest.php
 create mode 100644 tests/Feature/Models/EventTest.php

diff --git a/tests/Feature/Models/EntryTest.phpTest.php b/tests/Feature/Models/EntryTest.phpTest.php
deleted file mode 100644
index a9bea2f..0000000
--- a/tests/Feature/Models/EntryTest.phpTest.php
+++ /dev/null
@@ -1,46 +0,0 @@
-<?php
-
-use App\Models\Entry;
-use Illuminate\Foundation\Testing\RefreshDatabase;
-
-uses(RefreshDatabase::class);
-
-it('only returns entries for seating with forSeating scope', function () {
-    // Arrange
-    Entry::factory()->advanceOnly()->create();
-    $seatingEntry = Entry::factory()->create();
-
-    // Act & Assert
-    expect(Entry::forSeating()->get())
-        ->toHaveCount(1)
-        ->first()->id->toEqual($seatingEntry->id);
-});
-
-it('only returns entries for advancement with for forAdvancement scope', function () {
-    // Arrange
-    Entry::factory()->seatingOnly()->create();
-    $advancementEntry = Entry::factory()->create();
-
-    // Act & Assert
-    expect(Entry::forAdvancement()->get())
-        ->toHaveCount(1)
-        ->first()->id->toEqual($advancementEntry->id);
-});
-
-it('only returns entries that do not have a declined, no-show, or failed-prelim flag with available scope',
-    function () {
-        // Arrange
-        $availableEntry = Entry::factory()->create();
-        $declinedEntry = Entry::factory()->create();
-        $noShowEntry = Entry::factory()->create();
-        $failedPrelimEntry = Entry::factory()->create();
-        $declinedEntry->addFlag('declined');
-        $noShowEntry->addFlag('no-show');
-        $failedPrelimEntry->addFlag('failed-prelim');
-
-        // Act & Assert
-        expect(Entry::available()->get())
-            ->toHaveCount(1)
-            ->first()->id->toEqual($availableEntry->id);
-
-    });
diff --git a/tests/Feature/Models/EventTest.php b/tests/Feature/Models/EventTest.php
new file mode 100644
index 0000000..18fa8ca
--- /dev/null
+++ b/tests/Feature/Models/EventTest.php
@@ -0,0 +1,28 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Ensemble;
+use App\Models\Event;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+it('has auditions', function () {
+    $event = Event::factory()->create();
+    $ddAudition = Audition::factory()->create(['event_id' => $event->id, 'name' => 'Digereedoo']);
+    Audition::factory()->count(7)->create(['event_id' => $event->id]);
+
+    expect($event->auditions->count())->toBe(8)
+        ->and($event->auditions->first()->name)->toBe('Digereedoo');
+});
+
+it('has ensembles', function () {
+    // Arrange
+    $event = Event::factory()->create();
+    $ensemble = Ensemble::factory()->create(['event_id' => $event->id, 'name' => 'Symphonic Concert Wind Band']);
+    Ensemble::factory()->count(7)->create();
+    // Act & Assert
+    expect($event->ensembles->count())->toBe(1)
+        ->and($event->ensembles->first()->name)->toBe('Symphonic Concert Wind Band');
+
+});
-- 
2.39.5


From 0cf4727aac3287829fa2ad2388347c45c6c58c5c Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 10:38:57 -0500
Subject: [PATCH 07/61] Create JudgeAdvancementVoteTest.php

---
 .../Models/JudgeAdvancementVoteTest.php       | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 tests/Feature/Models/JudgeAdvancementVoteTest.php

diff --git a/tests/Feature/Models/JudgeAdvancementVoteTest.php b/tests/Feature/Models/JudgeAdvancementVoteTest.php
new file mode 100644
index 0000000..767cf5a
--- /dev/null
+++ b/tests/Feature/Models/JudgeAdvancementVoteTest.php
@@ -0,0 +1,28 @@
+<?php
+
+use App\Models\Entry;
+use App\Models\JudgeAdvancementVote;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->judge = User::factory()->create();
+    $this->entry = Entry::factory()->create();
+    $this->vote = JudgeAdvancementVote::create([
+        'user_id' => $this->judge->id,
+        'entry_id' => $this->entry->id,
+        'vote' => 'pass',
+    ]);
+});
+
+test('has a judge', function () {
+    expect($this->vote->judge)->toBeInstanceOf(User::class)
+        ->and($this->vote->judge->first_name)->toBe($this->judge->first_name);
+});
+
+test('has an entry', function () {
+    expect($this->vote->entry)->toBeInstanceOf(Entry::class)
+        ->and($this->vote->entry->student->first_name)->toBe($this->entry->student->first_name);
+});
-- 
2.39.5


From d32b835cae7eed1b8c27dfc36b8f9e5ac0dd4cea Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 11:14:35 -0500
Subject: [PATCH 08/61] Model Room Test

---
 app/Models/Room.php               |  2 +
 tests/Feature/Models/RoomTest.php | 70 +++++++++++++++++++++++++++++++
 2 files changed, 72 insertions(+)
 create mode 100644 tests/Feature/Models/RoomTest.php

diff --git a/app/Models/Room.php b/app/Models/Room.php
index add191f..d92b944 100644
--- a/app/Models/Room.php
+++ b/app/Models/Room.php
@@ -45,12 +45,14 @@ class Room extends Model
     public function addJudge($userId): void
     {
         $this->judges()->attach($userId);
+        $this->load('judges');
         AuditionChange::dispatch();
     }
 
     public function removeJudge($userId): void
     {
         $this->judges()->detach($userId);
+        $this->load('judges');
         AuditionChange::dispatch();
     }
 }
diff --git a/tests/Feature/Models/RoomTest.php b/tests/Feature/Models/RoomTest.php
new file mode 100644
index 0000000..ee68615
--- /dev/null
+++ b/tests/Feature/Models/RoomTest.php
@@ -0,0 +1,70 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\Room;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->room = Room::factory()->create();
+    $otherRoom = Room::factory()->create();
+    $auditions = Audition::factory()->count(3)->create(['room_id' => $this->room->id]);
+    foreach ($auditions as $audition) {
+        Entry::factory()->count(5)->create(['audition_id' => $audition->id]);
+    }
+    $otherAuditions = Audition::factory()->count(3)->create(['room_id' => $otherRoom->id]);
+    foreach ($otherAuditions as $audition) {
+        Entry::factory()->count(5)->create(['audition_id' => $audition->id]);
+    }
+});
+
+test('created 30 entries in prep', function () {
+    expect(Entry::all()->count())->toBe(30);
+});
+
+it('has auditions', function () {
+    expect($this->room->auditions->count())->toBe(3)
+        ->and($this->room->auditions->first())->toBeInstanceOf(Audition::class);
+});
+
+it('has entries', function () {
+    expect($this->room->entries->count())->toBe(15)
+        ->and($this->room->entries->first())->toBeInstanceOf(Entry::class);
+});
+
+it('has users', function () {
+    $user = User::factory()->create();
+    $this->room->users()->attach($user->id);
+    expect($this->room->users->count())->toBe(1)
+        ->and($this->room->users->first()->first_name)->toBe($user->first_name);
+});
+
+it('has judges', function () {
+    $user = User::factory()->create();
+    $this->room->judges()->attach($user->id);
+    expect($this->room->judges->count())->toBe(1)
+        ->and($this->room->judges->first()->first_name)->toBe($user->first_name);
+});
+
+it('can add a judge', function () {
+    $user = User::factory()->create();
+    $this->room->addJudge($user->id);
+    expect($this->room->judges->count())->toBe(1)
+        ->and($this->room->judges->first()->first_name)->toBe($user->first_name);
+});
+
+it('can remove a judge', function () {
+    // Arrange
+    $user = User::factory()->create();
+    $this->room->addJudge($user->id);
+    // Act & Assert
+    expect($this->room->judges->count())->toBe(1)
+        ->and($this->room->judges->first()->first_name)->toBe($user->first_name);
+    // Re Act
+    $this->room->removeJudge($user->id);
+    // Reassert
+    expect($this->room->judges->count())->toBe(0);
+});
-- 
2.39.5


From e8f062060059011d19426c12c14e3e868a779df1 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 11:22:57 -0500
Subject: [PATCH 09/61] Model RoomUser Test

---
 app/Models/RoomUser.php               |  5 ++++-
 tests/Feature/Models/RoomUserTest.php | 26 ++++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)
 create mode 100644 tests/Feature/Models/RoomUserTest.php

diff --git a/app/Models/RoomUser.php b/app/Models/RoomUser.php
index d493039..ff5e8c3 100644
--- a/app/Models/RoomUser.php
+++ b/app/Models/RoomUser.php
@@ -9,6 +9,9 @@ use Illuminate\Database\Eloquent\Relations\BelongsTo;
 class RoomUser extends Model
 {
     protected $table = 'room_user';
+
+    protected $guarded = [];
+
     public function user(): BelongsTo
     {
         return $this->belongsTo(User::class);
@@ -16,7 +19,7 @@ class RoomUser extends Model
 
     public function judge(): BelongsTo
     {
-        return $this->belongsTo(User::class);
+        return $this->belongsTo(User::class, 'user_id');
     }
 
     public function room(): BelongsTo
diff --git a/tests/Feature/Models/RoomUserTest.php b/tests/Feature/Models/RoomUserTest.php
new file mode 100644
index 0000000..69273f9
--- /dev/null
+++ b/tests/Feature/Models/RoomUserTest.php
@@ -0,0 +1,26 @@
+<?php
+
+use App\Models\Room;
+use App\Models\RoomUser;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->user = User::factory()->create();
+    $this->room = Room::factory()->create();
+    $this->roomUser = RoomUser::create(['user_id' => $this->user->id, 'room_id' => $this->room->id]);
+});
+
+it('has a user', function () {
+    expect($this->roomUser->user->first_name)->toBe($this->user->first_name);
+});
+
+it('has a judge', function () {
+    expect($this->roomUser->judge->first_name)->toBe($this->user->first_name);
+});
+
+it('has a room', function () {
+    expect($this->roomUser->room->name)->toBe($this->room->name);
+});
-- 
2.39.5


From 34f5dd2952cc81c2c7a01a40b6446f9022e8e41c Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 12:12:52 -0500
Subject: [PATCH 10/61] Create SchoolTest.php

---
 tests/Feature/Models/SchoolTest.php | 76 +++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)
 create mode 100644 tests/Feature/Models/SchoolTest.php

diff --git a/tests/Feature/Models/SchoolTest.php b/tests/Feature/Models/SchoolTest.php
new file mode 100644
index 0000000..eba7835
--- /dev/null
+++ b/tests/Feature/Models/SchoolTest.php
@@ -0,0 +1,76 @@
+<?php
+
+use App\Models\Entry;
+use App\Models\School;
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\Http;
+
+uses(RefreshDatabase::class);
+
+test('it has users that are also called directors', function () {
+    $school = School::factory()->create();
+    $user = User::factory()->create(['school_id' => $school->id]);
+    User::factory()->count(2)->create(['school_id' => $school->id]);
+    User::factory()->count(2)->create(['school_id' => 103]);
+
+    expect($school->directors->count())->toBe(3)
+        ->and($school->directors->first()->first_name)->toBe($user->first_name)
+        ->and($school->users->count())->toBe(3)
+        ->and($school->users->first()->first_name)->toBe($user->first_name);
+});
+
+test('it has email domains', function () {
+    $school = School::factory()->create();
+    $school->emailDomains()->create(['domain' => 'example.com']);
+    $school->emailDomains()->create(['domain' => 'example.org']);
+
+    expect($school->emailDomains->count())->toBe(2)
+        ->and($school->emailDomains->first()->domain)->toBe('example.com');
+});
+
+it('can set a default image with school initial letter', function () {
+    // Arrange
+    $school = School::factory()->create(['name' => 'Example School']);
+    // Act & Assert
+    expect($school->initialLetterImageURL())->toBe('https://ui-avatars.com/api/?background=4f46e5&color=fff&name=E');
+    $response = Http::get($school->initialLetterImageURL());
+    expect($response->status())->toBe(200);
+});
+
+it('has students sorted by their name', function () {
+    // Arrange
+    $school = School::factory()->create();
+    Student::factory()->create(['school_id' => $school->id, 'last_name' => 'Aaaaaa', 'first_name' => 'Zzz']);
+    $firstStudent = Student::factory()->create([
+        'school_id' => $school->id, 'last_name' => 'Aaaaaa',
+        'first_name' => 'Aaron',
+    ]);
+    $lastStudent = Student::factory()->create(['school_id' => $school->id, 'last_name' => 'Zzzz']);
+    Student::factory()->count(2)->create(['school_id' => $school->id]);
+
+    // Act & Assert
+    expect($school->students->count())->toBe(5)
+        ->and($school->students->first()->first_name)->toBe($firstStudent->first_name)
+        ->and($school->students->last()->first_name)->toBe($lastStudent->first_name);
+});
+
+it('has entries', function () {
+    // Arrange
+    $school = School::factory()->create();
+    $student = Student::factory()->create(['school_id' => $school->id, 'last_name' => 'Aaaaaa']);
+    $entry = Entry::factory()->create(['student_id' => $student->id]);
+    Entry::factory()->create(['student_id' => $student->id]);
+
+    $students = Student::factory()->count(7)->create(['school_id' => $school->id]);
+    foreach ($students as $student) {
+        Entry::factory()->create(['student_id' => $student->id]);
+    }
+    // Act & Assert
+    expect($school->entries->count())->toBe(9)
+        ->and($school->entries->first())->toBeInstanceOf(Entry::class)
+        ->and($school->entries->first()->student->first_name)->toBe($student->first_name);
+    // Assert
+
+});
-- 
2.39.5


From c3d7a7293bb85df14a8c56f39f521bdeed666ae1 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 12:22:42 -0500
Subject: [PATCH 11/61] Create SchoolEmailDomainTest.php

---
 tests/Feature/Models/SchoolEmailDomainTest.php | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
 create mode 100644 tests/Feature/Models/SchoolEmailDomainTest.php

diff --git a/tests/Feature/Models/SchoolEmailDomainTest.php b/tests/Feature/Models/SchoolEmailDomainTest.php
new file mode 100644
index 0000000..2eece48
--- /dev/null
+++ b/tests/Feature/Models/SchoolEmailDomainTest.php
@@ -0,0 +1,14 @@
+<?php
+
+use App\Models\School;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+it('has a school', function () {
+    $school = School::factory()->create();
+    $schoolEmailDomain = $school->emailDomains()->create([
+        'domain' => 'example.com',
+    ]);
+    expect($schoolEmailDomain->school->id)->toBe($school->id);
+});
-- 
2.39.5


From 218d7bc1420fb0b9f153a9b7095bb8a9d0a0d9e2 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 12:28:31 -0500
Subject: [PATCH 12/61] SchoreSheet Test

---
 app/Models/ScoreSheet.php               |  5 ----
 tests/Feature/Models/ScoreSheetTest.php | 39 +++++++++++++++++++++++++
 2 files changed, 39 insertions(+), 5 deletions(-)
 create mode 100644 tests/Feature/Models/ScoreSheetTest.php

diff --git a/app/Models/ScoreSheet.php b/app/Models/ScoreSheet.php
index cf93064..7b7c337 100644
--- a/app/Models/ScoreSheet.php
+++ b/app/Models/ScoreSheet.php
@@ -38,11 +38,6 @@ class ScoreSheet extends Model
         );
     }
 
-    public function getSubscore($id)
-    {
-        return $this->subscores[$id]['score'] ?? false;
-    }
-
     public function isValid()
     {
         // TODO move to either TabulationService or a specific service for scoreValidation
diff --git a/tests/Feature/Models/ScoreSheetTest.php b/tests/Feature/Models/ScoreSheetTest.php
new file mode 100644
index 0000000..3dd1a02
--- /dev/null
+++ b/tests/Feature/Models/ScoreSheetTest.php
@@ -0,0 +1,39 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\ScoreSheet;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->judge = User::factory()->create();
+    $this->entry = Entry::factory()->create();
+    $this->scoreSheet = ScoreSheet::create([
+        'user_id' => $this->judge->id,
+        'entry_id' => $this->entry->id,
+        'subscores' => [
+            1 => ['score' => 10],
+            2 => ['score' => 20],
+            3 => ['score' => 30],
+        ],
+    ]);
+});
+
+it('has an entry', function () {
+    expect($this->scoreSheet->entry->id)->toBe($this->entry->id)
+        ->and($this->scoreSheet->entry)->toBeInstanceOf(Entry::class);
+});
+
+it('has a judge', function () {
+    expect($this->scoreSheet->judge->id)->toBe($this->judge->id)
+        ->and($this->scoreSheet->judge)->toBeInstanceOf(User::class);
+});
+
+it('has an audition', function () {
+    expect($this->scoreSheet->audition->id)->toBe($this->entry->audition->id)
+        ->and($this->scoreSheet->audition)->toBeInstanceOf(Audition::class);
+
+});
-- 
2.39.5


From 1b37aa65c3e3089134d6bb9e264ec2be7ed8a27c Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 12:47:38 -0500
Subject: [PATCH 13/61] ScoringGuide Test

---
 .../factories/SubscoreDefinitionFactory.php   | 40 ++++++++++++++++++-
 tests/Feature/Models/SchoolTest.php           |  3 +-
 tests/Feature/Models/ScoringGuideTest.php     | 29 ++++++++++++++
 3 files changed, 69 insertions(+), 3 deletions(-)
 create mode 100644 tests/Feature/Models/ScoringGuideTest.php

diff --git a/database/factories/SubscoreDefinitionFactory.php b/database/factories/SubscoreDefinitionFactory.php
index 2ce384e..b84d521 100644
--- a/database/factories/SubscoreDefinitionFactory.php
+++ b/database/factories/SubscoreDefinitionFactory.php
@@ -2,6 +2,7 @@
 
 namespace Database\Factories;
 
+use App\Models\ScoringGuide;
 use Illuminate\Database\Eloquent\Factories\Factory;
 
 /**
@@ -16,8 +17,45 @@ class SubscoreDefinitionFactory extends Factory
      */
     public function definition(): array
     {
+        $sg = ScoringGuide::factory()->create();
+
         return [
-            //
+            'scoring_guide_id' => $sg->id,
+            'name' => $this->faker->word,
+            'max_score' => 100,
+            'weight' => $this->faker->numberBetween(1, 4),
+            'display_order' => $this->faker->numberBetween(1, 20),
+            'tiebreak_order' => $this->faker->numberBetween(1, 20),
+            'for_seating' => 1,
+            'for_advance' => 1,
         ];
     }
+    public function seatingOnly(): self
+    {
+        return $this->state(
+            fn (array $attributes) => ['for_advance' => 0]
+        );
+    }
+
+    public function advanceOnly(): self
+    {
+        return $this->state(
+            fn (array $attributes) => ['for_seating' => 0]
+        );
+    }
+
+    public function displayFirst(): self
+    {
+        return $this->state(
+            fn (array $attributes) => ['display_order' => 0]
+        );
+    }
+
+    public function tiebreakFirst(): self
+    {
+        return $this->state(
+            fn (array $attributes) => ['tiebreak_order' => 0]
+        );
+    }
+
 }
diff --git a/tests/Feature/Models/SchoolTest.php b/tests/Feature/Models/SchoolTest.php
index eba7835..9b6360a 100644
--- a/tests/Feature/Models/SchoolTest.php
+++ b/tests/Feature/Models/SchoolTest.php
@@ -69,8 +69,7 @@ it('has entries', function () {
     }
     // Act & Assert
     expect($school->entries->count())->toBe(9)
-        ->and($school->entries->first())->toBeInstanceOf(Entry::class)
-        ->and($school->entries->first()->student->first_name)->toBe($student->first_name);
+        ->and($school->entries->first())->toBeInstanceOf(Entry::class);
     // Assert
 
 });
diff --git a/tests/Feature/Models/ScoringGuideTest.php b/tests/Feature/Models/ScoringGuideTest.php
new file mode 100644
index 0000000..2322f6b
--- /dev/null
+++ b/tests/Feature/Models/ScoringGuideTest.php
@@ -0,0 +1,29 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+it('has auditions in score order', function () {
+    // Arrange
+    $scoringGuide = ScoringGuide::factory()->create();
+    Audition::factory()->count(5)->create(['scoring_guide_id' => $scoringGuide->id]);
+    $audition = Audition::factory()->create(['scoring_guide_id' => $scoringGuide->id, 'score_order' => 0]);
+
+    // Act & Assert
+    expect($scoringGuide->auditions->count())->toBe(6)
+        ->and($scoringGuide->auditions->first()->id)->toBe($audition->id)
+        ->and($scoringGuide->auditions->first())->toBeInstanceOf(Audition::class);
+});
+
+it('has subscores', function () {
+    // Arrange
+    $sg = ScoringGuide::factory()->create();
+    SubscoreDefinition::factory()->count(5)->create(['scoring_guide_id' => $sg->id]);
+    // Act & Assert
+    expect($sg->subscores->count())->toBe(5)
+        ->and($sg->subscores->first())->toBeInstanceOf(SubscoreDefinition::class);
+});
-- 
2.39.5


From 7adb008d0ab02dad3ccb5d167e349f33cb47924c Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 13:00:36 -0500
Subject: [PATCH 14/61] Seat test

---
 database/factories/AuditionFactory.php |  2 +-
 tests/Feature/Models/SeatTest.php      | 50 ++++++++++++++++++++++++++
 2 files changed, 51 insertions(+), 1 deletion(-)
 create mode 100644 tests/Feature/Models/SeatTest.php

diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index 9fe13e5..9084a08 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -41,7 +41,7 @@ class AuditionFactory extends Factory
 
         return [
             'event_id' => $event->id,
-            'name' => $this->faker->randomElement($instruments).$this->faker->randomNumber(3),
+            'name' => $this->faker->randomElement($instruments).$this->faker->numberBetween(1, 1000),
             'score_order' => $this->faker->numberBetween(2, 50),
             'entry_deadline' => Carbon::tomorrow(),
             'entry_fee' => 1000,
diff --git a/tests/Feature/Models/SeatTest.php b/tests/Feature/Models/SeatTest.php
new file mode 100644
index 0000000..2a4144e
--- /dev/null
+++ b/tests/Feature/Models/SeatTest.php
@@ -0,0 +1,50 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Ensemble;
+use App\Models\Entry;
+use App\Models\Event;
+use App\Models\Seat;
+use App\Models\Student;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->event = Event::factory()->create();
+    $this->audition = Audition::factory()->create([
+        'event_id' => $this->event->id,
+    ]);
+    $this->ensemble = Ensemble::factory()->create([
+        'event_id' => $this->event->id,
+    ]);
+    $this->entry = Entry::factory()->create([
+        'audition_id' => $this->audition->id,
+    ]);
+    $this->seat = Seat::create([
+        'ensemble_id' => $this->ensemble->id,
+        'audition_id' => $this->audition->id,
+        'seat' => '1',
+        'entry_id' => $this->entry->id,
+    ]);
+});
+
+it('has an ensemble', function () {
+    expect($this->seat->ensemble->name)->toBe($this->ensemble->name)
+        ->and($this->seat->ensemble)->toBeInstanceOf(Ensemble::class);
+});
+
+it('has an audition', function () {
+    expect($this->seat->audition->name)->toBe($this->audition->name)
+        ->and($this->seat->audition)->toBeInstanceOf(Audition::class);
+});
+
+it('has an entry', function () {
+    expect($this->seat->entry->student->first_name)->toBe($this->entry->student->first_name)
+        ->and($this->seat->entry)->toBeInstanceOf(Entry::class);
+});
+
+it('has a student', function () {
+    expect($this->seat->student->first_name)->toBe($this->entry->student->first_name)
+        ->and($this->seat->student)->toBeInstanceOf(Student::class);
+});
-- 
2.39.5


From a051808c2dec21cc77ca61f80d81d05131162390 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 13:06:08 -0500
Subject: [PATCH 15/61] Create SeatingLimitTest.php

---
 tests/Feature/Models/SeatingLimitTest.php | 28 +++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 tests/Feature/Models/SeatingLimitTest.php

diff --git a/tests/Feature/Models/SeatingLimitTest.php b/tests/Feature/Models/SeatingLimitTest.php
new file mode 100644
index 0000000..ee4548c
--- /dev/null
+++ b/tests/Feature/Models/SeatingLimitTest.php
@@ -0,0 +1,28 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Ensemble;
+use App\Models\SeatingLimit;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->ensemble = Ensemble::factory()->create();
+    $this->audition = Audition::factory()->create();
+    $this->seatingLimit = SeatingLimit::create([
+        'audition_id' => $this->audition->id,
+        'ensemble_id' => $this->ensemble->id,
+        'maximum_accepted' => 10,
+    ]);
+});
+
+it('has an audition', function () {
+    expect($this->seatingLimit->audition->name)->toBe($this->audition->name)
+    ->and($this->seatingLimit)->toBeInstanceOf(SeatingLimit::class);
+});
+
+it('has an ensemble', function () {
+    expect($this->seatingLimit->ensemble)->toBeInstanceOf(Ensemble::class)
+        ->and($this->seatingLimit->ensemble->name)->toBe($this->ensemble->name);
+});
-- 
2.39.5


From b46d488cc579fc38a645d73b4d4e2321f8a9a3ba Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 13:25:32 -0500
Subject: [PATCH 16/61] Model Student Test

---
 app/Models/Student.php               | 17 +++++++--
 tests/Feature/Models/StudentTest.php | 54 ++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+), 2 deletions(-)
 create mode 100644 tests/Feature/Models/StudentTest.php

diff --git a/app/Models/Student.php b/app/Models/Student.php
index f93465b..f4c9667 100644
--- a/app/Models/Student.php
+++ b/app/Models/Student.php
@@ -21,7 +21,19 @@ class Student extends Model
 
     public function users(): HasManyThrough
     {
-        return $this->hasManyThrough(User::class, School::class);
+        return $this->hasManyThrough(
+            User::class, // The target model we want to access
+            School::class, // The intermediate model through which we access the target model
+            'id', // The foreign key on the intermediate model
+            'school_id', // The foreign key on the target model
+            'school_id', // The local key
+            'id' // The local key on the intermediate model
+        );
+    }
+
+    public function directors(): HasManyThrough
+    {
+        return $this->users();
     }
 
     public function entries(): HasMany
@@ -32,8 +44,9 @@ class Student extends Model
     public function full_name(bool $last_name_first = false): string
     {
         if ($last_name_first) {
-            return ($this->last_name.', '.$this->first_name);
+            return $this->last_name.', '.$this->first_name;
         }
+
         return $this->first_name.' '.$this->last_name;
     }
 }
diff --git a/tests/Feature/Models/StudentTest.php b/tests/Feature/Models/StudentTest.php
new file mode 100644
index 0000000..8db512b
--- /dev/null
+++ b/tests/Feature/Models/StudentTest.php
@@ -0,0 +1,54 @@
+<?php
+
+use App\Models\Entry;
+use App\Models\School;
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->school = School::factory()->create();
+    $this->student = Student::factory()->create([
+        'school_id' => $this->school->id,
+        'first_name' => 'Chris',
+        'last_name' => 'Tomlin',
+    ]);
+});
+
+it('has a school', function () {
+    expect($this->student->school->is($this->school))->toBeTrue()
+        ->and($this->student->school)->toBeInstanceOf(School::class);
+});
+
+it('has users also called directors', function () {
+    // Arrange
+    $users = User::factory()->count(2)->create([
+        'school_id' => $this->school->id,
+    ]);
+    // Act & Assert
+    expect($this->student->users->count())->toBe(2)
+        ->and($this->student->users->first()->is($users->first()))->toBeTrue()
+        ->and($this->student->directors->count())->toBe(2)
+        ->and($this->student->directors->first()->is($users->first()))->toBeTrue();
+});
+
+it('has entries', function () {
+    // Arrange
+    $entry = Entry::factory()->create([
+        'student_id' => $this->student->id,
+    ]);
+    Entry::factory()->count(4)->create([
+        'student_id' => $this->student->id,
+    ]);
+    // Act & Assert
+    expect($this->student->entries->count())->toBe(5)
+        ->and($this->student->entries->first()->is($entry))->toBeTrue()
+        ->and($this->student->entries->first())->toBeInstanceOf(Entry::class);
+});
+
+it('formats a full name and can do it last name first if needed', function () {
+    expect($this->student->full_name())->toBe('Chris Tomlin')
+        ->and($this->student->full_name(true))->toBe('Tomlin, Chris');
+});
-- 
2.39.5


From 3ba70bea893cb5e7d5a27835abee139b7bf150d9 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 14:07:22 -0500
Subject: [PATCH 17/61] Model User Test

---
 app/Models/User.php               |   9 +-
 tests/Feature/Models/UserTest.php | 148 ++++++++++++++++++++++++++++++
 2 files changed, 155 insertions(+), 2 deletions(-)
 create mode 100644 tests/Feature/Models/UserTest.php

diff --git a/app/Models/User.php b/app/Models/User.php
index eb96143..361da51 100644
--- a/app/Models/User.php
+++ b/app/Models/User.php
@@ -10,6 +10,7 @@ use Illuminate\Database\Eloquent\Relations\HasMany;
 use Illuminate\Database\Eloquent\Relations\HasManyThrough;
 use Illuminate\Foundation\Auth\User as Authenticatable;
 use Illuminate\Notifications\Notifiable;
+use Illuminate\Support\Collection;
 
 class User extends Authenticatable implements MustVerifyEmail
 {
@@ -131,7 +132,7 @@ class User extends Authenticatable implements MustVerifyEmail
      *
      * @return SchoolEmailDomain[]
      */
-    public function possibleSchools()
+    public function possibleSchools(): Collection
     {
         if ($this->school_id) {
             $return[] = $this->school;
@@ -148,7 +149,11 @@ class User extends Authenticatable implements MustVerifyEmail
             return true;
         }
 
-        return $this->is_tab;
+        if ($this->is_tab) {
+            return true;
+        }
+
+        return false;
     }
 
     public function scoreSheets(): HasMany
diff --git a/tests/Feature/Models/UserTest.php b/tests/Feature/Models/UserTest.php
new file mode 100644
index 0000000..82baa6d
--- /dev/null
+++ b/tests/Feature/Models/UserTest.php
@@ -0,0 +1,148 @@
+<?php
+
+use App\Models\Entry;
+use App\Models\JudgeAdvancementVote;
+use App\Models\Room;
+use App\Models\School;
+use App\Models\SchoolEmailDomain;
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Collection;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->user = User::factory()->create([
+        'first_name' => 'Bandit',
+        'last_name' => 'Heeler',
+        'email' => 'bheeler@calypso.null',
+    ]);
+});
+
+it('formats a full name and can put last first if needed', function () {
+    expect($this->user->full_name())->toBe('Bandit Heeler')
+        ->and($this->user->full_name(true))->toBe('Heeler, Bandit');
+});
+
+it('formats a short name with the first initial of first name and full last name', function () {
+    expect($this->user->short_name())->toBe('B. Heeler');
+});
+
+it('checks if it has a school', function () {
+    expect($this->user->has_school())->toBeFalse();
+    $school = School::factory()->create(['name' => 'Calypso School']);
+    $this->user->school_id = $school->id;
+    $this->user->save();
+    expect($this->user->has_school())->toBeTrue();
+});
+
+it('has a school', function () {
+    // Arrange
+    $school = School::factory()->create(['name' => 'Calypso School']);
+    $this->user->school_id = $school->id;
+    $this->user->save();
+    // Act & Assert
+    expect($this->user->school->name)->toBe('Calypso School')
+        ->and($this->user->school)->toBeInstanceOf(School::class);
+
+});
+
+it('has an email domain', function () {
+    expect($this->user->emailDomain())->toBe('calypso.null');
+});
+
+it('has students', function () {
+    // Arrange
+    $school = School::factory()->create(['name' => 'Calypso School']);
+    $this->user->school_id = $school->id;
+    $this->user->save();
+    Student::factory()->count(5)->create(['school_id' => $school->id]);
+    // Act & Assert
+    expect($this->user->students->count())->toBe(5)
+        ->and($this->user->students->first())->toBeInstanceOf(Student::class);
+
+});
+
+it('has entries', function () {
+    // Arrange
+    $school = School::factory()->create(['name' => 'Calypso School']);
+    $this->user->school_id = $school->id;
+    $this->user->save();
+    $students = Student::factory()->count(5)->create(['school_id' => $school->id]);
+    foreach ($students as $student) {
+        Entry::factory()->count(2)->create(['student_id' => $student->id]);
+    }
+    // Act & Assert
+    expect($this->user->entries->count())->toBe(10)
+        ->and($this->user->entries->first())->toBeInstanceOf(Entry::class);
+});
+
+it('has rooms also called judgingAssignments', function () {
+    // Arrange
+    $rooms = Room::factory()->count(3)->create();
+    foreach ($rooms as $room) {
+        $room->addJudge($this->user);
+    }
+    // Act & Assert
+    expect($this->user->rooms->count())->toBe(3)
+        ->and($this->user->rooms->first())->toBeInstanceOf(Room::class)
+        ->and($this->user->judgingAssignments->count())->toBe(3)
+        ->and($this->user->judgingAssignments->first())->toBeInstanceOf(Room::class);
+});
+
+it('has advancement votes', function () {
+    // Arrange
+    $entries = Entry::factory()->count(5)->create();
+    foreach ($entries as $entry) {
+        JudgeAdvancementVote::create([
+            'user_id' => $this->user->id,
+            'entry_id' => $entry->id,
+            'vote' => fake()->randomElement(['yes', 'no', 'dq']),
+        ]);
+    }
+    // Act & Assert
+    expect($this->user->advancementVotes->count())->toBe(5)
+        ->and($this->user->advancementVotes->first())->toBeInstanceOf(JudgeAdvancementVote::class);
+});
+
+it('knows if it is a judge', function () {
+    expect($this->user->isJudge())->toBeFalse();
+    Room::factory()->create()->addJudge($this->user);
+    $this->user->load('judgingAssignments');
+    expect($this->user->isJudge())->toBeTrue();
+});
+
+it('knows what schools share its email domain', function () {
+    // Arrange
+    $school1 = School::factory()->create(['name' => 'Calypso Elementary School']);
+    $school2 = School::factory()->create(['name' => 'Calypso Middle School']);
+    $otherSchools = School::factory()->count(4)->create();
+    SchoolEmailDomain::create([
+        'school_id' => $school1->id,
+        'domain' => 'calypso.null',
+    ]);
+    SchoolEmailDomain::create([
+        'school_id' => $school2->id,
+        'domain' => 'calypso.null',
+    ]);
+    foreach ($otherSchools as $school) {
+        SchoolEmailDomain::create([
+            'school_id' => $school->id,
+            'domain' => fake()->domainName,
+        ]);
+    }
+    // Act & Assert
+    expect($this->user->possibleSchools())->toBeInstanceOf(Collection::class)
+        ->and($this->user->possibleSchools()->count())->toBe(2)
+        ->and($this->user->possibleSchools()->first())->toBeInstanceOf(SchoolEmailDomain::class)
+        ->and($this->user->possibleSchools()->first()->school)->toBeInstanceOf(School::class)
+        ->and($this->user->possibleSchools()->first()->school->name)->toBe('Calypso Elementary School');
+});
+
+it('knows if it is a score tabulator', function () {
+    expect($this->user->canTab())->toBeFalse()
+        ->and(User::factory()->tab()->create())->canTab()->toBe(true)
+        ->and(User::factory()->admin()->create())->canTab()->toBe(true);
+
+});
-- 
2.39.5


From 96e5896887778a8e0065f5380418734e6a291220 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 14:17:24 -0500
Subject: [PATCH 18/61] Add check for not logged in user to PageResponse

---
 tests/Feature/PagesResponseTest.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/Feature/PagesResponseTest.php b/tests/Feature/PagesResponseTest.php
index 6cfea8d..66b1c50 100644
--- a/tests/Feature/PagesResponseTest.php
+++ b/tests/Feature/PagesResponseTest.php
@@ -61,6 +61,10 @@ it('shows dashboard only if logged in', function () {
 
 it('shows students index only for a user with a school', function () {
     // Act & Assert
+    get(route('students.index'))
+        ->assertStatus(302)
+        ->assertRedirect(route('home'));
+
     $user = User::factory()->create();
     $this->actingAs($user);
     get(route('students.index'))
-- 
2.39.5


From 25a6084e25ecc54c3be46feed5bcff691f05e1f4 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 15:15:46 -0500
Subject: [PATCH 19/61] Finish StudentsIndex Test

---
 app/Http/Controllers/StudentController.php |  4 +-
 app/Observers/StudentObserver.php          |  5 +-
 resources/views/students/index.blade.php   | 10 +--
 tests/Feature/Pages/StudentsIndexTest.php  | 94 ++++++++++++++++++++++
 4 files changed, 103 insertions(+), 10 deletions(-)

diff --git a/app/Http/Controllers/StudentController.php b/app/Http/Controllers/StudentController.php
index f4d1186..ab9ff78 100644
--- a/app/Http/Controllers/StudentController.php
+++ b/app/Http/Controllers/StudentController.php
@@ -23,7 +23,7 @@ class StudentController extends Controller
         if (! Auth::user()->school_id) {
             return redirect()->route('dashboard');
         }
-        $students = Auth::user()->students()->with('entries')->get();
+        $students = Auth::user()->students()->withCount('entries')->get();
         $auditions = Audition::all();
 
         return view('students.index', ['students' => $students, 'auditions' => $auditions]);
@@ -121,6 +121,6 @@ class StudentController extends Controller
         }
         $student->delete();
 
-        return redirect('/students');
+        return redirect(route('students.index'));
     }
 }
diff --git a/app/Observers/StudentObserver.php b/app/Observers/StudentObserver.php
index d9af204..8cec44c 100644
--- a/app/Observers/StudentObserver.php
+++ b/app/Observers/StudentObserver.php
@@ -21,8 +21,7 @@ class StudentObserver
      */
     public function updated(Student $student): void
     {
-        AuditionChange::dispatch();
-        EntryChange::dispatch();
+        //
     }
 
     /**
@@ -30,7 +29,7 @@ class StudentObserver
      */
     public function deleted(Student $student): void
     {
-        AuditionChange::dispatch();
+        //
     }
 
     /**
diff --git a/resources/views/students/index.blade.php b/resources/views/students/index.blade.php
index 6442743..4e195e0 100644
--- a/resources/views/students/index.blade.php
+++ b/resources/views/students/index.blade.php
@@ -6,7 +6,7 @@
     <x-layout.page-section-container>
         <x-layout.page-section>
             <x-slot:section_name>Add Student</x-slot:section_name>
-            <x-form.form method="POST" action="/students" class="mb-6 mt-3">
+            <x-form.form method="POST" action="{{ route('students.store') }}" class="mb-6 mt-3">
                 <x-form.body-grid columns="8" class="max-w-full">
                     <x-form.field name="first_name" label_text="First Name" colspan="3"/>
                     <x-form.field name="last_name" label_text="Last Name" colspan="3"/>
@@ -46,10 +46,10 @@
                             <tr>
                                 <x-table.td first>{{ $student->full_name(true) }}</x-table.td>
                                 <x-table.td>{{ $student->grade }}</x-table.td>
-                                <x-table.td>{{ $student->entries->count() }}</x-table.td>
+                                <x-table.td>{{ $student->entries_count }}</x-table.td>
                                 <x-table.td for_button>
-                                    @if( $student->entries->count() > 0)
-                                        <form method="POST" action="/students/{{ $student->id }}" class="inline">
+                                    @if( $student->entries_count === 0)
+                                        <form method="POST" action="{{ route('students.destroy',$student) }}" class="inline">
                                             @csrf
                                             @method('DELETE')
                                             <x-table.button
@@ -59,7 +59,7 @@
                                         </form>
                                         |
                                     @endif
-                                    <x-table.button href="/students/{{ $student->id }}/edit">Edit</x-table.button>
+                                    <x-table.button href="{{ route('students.edit',$student) }}">Edit</x-table.button>
                                 </x-table.td>
                             </tr>
                         @endforeach
diff --git a/tests/Feature/Pages/StudentsIndexTest.php b/tests/Feature/Pages/StudentsIndexTest.php
index 9e8ab04..0324afc 100644
--- a/tests/Feature/Pages/StudentsIndexTest.php
+++ b/tests/Feature/Pages/StudentsIndexTest.php
@@ -1,10 +1,12 @@
 <?php
 
+use App\Models\Entry;
 use App\Models\School;
 use App\Models\Student;
 use App\Models\User;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 
+use function Pest\Laravel\delete;
 use function Pest\Laravel\get;
 use function Pest\Laravel\post;
 
@@ -132,3 +134,95 @@ it('cannot have two students with identical names at a school', function () {
         ->assertSessionHasErrors('last_name');
 
 });
+
+it('shows a delete link only if the student has no entries', function () {
+    // Arrange
+    $school = School::factory()->create();
+    $user = User::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $studentWithNoEntries = Student::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $studentWithEntries = Student::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    Entry::factory()->create([
+        'student_id' => $studentWithEntries->id,
+    ]);
+    // Act & Assert
+    $this->actingAs($user);
+    get(route('students.index'))
+        ->assertSee(route('students.destroy', $studentWithNoEntries))
+        ->assertDontSeeText(route('students.destroy', $studentWithEntries));
+});
+
+it('shows an edit link for each student', function () {
+    // Arrange
+    $school = School::factory()->create();
+    $user = User::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $students = Student::factory(3)->create([
+        'school_id' => $school->id,
+    ]);
+    // Act & Assert
+    foreach ($students as $student) {
+        $this->actingAs($user);
+        get(route('students.index'))
+            ->assertSee(route('students.edit', $student));
+    }
+
+});
+
+it('deletes a student with no entries', function () {
+    // Arrange
+    $school = School::factory()->create();
+    $user = User::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $student = Student::factory()->create([
+        'school_id' => $school->id,
+        'first_name' => 'John Jacob',
+    ]);
+
+    // Act & Assert
+    $this->actingAs($user);
+    get(route('students.index'))
+        ->assertSee('John Jacob');
+
+    expect($student->exists())->toBeTrue();
+
+    delete(route('students.destroy', $student))
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('students.index'));
+
+    expect($student->exists())->toBeFalse();
+
+    get(route('students.index'))
+        ->assertOk()
+        ->assertDontSee('John Jacob');
+});
+
+it('will not delete a student from another school', function () {
+    // Arrange
+    $school = School::factory()->create();
+    $user = User::factory()->create([
+        'school_id' => $school->id,
+    ]);
+    $student = Student::factory()->create([
+        'first_name' => 'John Jacob',
+    ]);
+    // Act & Assert
+    expect($student->exists())->toBeTrue();
+
+    $this->actingAs($user);
+    get(route('students.index'))
+        ->assertOk()
+        ->assertDontSee('John Jacob');
+
+    delete(route('students.destroy', $student))
+        ->assertStatus(403);
+
+    expect($student->exists())->toBeTrue();
+});
-- 
2.39.5


From 8f7c17ffe7bb7151bab5470e70348242c08e50bf Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 15:39:46 -0500
Subject: [PATCH 20/61] StudentEdit Page Test

---
 app/Http/Controllers/StudentController.php |  2 +-
 tests/Feature/Pages/StudentsEditTest.php   | 75 ++++++++++++++++++++++
 2 files changed, 76 insertions(+), 1 deletion(-)
 create mode 100644 tests/Feature/Pages/StudentsEditTest.php

diff --git a/app/Http/Controllers/StudentController.php b/app/Http/Controllers/StudentController.php
index ab9ff78..10a616a 100644
--- a/app/Http/Controllers/StudentController.php
+++ b/app/Http/Controllers/StudentController.php
@@ -108,7 +108,7 @@ class StudentController extends Controller
 
         //        TODO if a students grade is changed, we need to be sure they are still eligible for the auditions in which they are entered.
 
-        return redirect('/students');
+        return redirect('/students')->with('success', 'Student updated successfully.');
     }
 
     /**
diff --git a/tests/Feature/Pages/StudentsEditTest.php b/tests/Feature/Pages/StudentsEditTest.php
new file mode 100644
index 0000000..77b28e2
--- /dev/null
+++ b/tests/Feature/Pages/StudentsEditTest.php
@@ -0,0 +1,75 @@
+<?php
+
+use App\Models\School;
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+use function Pest\Laravel\patch;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->school = School::factory()->create();
+    $this->user = User::factory()->create(['school_id' => $this->school->id]);
+    $this->student = Student::factory()->create([
+        'school_id' => $this->school->id, 'first_name' => 'Bandit', 'last_name' => 'Heeler',
+    ]);
+});
+
+test('responds positively when the user has the same school as the entry', function () {
+    actingAs($this->user);
+    get(route('students.edit', $this->student))
+        ->assertOk()
+        ->assertSee([$this->student->first_name, 'Edit Student', 'Save Changes']);
+});
+
+it('denies guests', function () {
+    get(route('students.edit', $this->student))
+        ->assertRedirect(route('home'));
+});
+
+it('denies users that are not at the students school', function () {
+    // Arrange
+    $otherUser = User::factory()->create();
+    // Act & Assert
+    actingAs($otherUser);
+    get(route('students.edit', $this->student))
+        ->assertForbidden();
+});
+
+it('modifies the student', function () {
+    actingAs($this->user);
+    get(route('students.index'))
+        ->assertSee('Bandit')
+        ->assertDontSee('Bluey');
+
+    patch(route('students.update', $this->student), [
+        'first_name' => 'Bluey',
+        'last_name' => 'Heeler',
+        'grade' => 1,
+    ])->assertRedirect(route('students.index'))
+        ->assertSessionHas('success', 'Student updated successfully.')
+        ->assertSessionHasNoErrors();
+
+    get(route('students.index'))
+        ->assertSee('Bluey')
+        ->assertDontSee('Bandit');
+
+});
+
+it('will not modify a student not at the users school', function () {
+    actingAs(User::factory()->create());
+    patch(route('students.update', $this->student), [
+        'first_name' => 'Bluey',
+        'last_name' => 'Heeler',
+        'grade' => 1,
+    ])->assertForbidden();
+
+    actingAs($this->user);
+    get(route('students.index'))
+        ->assertSee('Bandit')
+        ->assertDontSee('Bluey');
+});
-- 
2.39.5


From 6724a31c38239747234d652768aaea4a683b2728 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 15:42:58 -0500
Subject: [PATCH 21/61] Replace link with route binding. Delete old work

---
 resources/views/students/edit.blade.php      |  2 +-
 resources/views/students/index.blade.php.bak | 37 --------------------
 2 files changed, 1 insertion(+), 38 deletions(-)
 delete mode 100644 resources/views/students/index.blade.php.bak

diff --git a/resources/views/students/edit.blade.php b/resources/views/students/edit.blade.php
index 1b77c5b..d7ef1d6 100644
--- a/resources/views/students/edit.blade.php
+++ b/resources/views/students/edit.blade.php
@@ -3,7 +3,7 @@
         <x-card.card>
             <x-card.heading>Edit Student</x-card.heading>
 
-            <x-form.form method="PATCH" class="!pt-2 !pb-6 !space-y-2" action="/students/{{ $student->id }}">
+            <x-form.form method="PATCH" class="!pt-2 !pb-6 !space-y-2" action="{{route('students.update')}}">
                 <x-form.field name="first_name" label_text="First Name" type="text" value="{{ $student->first_name }}"/>
                 <x-form.field name="last_name" label_text="Last Name" type="text" value="{{ $student->last_name }}"/>
                 <x-form.field name="grade" label_text="Grade" type="number" class="mb-3" value="{{ $student->grade }}"/>
diff --git a/resources/views/students/index.blade.php.bak b/resources/views/students/index.blade.php.bak
deleted file mode 100644
index 4ab2468..0000000
--- a/resources/views/students/index.blade.php.bak
+++ /dev/null
@@ -1,37 +0,0 @@
-@php use Illuminate\Support\Facades\Auth; @endphp
-@push('scripts')
-{{--    Code from https://codepen.io/ryangjchandler/pen/WNQQKeR--}}
-    <script src="{{ asset('js/sort_table_by_column.js') }}"></script>
-@endpush
-<x-layout.app>
-    <x-slot:page_title>Students</x-slot:page_title>
-
-    <x-table.container class="mx-auto max-w-2xl" x-data="data()">
-        <x-table.title_above_table>
-            <x-slot:title>Students <x-badge_pill>{{ $students->count() }}</x-badge_pill></x-slot:title>
-            <x-slot:subtitle>Before submitting entries, you must enter your students</x-slot:subtitle>
-            <x-slot:button>Add Student</x-slot:button>
-        </x-table.title_above_table>
-
-        <x-table.table>
-            <x-table.table_header_row>
-                <x-table.th first @click="sortByColumn" class="cursor-pointer select-none">Name</x-table.th>
-                <x-table.th @click="sortByColumn" class="cursor-pointer select-none">Grade</x-table.th>
-                <x-table.th :placeholder="true">
-                    <span class="sr-only">Edit</span>
-                </x-table.th>
-                <x-table.body x-ref="tbody">
-                    @foreach($students as $student)
-                        <tr>
-                            <x-table.td :first="true">{{ $student->full_name(true) }}</x-table.td>
-                            <x-table.td>{{ $student->grade }}</x-table.td>
-                            <x-table.td_right_link sr_text=", {{ $student->full_name() }}">
-                                <x-slot:a href="/students/{{ $student->id }}/edit">Edit</x-slot:a>
-                            </x-table.td_right_link>
-                        </tr>
-                    @endforeach
-                </x-table.body>
-            </x-table.table_header_row>
-        </x-table.table>
-    </x-table.container>
-</x-layout.app>
-- 
2.39.5


From 526dd453cc35f8562fd27d36b877b8455734b205 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 15:44:52 -0500
Subject: [PATCH 22/61] Correct forgotten parameter

---
 resources/views/students/edit.blade.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/resources/views/students/edit.blade.php b/resources/views/students/edit.blade.php
index d7ef1d6..747982a 100644
--- a/resources/views/students/edit.blade.php
+++ b/resources/views/students/edit.blade.php
@@ -3,7 +3,7 @@
         <x-card.card>
             <x-card.heading>Edit Student</x-card.heading>
 
-            <x-form.form method="PATCH" class="!pt-2 !pb-6 !space-y-2" action="{{route('students.update')}}">
+            <x-form.form method="PATCH" class="!pt-2 !pb-6 !space-y-2" action="{{route('students.update',$student)}}">
                 <x-form.field name="first_name" label_text="First Name" type="text" value="{{ $student->first_name }}"/>
                 <x-form.field name="last_name" label_text="Last Name" type="text" value="{{ $student->last_name }}"/>
                 <x-form.field name="grade" label_text="Grade" type="number" class="mb-3" value="{{ $student->grade }}"/>
-- 
2.39.5


From 38a72657be008167450f441175aacc498e5f63c5 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 22:04:27 -0500
Subject: [PATCH 23/61] EntriesIndex page test

---
 app/Http/Controllers/EntryController.php      |   2 +-
 app/Observers/EntryObserver.php               |  14 +-
 app/Policies/EntryPolicy.php                  |  29 ++-
 database/factories/AuditionFactory.php        |   4 +-
 .../components/icons/checkmark.blade.php      |   3 +-
 .../icons/circle-slash-no.blade.php           |   3 +-
 .../components/icons/hamburger-menu.blade.php |   2 +
 .../components/icons/thumbs-down.blade.php    |   3 +-
 .../components/icons/thumbs-up.blade.php      |   3 +-
 resources/views/entries/index.blade.php       |  22 ++-
 tests/Feature/Pages/EntriesIndexTest.php      | 179 ++++++++++++++++++
 11 files changed, 233 insertions(+), 31 deletions(-)
 create mode 100644 tests/Feature/Pages/EntriesIndexTest.php

diff --git a/app/Http/Controllers/EntryController.php b/app/Http/Controllers/EntryController.php
index 6c16d8f..9396f2e 100644
--- a/app/Http/Controllers/EntryController.php
+++ b/app/Http/Controllers/EntryController.php
@@ -56,7 +56,7 @@ class EntryController extends Controller
         }
         $entry->delete();
 
-        return redirect('/entries')->with('success', 'The '.$entry->audition->name.'entry for '.$entry->student->full_name().'has been deleted.');
+        return redirect()->route('entries.index')->with('success', 'The '.$entry->audition->name.'entry for '.$entry->student->full_name().'has been deleted.');
 
     }
 }
diff --git a/app/Observers/EntryObserver.php b/app/Observers/EntryObserver.php
index 67a51cf..c18ec21 100644
--- a/app/Observers/EntryObserver.php
+++ b/app/Observers/EntryObserver.php
@@ -13,8 +13,7 @@ class EntryObserver
      */
     public function created(Entry $entry): void
     {
-        AuditionChange::dispatch();
-        EntryChange::dispatch($entry->audition_id);
+
     }
 
     /**
@@ -22,8 +21,7 @@ class EntryObserver
      */
     public function updated(Entry $entry): void
     {
-        AuditionChange::dispatch();
-        EntryChange::dispatch($entry->audition_id);
+
     }
 
     /**
@@ -31,8 +29,7 @@ class EntryObserver
      */
     public function deleted(Entry $entry): void
     {
-        AuditionChange::dispatch();
-        EntryChange::dispatch($entry->audition_id);
+
     }
 
     /**
@@ -40,8 +37,7 @@ class EntryObserver
      */
     public function restored(Entry $entry): void
     {
-        AuditionChange::dispatch();
-        EntryChange::dispatch($entry->audition_id);
+
     }
 
     /**
@@ -49,6 +45,6 @@ class EntryObserver
      */
     public function forceDeleted(Entry $entry): void
     {
-        EntryChange::dispatch($entry->audition_id);
+
     }
 }
diff --git a/app/Policies/EntryPolicy.php b/app/Policies/EntryPolicy.php
index e080f66..051f529 100644
--- a/app/Policies/EntryPolicy.php
+++ b/app/Policies/EntryPolicy.php
@@ -4,7 +4,7 @@ namespace App\Policies;
 
 use App\Models\Entry;
 use App\Models\User;
-use Illuminate\Auth\Access\Response;
+
 use function is_null;
 
 class EntryPolicy
@@ -14,7 +14,7 @@ class EntryPolicy
      */
     public function viewAny(User $user): bool
     {
-        //
+        return true;
     }
 
     /**
@@ -22,7 +22,10 @@ class EntryPolicy
      */
     public function view(User $user, Entry $entry): bool
     {
-        if($user->is_admin) return true;
+        if ($user->is_admin) {
+            return true;
+        }
+
         return $user->school_id == $entry->student()->school_id;
     }
 
@@ -31,7 +34,10 @@ class EntryPolicy
      */
     public function create(User $user): bool
     {
-        if($user->is_admin) return true;
+        if ($user->is_admin) {
+            return true;
+        }
+
         return ! is_null($user->school_id);
     }
 
@@ -40,7 +46,10 @@ class EntryPolicy
      */
     public function update(User $user, Entry $entry): bool
     {
-        if($user->is_admin) return true;
+        if ($user->is_admin) {
+            return true;
+        }
+
         return $user->school_id == $entry->student()->school_id;
     }
 
@@ -49,13 +58,15 @@ class EntryPolicy
      */
     public function delete(User $user, Entry $entry): bool
     {
-        if($user->is_admin) return true;
+        if ($user->is_admin) {
+            return true;
+        }
         // Return false if $entry->audition->entry_deadline is in the past, continue if not
         if ($entry->audition->entry_deadline < now()) {
             return false;
         }
 
-        return $user->school_id == $entry->student()->school_id;
+        return $user->school_id == $entry->student->school_id;
     }
 
     /**
@@ -63,7 +74,7 @@ class EntryPolicy
      */
     public function restore(User $user, Entry $entry): bool
     {
-        //
+        return true;
     }
 
     /**
@@ -71,6 +82,6 @@ class EntryPolicy
      */
     public function forceDelete(User $user, Entry $entry): bool
     {
-        //
+        return true;
     }
 }
diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index 9084a08..a5b83ed 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -45,8 +45,8 @@ class AuditionFactory extends Factory
             'score_order' => $this->faker->numberBetween(2, 50),
             'entry_deadline' => Carbon::tomorrow(),
             'entry_fee' => 1000,
-            'minimum_grade' => 7,
-            'maximum_grade' => 12,
+            'minimum_grade' => $this->faker->numberBetween(7, 9),
+            'maximum_grade' => $this->faker->numberBetween(8, 12),
             'for_seating' => 1,
             'for_advancement' => 1,
         ];
diff --git a/resources/views/components/icons/checkmark.blade.php b/resources/views/components/icons/checkmark.blade.php
index 3231384..e781c65 100644
--- a/resources/views/components/icons/checkmark.blade.php
+++ b/resources/views/components/icons/checkmark.blade.php
@@ -1,4 +1,5 @@
-@props(['color' => 'currentColor'])
+@props(['color' => 'currentColor', 'title'=>false])
 <svg class="w-6 h-6 text-gray-800 dark:text-white" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none" viewBox="0 0 24 24">
+    @if($title)<title>{{ $title }}</title>@endif
     <path stroke="{{$color}}" stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M5 11.917 9.724 16.5 19 7.5"/>
 </svg>
diff --git a/resources/views/components/icons/circle-slash-no.blade.php b/resources/views/components/icons/circle-slash-no.blade.php
index 1bedb5e..187593a 100644
--- a/resources/views/components/icons/circle-slash-no.blade.php
+++ b/resources/views/components/icons/circle-slash-no.blade.php
@@ -1,4 +1,5 @@
-@props(['color' => 'currentColor'])
+@props(['color' => 'currentColor', 'title' => false])
 <svg class="w-6 h-6 text-gray-800 dark:text-white" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none" viewBox="0 0 24 24">
+    @if($title)<title>{{ $title }}</title>@endif
     <path stroke="{{ $color }}" stroke-linecap="round" stroke-width="2" d="m6 6 12 12m3-6a9 9 0 1 1-18 0 9 9 0 0 1 18 0Z"/>
 </svg>
diff --git a/resources/views/components/icons/hamburger-menu.blade.php b/resources/views/components/icons/hamburger-menu.blade.php
index 3097cd3..eccb66c 100644
--- a/resources/views/components/icons/hamburger-menu.blade.php
+++ b/resources/views/components/icons/hamburger-menu.blade.php
@@ -1,3 +1,5 @@
+@props(['title' => false])
 <svg class="w-6 h-6 text-gray-800 dark:text-white" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none" viewBox="0 0 24 24">
+    @if($title)<title>{{ $title }}</title>@endif
     <path stroke="currentColor" stroke-linecap="round" stroke-width="2" d="M5 7h14M5 12h14M5 17h14"/>
 </svg>
diff --git a/resources/views/components/icons/thumbs-down.blade.php b/resources/views/components/icons/thumbs-down.blade.php
index 1990c19..7427f65 100644
--- a/resources/views/components/icons/thumbs-down.blade.php
+++ b/resources/views/components/icons/thumbs-down.blade.php
@@ -1,4 +1,5 @@
-@props(['color' => 'currentColor'])
+@props(['color' => 'currentColor','title'=>false])
 <svg class="w-6 h-6 text-gray-800 dark:text-white" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="{{ $color }}" viewBox="0 0 24 24">
+    @if($title)<title>{{ $title }}</title>@endif
     <path fill-rule="evenodd" d="M8.97 14.316H5.004c-.322 0-.64-.08-.925-.232a2.022 2.022 0 0 1-.717-.645 2.108 2.108 0 0 1-.242-1.883l2.36-7.201C5.769 3.54 5.96 3 7.365 3c2.072 0 4.276.678 6.156 1.256.473.145.925.284 1.35.404h.114v9.862a25.485 25.485 0 0 0-4.238 5.514c-.197.376-.516.67-.901.83a1.74 1.74 0 0 1-1.21.048 1.79 1.79 0 0 1-.96-.757 1.867 1.867 0 0 1-.269-1.211l1.562-4.63ZM19.822 14H17V6a2 2 0 1 1 4 0v6.823c0 .65-.527 1.177-1.177 1.177Z" clip-rule="evenodd"/>
 </svg>
diff --git a/resources/views/components/icons/thumbs-up.blade.php b/resources/views/components/icons/thumbs-up.blade.php
index 1f5c405..6a97b0a 100644
--- a/resources/views/components/icons/thumbs-up.blade.php
+++ b/resources/views/components/icons/thumbs-up.blade.php
@@ -1,4 +1,5 @@
-@props(['color' => 'currentColor'])
+@props(['color' => 'currentColor','title'=>false])
 <svg class="w-6 h-6 text-gray-800 dark:text-white" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="{{ $color }}" viewBox="0 0 24 24">
+    @if($title)<title>{{ $title }}</title>@endif
     <path fill-rule="evenodd" d="M15.03 9.684h3.965c.322 0 .64.08.925.232.286.153.532.374.717.645a2.109 2.109 0 0 1 .242 1.883l-2.36 7.201c-.288.814-.48 1.355-1.884 1.355-2.072 0-4.276-.677-6.157-1.256-.472-.145-.924-.284-1.348-.404h-.115V9.478a25.485 25.485 0 0 0 4.238-5.514 1.8 1.8 0 0 1 .901-.83 1.74 1.74 0 0 1 1.21-.048c.396.13.736.397.96.757.225.36.32.788.269 1.211l-1.562 4.63ZM4.177 10H7v8a2 2 0 1 1-4 0v-6.823C3 10.527 3.527 10 4.176 10Z" clip-rule="evenodd"/>
 </svg>
diff --git a/resources/views/entries/index.blade.php b/resources/views/entries/index.blade.php
index 1838d73..80e9d3a 100644
--- a/resources/views/entries/index.blade.php
+++ b/resources/views/entries/index.blade.php
@@ -9,7 +9,7 @@
     <x-layout.page-section-container>
         <x-layout.page-section>
             <x-slot:section_name>Add Entry</x-slot:section_name>
-            <x-form.form method="POST" action="/entries" class="pt-6 pb-8">
+            <x-form.form method="POST" action="{{ route('entries.store') }}" class="pt-6 pb-8">
 
                 <x-form.body-grid columns="6" class="max-w-full" x-data="studentAuditionFilter()">
 
@@ -81,23 +81,33 @@
                                 @if(auditionSetting('advanceTo'))
                                     <x-table.td>
                                         @if($entry->for_seating)
-                                            <x-icons.checkmark color="green" />
+                                            <div aria-label="{{ $entry->student->full_name()  }} on {{ $entry->audition->name }} is entered for seating. Entry ID {{ $entry->id }}">
+                                                <x-icons.checkmark color="green"/>
+                                            </div>
                                         @else
-                                            <x-icons.circle-slash-no color="red" />
+                                            <div aria-label="{{ $entry->student->full_name()  }} on {{ $entry->audition->name }} is not entered for seating. Entry ID {{ $entry->id }}">
+                                                <x-icons.circle-slash-no color="red"/>
+                                            </div>
                                         @endif
                                     </x-table.td>
                                     <x-table.td>
                                         @if($entry->for_advancement)
-                                            <x-icons.checkmark color="green" />
+                                            <div aria-label="{{ $entry->student->full_name()  }} on {{ $entry->audition->name }} is entered for advancement. Entry ID {{ $entry->id }}">
+                                                <x-icons.checkmark color="green"/>
+
+                                            </div>
                                         @else
-                                            <x-icons.circle-slash-no color="red" />
+                                            <div aria-label="{{ $entry->student->full_name()  }} on {{ $entry->audition->name }} is not entered for advancement. Entry ID {{ $entry->id }}">
+                                                <x-icons.circle-slash-no color="red"/>
+
+                                            </div>
                                         @endif
                                     </x-table.td>
                                 @endif
 
                                 <x-table.td for_button>
                                     @if( $entry->audition->entry_deadline >= now())
-                                        <form method="POST" action="/entries/{{ $entry->id }}" class="inline">
+                                        <form method="POST" action="{{ route('entries.destroy',$entry) }}" class="inline">
                                             @csrf
                                             @method('DELETE')
                                             <x-table.button
diff --git a/tests/Feature/Pages/EntriesIndexTest.php b/tests/Feature/Pages/EntriesIndexTest.php
new file mode 100644
index 0000000..78af1ab
--- /dev/null
+++ b/tests/Feature/Pages/EntriesIndexTest.php
@@ -0,0 +1,179 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\School;
+use App\Models\Student;
+use App\Models\User;
+use App\Settings;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\delete;
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    Settings::set('auditionAbbreviation', 'SBDA');
+    Settings::set('advanceTo', 'OMEA');
+    $this->school = School::factory()->create();
+    $this->user = User::factory()->create(['school_id' => $this->school->id]);
+});
+
+it('works for a user with a school', function () {
+    actingAs($this->user)
+        ->get(route('entries.index'))
+        ->assertOk();
+});
+
+it('denies a user without a school', function () {
+    get(route('entries.index'))
+        ->assertRedirect(route('home'));
+
+    actingAs(User::factory()->create())
+        ->get(route('entries.index'))
+        ->assertForbidden();
+
+});
+
+it('has appropriate students in JS array for select', function () {
+    // Arrange
+    $student = Student::factory()->create(['school_id' => $this->school->id]);
+    // Act & Assert
+    actingAs($this->user);
+    get(route('entries.index'))
+        ->assertSeeInOrder([
+            'id: ',
+            $student->id,
+            'name: ',
+            $student->full_name(true),
+        ], false); // The false parameter makes the assertion case-sensitive and allows for HTML tags
+});
+
+it('has auditions in JS array for select', function () {
+    // Arrange
+    $auditions = Audition::factory()->count(5)->create();
+    // Act & Assert
+    actingAs($this->user);
+    $response = get(route('entries.index'));
+    foreach ($auditions as $audition) {
+        $response->assertSeeInOrder([
+            'id: ',
+            $audition->id,
+            'name: ',
+            $audition->name,
+            'minGrade: ',
+            $audition->minimum_grade,
+            'maxGrade: ',
+            $audition->maximum_grade,
+        ], false);
+    }
+
+});
+
+it('shows existing entries in a table', function () {
+    // Arrange
+    $students = Student::factory()->count(5)->create(['school_id' => $this->school->id]);
+    $entries = [];
+    foreach ($students as $student) {
+        $entries[] = Entry::factory()->create(['student_id' => $student->id]);
+    }
+    foreach ($students as $student) {
+        Entry::class::factory()->create(['student_id' => $student->id]);
+    }
+    // Act & Assert
+    actingAs($this->user);
+    $response = get(route('entries.index'));
+    foreach ($entries as $entry) {
+        $response->
+        assertSeeInOrder([
+            '<td',
+            $entry->student->full_name(true),
+            $entry->student->grade,
+            $entry->audition->name,
+            '</td>',
+        ], false);
+    }
+});
+
+it('shows a delete link for entries whose deadline is not past', function () {
+    // Arrange
+    $openAudition = Audition::factory()->create();
+    $closedAudition = Audition::factory()->closed()->create();
+    $student = Student::factory()->create(['school_id' => $this->school->id]);
+    $pendingEntry = Entry::factory()->create(['audition_id' => $openAudition->id, 'student_id' => $student->id]);
+    $protectedEntry = Entry::factory()->create(['audition_id' => $closedAudition->id, 'student_id' => $student->id]);
+    // Act & Assert
+    actingAs($this->user);
+    get(route('entries.index'))
+        ->assertSee(route('entries.destroy', $pendingEntry))
+        ->assertDontSee(route('entries.destroy', $protectedEntry));
+});
+
+it('shows appropriate flags for entry types when advancement is enabled', function () {
+    // Arrange
+
+    $student = Student::factory()->create(['school_id' => $this->school->id]);
+    $auditionOnlyEntry = Entry::factory()->seatingOnly()->create(['student_id' => $student->id]);
+    $advanceOnlyEntry = Entry::factory()->advanceOnly()->create(['student_id' => $student->id]);
+    $bothEntry = Entry::factory()->create(['student_id' => $student->id]);
+    // Act & Assert
+    actingAs($this->user);
+    get(route('entries.index'))
+        ->assertOk()
+        ->assertSee('is entered for seating. Entry ID '.$bothEntry->id)
+        ->assertSee('is entered for advancement. Entry ID '.$bothEntry->id)
+        ->assertSee('is entered for seating. Entry ID '.$auditionOnlyEntry->id)
+        ->assertSee('is not entered for advancement. Entry ID '.$auditionOnlyEntry->id)
+        ->assertSee('is entered for advancement. Entry ID '.$advanceOnlyEntry->id)
+        ->assertSee('is not entered for seating. Entry ID '.$advanceOnlyEntry->id);
+});
+
+it('accepts a valid entry', function () {
+    // Arrange
+    $student = Student::factory()->create(['school_id' => $this->school->id]);
+    $audition = Audition::factory()->create();
+    // Act & Assert
+    actingAs($this->user);
+    $response = post(route('entries.store'), [
+        'student_id' => $student->id,
+        'audition_id' => $audition->id,
+    ]);
+    $response->assertSessionHasNoErrors();
+    $response->assertRedirect(route('entries.index'));
+    $this->assertDatabaseHas('entries', [
+        'student_id' => $student->id,
+        'audition_id' => $audition->id,
+    ]);
+});
+
+it('deletes an entry', function () {
+    // Arrange
+    $student = Student::factory()->create(['school_id' => $this->school->id]);
+    $audition = Audition::factory()->create(['name' => 'Flute']);
+    $entry = Entry::factory()->create(['student_id' => $student->id, 'audition_id' => $audition->id]);
+    // Act
+    actingAs($this->user);
+    $response = delete(route('entries.destroy', $entry));
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('entries.index'));
+    // Assert
+    $this->assertDatabaseMissing('entries', [
+        'id' => $entry->id,
+    ]);
+});
+
+it('shows entry type checkboxes only when advancement is enabled', function () {
+    // Arrange
+    Settings::set('advanceTo', 'OMEA');
+    // Act & Assert
+    actingAs($this->user);
+    get(route('entries.index'))
+        ->assertSee('Enter for');
+    Settings::set('advanceTo', null);
+    get(route('entries.index'))
+        ->assertDontSee('Enter for');
+});
-- 
2.39.5


From 183d1ed0303f02ef7d3b05765ee27c57c3415a6c Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 22:48:21 -0500
Subject: [PATCH 24/61] Judging Index Test

---
 app/Policies/EntryPolicy.php             |   4 +-
 database/factories/AuditionFactory.php   |   3 +-
 resources/views/judging/index.blade.php  |   2 +-
 tests/Feature/Pages/JudgingIndexTest.php | 115 +++++++++++++++++++++++
 4 files changed, 120 insertions(+), 4 deletions(-)
 create mode 100644 tests/Feature/Pages/JudgingIndexTest.php

diff --git a/app/Policies/EntryPolicy.php b/app/Policies/EntryPolicy.php
index 051f529..f508bff 100644
--- a/app/Policies/EntryPolicy.php
+++ b/app/Policies/EntryPolicy.php
@@ -26,7 +26,7 @@ class EntryPolicy
             return true;
         }
 
-        return $user->school_id == $entry->student()->school_id;
+        return $user->school_id == $entry->student->school_id;
     }
 
     /**
@@ -50,7 +50,7 @@ class EntryPolicy
             return true;
         }
 
-        return $user->school_id == $entry->student()->school_id;
+        return $user->school_id == $entry->student->school_id;
     }
 
     /**
diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index a5b83ed..96e5a59 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -41,7 +41,8 @@ class AuditionFactory extends Factory
 
         return [
             'event_id' => $event->id,
-            'name' => $this->faker->randomElement($instruments).$this->faker->numberBetween(1, 1000),
+            #'name' => $this->faker->randomElement($instruments).$this->faker->numberBetween(1, 1000),
+            'name' => 'New Instrument ' . $this->faker->sentence(5),
             'score_order' => $this->faker->numberBetween(2, 50),
             'entry_deadline' => Carbon::tomorrow(),
             'entry_fee' => 1000,
diff --git a/resources/views/judging/index.blade.php b/resources/views/judging/index.blade.php
index 27cdb34..abd34eb 100644
--- a/resources/views/judging/index.blade.php
+++ b/resources/views/judging/index.blade.php
@@ -8,7 +8,7 @@
             <x-card.heading>{{ $room->name }}</x-card.heading>
             <x-card.list.body>
                 @foreach($room->auditions as $audition)
-                    <a href="/judging/audition/{{$audition->id}}">
+                    <a href="{{ route('judging.auditionEntryList', $audition) }}">
                         <x-card.list.row class="!py-3 ml-3">{{ $audition->name }}</x-card.list.row>
                     </a>
                 @endforeach
diff --git a/tests/Feature/Pages/JudgingIndexTest.php b/tests/Feature/Pages/JudgingIndexTest.php
new file mode 100644
index 0000000..082b1f7
--- /dev/null
+++ b/tests/Feature/Pages/JudgingIndexTest.php
@@ -0,0 +1,115 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\Room;
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use App\Models\User;
+use App\Settings;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    Settings::set('judging_enabled', true);
+    Settings::set('advanceTo', 'OMEA');
+    $scoringGuide = ScoringGuide::factory()->create();
+    SubscoreDefinition::factory()->count(5)->create(['scoring_guide_id' => $scoringGuide->id]);
+    $this->user = User::factory()->create();
+    $this->rooms = Room::factory()->count(2)->create();
+    $this->auditions = [];
+    foreach ($this->rooms as $room) {
+        $room->judges()->attach($this->user);
+        $this->auditions[] = Audition::factory()->create(['room_id' => $room->id, 'scoring_guide_id' => $scoringGuide->id]);
+        $this->auditions[] = Audition::factory()->create(['room_id' => $room->id, 'scoring_guide_id' => $scoringGuide->id]);
+        $this->auditions[] = Audition::factory()->create(['room_id' => $room->id, 'scoring_guide_id' => $scoringGuide->id]);
+    }
+
+    foreach ($this->auditions as $audition) {
+        Entry::factory()->count(23)->create(['audition_id' => $audition->id]);
+    }
+
+});
+
+it('responds nicely to a user assigned to judge when judging is enabled', function () {
+    actingAs($this->user);
+    get(route('judging.index'))
+        ->assertOk();
+});
+
+it('redirects when judging is not enabled', function () {
+    Settings::set('judging_enabled', false);
+    actingAs($this->user);
+    get(route('judging.index'))
+        ->assertRedirect(route('dashboard'));
+});
+
+it('redirects when a user not assigned to judge tries', function () {
+    // Arrange
+    actingAs(User::factory()->create());
+    // Act
+    $response = get(route('judging.index'));
+    // Assert
+    $response->assertRedirect(route('dashboard'));
+});
+
+it('redirects when a guest attempts to access', function () {
+    // Act & Assert
+    get(route('judging.index'))
+        ->assertRedirect(route('home'));
+});
+it('shows rooms the user is assigned to judge', function () {
+    // Arrange
+    actingAs($this->user);
+    // Act
+    $response = get(route('judging.index'));
+    // Assert
+    foreach ($this->rooms as $room) {
+        $response->assertSee($room->name);
+    }
+});
+it('shows auditions in the rooms the user is assigned to judge', function () {
+    // Arrange
+    actingAs($this->user);
+    // Act
+    $response = get(route('judging.index'));
+    // Assert
+    foreach ($this->auditions as $audition) {
+        $response->assertSee($audition->name);
+    }
+});
+it('links to the entry list for each audition the user is assigned to judge', function () {
+    // Arrange
+    actingAs($this->user);
+    // Act
+    $response = get(route('judging.index'));
+    // Assert
+    foreach ($this->auditions as $audition) {
+        $response->assertSee(route('judging.auditionEntryList', $audition));
+    }
+});
+it('has links that work for each audition the user is assigned to judge', function () {
+    // Arrange
+    actingAs($this->user);
+    // Act & Assert
+    foreach ($this->auditions as $audition) {
+        get(route('judging.auditionEntryList', $audition))
+            ->assertOk();
+    }
+});
+it('does not show the user room and auditions they are not assigned to judge', function () {
+    // Arrange
+    $otherRoom = Room::factory()->create();
+    $otherAudition = Audition::factory()->create(['room_id' => $otherRoom->id]);
+    actingAs($this->user);
+    // Act
+    $response = get(route('judging.index'));
+    // Assert
+    $response
+        ->assertDontSee($otherRoom->name)
+        ->assertDontSee($otherAudition->name);
+});
-- 
2.39.5


From 6b983cc0758711299b77c8802320c485756d4c5c Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Mon, 1 Jul 2024 23:43:03 -0500
Subject: [PATCH 25/61] Page Test for AuditionEntryList

---
 .../judging/audition_entry_list.blade.php     |   2 +-
 .../Pages/JudgingAudtionEntryListTest.php     | 110 ++++++++++++++++++
 2 files changed, 111 insertions(+), 1 deletion(-)
 create mode 100644 tests/Feature/Pages/JudgingAudtionEntryListTest.php

diff --git a/resources/views/judging/audition_entry_list.blade.php b/resources/views/judging/audition_entry_list.blade.php
index dfaec6a..a510a12 100644
--- a/resources/views/judging/audition_entry_list.blade.php
+++ b/resources/views/judging/audition_entry_list.blade.php
@@ -20,7 +20,7 @@
                 @foreach($entries as $entry)
                     <tr>
                         <x-table.td>
-                            <a href="/judging/entry/{{$entry->id}}">
+                            <a href="{{ route('judging.entryScoreSheet',$entry) }}">
                                 {{ $audition->name }} {{ $entry->draw_number }}
                             </a>
                         </x-table.td>
diff --git a/tests/Feature/Pages/JudgingAudtionEntryListTest.php b/tests/Feature/Pages/JudgingAudtionEntryListTest.php
new file mode 100644
index 0000000..e700af0
--- /dev/null
+++ b/tests/Feature/Pages/JudgingAudtionEntryListTest.php
@@ -0,0 +1,110 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\Room;
+use App\Models\ScoreSheet;
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use App\Models\User;
+use App\Settings;
+use Database\Seeders\ScoreAllAuditions;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\Artisan;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    Settings::set('judging_enabled', true);
+    Settings::set('advanceTo', 'OMEA');
+    $scoringGuide = ScoringGuide::factory()->create();
+    SubscoreDefinition::factory()->count(5)->create(['scoring_guide_id' => $scoringGuide->id]);
+    $this->user = User::factory()->create();
+    $this->room = Room::factory()->create();
+    $this->room->addJudge($this->user->id);
+    $this->audition = Audition::factory()->create([
+        'room_id' => $this->room->id,
+        'scoring_guide_id' => $scoringGuide->id,
+    ]);
+    $this->entries = Entry::factory()->count(35)->create(['audition_id' => $this->audition->id]);
+    $n = 1;
+    foreach ($this->entries as $entry) {
+        $entry->draw_number = $n++;
+        $entry->save();
+    }
+
+});
+
+test('responds favorably to a user assigned to judge this audition', function () {
+    $this->actingAs($this->user);
+    $this->get(route('judging.auditionEntryList', $this->audition->id))
+        ->assertOK();
+});
+test('redirects a user that is not assigned to judge this audition', function () {
+    $user = User::factory()->create();
+    $this->actingAs($user);
+    $this->get(route('judging.auditionEntryList', $this->audition->id))
+        ->assertRedirect(route('dashboard'));
+});
+test('redirects a guest', function () {
+    $this->get(route('judging.auditionEntryList', $this->audition->id))
+        ->assertRedirect(route('home'));
+});
+it('redirects if judging is not enabled', function () {
+    // Arrange
+    Settings::set('judging_enabled', false);
+    // Act & Assert
+    $this->actingAs($this->user);
+    $this->get(route('judging.auditionEntryList', $this->audition->id))
+        ->assertRedirect(route('dashboard'));
+});
+test('shows headings for each subscore', function () {
+    $this->actingAs($this->user);
+    $response = $this->get(route('judging.auditionEntryList', $this->audition->id));
+    foreach ($this->audition->scoringGuide->subscores as $subscore) {
+        $response->assertSeeInOrder(['th', $subscore->name, '/th']);
+    }
+});
+test('it shows each entry in the audition', function () {
+    $this->actingAs($this->user);
+    $response = $this->get(route('judging.auditionEntryList', $this->audition->id));
+    foreach ($this->entries as $entry) {
+        $response->assertSeeInOrder(['td', $entry->draw_number, '/td']);
+    }
+});
+test('it shows a working link to the score sheet for each entry in the audition', function () {
+    $this->actingAs($this->user);
+    $response = $this->get(route('judging.auditionEntryList', $this->audition->id));
+    foreach ($this->entries as $entry) {
+        $response->assertSee(route('judging.entryScoreSheet', $entry));
+        $this->get(route('judging.entryScoreSheet', $entry))
+            ->assertOK();
+    }
+});
+test('it has a column for votes if advancement is enabled', function () {
+    Settings::set('advanceTo', 'OMEA');
+    $this->actingAs($this->user);
+    $response = $this->get(route('judging.auditionEntryList', $this->audition->id));
+    $response->assertSeeInOrder(['th', 'OMEA', '/th']);
+});
+test('it shows scores previously entered', function () {
+    $this->actingAs($this->user);
+    Artisan::call('db:seed', ['--class' => ScoreAllAuditions::class]);
+    $response = $this->get(route('judging.auditionEntryList', $this->audition->id));
+
+    $testEntry = $this->entries->first();
+    $testSubscores = ScoreSheet::where('entry_id', $testEntry->id)->first()->subscores;
+    $arrayToTest = [];
+    $orderedSubscores = $this->audition->scoringGuide->subscores()->orderBy('display_order')->get();
+    foreach ($orderedSubscores as $subscore) {
+        $arrayToTest[] = $testSubscores[$subscore->id]['score'];
+    }
+    $response->assertSeeInOrder([
+        'td', $arrayToTest[0], '/td',
+        'td', $arrayToTest[1], '/td',
+        'td', $arrayToTest[2], '/td',
+        'td', $arrayToTest[3], '/td',
+        'td', $arrayToTest[4], '/td',
+    ]);
+
+});
-- 
2.39.5


From 482acd791304cb5d62148e9dd11f85a43add0a6e Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 00:30:10 -0500
Subject: [PATCH 26/61] Create JudgingEntryScoreSheetTest.php

---
 .../Pages/JudgingEntryScoreSheetTest.php      | 120 ++++++++++++++++++
 1 file changed, 120 insertions(+)
 create mode 100644 tests/Feature/Pages/JudgingEntryScoreSheetTest.php

diff --git a/tests/Feature/Pages/JudgingEntryScoreSheetTest.php b/tests/Feature/Pages/JudgingEntryScoreSheetTest.php
new file mode 100644
index 0000000..990c674
--- /dev/null
+++ b/tests/Feature/Pages/JudgingEntryScoreSheetTest.php
@@ -0,0 +1,120 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\Room;
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use App\Models\User;
+use App\Settings;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    Settings::set('judging_enabled', true);
+    Settings::set('advanceTo', 'OMEA');
+    $this->scoringGuide = ScoringGuide::factory()->create();
+    SubscoreDefinition::factory()->count(5)->create(['scoring_guide_id' => $this->scoringGuide->id]);
+    $this->user = User::factory()->create();
+    $this->room = Room::factory()->create();
+    $this->room->addJudge($this->user->id);
+    $this->audition = Audition::factory()->create([
+        'room_id' => $this->room->id,
+        'scoring_guide_id' => $this->scoringGuide->id,
+    ]);
+    $this->entries = Entry::factory()->count(35)->create(['audition_id' => $this->audition->id]);
+    $n = 1;
+    foreach ($this->entries as $entry) {
+        $entry->draw_number = $n++;
+        $entry->save();
+    }
+
+});
+
+it('responds favorably to a user assigned to judge this audition', function () {
+    $this->actingAs($this->user);
+    $this->get(route('judging.entryScoreSheet', $this->entries->first()))
+        ->assertOK();
+});
+it('redirects a user that is not assigned to judge this audition', function () {
+    $user = User::factory()->create();
+    $this->actingAs($user);
+    $this->get(route('judging.entryScoreSheet', $this->entries->first()))
+        ->assertRedirect(route('dashboard'));
+});
+it('redirects a guest', function () {
+    $this->get(route('judging.entryScoreSheet', $this->entries->first()))
+        ->assertRedirect(route('home'));
+});
+it('redirects if judging is not enabled', function () {
+    // Arrange
+    Settings::set('judging_enabled', false);
+    // Act & Assert
+    $this->actingAs($this->user);
+    $this->get(route('judging.entryScoreSheet', $this->entries->first()))
+        ->assertRedirect(route('dashboard'));
+});
+it('has a field label for each subscore', function () {
+    // Arrange
+    $this->actingAs($this->user);
+    $response = $this->get(route('judging.entryScoreSheet', $this->entries->first()));
+    // Act & Assert
+    foreach ($this->scoringGuide->subscores as $subscore) {
+        $response->assertSeeInOrder(['label', $subscore->name, '/label']);
+    }
+});
+it('has an input field for each subscore', function () {
+    // Arrange
+    $this->actingAs($this->user);
+    // Act & Assert
+    $response = $this->get(route('judging.entryScoreSheet', $this->entries->first()));
+    foreach ($this->scoringGuide->subscores as $subscore) {
+        $response->assertSeeInOrder(['input', 'name=', 'score['.$subscore->id.']']);
+    }
+});
+it('shows advancement votes if advancement is enabled', function () {
+    // Arrange
+    Settings::set('advanceTo', 'OMEA');
+    $this->actingAs($this->user);
+    // Act & Assert
+    $response = $this->get(route('judging.entryScoreSheet', $this->entries->first()));
+    $response
+        ->assertSee(auditionSetting('advanceTo').' Advancement')
+        ->assertSeeInOrder(['Yes', 'No', 'DQ']);
+
+    Settings::set('advanceTo', null);
+    $response = $this->get(route('judging.entryScoreSheet', $this->entries->first()));
+    $response
+        ->assertDontSee([auditionSetting('advanceTo').' Advancement', 'Yes', 'DQ']);
+});
+it('allows an assigned judge to enter scores', function () {
+    // Arrange
+    $this->actingAs($this->user);
+    $score = [];
+    foreach ($this->scoringGuide->subscores as $subscore) {
+        $score[$subscore->id] = mt_rand(0, 100);
+    }
+    // Act & Assert
+    $this->post(route('judging.saveScoreSheet', $this->entries->first()),
+        ['advancement-vote' => 'yes', 'score' => $score])
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('judging.auditionEntryList', $this->entries->first()->audition))
+        ->assertSessionHas('success',
+            'Entered scores for '.$this->entries->first()->audition->name.' '.$this->entries->first()->draw_number);
+
+    $arrayToTest = [];
+    $orderedSubscores = $this->audition->scoringGuide->subscores()->orderBy('display_order')->get();
+    foreach ($orderedSubscores as $subscore) {
+        $arrayToTest[] = $score[$subscore->id];
+    }
+    $this->get(route('judging.auditionEntryList', $this->entries->first()->audition))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'td', $arrayToTest[0], '/td',
+            'td', $arrayToTest[1], '/td',
+            'td', $arrayToTest[2], '/td',
+            'td', $arrayToTest[3], '/td',
+            'td', $arrayToTest[4], '/td',
+        ]);
+});
-- 
2.39.5


From d79ad3e5d1303d363eb1351ab859694c2d377a5f Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 09:28:39 -0500
Subject: [PATCH 27/61] Navbar and admin dashboard tests

---
 app/Http/Middleware/CheckIfAdmin.php        |  2 +-
 routes/admin.php                            |  2 +-
 tests/Feature/NavbarTest.php                | 61 +++++++++++++++++++++
 tests/Feature/Pages/Admin/DashboardTest.php | 21 +++++++
 4 files changed, 84 insertions(+), 2 deletions(-)
 create mode 100644 tests/Feature/NavbarTest.php
 create mode 100644 tests/Feature/Pages/Admin/DashboardTest.php

diff --git a/app/Http/Middleware/CheckIfAdmin.php b/app/Http/Middleware/CheckIfAdmin.php
index 69b2a37..50d63ab 100644
--- a/app/Http/Middleware/CheckIfAdmin.php
+++ b/app/Http/Middleware/CheckIfAdmin.php
@@ -20,7 +20,7 @@ class CheckIfAdmin
             return $next($request);
         }
 
-        return redirect(route('home'))->with('error', 'You do not have admin access.');
+        return redirect(route('dashboard'))->with('error', 'You do not have admin access.');
 
     }
 }
diff --git a/routes/admin.php b/routes/admin.php
index 4f7d721..95a7879 100644
--- a/routes/admin.php
+++ b/routes/admin.php
@@ -5,7 +5,7 @@ use App\Http\Middleware\CheckIfAdmin;
 use Illuminate\Support\Facades\Route;
 
 Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->group(function () {
-    Route::view('/', 'admin.dashboard');
+    Route::view('/', 'admin.dashboard')->name('admin.dashboard');
 
     Route::post('/auditions/roomUpdate', [\App\Http\Controllers\Admin\AuditionController::class, 'roomUpdate']); // Endpoint for JS assigning auditions to rooms
     Route::post('/scoring/assign_guide_to_audition', [\App\Http\Controllers\Admin\AuditionController::class, 'scoringGuideUpdate']); // Endpoint for JS assigning scoring guides to auditions
diff --git a/tests/Feature/NavbarTest.php b/tests/Feature/NavbarTest.php
new file mode 100644
index 0000000..d267234
--- /dev/null
+++ b/tests/Feature/NavbarTest.php
@@ -0,0 +1,61 @@
+<?php
+
+use App\Models\Room;
+use App\Models\User;
+use App\Settings;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+it('only shows the judging option when a user is assigned to judge and judging is enabled', function () {
+    // Arrange
+    $room = Room::factory()->create();
+    $noJudgeUser = User::factory()->create();
+    $judgeUser = User::factory()->create();
+    $adminNoJudgeUser = User::factory()->admin()->create();
+    $room->judges()->attach($judgeUser);
+
+    Settings::set('judging_enabled', false);
+    actingAs($noJudgeUser);
+    get(route('dashboard'))->assertDontSee('Judging');
+    actingAs($judgeUser);
+    get(route('dashboard'))->assertDontSee('Judging');
+    actingAs($adminNoJudgeUser);
+    get(route('dashboard'))->assertDontSee('Judging');
+
+    Settings::set('judging_enabled', true);
+    actingAs($noJudgeUser);
+    get(route('dashboard'))->assertDontSee('Judging');
+    actingAs($judgeUser);
+    get(route('dashboard'))->assertSee('Judging');
+    actingAs($adminNoJudgeUser);
+    get(route('dashboard'))->assertDontSee('Judging');
+});
+
+it('only shows Administration and Setup menus when the user is an administrator', function () {
+    // Arrange
+    $adminUser = User::factory()->admin()->create();
+    $nonAdminUser = User::factory()->create();
+
+    actingAs($adminUser);
+    get(route('dashboard'))->assertSee('Administration')->assertSee('Setup');
+    actingAs($nonAdminUser);
+    get(route('dashboard'))->assertDontSee('Administration')->assertDontSee('Setup');
+});
+
+it('only shows the Tabulation dropdown to tabulators and administrators', function () {
+    // Arrange
+    $adminUser = User::factory()->admin()->create();
+    $tabUser = User::factory()->tab()->create();
+    $normalUser = User::factory()->create();
+    // Act & Assert
+    actingAs($adminUser);
+    get(route('dashboard'))->assertSee('Tabulation');
+    actingAs($tabUser);
+    get(route('dashboard'))->assertSee('Tabulation');
+    actingAs($normalUser);
+    get(route('dashboard'))->assertDontSee('Tabulation');
+
+});
diff --git a/tests/Feature/Pages/Admin/DashboardTest.php b/tests/Feature/Pages/Admin/DashboardTest.php
new file mode 100644
index 0000000..fa4d779
--- /dev/null
+++ b/tests/Feature/Pages/Admin/DashboardTest.php
@@ -0,0 +1,21 @@
+<?php
+
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+it('only shows for an admin user', function () {
+    // Arrange
+    $adminUser = User::factory()->admin()->create();
+    $nonAdminUser = User::factory()->create();
+
+    // Act & Assert
+    get(route('dashboard'))->assertRedirect(route('home'));
+    actingAs($adminUser);
+    get(route('admin.dashboard'))->assertOk();
+    actingAs($nonAdminUser);
+    get(route('admin.dashboard'))->assertRedirect(route('dashboard'));
+});
-- 
2.39.5


From e5699ed8d845e09eeb2f5fc1def1b0bd507e12b6 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 09:57:29 -0500
Subject: [PATCH 28/61] AdminUsersIndex page test

---
 resources/views/admin/users/index.blade.php  |  4 +-
 routes/admin.php                             | 12 +--
 tests/Feature/Pages/Admin/DashboardTest.php  |  2 +-
 tests/Feature/Pages/Admin/UsersIndexTest.php | 78 ++++++++++++++++++++
 4 files changed, 87 insertions(+), 9 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/UsersIndexTest.php

diff --git a/resources/views/admin/users/index.blade.php b/resources/views/admin/users/index.blade.php
index 4379bab..137e5e2 100644
--- a/resources/views/admin/users/index.blade.php
+++ b/resources/views/admin/users/index.blade.php
@@ -6,7 +6,7 @@
             <x-slot:title class="ml-3">Users</x-slot:title>
             <x-slot:subtitle class="ml-3">Click name to edit</x-slot:subtitle>
             <x-slot:title_block_right class="mr-3">
-                <x-form.button href="/admin/users/create">New User</x-form.button>
+                <x-form.button href="{{ route('admin.users.create') }}">New User</x-form.button>
             </x-slot:title_block_right>
 
             <thead>
@@ -21,7 +21,7 @@
             <x-table.body>
             @foreach($users as $user)
                 <tr>
-                    <x-table.td><a href="/admin/users/{{ $user->id }}/edit">{{ $user->full_name(true) }}</a></x-table.td>
+                    <x-table.td><a href="{{ route('admin.users.edit',$user) }}">{{ $user->full_name(true) }}</a></x-table.td>
                     <x-table.td>{{ $user->has_school() ?  $user->school->name : ' ' }}</x-table.td>
                     <x-table.td>{{ $user->email }}</x-table.td>
                     <x-table.td>{{ $user->cell_phone }}</x-table.td>
diff --git a/routes/admin.php b/routes/admin.php
index 95a7879..9c0c26a 100644
--- a/routes/admin.php
+++ b/routes/admin.php
@@ -108,11 +108,11 @@ Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->
 
     // Admin User Routes
     Route::prefix('users')->controller(\App\Http\Controllers\Admin\UserController::class)->group(function () {
-        Route::get('/', 'index');
-        Route::get('/create', 'create');
-        Route::post('/', 'store');
-        Route::get('/{user}/edit', 'edit');
-        Route::patch('/{user}', 'update');
-        Route::delete('/{user}', 'destroy');
+        Route::get('/', 'index')->name('admin.users.index');
+        Route::get('/create', 'create')->name('admin.users.create');
+        Route::post('/', 'store')->name('admin.users.store');
+        Route::get('/{user}/edit', 'edit')->name('admin.users.edit');
+        Route::patch('/{user}', 'update')->name('admin.users.update');
+        Route::delete('/{user}', 'destroy')->name('admin.users.destroy');
     });
 });
diff --git a/tests/Feature/Pages/Admin/DashboardTest.php b/tests/Feature/Pages/Admin/DashboardTest.php
index fa4d779..1b4435a 100644
--- a/tests/Feature/Pages/Admin/DashboardTest.php
+++ b/tests/Feature/Pages/Admin/DashboardTest.php
@@ -13,7 +13,7 @@ it('only shows for an admin user', function () {
     $nonAdminUser = User::factory()->create();
 
     // Act & Assert
-    get(route('dashboard'))->assertRedirect(route('home'));
+    get(route('admin.dashboard'))->assertRedirect(route('home'));
     actingAs($adminUser);
     get(route('admin.dashboard'))->assertOk();
     actingAs($nonAdminUser);
diff --git a/tests/Feature/Pages/Admin/UsersIndexTest.php b/tests/Feature/Pages/Admin/UsersIndexTest.php
new file mode 100644
index 0000000..c9198ff
--- /dev/null
+++ b/tests/Feature/Pages/Admin/UsersIndexTest.php
@@ -0,0 +1,78 @@
+<?php
+
+use App\Models\School;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->nonAdminUser = User::factory()->create();
+    $this->tabUser = User::factory()->tab()->create();
+    $this->users = User::factory(3)->create();
+    $this->schools = [];
+    foreach ($this->users as $user) {
+        $school = School::factory()->create();
+        $user->school_id = $school->id;
+        $user->save();
+    }
+});
+
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.users.index';
+    get(route($checkRoute))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute))->assertOk();
+    actingAs($this->nonAdminUser);
+    get(route($checkRoute))->assertRedirect(route('dashboard'));
+});
+
+it('has a new user link', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.users.index'))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'href=',
+            route('admin.users.create'),
+            'New User',
+            '/a',
+        ]);
+});
+
+it('shows user data', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.index'));
+    $response->assertOk();
+    foreach ($this->users as $user) {
+        $response->assertSeeInOrder([
+            $user->full_name(true),
+            $user->school->name,
+            $user->email,
+            $user->cell_phone,
+            $user->judging_preference,
+        ]);
+    }
+});
+
+it('has an edit link for each user', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.index'));
+    $response->assertOk();
+    $response->assertSee(route('admin.users.edit', $this->adminUser));
+    $response->assertSee(route('admin.users.edit', $this->nonAdminUser));
+    $response->assertSee(route('admin.users.edit', $this->tabUser));
+    foreach ($this->users as $user) {
+        $response->assertSee(route('admin.users.edit', $user));
+    }
+});
-- 
2.39.5


From f2e68f7388c48165d5c0328b2ca36374b97e2cef Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 10:58:21 -0500
Subject: [PATCH 29/61] AdminUserEdit Page Test - includes AdminUserUpdate

---
 app/Http/Controllers/Admin/UserController.php |  34 ++--
 resources/views/admin/users/edit.blade.php    |   2 +-
 tests/Feature/Pages/Admin/UsersEditTest.php   | 160 ++++++++++++++++++
 3 files changed, 183 insertions(+), 13 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/UsersEditTest.php

diff --git a/app/Http/Controllers/Admin/UserController.php b/app/Http/Controllers/Admin/UserController.php
index ab5a1a6..60d38ef 100644
--- a/app/Http/Controllers/Admin/UserController.php
+++ b/app/Http/Controllers/Admin/UserController.php
@@ -2,8 +2,6 @@
 
 namespace App\Http\Controllers\Admin;
 
-use App\Events\AuditionChange;
-use App\Events\RoomJudgeChange;
 use App\Http\Controllers\Controller;
 use App\Mail\NewUserPassword;
 use App\Models\School;
@@ -18,28 +16,39 @@ class UserController extends Controller
 {
     public function index()
     {
-        if (! Auth::user()->is_admin) abort(403);
+        if (! Auth::user()->is_admin) {
+            abort(403);
+        }
         $users = User::with('school')->orderBy('last_name')->orderBy('first_name')->get();
+
         return view('admin.users.index', ['users' => $users]);
     }
 
     public function edit(User $user)
     {
-        if (! Auth::user()->is_admin) abort(403);
+        if (! Auth::user()->is_admin) {
+            abort(403);
+        }
         $schools = School::orderBy('name')->get();
-        return view('admin.users.edit', ['user' => $user,'schools' => $schools]);
+
+        return view('admin.users.edit', ['user' => $user, 'schools' => $schools]);
     }
 
     public function create()
     {
-        if (! Auth::user()->is_admin) abort(403);
+        if (! Auth::user()->is_admin) {
+            abort(403);
+        }
         $schools = School::orderBy('name')->get();
+
         return view('admin.users.create', ['schools' => $schools]);
     }
 
     public function update(Request $request, User $user)
     {
-        if (! Auth::user()->is_admin) abort(403);
+        if (! Auth::user()->is_admin) {
+            abort(403);
+        }
 
         request()->validate([
             'first_name' => ['required'],
@@ -47,7 +56,7 @@ class UserController extends Controller
             'email' => ['required', 'email'],
             'cell_phone' => ['required'],
             'judging_preference' => ['required'],
-            'school_id' => ['required','exists:schools,id'],
+            'school_id' => ['required', 'exists:schools,id'],
         ]);
 
         $user->update([
@@ -56,8 +65,9 @@ class UserController extends Controller
             'email' => request('email'),
             'cell_phone' => request('cell_phone'),
             'judging_preference' => request('judging_preference'),
-            'school_id' => request('school_id')
+            'school_id' => request('school_id'),
         ]);
+
         return redirect('/admin/users');
     }
 
@@ -66,7 +76,7 @@ class UserController extends Controller
         $request->validate([
             'first_name' => ['required'],
             'last_name' => ['required'],
-            'email' => ['required', 'email','unique:users'],
+            'email' => ['required', 'email', 'unique:users'],
         ]);
 
         // Genearte a random password
@@ -81,9 +91,9 @@ class UserController extends Controller
             'password' => Hash::make($randomPassword),
         ]);
 
-        if (!is_null(request('school_id'))) {
+        if (! is_null(request('school_id'))) {
             $request->validate([
-                'school_id' => ['exists:schools,id']
+                'school_id' => ['exists:schools,id'],
             ]);
         }
         $user->school_id = request('school_id');
diff --git a/resources/views/admin/users/edit.blade.php b/resources/views/admin/users/edit.blade.php
index 7dbd695..99c4aad 100644
--- a/resources/views/admin/users/edit.blade.php
+++ b/resources/views/admin/users/edit.blade.php
@@ -1,7 +1,7 @@
 <x-layout.app>
     <x-card.card class="mx-auto max-w-lg">
         <x-card.heading>Edit User</x-card.heading>
-        <x-form.form method="PATCH" action="/admin/users/{{ $user->id }}">
+        <x-form.form method="PATCH" action="{{ route('admin.users.update', $user) }}">
             <x-form.body-grid>
                 <x-form.field name="first_name" label_text="First Name" colspan="3" value="{{ $user->first_name }}" />
                 <x-form.field name="last_name" label_text="Last Name" colspan="3" value="{{ $user->last_name }}" />
diff --git a/tests/Feature/Pages/Admin/UsersEditTest.php b/tests/Feature/Pages/Admin/UsersEditTest.php
new file mode 100644
index 0000000..eacde34
--- /dev/null
+++ b/tests/Feature/Pages/Admin/UsersEditTest.php
@@ -0,0 +1,160 @@
+<?php
+
+use App\Models\School;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+use function Pest\Laravel\patch;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->nonAdminUser = User::factory()->create();
+    $this->tabUser = User::factory()->tab()->create();
+    $this->users = User::factory(3)->create();
+    $this->schools = [];
+    foreach ($this->users as $user) {
+        $school = School::factory()->create();
+        $user->school_id = $school->id;
+        $user->save();
+    }
+});
+
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.users.edit';
+    get(route($checkRoute, $this->users[0]))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute, $this->users[0]))->assertOk();
+    actingAs($this->nonAdminUser);
+    get(route($checkRoute, $this->users[0]))->assertRedirect(route('dashboard'));
+});
+
+it('submits a patch request', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.edit', $this->users[0]));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'form',
+        'method',
+        'POST',
+        'action=',
+        route('admin.users.update', $this->users[0]),
+        '/form',
+    ]);
+    $response->assertSee('<input type="hidden" name="_method" value="PATCH">', false);
+});
+it('has all needed fields', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $fieldNames = [
+        'first_name',
+        'last_name',
+        'email',
+        'cell_phone',
+        'judging_preference',
+    ];
+    // Act & Assert
+    $response = get(route('admin.users.edit', $this->users[0]));
+    $response->assertOk();
+    foreach ($fieldNames as $fieldName) {
+        $response->assertSeeInOrder([
+            'input',
+            'name=',
+            $fieldName,
+            '/',
+        ]);
+    }
+    $response->assertSeeInOrder([
+        'select',
+        'name',
+        'school_id',
+        '/select',
+    ]);
+});
+it('is prefilled with existing user data', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $valueChecks = [
+        'first_name' => $this->users[0]->first_name,
+        'last_name' => $this->users[0]->last_name,
+        'email' => $this->users[0]->email,
+        'cell_phone' => $this->users[0]->cell_phone,
+        'judging_preference' => $this->users[0]->judging_preference,
+    ];
+    // Act & Assert
+    $response = get(route('admin.users.edit', $this->users[0]));
+    $response->assertOk();
+    foreach ($valueChecks as $check) {
+        $response->assertSeeInOrder(
+            [
+                'input',
+                'value=',
+                $check,
+                '/',
+            ]
+        );
+    }
+    $response->assertSeeInOrder([
+        'option',
+        'value=',
+        $this->users[0]->school_id,
+        'selected',
+        '/option',
+    ]);
+});
+it('has all schools in a dropdown', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.edit', $this->users[0]));
+    $response->assertOk();
+    foreach ($this->schools as $school) {
+        $response->assertSeeInOrder([
+            'option',
+            'value=',
+            $school->id,
+            $school->name,
+            '/option',
+        ]);
+    }
+});
+it('rejects a submission by a non administrator', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    // Act & Assert
+    $response = patch(route('admin.users.update', $this->users[0]), [
+        'first_name' => 'New First Name',
+        'last_name' => 'New Last Name',
+    ]);
+    $response->assertRedirect(route('dashboard'));
+});
+it('allows an administrator to modify a user', function () {
+    // Arrange
+    $newSchool = School::factory()->create(['name' => 'New School']);
+    actingAs($this->adminUser);
+    $newData = [
+        'first_name' => 'New First Name',
+        'last_name' => 'New Last Name',
+        'email' => 'new@emailllllll.com',
+        'cell_phone' => '123-456-7890',
+        'judging_preference' => 'New Judging Preference',
+        'school_id' => $newSchool->id,
+    ];
+    // Act
+    $response = patch(route('admin.users.update', $this->users[0]), $newData);
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.users.index'));
+    $this->users[0]->refresh();
+    expect($this->users[0]->first_name)->toBe($newData['first_name'])
+        ->and($this->users[0]->last_name)->toBe($newData['last_name'])
+        ->and($this->users[0]->email)->toBe($newData['email'])
+        ->and($this->users[0]->cell_phone)->toBe($newData['cell_phone'])
+        ->and($this->users[0]->judging_preference)->toBe($newData['judging_preference'])
+        ->and($this->users[0]->school->name)->toBe($newSchool->name);
+});
-- 
2.39.5


From 164ed813629b5efc62d8f6fc28307ee3eff57361 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 11:03:42 -0500
Subject: [PATCH 30/61] Install paralell testing

---
 composer.json | 1 +
 composer.lock | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/composer.json b/composer.json
index ec0e281..177ffef 100644
--- a/composer.json
+++ b/composer.json
@@ -16,6 +16,7 @@
     },
     "require-dev": {
         "barryvdh/laravel-debugbar": "^3.13",
+        "brianium/paratest": "^7.4",
         "fakerphp/faker": "^1.23",
         "laravel/pint": "^1.13",
         "laravel/sail": "^1.26",
diff --git a/composer.lock b/composer.lock
index 89e03a3..d9ebfa5 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "8a539bb700e8acfbb39c896521c16609",
+    "content-hash": "91ced10faccf6fc9b3fe05fe288ec1d6",
     "packages": [
         {
             "name": "bacon/bacon-qr-code",
-- 
2.39.5


From 396a1dcc076afb09b7c07b521ce61cc011eee3aa Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 11:26:50 -0500
Subject: [PATCH 31/61] AdminUsersCreate Test

---
 resources/views/admin/users/create.blade.php  |   4 +-
 tests/Feature/Pages/Admin/UsersCreateTest.php | 140 ++++++++++++++++++
 tests/Feature/Pages/Admin/UsersEditTest.php   |  10 ++
 3 files changed, 152 insertions(+), 2 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/UsersCreateTest.php

diff --git a/resources/views/admin/users/create.blade.php b/resources/views/admin/users/create.blade.php
index 5e28ea4..ebc9fdf 100644
--- a/resources/views/admin/users/create.blade.php
+++ b/resources/views/admin/users/create.blade.php
@@ -1,7 +1,7 @@
 <x-layout.app>
     <x-card.card class="mx-auto max-w-lg">
         <x-card.heading>Create User</x-card.heading>
-        <x-form.form method="POST" action="/admin/users">
+        <x-form.form method="POST" action="{{ route('admin.users.store') }}">
             <x-form.body-grid>
                 <x-form.field name="first_name" label_text="First Name" colspan="3" />
                 <x-form.field name="last_name" label_text="Last Name" colspan="3" />
@@ -18,7 +18,7 @@
 
                 </x-form.select>
             </x-form.body-grid>
-            <x-form.footer>
+            <x-form.footer class="pb-5">
                 <x-form.button>Create User</x-form.button>
             </x-form.footer>
         </x-form.form>
diff --git a/tests/Feature/Pages/Admin/UsersCreateTest.php b/tests/Feature/Pages/Admin/UsersCreateTest.php
new file mode 100644
index 0000000..6818903
--- /dev/null
+++ b/tests/Feature/Pages/Admin/UsersCreateTest.php
@@ -0,0 +1,140 @@
+<?php
+
+use App\Models\School;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->nonAdminUser = User::factory()->create();
+    $this->tabUser = User::factory()->tab()->create();
+    $this->users = User::factory(3)->create();
+    $this->schools = [];
+    foreach ($this->users as $user) {
+        $school = School::factory()->create();
+        $user->school_id = $school->id;
+        $user->save();
+    }
+});
+
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.users.create';
+    get(route($checkRoute, $this->users[0]))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute, $this->users[0]))->assertOk();
+    actingAs($this->nonAdminUser);
+    get(route($checkRoute, $this->users[0]))->assertRedirect(route('dashboard'));
+});
+it('submits a post request', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.create'));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'form',
+        'method',
+        'POST',
+        'action=',
+        route('admin.users.store'),
+        '/form',
+    ]);
+});
+it('has all needed fields', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $fieldNames = [
+        'first_name',
+        'last_name',
+        'email',
+        'cell_phone',
+        'judging_preference',
+    ];
+    // Act & Assert
+    $response = get(route('admin.users.create'));
+    $response->assertOk();
+    foreach ($fieldNames as $fieldName) {
+        $response->assertSeeInOrder([
+            'input',
+            'name=',
+            $fieldName,
+            '/',
+        ]);
+    }
+    $response->assertSeeInOrder([
+        'select',
+        'name',
+        'school_id',
+        '/select',
+    ]);
+});
+it('has all schools in a dropdown', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.create'));
+    $response->assertOk();
+    foreach ($this->schools as $school) {
+        $response->assertSeeInOrder([
+            'option',
+            'value=',
+            $school->id,
+            $school->name,
+            '/option',
+        ]);
+    }
+});
+it('rejects a submission by a non administrator', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    // Act & Assert
+    $response = post(route('admin.users.store'), [
+        'first_name' => 'New First Name',
+        'last_name' => 'New Last Name',
+    ]);
+    $response->assertRedirect(route('dashboard'));
+});
+it('allows an administrator to create a user', function () {
+    // Arrange
+    $newSchool = School::factory()->create(['name' => 'New School']);
+    actingAs($this->adminUser);
+    $newData = [
+        'first_name' => 'New First Name',
+        'last_name' => 'New Last Name',
+        'email' => 'new@emailllllll.com',
+        'cell_phone' => '123-456-7890',
+        'judging_preference' => 'New Judging Preference',
+        'school_id' => $newSchool->id,
+    ];
+    // Act
+    $response = post(route('admin.users.store'), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.users.index'));
+
+    // Get the latest created user
+    $createdUser = User::where('email', $newData['email'])->first();
+    expect($createdUser->first_name)->toBe($newData['first_name'])
+        ->and($createdUser->last_name)->toBe($newData['last_name'])
+        ->and($createdUser->email)->toBe($newData['email'])
+        ->and($createdUser->cell_phone)->toBe($newData['cell_phone'])
+        ->and($createdUser->judging_preference)->toBe($newData['judging_preference'])
+        ->and($createdUser->school->name)->toBe($newSchool->name);
+
+    get(route('admin.users.index'))
+        ->assertOk()
+        ->assertSee($newData['first_name'])
+        ->assertSee($newData['last_name'])
+        ->assertSee($newData['email'])
+        ->assertSee($newData['cell_phone'])
+        ->assertSee($newData['judging_preference'])
+        ->assertSee($newSchool->name);
+});
diff --git a/tests/Feature/Pages/Admin/UsersEditTest.php b/tests/Feature/Pages/Admin/UsersEditTest.php
index eacde34..202c7cb 100644
--- a/tests/Feature/Pages/Admin/UsersEditTest.php
+++ b/tests/Feature/Pages/Admin/UsersEditTest.php
@@ -147,6 +147,7 @@ it('allows an administrator to modify a user', function () {
     ];
     // Act
     $response = patch(route('admin.users.update', $this->users[0]), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
     $response
         ->assertSessionHasNoErrors()
         ->assertRedirect(route('admin.users.index'));
@@ -157,4 +158,13 @@ it('allows an administrator to modify a user', function () {
         ->and($this->users[0]->cell_phone)->toBe($newData['cell_phone'])
         ->and($this->users[0]->judging_preference)->toBe($newData['judging_preference'])
         ->and($this->users[0]->school->name)->toBe($newSchool->name);
+
+    get(route('admin.users.index'))
+        ->assertOk()
+        ->assertSee($newData['first_name'])
+        ->assertSee($newData['last_name'])
+        ->assertSee($newData['email'])
+        ->assertSee($newData['cell_phone'])
+        ->assertSee($newData['judging_preference'])
+        ->assertSee($newSchool->name);
 });
-- 
2.39.5


From a2ba06898f3bc40d06850f2797aba79e102576fe Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 12:04:24 -0500
Subject: [PATCH 32/61] Admin UserEditPage test

---
 app/Http/Controllers/Admin/UserController.php | 11 ++++++-
 resources/views/admin/users/edit.blade.php    | 13 +++++++-
 resources/views/admin/users/index.blade.php   |  2 +-
 tests/Feature/Pages/Admin/UsersEditTest.php   | 33 +++++++++++++++++++
 tests/Feature/Pages/Admin/UsersIndexTest.php  | 10 +++---
 5 files changed, 61 insertions(+), 8 deletions(-)

diff --git a/app/Http/Controllers/Admin/UserController.php b/app/Http/Controllers/Admin/UserController.php
index 60d38ef..1da19b7 100644
--- a/app/Http/Controllers/Admin/UserController.php
+++ b/app/Http/Controllers/Admin/UserController.php
@@ -79,7 +79,7 @@ class UserController extends Controller
             'email' => ['required', 'email', 'unique:users'],
         ]);
 
-        // Genearte a random password
+        // Generate a random password
         $randomPassword = Str::random(12);
 
         $user = \App\Models\User::make([
@@ -103,4 +103,13 @@ class UserController extends Controller
 
         return redirect('/admin/users');
     }
+
+    public function destroy(Request $request, User $user)
+    {
+        if (! Auth::user()->is_admin) {
+            abort(403);
+        }
+        $user->delete();
+        return redirect()->route('admin.users.index')->with('success', 'User deleted successfully');
+    }
 }
diff --git a/resources/views/admin/users/edit.blade.php b/resources/views/admin/users/edit.blade.php
index 99c4aad..c78ce44 100644
--- a/resources/views/admin/users/edit.blade.php
+++ b/resources/views/admin/users/edit.blade.php
@@ -1,6 +1,17 @@
 <x-layout.app>
     <x-card.card class="mx-auto max-w-lg">
-        <x-card.heading>Edit User</x-card.heading>
+        <x-card.heading>
+            Edit User
+            <x-slot:right_side>
+                @if($user->id != Auth::user()->id)
+                    <form method="POST" action="{{ route('admin.users.destroy',['user' => $user->id]) }}">
+                        @csrf
+                        @method('DELETE')
+                        <x-form.red-trash-button type="submit" />
+                    </form>
+                @endif
+            </x-slot:right_side>
+        </x-card.heading>
         <x-form.form method="PATCH" action="{{ route('admin.users.update', $user) }}">
             <x-form.body-grid>
                 <x-form.field name="first_name" label_text="First Name" colspan="3" value="{{ $user->first_name }}" />
diff --git a/resources/views/admin/users/index.blade.php b/resources/views/admin/users/index.blade.php
index 137e5e2..46da2fe 100644
--- a/resources/views/admin/users/index.blade.php
+++ b/resources/views/admin/users/index.blade.php
@@ -4,7 +4,7 @@
     <x-card.card>
         <x-table.table with_title_area>
             <x-slot:title class="ml-3">Users</x-slot:title>
-            <x-slot:subtitle class="ml-3">Click name to edit</x-slot:subtitle>
+            <x-slot:subtitle class="ml-3">Click name to edit or delete</x-slot:subtitle>
             <x-slot:title_block_right class="mr-3">
                 <x-form.button href="{{ route('admin.users.create') }}">New User</x-form.button>
             </x-slot:title_block_right>
diff --git a/tests/Feature/Pages/Admin/UsersEditTest.php b/tests/Feature/Pages/Admin/UsersEditTest.php
index 202c7cb..b0f12a6 100644
--- a/tests/Feature/Pages/Admin/UsersEditTest.php
+++ b/tests/Feature/Pages/Admin/UsersEditTest.php
@@ -5,6 +5,7 @@ use App\Models\User;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 
 use function Pest\Laravel\actingAs;
+use function Pest\Laravel\delete;
 use function Pest\Laravel\get;
 use function Pest\Laravel\patch;
 
@@ -168,3 +169,35 @@ it('allows an administrator to modify a user', function () {
         ->assertSee($newData['judging_preference'])
         ->assertSee($newSchool->name);
 });
+it('has a delete link for the user if not the current user', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.edit', $this->users[0]));
+    $response->assertOk();
+    $response->assertSee(route('admin.users.destroy', $this->users[0]));
+    $response->assertSee('<input type="hidden" name="_method" value="DELETE">', false);
+});
+it('does not show a delete link for the current user', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.edit', $this->adminUser));
+    $response->assertOk();
+    $response->assertDontSee('<input type="hidden" name="_method" value="DELETE">', false);
+});
+it('allows an administrator to destroy a user', function () {
+    // Arrange
+    $newUser = User::factory()->create();
+    actingAs($this->adminUser);
+    // Act & Assert
+    assert($newUser->exists());
+    $response = delete(route('admin.users.destroy', $newUser));
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'User deleted successfully')
+        ->assertRedirect(route('admin.users.index'));
+
+    expect(User::find($newUser->id))->toBeNull();
+});
diff --git a/tests/Feature/Pages/Admin/UsersIndexTest.php b/tests/Feature/Pages/Admin/UsersIndexTest.php
index c9198ff..bee9992 100644
--- a/tests/Feature/Pages/Admin/UsersIndexTest.php
+++ b/tests/Feature/Pages/Admin/UsersIndexTest.php
@@ -10,13 +10,13 @@ use function Pest\Laravel\get;
 uses(RefreshDatabase::class);
 
 beforeEach(function () {
-    $this->adminUser = User::factory()->admin()->create();
+    $this->adminUser    = User::factory()->admin()->create();
     $this->nonAdminUser = User::factory()->create();
-    $this->tabUser = User::factory()->tab()->create();
-    $this->users = User::factory(3)->create();
-    $this->schools = [];
+    $this->tabUser      = User::factory()->tab()->create();
+    $this->users        = User::factory(3)->create();
+    $this->schools      = [];
     foreach ($this->users as $user) {
-        $school = School::factory()->create();
+        $school          = School::factory()->create();
         $user->school_id = $school->id;
         $user->save();
     }
-- 
2.39.5


From f1a0f08f44848fd675e65b3f54dc0e629e8d6d74 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 12:16:43 -0500
Subject: [PATCH 33/61] Remove leftover scratch

---
 resources/views/admin/users/index.blade.php | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/resources/views/admin/users/index.blade.php b/resources/views/admin/users/index.blade.php
index 46da2fe..d5bef00 100644
--- a/resources/views/admin/users/index.blade.php
+++ b/resources/views/admin/users/index.blade.php
@@ -32,7 +32,3 @@
         </x-table.table>
     </x-card.card>
 </x-layout.app>
-
-
-
-{{ $user->has_school() ?  $user->school->name : 'No School' }}
-- 
2.39.5


From 71b4c245f977c4c9e12e7cfd2d30c2a71b15b44c Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 15:44:43 -0500
Subject: [PATCH 34/61] AdminSchoolsIndex test

---
 resources/views/admin/schools/index.blade.php |   4 +-
 .../Feature/Pages/Admin/SchoolsIndexTest.php  | 112 ++++++++++++++++++
 2 files changed, 114 insertions(+), 2 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/SchoolsIndexTest.php

diff --git a/resources/views/admin/schools/index.blade.php b/resources/views/admin/schools/index.blade.php
index 9ffc01e..e025c45 100644
--- a/resources/views/admin/schools/index.blade.php
+++ b/resources/views/admin/schools/index.blade.php
@@ -22,9 +22,9 @@
             <x-table.body>
                 @foreach($schools as $school)
                     <tr>
-                        <x-table.td><a href="/admin/schools/{{ $school->id }}">{{ $school->name }}</a></x-table.td>
+                        <x-table.td><a href="{{ route('admin.schools.edit',$school) }}">{{ $school->name }}</a></x-table.td>
                         <x-table.td>
-                            <a href="{{ route('admin.schools.invoice',$school->id) }}">
+                            <a href="{{ route('admin.schools.invoice',$school) }}">
                                 ${{ number_format($schoolTotalFees[$school->id],2) }}
                             </a>
                         </x-table.td>
diff --git a/tests/Feature/Pages/Admin/SchoolsIndexTest.php b/tests/Feature/Pages/Admin/SchoolsIndexTest.php
new file mode 100644
index 0000000..9e455b3
--- /dev/null
+++ b/tests/Feature/Pages/Admin/SchoolsIndexTest.php
@@ -0,0 +1,112 @@
+<?php
+
+use App\Models\Entry;
+use App\Models\School;
+use App\Models\Student;
+use App\Models\User;
+use App\Settings;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->nonAdminUser = User::factory()->create();
+    $this->tabUser = User::factory()->tab()->create();
+    $this->schools = School::factory()->count(5)->create();
+    $n = 10;
+    $this->students = [];
+    foreach ($this->schools as $school) {
+        $newStus = Student::factory()->count($n)->create(['school_id' => $school->id]);
+        foreach ($newStus as $student) {
+            $this->students[] = $student;
+        }
+        $n = $n + 3;
+    }
+    $n = 0;
+    foreach ($this->students as $student) {
+        Entry::factory()->create(['student_id' => $student->id]);
+        $n++;
+        if ($n === 10) {
+            Entry::factory()->create(['student_id' => $student->id]);
+            $n = 0;
+        }
+    }
+
+});
+
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.schools.index';
+    get(route($checkRoute))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute))->assertOk();
+    actingAs($this->nonAdminUser);
+    get(route($checkRoute))->assertRedirect(route('dashboard'));
+});
+it('has a new school link', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.schools.index'))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'href=',
+            route('admin.schools.create'),
+            'New School',
+            '/a',
+        ]);
+});
+it('shows school data', function () {
+    // Arrange
+    $invoiceDataService = new App\Services\Invoice\InvoiceOneFeePerEntry(new App\Services\EntryService(new App\Services\AuditionService()));
+    Settings::set('school_fees', 1000);
+    Settings::set('late_fee', 2500);
+    actingAs($this->adminUser);
+    $this->schools->loadCount(['users', 'students', 'entries']);
+    // Act & Assert
+    $response = get(route('admin.schools.index'));
+    $response->assertOk();
+    foreach ($this->schools as $school) {
+        $response->assertSeeInOrder([
+            'td',
+            $school->name,
+            '/td',
+            'td',
+            $invoiceDataService->getGrandTotal($school->id),
+            '/td',
+            'td',
+            $school->users_count,
+            '/td',
+            'td',
+            $school->students_count,
+            '/td',
+            'td',
+            $school->entries_count,
+            '/td',
+        ], false);
+    }
+});
+it('has an edit link for each school', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.schools.index'));
+    $response->assertOk();
+    foreach ($this->schools as $school) {
+        $response->assertSee(route('admin.schools.edit', $school));
+    }
+});
+it('has an invoice link for each school', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.schools.index'));
+    $response->assertOk();
+    foreach ($this->schools as $school) {
+        $response->assertSee(route('admin.schools.invoice', $school));
+    }
+});
-- 
2.39.5


From 635cf3f7be827176534a5344a7a137cbeb11c277 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 16:09:12 -0500
Subject: [PATCH 35/61] AdminSchoolsCreate Page Test

---
 .../views/admin/schools/create.blade.php      |   2 +-
 routes/admin.php                              |  10 +-
 .../Feature/Pages/Admin/SchoolsCreateTest.php | 101 ++++++++++++++++++
 3 files changed, 107 insertions(+), 6 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/SchoolsCreateTest.php

diff --git a/resources/views/admin/schools/create.blade.php b/resources/views/admin/schools/create.blade.php
index 145406c..c513bad 100644
--- a/resources/views/admin/schools/create.blade.php
+++ b/resources/views/admin/schools/create.blade.php
@@ -5,7 +5,7 @@
         </x-card.heading>
 
 
-        <x-form.form method="POST" action="/admin/schools" class="!mt-4">
+        <x-form.form method="POST" action="{{ route('admin.schools.store') }}" class="!mt-4">
             <x-form.body-grid columns="6" class="max-w-full">
                 <x-form.field name="name" label_text="School Name" colspan="6"/>
                 <x-form.field name="address" label_text="School Address" colspan="6"/>
diff --git a/routes/admin.php b/routes/admin.php
index 9c0c26a..8479387 100644
--- a/routes/admin.php
+++ b/routes/admin.php
@@ -85,11 +85,11 @@ Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->
 
     // Admin Student Routes
     Route::prefix('students')->controller(\App\Http\Controllers\Admin\StudentController::class)->group(function () {
-        Route::get('/', 'index');
-        Route::get('/create', 'create');
-        Route::post('/', 'store');
-        Route::get('/{student}/edit', 'edit');
-        Route::patch('/{student}', 'update');
+        Route::get('/', 'index')->name('admin.students.index');
+        Route::get('/create', 'create')->name('admin.students.create');
+        Route::post('/', 'store')->name('admin.students.store');
+        Route::get('/{student}/edit', 'edit')->name('admin.students.edit');
+        Route::patch('/{student}', 'update')->name('admin.students.update');
     });
 
     // Admin School Routes
diff --git a/tests/Feature/Pages/Admin/SchoolsCreateTest.php b/tests/Feature/Pages/Admin/SchoolsCreateTest.php
new file mode 100644
index 0000000..23a26aa
--- /dev/null
+++ b/tests/Feature/Pages/Admin/SchoolsCreateTest.php
@@ -0,0 +1,101 @@
+<?php
+
+use App\Models\School;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->nonAdminUser = User::factory()->create();
+    $this->tabUser = User::factory()->tab()->create();
+    $this->school = School::factory()->create();
+});
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.schools.create';
+    get(route($checkRoute, $this->school))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute, $this->school))->assertOk();
+    actingAs($this->nonAdminUser);
+    get(route($checkRoute, $this->school))->assertRedirect(route('dashboard'));
+});
+it('submits a post request', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.schools.create'));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'form',
+        'method',
+        'POST',
+        'action=',
+        route('admin.schools.store'),
+        '/form',
+    ]);
+});
+it('has all needed fields', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $fieldNames = [
+        'name',
+        'address',
+        'city',
+        'state',
+        'zip',
+    ];
+    // Act & Assert
+    $response = get(route('admin.schools.create'));
+    $response->assertOk();
+    foreach ($fieldNames as $fieldName) {
+        $response->assertSeeInOrder([
+            'input',
+            'name=',
+            $fieldName,
+            '/',
+        ]);
+    }
+});
+it('rejects a submission by a non administrator', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    // Act & Assert
+    $response = post(route('admin.schools.store'), [
+        'name' => 'Hacker High',
+        'address' => 'Lost Highway',
+    ]);
+    $response->assertRedirect(route('dashboard'));
+});
+it('allows an administrator to create a school', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $newData = [
+        'name' => fake()->city(),
+        'address' => fake()->streetAddress(),
+        'city' => fake()->city(),
+        'state' => 'OK',
+        'zip' => fake()->postcode(),
+    ];
+    // Act
+    $response = post(route('admin.schools.store'), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.schools.index'));
+
+    // Get the latest created user
+    $createdSchool = School::where('name', $newData['name'])->first();
+    expect($createdSchool->name)->toBe($newData['name'])
+        ->and($createdSchool->address)->toBe($newData['address'])
+        ->and($createdSchool->city)->toBe($newData['city'])
+        ->and($createdSchool->state)->toBe($newData['state'])
+        ->and($createdSchool->zip)->toEqual($newData['zip']);
+
+    get(route('admin.schools.index'))
+        ->assertOk()
+        ->assertSee($newData['name']);
+});
-- 
2.39.5


From 9ca0e5bb3ee67ded4388ceef02586b640ef13230 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 17:25:45 -0500
Subject: [PATCH 36/61] AdminSchoolsEdit Test

---
 .../Controllers/Admin/SchoolController.php    |   4 -
 .../factories/SchoolEmailDomainFactory.php    |  26 +++
 resources/views/admin/schools/edit.blade.php  |  42 +++-
 .../Feature/Pages/Admin/SchoolsCreateTest.php |   6 +-
 tests/Feature/Pages/Admin/SchoolsEditTest.php | 192 ++++++++++++++++++
 5 files changed, 261 insertions(+), 9 deletions(-)
 create mode 100644 database/factories/SchoolEmailDomainFactory.php
 create mode 100644 tests/Feature/Pages/Admin/SchoolsEditTest.php

diff --git a/app/Http/Controllers/Admin/SchoolController.php b/app/Http/Controllers/Admin/SchoolController.php
index af0ea3c..c081cfb 100644
--- a/app/Http/Controllers/Admin/SchoolController.php
+++ b/app/Http/Controllers/Admin/SchoolController.php
@@ -56,10 +56,6 @@ class SchoolController extends Controller
 
     public function update(School $school)
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
-        }
-
         request()->validate([
             'name' => ['required'],
             'address' => ['required'],
diff --git a/database/factories/SchoolEmailDomainFactory.php b/database/factories/SchoolEmailDomainFactory.php
new file mode 100644
index 0000000..e6f4646
--- /dev/null
+++ b/database/factories/SchoolEmailDomainFactory.php
@@ -0,0 +1,26 @@
+<?php
+
+namespace Database\Factories;
+
+use App\Models\School;
+use Illuminate\Database\Eloquent\Factories\Factory;
+
+/**
+ * @extends \Illuminate\Database\Eloquent\Factories\Factory<\App\Models\SchoolEmailDomain>
+ */
+class SchoolEmailDomainFactory extends Factory
+{
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     */
+    public function definition(): array
+    {
+        $school = School::factory()->create();
+        return [
+            'school_id' => $school->id,
+            'domain' => $this->faker->domainName,
+        ];
+    }
+}
diff --git a/resources/views/admin/schools/edit.blade.php b/resources/views/admin/schools/edit.blade.php
index cb3fe60..99b93a9 100644
--- a/resources/views/admin/schools/edit.blade.php
+++ b/resources/views/admin/schools/edit.blade.php
@@ -1,7 +1,45 @@
 <x-layout.app>
 
-    <x-school.school-edit-form :form_action="'admin/schools/' . $school->id " :school="$school" />
+    <x-card.card class="mx-auto max-w-xl">
+        <x-card.heading>Edit School</x-card.heading>
+        <x-form.form method="PATCH" action="{{ route('admin.schools.update',$school) }}">
+            <x-form.body-grid>
+                <x-form.field name="name" label_text="Name" colspan="6" value="{{ $school->name }}" />
+                <x-form.field name="address" label_text="Address" colspan="6" value="{{ $school->address }}" />
+                <x-form.field name="city" label_text="City" colspan="3" value="{{ $school->city }}" />
+                <x-form.field name="state" label_text="State" colspan="2" value="{{ $school->state }}" />
+                <x-form.field name="zip" label_text="Zip" colspan="1" value="{{ $school->zip }}" />
+            </x-form.body-grid>
+            <x-form.footer>
+                <x-form.button class="mb-5">Update School</x-form.button>
+            </x-form.footer>
+        </x-form.form>
+    </x-card.card>
 
-    <x-school.school-domain-form :school="$school" />
+    <x-card.card class="mx-auto max-w-sm mt-8">
+        <x-card.heading>Associated Domains</x-card.heading>
+        <x-card.list.body>
+            @foreach($school->emailDomains as $domain)
+                <x-card.list.row class="!py-1.5 align-middle">
+                    <form method="POST" action="{{ route('admin.schools.destroy_domain',$domain) }}" id="deleteDomain{{$domain->id}}">
+                        @csrf
+                        @method('DELETE')
+                        <button type="submit">
+                            <svg class="w-6 h-6 text-gray-800 dark:text-white" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="currentColor" viewBox="0 0 24 24">
+                                <path fill-rule="evenodd" d="M2 12C2 6.477 6.477 2 12 2s10 4.477 10 10-4.477 10-10 10S2 17.523 2 12Zm7.707-3.707a1 1 0 0 0-1.414 1.414L10.586 12l-2.293 2.293a1 1 0 1 0 1.414 1.414L12 13.414l2.293 2.293a1 1 0 0 0 1.414-1.414L13.414 12l2.293-2.293a1 1 0 0 0-1.414-1.414L12 10.586 9.707 8.293Z" clip-rule="evenodd"/>
+                            </svg>
+
+                        </button><span class="px-3">{{ $domain->domain }}</span>
+                    </form>
+                </x-card.list.row>
+            @endforeach
+            <x-card.list.row class="!py-1.5">
+                <form method="POST" action="{{ route('admin.schools.add_domain',$school) }}" class="grid sm:grid-cols-2 gap-4">
+                    @csrf
+                    <x-form.field name="domain" label_text="Add Domain" /><x-form.button class="sm:mt-6">Add Domain</x-form.button>
+                </form>
+            </x-card.list.row>
+        </x-card.list.body>
+    </x-card.card>
 
 </x-layout.app>
diff --git a/tests/Feature/Pages/Admin/SchoolsCreateTest.php b/tests/Feature/Pages/Admin/SchoolsCreateTest.php
index 23a26aa..5420d16 100644
--- a/tests/Feature/Pages/Admin/SchoolsCreateTest.php
+++ b/tests/Feature/Pages/Admin/SchoolsCreateTest.php
@@ -17,11 +17,11 @@ beforeEach(function () {
 it('only shows for an admin user', function () {
     // Act & Assert
     $checkRoute = 'admin.schools.create';
-    get(route($checkRoute, $this->school))->assertRedirect(route('home'));
+    get(route($checkRoute))->assertRedirect(route('home'));
     actingAs($this->adminUser);
-    get(route($checkRoute, $this->school))->assertOk();
+    get(route($checkRoute))->assertOk();
     actingAs($this->nonAdminUser);
-    get(route($checkRoute, $this->school))->assertRedirect(route('dashboard'));
+    get(route($checkRoute))->assertRedirect(route('dashboard'));
 });
 it('submits a post request', function () {
     // Arrange
diff --git a/tests/Feature/Pages/Admin/SchoolsEditTest.php b/tests/Feature/Pages/Admin/SchoolsEditTest.php
new file mode 100644
index 0000000..149921c
--- /dev/null
+++ b/tests/Feature/Pages/Admin/SchoolsEditTest.php
@@ -0,0 +1,192 @@
+<?php
+
+use App\Models\School;
+use App\Models\User;
+use Database\Factories\SchoolEmailDomainFactory;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\delete;
+use function Pest\Laravel\get;
+use function Pest\Laravel\patch;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->nonAdminUser = User::factory()->create();
+    $this->tabUser = User::factory()->tab()->create();
+    $this->school = School::factory()->create();
+});
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.schools.edit';
+    get(route($checkRoute, $this->school))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute, $this->school))->assertOk();
+    actingAs($this->nonAdminUser);
+    get(route($checkRoute, $this->school))->assertRedirect(route('dashboard'));
+});
+it('submits a patch request', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.schools.edit', $this->school));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'form',
+        'method',
+        'POST',
+        'action=',
+        route('admin.schools.update', $this->school),
+        '/form',
+    ]);
+    $response->assertSee('<input type="hidden" name="_method" value="PATCH">', false);
+});
+it('has all needed fields', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $fieldNames = [
+        'name',
+        'address',
+        'city',
+        'state',
+        'zip',
+    ];
+    // Act & Assert
+    $response = get(route('admin.schools.edit', $this->school));
+    $response->assertOk();
+    foreach ($fieldNames as $fieldName) {
+        $response->assertSeeInOrder([
+            'input',
+            'name=',
+            $fieldName,
+            '/',
+        ]);
+    }
+});
+it('rejects a submission by a non administrator', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    // Act & Assert
+    $response = patch(route('admin.schools.update', $this->school), [
+        'name' => 'Hacker High',
+        'address' => 'Lost Highway',
+    ]);
+    $response->assertRedirect(route('dashboard'));
+});
+it('allows an administrator to update a school', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $newData = [
+        'name' => fake()->city(),
+        'address' => fake()->streetAddress(),
+        'city' => fake()->city(),
+        'state' => 'OK',
+        'zip' => fake()->postcode(),
+    ];
+    // Act
+    $response = patch(route('admin.schools.update', $this->school), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.schools.show', $this->school));
+
+    $this->school->refresh();
+
+    expect($this->school->name)->toBe($newData['name'])
+        ->and($this->school->address)->toBe($newData['address'])
+        ->and($this->school->city)->toBe($newData['city'])
+        ->and($this->school->state)->toBe($newData['state'])
+        ->and($this->school->zip)->toEqual($newData['zip']);
+
+    get(route('admin.schools.index'))
+        ->assertOk()
+        ->assertSee($newData['name']);
+});
+it('has a domain add form', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.schools.edit', $this->school))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'form',
+            'method',
+            'POST',
+            'action=',
+            route('admin.schools.add_domain', $this->school),
+            '/form',
+        ]);
+});
+it('as a field to submit a new domain', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.schools.edit', $this->school))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'input',
+            'name=',
+            'domain',
+            '/',
+        ]);
+});
+it('allows an administrator to add a domain and shows it on the school edit page', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $newDomain = 'example.com';
+    // Act
+    $response = post(route('admin.schools.add_domain', $this->school), ['domain' => $newDomain]);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.schools.edit', $this->school));
+
+    $this->school->refresh();
+
+    $this->assertDatabaseHas('school_email_domains', ['school_id' => $this->school->id, 'domain' => $newDomain]);
+
+    get(route('admin.schools.edit', $this->school))
+        ->assertOk()
+        ->assertSee($newDomain);
+});
+it('rejects a domain submission by a non administrator', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    // Act & Assert
+    $response = post(route('admin.schools.add_domain', $this->school), ['domain' => 'example.com']);
+    $response->assertRedirect(route('dashboard'));
+});
+it('shows a delete button for each domain', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $domain = $this->school->emailDomains()->create(['domain' => 'example.com']);
+    // Act & Assert
+    get(route('admin.schools.edit', $this->school))
+        ->assertOk()
+        ->assertSee(route('admin.schools.destroy_domain', $domain));
+});
+it('allows an admin to delete a domain', function () {
+    // Arrange
+    session()->setPreviousUrl(route('admin.schools.edit', $this->school));
+    actingAs($this->adminUser);
+    $domain = $this->school->emailDomains()->create(['domain' => 'example.com']);
+    // Act
+    $response = delete(route('admin.schools.destroy_domain', $domain));
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.schools.edit', $this->school));
+
+    $this->assertDatabaseMissing('school_email_domains', ['id' => $domain->id]);
+
+});
+it('does not allow a non admin user to delete a domain', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    $domain = SchoolEmailDomainFactory::new()->create();
+    // Act & Assert
+    $response = delete(route('admin.schools.destroy_domain', $domain));
+    $response->assertRedirect(route('dashboard'));
+});
-- 
2.39.5


From 5a5207357ee9ec359246514fd08990bb62d1962f Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Tue, 2 Jul 2024 17:53:45 -0500
Subject: [PATCH 37/61] AdminSchoolsShow Page Tests

---
 .../Controllers/Admin/SchoolController.php    |   2 +-
 resources/views/admin/schools/index.blade.php |   2 +-
 .../admin/schools/show-domain-form.blade.php  |   4 +-
 tests/Feature/Pages/Admin/SchoolsEditTest.php |   4 +-
 .../Feature/Pages/Admin/SchoolsIndexTest.php  |   4 +-
 tests/Feature/Pages/Admin/SchoolsShowTest.php | 237 ++++++++++++++++++
 6 files changed, 245 insertions(+), 8 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/SchoolsShowTest.php

diff --git a/app/Http/Controllers/Admin/SchoolController.php b/app/Http/Controllers/Admin/SchoolController.php
index c081cfb..f8ac8c9 100644
--- a/app/Http/Controllers/Admin/SchoolController.php
+++ b/app/Http/Controllers/Admin/SchoolController.php
@@ -118,7 +118,7 @@ class SchoolController extends Controller
             'school_id' => $school->id,
             'domain' => request('domain')], []);
 
-        return redirect('/admin/schools/'.$school->id.'/edit')->with('success', 'Domain Added');
+        return redirect()->route('admin.schools.show', $school)->with('success', 'Domain Added');
 
     }
 
diff --git a/resources/views/admin/schools/index.blade.php b/resources/views/admin/schools/index.blade.php
index e025c45..61f351a 100644
--- a/resources/views/admin/schools/index.blade.php
+++ b/resources/views/admin/schools/index.blade.php
@@ -22,7 +22,7 @@
             <x-table.body>
                 @foreach($schools as $school)
                     <tr>
-                        <x-table.td><a href="{{ route('admin.schools.edit',$school) }}">{{ $school->name }}</a></x-table.td>
+                        <x-table.td><a href="{{ route('admin.schools.show',$school) }}">{{ $school->name }}</a></x-table.td>
                         <x-table.td>
                             <a href="{{ route('admin.schools.invoice',$school) }}">
                                 ${{ number_format($schoolTotalFees[$school->id],2) }}
diff --git a/resources/views/admin/schools/show-domain-form.blade.php b/resources/views/admin/schools/show-domain-form.blade.php
index f62c928..4100842 100644
--- a/resources/views/admin/schools/show-domain-form.blade.php
+++ b/resources/views/admin/schools/show-domain-form.blade.php
@@ -3,7 +3,7 @@
     <x-card.list.body>
         @foreach($school->emailDomains as $domain)
             <x-card.list.row class="!py-1.5 align-middle">
-                <form method="POST" action="/admin/schools/domain/{{ $domain->id }}" id="deleteDomain{{$domain->id}}">
+                <form method="POST" action="{{ route('admin.schools.destroy_domain',$domain) }}" id="deleteDomain{{$domain->id}}">
                     @csrf
                     @method('DELETE')
                     <button type="submit">
@@ -16,7 +16,7 @@
             </x-card.list.row>
         @endforeach
         <x-card.list.row class="!py-1.5">
-            <form method="POST" action="/admin/schools/{{ $school->id }}/add_domain" class="grid sm:grid-cols-2 gap-4">
+            <form method="POST" action="{{ route('admin.schools.add_domain',$school) }}" class="grid sm:grid-cols-2 gap-4">
                 @csrf
                 <x-form.field name="domain" label_text="Add Domain" /><x-form.button class="sm:mt-6">Add Domain</x-form.button>
             </form>
diff --git a/tests/Feature/Pages/Admin/SchoolsEditTest.php b/tests/Feature/Pages/Admin/SchoolsEditTest.php
index 149921c..d8d5484 100644
--- a/tests/Feature/Pages/Admin/SchoolsEditTest.php
+++ b/tests/Feature/Pages/Admin/SchoolsEditTest.php
@@ -119,7 +119,7 @@ it('has a domain add form', function () {
             '/form',
         ]);
 });
-it('as a field to submit a new domain', function () {
+it('has a field to submit a new domain', function () {
     // Arrange
     actingAs($this->adminUser);
     // Act & Assert
@@ -141,7 +141,7 @@ it('allows an administrator to add a domain and shows it on the school edit page
     /** @noinspection PhpUnhandledExceptionInspection */
     $response
         ->assertSessionHasNoErrors()
-        ->assertRedirect(route('admin.schools.edit', $this->school));
+        ->assertRedirect(route('admin.schools.show', $this->school));
 
     $this->school->refresh();
 
diff --git a/tests/Feature/Pages/Admin/SchoolsIndexTest.php b/tests/Feature/Pages/Admin/SchoolsIndexTest.php
index 9e455b3..630669b 100644
--- a/tests/Feature/Pages/Admin/SchoolsIndexTest.php
+++ b/tests/Feature/Pages/Admin/SchoolsIndexTest.php
@@ -90,14 +90,14 @@ it('shows school data', function () {
         ], false);
     }
 });
-it('has an edit link for each school', function () {
+it('has a show link for each school', function () {
     // Arrange
     actingAs($this->adminUser);
     // Act & Assert
     $response = get(route('admin.schools.index'));
     $response->assertOk();
     foreach ($this->schools as $school) {
-        $response->assertSee(route('admin.schools.edit', $school));
+        $response->assertSee(route('admin.schools.show', $school));
     }
 });
 it('has an invoice link for each school', function () {
diff --git a/tests/Feature/Pages/Admin/SchoolsShowTest.php b/tests/Feature/Pages/Admin/SchoolsShowTest.php
new file mode 100644
index 0000000..d3c42da
--- /dev/null
+++ b/tests/Feature/Pages/Admin/SchoolsShowTest.php
@@ -0,0 +1,237 @@
+<?php
+
+use App\Models\School;
+use App\Models\SchoolEmailDomain;
+use App\Models\User;
+use Database\Factories\SchoolEmailDomainFactory;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\delete;
+use function Pest\Laravel\get;
+use function Pest\Laravel\patch;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->nonAdminUser = User::factory()->create();
+    $this->tabUser = User::factory()->tab()->create();
+    $this->school = School::factory()->create();
+    $this->domains = SchoolEmailDomain::factory()->count(3)->create(['school_id' => $this->school->id]);
+    $this->directors = User::factory()->count(3)->create(['school_id' => $this->school->id]);
+});
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.schools.show';
+    get(route($checkRoute, $this->school))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute, $this->school))->assertOk();
+    actingAs($this->nonAdminUser);
+    get(route($checkRoute, $this->school))->assertRedirect(route('dashboard'));
+});
+it('shows the school address', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.schools.show', $this->school));
+    $response->assertOk();
+    $response->assertSee($this->school->name);
+    $response->assertSee($this->school->address);
+    $response->assertSee($this->school->city);
+    $response->assertSee($this->school->state);
+    $response->assertSee($this->school->zip);
+});
+it('shows the schools directors and their information', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.schools.show', $this->school));
+    $response->assertOk();
+    foreach ($this->directors as $director) {
+        $response->assertSee($director->full_name());
+        $response->assertSee($director->email);
+        $response->assertSee($director->cell_phone);
+        $response->assertSee($director->judging_preference);
+    }
+});
+
+// Tests dealing with the school email domains
+it('has a domain add form', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.schools.show', $this->school))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'form',
+            'method',
+            'POST',
+            'action=',
+            route('admin.schools.add_domain', $this->school),
+            '/form',
+        ]);
+});
+it('has a field to submit a new domain', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.schools.show', $this->school))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'input',
+            'name=',
+            'domain',
+            '/',
+        ]);
+});
+it('allows an administrator to add a domain and shows it on the school edit page', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $newDomain = 'example.com';
+    // Act
+    $response = post(route('admin.schools.add_domain', $this->school), ['domain' => $newDomain]);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.schools.show', $this->school));
+
+    $this->school->refresh();
+
+    $this->assertDatabaseHas('school_email_domains', ['school_id' => $this->school->id, 'domain' => $newDomain]);
+
+    get(route('admin.schools.show', $this->school))
+        ->assertOk()
+        ->assertSee($newDomain);
+});
+it('rejects a domain submission by a non administrator', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    // Act & Assert
+    $response = post(route('admin.schools.add_domain', $this->school), ['domain' => 'example.com']);
+    $response->assertRedirect(route('dashboard'));
+});
+it('shows a delete button for each domain', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $domain = $this->school->emailDomains()->create(['domain' => 'example.com']);
+    // Act & Assert
+    get(route('admin.schools.show', $this->school))
+        ->assertOk()
+        ->assertSee(route('admin.schools.destroy_domain', $domain));
+});
+it('allows an admin to delete a domain', function () {
+    // Arrange
+    session()->setPreviousUrl(route('admin.schools.show', $this->school));
+    actingAs($this->adminUser);
+    $domain = $this->school->emailDomains()->create(['domain' => 'example.com']);
+    // Act
+    $response = delete(route('admin.schools.destroy_domain', $domain));
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.schools.show', $this->school));
+
+    $this->assertDatabaseMissing('school_email_domains', ['id' => $domain->id]);
+
+});
+it('does not allow a non admin user to delete a domain', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    $domain = SchoolEmailDomainFactory::new()->create();
+    // Act & Assert
+    $response = delete(route('admin.schools.destroy_domain', $domain));
+    $response->assertRedirect(route('dashboard'));
+});
+
+// Tests Dealing With The Edit Modal
+it('has a link to open the edit modal', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.schools.show', $this->school))
+        ->assertOk()
+        ->assertSeeInOrder([
+            '@click',
+            'showModal',
+            'edit',
+        ]);
+});
+it('submits a patch request', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.schools.show', $this->school));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'form',
+        'method',
+        'POST',
+        'action=',
+        route('admin.schools.update', $this->school),
+        '/form',
+    ]);
+    $response->assertSee('<input type="hidden" name="_method" value="PATCH">', false);
+});
+it('has all needed fields', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $fieldNames = [
+        'name',
+        'address',
+        'city',
+        'state',
+        'zip',
+    ];
+    // Act & Assert
+    $response = get(route('admin.schools.show', $this->school));
+    $response->assertOk();
+    foreach ($fieldNames as $fieldName) {
+        $response->assertSeeInOrder([
+            'input',
+            'name=',
+            $fieldName,
+            '/',
+        ]);
+    }
+});
+it('rejects a submission by a non administrator', function () {
+    // Arrange
+    actingAs($this->nonAdminUser);
+    // Act & Assert
+    $response = patch(route('admin.schools.update', $this->school), [
+        'name' => 'Hacker High',
+        'address' => 'Lost Highway',
+    ]);
+    $response->assertRedirect(route('dashboard'));
+});
+it('allows an administrator to update a school', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $newData = [
+        'name' => fake()->city(),
+        'address' => fake()->streetAddress(),
+        'city' => fake()->city(),
+        'state' => 'OK',
+        'zip' => fake()->postcode(),
+    ];
+    // Act
+    $response = patch(route('admin.schools.update', $this->school), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.schools.show', $this->school));
+
+    $this->school->refresh();
+
+    expect($this->school->name)->toBe($newData['name'])
+        ->and($this->school->address)->toBe($newData['address'])
+        ->and($this->school->city)->toBe($newData['city'])
+        ->and($this->school->state)->toBe($newData['state'])
+        ->and($this->school->zip)->toEqual($newData['zip']);
+
+    get(route('admin.schools.index'))
+        ->assertOk()
+        ->assertSee($newData['name']);
+});
-- 
2.39.5


From 75ce5043c2d34a06cfee51c777cfc8fdd0fa5087 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Wed, 3 Jul 2024 01:28:18 -0500
Subject: [PATCH 38/61] Cleanup

---
 app/Http/Controllers/Admin/SchoolController.php | 15 +++++++--------
 database/factories/AuditionFactory.php          |  2 +-
 database/factories/EventFactory.php             |  2 +-
 tests/Feature/Pages/EntriesIndexTest.php        |  2 ++
 4 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/app/Http/Controllers/Admin/SchoolController.php b/app/Http/Controllers/Admin/SchoolController.php
index f8ac8c9..e0c9485 100644
--- a/app/Http/Controllers/Admin/SchoolController.php
+++ b/app/Http/Controllers/Admin/SchoolController.php
@@ -6,7 +6,6 @@ use App\Http\Controllers\Controller;
 use App\Models\School;
 use App\Models\SchoolEmailDomain;
 use App\Services\Invoice\InvoiceDataService;
-use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
 
 use function abort;
@@ -15,7 +14,7 @@ use function request;
 
 class SchoolController extends Controller
 {
-    protected $invoiceService;
+    protected InvoiceDataService $invoiceService;
 
     public function __construct(InvoiceDataService $invoiceController)
     {
@@ -36,7 +35,7 @@ class SchoolController extends Controller
         return view('admin.schools.index', compact('schools', 'schoolTotalFees'));
     }
 
-    public function show(Request $request, School $school)
+    public function show(School $school)
     {
         if (! Auth::user()->is_admin) {
             abort(403);
@@ -84,7 +83,7 @@ class SchoolController extends Controller
         return view('admin.schools.create');
     }
 
-    public function store(Request $request)
+    public function store()
     {
         request()->validate([
             'name' => ['required'],
@@ -105,7 +104,7 @@ class SchoolController extends Controller
         return redirect('/admin/schools')->with('success', 'School '.$school->name.' created');
     }
 
-    public function add_domain(Request $request, School $school)
+    public function add_domain(School $school)
     {
         if (! Auth::user()->is_admin) {
             abort(403);
@@ -116,13 +115,13 @@ class SchoolController extends Controller
         ]);
         SchoolEmailDomain::updateOrInsert([
             'school_id' => $school->id,
-            'domain' => request('domain')], []);
+            'domain' => request('domain')]);
 
         return redirect()->route('admin.schools.show', $school)->with('success', 'Domain Added');
 
     }
 
-    public function destroy_domain(Request $request, SchoolEmailDomain $domain)
+    public function destroy_domain(SchoolEmailDomain $domain)
     {
         // Destroy the $domain
         $domain->delete();
@@ -131,7 +130,7 @@ class SchoolController extends Controller
         return redirect()->back();
     }
 
-    public function viewInvoice(Request $request, School $school)
+    public function viewInvoice(School $school)
     {
         $invoiceData = $this->invoiceService->allData($school->id);
 
diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index 96e5a59..484728f 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -42,7 +42,7 @@ class AuditionFactory extends Factory
         return [
             'event_id' => $event->id,
             #'name' => $this->faker->randomElement($instruments).$this->faker->numberBetween(1, 1000),
-            'name' => 'New Instrument ' . $this->faker->sentence(5),
+            'name' => 'New Instrument ' . $this->faker->unique()->sentence(5),
             'score_order' => $this->faker->numberBetween(2, 50),
             'entry_deadline' => Carbon::tomorrow(),
             'entry_fee' => 1000,
diff --git a/database/factories/EventFactory.php b/database/factories/EventFactory.php
index ae4a7c9..e481e64 100644
--- a/database/factories/EventFactory.php
+++ b/database/factories/EventFactory.php
@@ -17,7 +17,7 @@ class EventFactory extends Factory
     public function definition(): array
     {
         return [
-            'name' => $this->faker->name(),
+            'name' => $this->faker->unique()->name(),
         ];
     }
 }
diff --git a/tests/Feature/Pages/EntriesIndexTest.php b/tests/Feature/Pages/EntriesIndexTest.php
index 78af1ab..e633133 100644
--- a/tests/Feature/Pages/EntriesIndexTest.php
+++ b/tests/Feature/Pages/EntriesIndexTest.php
@@ -141,6 +141,7 @@ it('accepts a valid entry', function () {
         'student_id' => $student->id,
         'audition_id' => $audition->id,
     ]);
+    /** @noinspection PhpUnhandledExceptionInspection */
     $response->assertSessionHasNoErrors();
     $response->assertRedirect(route('entries.index'));
     $this->assertDatabaseHas('entries', [
@@ -157,6 +158,7 @@ it('deletes an entry', function () {
     // Act
     actingAs($this->user);
     $response = delete(route('entries.destroy', $entry));
+    /** @noinspection PhpUnhandledExceptionInspection */
     $response
         ->assertSessionHasNoErrors()
         ->assertRedirect(route('entries.index'));
-- 
2.39.5


From 2ae6ecd8caf72941d393443e685111e54d118f80 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Wed, 3 Jul 2024 02:03:33 -0500
Subject: [PATCH 39/61] AdminStudentIndex Tests

---
 .../views/admin/students/index.blade.php      |  4 +-
 .../Feature/Pages/Admin/StudentIndexTest.php  | 69 +++++++++++++++++++
 tests/Feature/Pages/Admin/UsersIndexTest.php  | 10 +--
 3 files changed, 76 insertions(+), 7 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/StudentIndexTest.php

diff --git a/resources/views/admin/students/index.blade.php b/resources/views/admin/students/index.blade.php
index 9c40ddb..1d946f6 100644
--- a/resources/views/admin/students/index.blade.php
+++ b/resources/views/admin/students/index.blade.php
@@ -6,7 +6,7 @@
             <x-slot:title class="ml-3">Students</x-slot:title>
             <x-slot:subtitle class="ml-3">Click name to edit</x-slot:subtitle>
             <x-slot:title_block_right class="mr-3">
-                <x-form.button href="/admin/students/create">New Student</x-form.button>
+                <x-form.button href="{{ route('admin.students.create') }}">New Student</x-form.button>
             </x-slot:title_block_right>
 
             <thead>
@@ -20,7 +20,7 @@
             <x-table.body>
                 @foreach($students as $student)
                     <tr>
-                        <x-table.td><a href="/admin/students/{{ $student->id }}/edit">{{ $student->full_name(true) }}</a></x-table.td>
+                        <x-table.td><a href="{{ route('admin.students.edit',$student) }}">{{ $student->full_name(true) }}</a></x-table.td>
                         <x-table.td>{{ $student->school->name }}</x-table.td>
                         <x-table.td>{{ $student->grade }}</x-table.td>
                         <x-table.td>{{ $student->entries->count() }}</x-table.td>
diff --git a/tests/Feature/Pages/Admin/StudentIndexTest.php b/tests/Feature/Pages/Admin/StudentIndexTest.php
new file mode 100644
index 0000000..56cba25
--- /dev/null
+++ b/tests/Feature/Pages/Admin/StudentIndexTest.php
@@ -0,0 +1,69 @@
+<?php
+
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->normalUser = User::factory()->create();
+    $this->students = Student::factory()->count(5)->create();
+});
+
+it('is available to admin users', function () {
+    $user = User::factory()->admin()->create();
+
+    $response = $this->actingAs($user)->get(route('admin.students.index'));
+
+    $response->assertOk();
+});
+
+it('is not available to normal users', function () {
+    $response = $this->actingAs($this->normalUser)->get(route('admin.students.index'));
+
+    $response->assertRedirect(route('dashboard'));
+});
+
+it('has a new student button', function () {
+    $response = $this->actingAs($this->adminUser)->get(route('admin.students.index'));
+
+    $response
+        ->assertSee('New Student')
+        ->assertSeeInOrder([
+            'a href=',
+            route('admin.students.create'),
+            'New Student',
+            '/a',
+        ], false);
+});
+it('shows info for each student', function () {
+    // Arrange
+    $response = $this->actingAs($this->adminUser)->get(route('admin.students.index'));
+    // Act & Assert
+    $response->assertOk();
+    foreach ($this->students as $student) {
+        $response->assertSeeInOrder([
+            'td',
+            $student->full_name(true),
+            '/td',
+            'td',
+            $student->school->name,
+            '/td',
+            'td',
+            $student->grade,
+            '/td',
+            'td',
+            $student->entries->count(),
+            '/td',
+        ]);
+    }
+});
+it('shows a link to edit each student', function () {
+    // Arrange
+    $response = $this->actingAs($this->adminUser)->get(route('admin.students.index'));
+    // Act & Assert
+    foreach ($this->students as $student) {
+        $response->assertSee(route('admin.students.edit', $student));
+    }
+});
diff --git a/tests/Feature/Pages/Admin/UsersIndexTest.php b/tests/Feature/Pages/Admin/UsersIndexTest.php
index bee9992..c9198ff 100644
--- a/tests/Feature/Pages/Admin/UsersIndexTest.php
+++ b/tests/Feature/Pages/Admin/UsersIndexTest.php
@@ -10,13 +10,13 @@ use function Pest\Laravel\get;
 uses(RefreshDatabase::class);
 
 beforeEach(function () {
-    $this->adminUser    = User::factory()->admin()->create();
+    $this->adminUser = User::factory()->admin()->create();
     $this->nonAdminUser = User::factory()->create();
-    $this->tabUser      = User::factory()->tab()->create();
-    $this->users        = User::factory(3)->create();
-    $this->schools      = [];
+    $this->tabUser = User::factory()->tab()->create();
+    $this->users = User::factory(3)->create();
+    $this->schools = [];
     foreach ($this->users as $user) {
-        $school          = School::factory()->create();
+        $school = School::factory()->create();
         $user->school_id = $school->id;
         $user->save();
     }
-- 
2.39.5


From 8e6c966edea9eb1523bf0421680c240a129c1753 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Wed, 3 Jul 2024 02:21:22 -0500
Subject: [PATCH 40/61] AdminStudentCreate Test

---
 .../views/admin/students/create.blade.php     |   4 +-
 .../Feature/Pages/Admin/StudentCreateTest.php | 128 ++++++++++++++++++
 tests/Feature/Pages/Admin/UsersCreateTest.php |   6 +-
 3 files changed, 133 insertions(+), 5 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/StudentCreateTest.php

diff --git a/resources/views/admin/students/create.blade.php b/resources/views/admin/students/create.blade.php
index 40bca42..fd3556a 100644
--- a/resources/views/admin/students/create.blade.php
+++ b/resources/views/admin/students/create.blade.php
@@ -1,7 +1,7 @@
 <x-layout.app>
     <x-card.card class="mx-auto max-w-xl">
         <x-card.heading>Create Student</x-card.heading>
-        <x-form.form method="POST" action="/admin/students">
+        <x-form.form method="POST" action="{{ route('admin.students.store') }}">
             <x-form.body-grid columns="12">
                 <x-form.field name="first_name" label_text="First Name" colspan="5" />
                 <x-form.field name="last_name" label_text="Last Name" colspan="5" />
@@ -22,7 +22,7 @@
 
                 </x-form.select>
             </x-form.body-grid>
-            <x-form.footer>
+            <x-form.footer class="pb-5">
                 <x-form.button>Create Student</x-form.button>
             </x-form.footer>
         </x-form.form>
diff --git a/tests/Feature/Pages/Admin/StudentCreateTest.php b/tests/Feature/Pages/Admin/StudentCreateTest.php
new file mode 100644
index 0000000..3a86d63
--- /dev/null
+++ b/tests/Feature/Pages/Admin/StudentCreateTest.php
@@ -0,0 +1,128 @@
+<?php
+
+use App\Models\School;
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->schools = School::factory()->count(5)->create();
+});
+
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.students.create';
+    get(route($checkRoute))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute))->assertOk();
+    actingAs(User::factory()->create());
+    get(route($checkRoute))->assertRedirect(route('dashboard'));
+});
+it('submits a post request', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.students.create'));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'form',
+        'method',
+        'POST',
+        'action=',
+        route('admin.students.store'),
+        '/form',
+    ]);
+});
+it('has all needed fields', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $fieldNames = [
+        'first_name',
+        'last_name',
+    ];
+    // Act & Assert
+    $response = get(route('admin.students.create'));
+    $response->assertOk();
+    foreach ($fieldNames as $fieldName) {
+        $response->assertSeeInOrder([
+            'input',
+            'name=',
+            $fieldName,
+            '/',
+        ]);
+    }
+    $response->assertSeeInOrder([
+        'select',
+        'name=',
+        'school_id',
+        '/select',
+    ]);
+    $response->assertSeeInOrder([
+        'select',
+        'name=',
+        'grade',
+        '/select',
+    ]);
+});
+it('has all schools in a dropdown', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.students.create'));
+    $response->assertOk();
+    foreach ($this->schools as $school) {
+        $response->assertSeeInOrder([
+            'option',
+            'value=',
+            $school->id,
+            $school->name,
+            '/option',
+        ]);
+    }
+});
+it('rejects a submission by a non administrator', function () {
+    // Arrange
+    actingAs(User::factory()->create());
+    // Act & Assert
+    $response = post(route('admin.students.store'), [
+        'first_name' => 'New First Name',
+        'last_name' => 'New Last Name',
+    ]);
+    $response->assertRedirect(route('dashboard'));
+});
+it('allows an administrator to create a student', function () {
+    // Arrange
+    $newSchool = School::factory()->create(['name' => 'New School']);
+    actingAs($this->adminUser);
+    $newData = [
+        'first_name' => 'New First Name',
+        'last_name' => 'New Last Name',
+        'grade' => '9',
+        'school_id' => $newSchool->id,
+    ];
+    // Act
+    $response = post(route('admin.students.store'), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.students.index'));
+
+    // Get the latest created user
+    $createdStudent = Student::where('first_name', $newData['first_name'])->first();
+    expect($createdStudent->first_name)->toBe($newData['first_name'])
+        ->and($createdStudent->last_name)->toBe($newData['last_name'])
+        ->and($createdStudent->grade)->toEqual($newData['grade'])
+        ->and($createdStudent->school->name)->toBe($newSchool->name);
+
+    get(route('admin.students.index'))
+        ->assertOk()
+        ->assertSee($newData['first_name'])
+        ->assertSee($newData['last_name'])
+        ->assertSee($newData['grade'])
+        ->assertSee($newSchool->name);
+});
diff --git a/tests/Feature/Pages/Admin/UsersCreateTest.php b/tests/Feature/Pages/Admin/UsersCreateTest.php
index 6818903..35ee3eb 100644
--- a/tests/Feature/Pages/Admin/UsersCreateTest.php
+++ b/tests/Feature/Pages/Admin/UsersCreateTest.php
@@ -26,11 +26,11 @@ beforeEach(function () {
 it('only shows for an admin user', function () {
     // Act & Assert
     $checkRoute = 'admin.users.create';
-    get(route($checkRoute, $this->users[0]))->assertRedirect(route('home'));
+    get(route($checkRoute))->assertRedirect(route('home'));
     actingAs($this->adminUser);
-    get(route($checkRoute, $this->users[0]))->assertOk();
+    get(route($checkRoute))->assertOk();
     actingAs($this->nonAdminUser);
-    get(route($checkRoute, $this->users[0]))->assertRedirect(route('dashboard'));
+    get(route($checkRoute))->assertRedirect(route('dashboard'));
 });
 it('submits a post request', function () {
     // Arrange
-- 
2.39.5


From 81b7e95b36854c7ef889de26919917ffac6ead42 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Wed, 3 Jul 2024 02:28:30 -0500
Subject: [PATCH 41/61] Cleanup

---
 tests/Feature/Pages/Admin/StudentCreateTest.php | 14 ++++++++++++++
 tests/Feature/Pages/Admin/UsersCreateTest.php   | 14 ++++++++++++++
 2 files changed, 28 insertions(+)

diff --git a/tests/Feature/Pages/Admin/StudentCreateTest.php b/tests/Feature/Pages/Admin/StudentCreateTest.php
index 3a86d63..81f764b 100644
--- a/tests/Feature/Pages/Admin/StudentCreateTest.php
+++ b/tests/Feature/Pages/Admin/StudentCreateTest.php
@@ -38,6 +38,20 @@ it('submits a post request', function () {
         '/form',
     ]);
 });
+it('has a Create Student submit button', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.students.create'));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'button',
+        'type',
+        'submit',
+        'Create Student',
+        '/button',
+    ], false);
+});
 it('has all needed fields', function () {
     // Arrange
     actingAs($this->adminUser);
diff --git a/tests/Feature/Pages/Admin/UsersCreateTest.php b/tests/Feature/Pages/Admin/UsersCreateTest.php
index 35ee3eb..9157dca 100644
--- a/tests/Feature/Pages/Admin/UsersCreateTest.php
+++ b/tests/Feature/Pages/Admin/UsersCreateTest.php
@@ -47,6 +47,20 @@ it('submits a post request', function () {
         '/form',
     ]);
 });
+it('has a Create User submit button', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.users.create'));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'button',
+        'type',
+        'submit',
+        'Create User',
+        '/button',
+    ], false);
+});
 it('has all needed fields', function () {
     // Arrange
     actingAs($this->adminUser);
-- 
2.39.5


From 0c782c9a64eb76c028d12d2dee614d8ce531524a Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Wed, 3 Jul 2024 02:52:42 -0500
Subject: [PATCH 42/61] AdminStudentEdit Page Test

---
 resources/views/admin/students/edit.blade.php |   2 +-
 tests/Feature/Pages/Admin/StudentEditTest.php | 159 ++++++++++++++++++
 2 files changed, 160 insertions(+), 1 deletion(-)
 create mode 100644 tests/Feature/Pages/Admin/StudentEditTest.php

diff --git a/resources/views/admin/students/edit.blade.php b/resources/views/admin/students/edit.blade.php
index 36dce16..81436b2 100644
--- a/resources/views/admin/students/edit.blade.php
+++ b/resources/views/admin/students/edit.blade.php
@@ -1,7 +1,7 @@
 <x-layout.app>
     <x-card.card class="mx-auto max-w-xl">
         <x-card.heading>Edit Student</x-card.heading>
-        <x-form.form method="PATCH" action="/admin/students/{{ $student->id }}">
+        <x-form.form method="PATCH" action="{{ route('admin.students.update',$student) }}">
             <x-form.body-grid columns="12">
                 <x-form.field name="first_name" label_text="First Name" colspan="5" value="{{ $student->first_name }}" />
                 <x-form.field name="last_name" label_text="Last Name" colspan="5" value="{{ $student->last_name }}" />
diff --git a/tests/Feature/Pages/Admin/StudentEditTest.php b/tests/Feature/Pages/Admin/StudentEditTest.php
new file mode 100644
index 0000000..bef15cf
--- /dev/null
+++ b/tests/Feature/Pages/Admin/StudentEditTest.php
@@ -0,0 +1,159 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\School;
+use App\Models\Student;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\actingAs;
+use function Pest\Laravel\get;
+use function Pest\Laravel\patch;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+    $this->adminUser = User::factory()->admin()->create();
+    $this->schools = School::factory()->count(5)->create();
+    $this->student = Student::factory()->create();
+});
+
+it('only shows for an admin user', function () {
+    // Act & Assert
+    $checkRoute = 'admin.students.edit';
+    get(route($checkRoute, $this->student))->assertRedirect(route('home'));
+    actingAs($this->adminUser);
+    get(route($checkRoute, $this->student))->assertOk();
+    actingAs(User::factory()->create());
+    get(route($checkRoute, $this->student))->assertRedirect(route('dashboard'));
+});
+it('submits a patch request', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.students.edit', $this->student));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'form',
+        'method',
+        'POST',
+        'action=',
+        route('admin.students.update', $this->student),
+        '/form',
+    ], false);
+    $response->assertSee('<input type="hidden" name="_method" value="PATCH">', false);
+});
+it('has an Edit Student submit button', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.students.edit', $this->student));
+    $response->assertOk();
+    $response->assertSeeInOrder([
+        'button',
+        'type',
+        'submit',
+        'Edit Student',
+        '/button',
+    ], false);
+});
+it('has all needed fields', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    $fieldNames = [
+        'first_name',
+        'last_name',
+    ];
+    // Act & Assert
+    $response = get(route('admin.students.edit', $this->student));
+    $response->assertOk();
+    foreach ($fieldNames as $fieldName) {
+        $response->assertSeeInOrder([
+            'input',
+            'name=',
+            $fieldName,
+            '/',
+        ]);
+    }
+    $response->assertSeeInOrder([
+        'select',
+        'name=',
+        'school_id',
+        '/select',
+    ]);
+    $response->assertSeeInOrder([
+        'select',
+        'name=',
+        'grade',
+        '/select',
+    ]);
+});
+it('has all schools in a dropdown', function () {
+    // Arrange
+    actingAs($this->adminUser);
+    // Act & Assert
+    $response = get(route('admin.students.edit', $this->student));
+    $response->assertOk();
+    foreach ($this->schools as $school) {
+        $response->assertSeeInOrder([
+            'option',
+            'value=',
+            $school->id,
+            $school->name,
+            '/option',
+        ]);
+    }
+});
+it('is populated with existing data', function () {
+    // Arrange
+    Audition::factory()->create(['minimum_grade' => 1, 'maximum_grade' => 18]); // Needed for the grade select
+    actingAs($this->adminUser);
+    $fieldList = ['first_name', 'last_name', 'grade', 'school_id'];
+    // Act & Assert
+    $response = get(route('admin.students.edit', $this->student));
+    $response->assertOk();
+    $response->assertSeeInOrder(['name=', 'first_name', 'value=', $this->student->first_name]);
+    $response->assertSeeInOrder(['name=', 'last_name', 'value=', $this->student->last_name]);
+    $response->assertSeeInOrder(['grade', 'option', 'value=', $this->student->grade], 'selected');
+    $response->assertSeeInOrder(['name=', 'school_id', 'value=', $this->student->school_id], 'selected');
+});
+it('rejects a submission by a non administrator', function () {
+    // Arrange
+    actingAs(User::factory()->create());
+    // Act & Assert
+    $response = patch(route('admin.students.update', $this->student), [
+        'first_name' => 'New First Name',
+        'last_name' => 'New Last Name',
+    ]);
+    $response->assertRedirect(route('dashboard'));
+});
+it('allows an administrator to edit a student', function () {
+    // Arrange
+    $newSchool = School::factory()->create(['name' => 'New School']);
+    actingAs($this->adminUser);
+    $newData = [
+        'first_name' => 'New First Name',
+        'last_name' => 'New Last Name',
+        'grade' => '9',
+        'school_id' => $newSchool->id,
+    ];
+    // Act
+    $response = patch(route('admin.students.update', $this->student), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.students.index'));
+
+    // Get the changed student
+    $this->student->refresh();
+    expect($this->student->first_name)->toBe($newData['first_name'])
+        ->and($this->student->last_name)->toBe($newData['last_name'])
+        ->and($this->student->grade)->toEqual($newData['grade'])
+        ->and($this->student->school->name)->toBe($newSchool->name);
+
+    get(route('admin.students.index'))
+        ->assertOk()
+        ->assertSee($newData['first_name'])
+        ->assertSee($newData['last_name'])
+        ->assertSee($newData['grade'])
+        ->assertSee($newSchool->name);
+});
-- 
2.39.5


From cd26479fd901ecb42ae8cbb74bce2d347908fa5c Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Wed, 3 Jul 2024 13:22:55 -0500
Subject: [PATCH 43/61] Add delete modal. Finish tests for AdminSchools and
 AdminStudents

---
 .../Controllers/Admin/SchoolController.php    |  18 ++-
 .../Controllers/Admin/StudentController.php   |  24 +++-
 composer.json                                 |   1 +
 composer.lock                                 |  80 ++++++++++-
 resources/views/admin/schools/edit.blade.php  |  11 +-
 resources/views/admin/students/edit.blade.php |  19 ++-
 .../views/admin/students/index.blade.php      |   2 +-
 .../delete-resource-modal.blade.php           | 126 ++++++++++++++++++
 .../form/red-trash-button.blade.php           |   1 -
 routes/admin.php                              |   2 +
 routes/console.php                            |   6 +
 storage/pail/.gitignore                       |   2 +
 tests/Feature/Pages/Admin/SchoolsShowTest.php |  68 ++++++++++
 tests/Feature/Pages/Admin/StudentEditTest.php |  69 +++++++++-
 14 files changed, 413 insertions(+), 16 deletions(-)
 create mode 100644 resources/views/components/delete-resource-modal.blade.php
 create mode 100644 storage/pail/.gitignore

diff --git a/app/Http/Controllers/Admin/SchoolController.php b/app/Http/Controllers/Admin/SchoolController.php
index e0c9485..da73483 100644
--- a/app/Http/Controllers/Admin/SchoolController.php
+++ b/app/Http/Controllers/Admin/SchoolController.php
@@ -49,6 +49,7 @@ class SchoolController extends Controller
         if (! Auth::user()->is_admin) {
             abort(403);
         }
+        $school->loadCount('students');
 
         return view('admin.schools.edit', ['school' => $school]);
     }
@@ -71,7 +72,8 @@ class SchoolController extends Controller
             'zip' => request('zip'),
         ]);
 
-        return redirect()->route('admin.schools.show', ['school' => $school->id])->with('success', 'School '.$school->name.' updated');
+        return redirect()->route('admin.schools.show', ['school' => $school->id])->with('success',
+            'School '.$school->name.' updated');
     }
 
     public function create()
@@ -104,6 +106,17 @@ class SchoolController extends Controller
         return redirect('/admin/schools')->with('success', 'School '.$school->name.' created');
     }
 
+    public function destroy(School $school)
+    {
+        if ($school->students()->count() > 0) {
+            return to_route('admin.schools.index')->with('error', 'You cannot delete a school with students.');
+        }
+        $name = $school->name;
+        $school->delete();
+
+        return to_route('admin.schools.index')->with('success', 'School '.$school->name.' deleted');
+    }
+
     public function add_domain(School $school)
     {
         if (! Auth::user()->is_admin) {
@@ -115,7 +128,8 @@ class SchoolController extends Controller
         ]);
         SchoolEmailDomain::updateOrInsert([
             'school_id' => $school->id,
-            'domain' => request('domain')]);
+            'domain' => request('domain'),
+        ]);
 
         return redirect()->route('admin.schools.show', $school)->with('success', 'Domain Added');
 
diff --git a/app/Http/Controllers/Admin/StudentController.php b/app/Http/Controllers/Admin/StudentController.php
index 6c775c9..24d29a5 100644
--- a/app/Http/Controllers/Admin/StudentController.php
+++ b/app/Http/Controllers/Admin/StudentController.php
@@ -9,7 +9,9 @@ use App\Models\Student;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
 
+use Illuminate\Support\Facades\Log;
 use function abort;
+use function to_route;
 use function view;
 
 class StudentController extends Controller
@@ -19,7 +21,7 @@ class StudentController extends Controller
         if (! Auth::user()->is_admin) {
             abort(403);
         }
-        $students = Student::with(['school', 'entries'])->orderBy('last_name')->orderBy('first_name')->paginate(15);
+        $students = Student::with(['school'])->withCount('entries')->orderBy('last_name')->orderBy('first_name')->paginate(15);
 
         return view('admin.students.index', ['students' => $students]);
     }
@@ -66,8 +68,9 @@ class StudentController extends Controller
         $minGrade = Audition::min('minimum_grade');
         $maxGrade = Audition::max('maximum_grade');
         $schools = School::orderBy('name')->get();
-
-        return view('admin.students.edit', ['student' => $student, 'schools' => $schools, 'minGrade' => $minGrade, 'maxGrade' => $maxGrade]);
+        $student->loadCount('entries');
+        return view('admin.students.edit',
+            ['student' => $student, 'schools' => $schools, 'minGrade' => $minGrade, 'maxGrade' => $maxGrade]);
     }
 
     public function update(Request $request, Student $student)
@@ -84,7 +87,8 @@ class StudentController extends Controller
 
         foreach ($student->entries as $entry) {
             if ($entry->audition->minimum_grade > request('grade') || $entry->audition->maximum_grade < request('grade')) {
-                return redirect('/admin/students/'.$student->id.'/edit')->with('error', 'This student is entered in an audition that is not available to their new grade.');
+                return redirect('/admin/students/'.$student->id.'/edit')->with('error',
+                    'This student is entered in an audition that is not available to their new grade.');
             }
         }
 
@@ -98,4 +102,16 @@ class StudentController extends Controller
         return redirect('/admin/students');
 
     }
+
+    public function destroy(Student $student)
+    {
+        Log::debug('Deleting student '.$student->id);
+        if($student->entries()->count() > 0) {
+            return to_route('admin.students.index')->with('error', 'You cannot delete a student with entries.');
+        }
+        $name = $student->full_name();
+        $student->delete();
+
+        return to_route('admin.students.index')->with('success', 'Student '.$name.' deleted successfully.');
+    }
 }
diff --git a/composer.json b/composer.json
index 177ffef..2f4c226 100644
--- a/composer.json
+++ b/composer.json
@@ -9,6 +9,7 @@
         "codedge/laravel-fpdf": "^1.12",
         "laravel/fortify": "^1.21",
         "laravel/framework": "^11.0",
+        "laravel/pail": "^1.1",
         "laravel/tinker": "^2.9",
         "predis/predis": "^2.2",
         "symfony/http-client": "^7.1",
diff --git a/composer.lock b/composer.lock
index d9ebfa5..b27dd43 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "91ced10faccf6fc9b3fe05fe288ec1d6",
+    "content-hash": "a21ed75b45b3f61cbc76446701fbc3ce",
     "packages": [
         {
             "name": "bacon/bacon-qr-code",
@@ -1491,6 +1491,84 @@
             },
             "time": "2024-05-21T17:57:45+00:00"
         },
+        {
+            "name": "laravel/pail",
+            "version": "v1.1.3",
+            "source": {
+                "type": "git",
+                "url": "https://github.com/laravel/pail.git",
+                "reference": "c22fe771277971eb9cd224955996bcf39c1a710d"
+            },
+            "dist": {
+                "type": "zip",
+                "url": "https://api.github.com/repos/laravel/pail/zipball/c22fe771277971eb9cd224955996bcf39c1a710d",
+                "reference": "c22fe771277971eb9cd224955996bcf39c1a710d",
+                "shasum": ""
+            },
+            "require": {
+                "ext-mbstring": "*",
+                "ext-pcntl": "*",
+                "illuminate/console": "^10.24|^11.0",
+                "illuminate/contracts": "^10.24|^11.0",
+                "illuminate/log": "^10.24|^11.0",
+                "illuminate/process": "^10.24|^11.0",
+                "illuminate/support": "^10.24|^11.0",
+                "nunomaduro/termwind": "^1.15|^2.0",
+                "php": "^8.2",
+                "symfony/console": "^6.0|^7.0"
+            },
+            "require-dev": {
+                "laravel/pint": "^1.13",
+                "orchestra/testbench": "^8.12|^9.0",
+                "pestphp/pest": "^2.20",
+                "pestphp/pest-plugin-type-coverage": "^2.3",
+                "phpstan/phpstan": "^1.10",
+                "symfony/var-dumper": "^6.3|^7.0"
+            },
+            "type": "library",
+            "extra": {
+                "branch-alias": {
+                    "dev-main": "1.x-dev"
+                },
+                "laravel": {
+                    "providers": [
+                        "Laravel\\Pail\\PailServiceProvider"
+                    ]
+                }
+            },
+            "autoload": {
+                "psr-4": {
+                    "Laravel\\Pail\\": "src/"
+                }
+            },
+            "notification-url": "https://packagist.org/downloads/",
+            "license": [
+                "MIT"
+            ],
+            "authors": [
+                {
+                    "name": "Taylor Otwell",
+                    "email": "taylor@laravel.com"
+                },
+                {
+                    "name": "Nuno Maduro",
+                    "email": "enunomaduro@gmail.com"
+                }
+            ],
+            "description": "Easily delve into your Laravel application's log files directly from the command line.",
+            "homepage": "https://github.com/laravel/pail",
+            "keywords": [
+                "laravel",
+                "logs",
+                "php",
+                "tail"
+            ],
+            "support": {
+                "issues": "https://github.com/laravel/pail/issues",
+                "source": "https://github.com/laravel/pail"
+            },
+            "time": "2024-05-08T18:19:39+00:00"
+        },
         {
             "name": "laravel/prompts",
             "version": "v0.1.22",
diff --git a/resources/views/admin/schools/edit.blade.php b/resources/views/admin/schools/edit.blade.php
index 99b93a9..8475878 100644
--- a/resources/views/admin/schools/edit.blade.php
+++ b/resources/views/admin/schools/edit.blade.php
@@ -1,7 +1,16 @@
 <x-layout.app>
 
     <x-card.card class="mx-auto max-w-xl">
-        <x-card.heading>Edit School</x-card.heading>
+        <x-card.heading>
+            Edit School
+            @if($school->students_count === 0)
+                <x-slot:right_side>
+                    <x-delete-resource-modal action="{{ route('admin.schools.destroy',$school) }}" title="Delete school {{ $school->name }}">
+                        Confirm you would like to delete the school {{ $school->name }}. This action cannot be undone.
+                    </x-delete-resource-modal>
+                </x-slot:right_side>
+            @endif
+        </x-card.heading>
         <x-form.form method="PATCH" action="{{ route('admin.schools.update',$school) }}">
             <x-form.body-grid>
                 <x-form.field name="name" label_text="Name" colspan="6" value="{{ $school->name }}" />
diff --git a/resources/views/admin/students/edit.blade.php b/resources/views/admin/students/edit.blade.php
index 81436b2..d8acda4 100644
--- a/resources/views/admin/students/edit.blade.php
+++ b/resources/views/admin/students/edit.blade.php
@@ -1,10 +1,19 @@
 <x-layout.app>
     <x-card.card class="mx-auto max-w-xl">
-        <x-card.heading>Edit Student</x-card.heading>
+        <x-card.heading>
+            Edit Student
+            @if($student->entries_count === 0)
+                <x-slot:right_side>
+                    <x-delete-resource-modal title="Delete Student {{ $student->full_name() }} from {{ $student->school->name }}" :action="route('admin.students.destroy',$student)">
+                        Please confirm you'd like to delete this student. This action cannot be undone.
+                    </x-delete-resource-modal>
+                </x-slot:right_side>
+            @endif
+        </x-card.heading>
         <x-form.form method="PATCH" action="{{ route('admin.students.update',$student) }}">
-            <x-form.body-grid columns="12">
-                <x-form.field name="first_name" label_text="First Name" colspan="5" value="{{ $student->first_name }}" />
-                <x-form.field name="last_name" label_text="Last Name" colspan="5" value="{{ $student->last_name }}" />
+            <x-form.body-grid columns="8">
+                <x-form.field name="first_name" label_text="First Name" colspan="3" value="{{ $student->first_name }}" />
+                <x-form.field name="last_name" label_text="Last Name" colspan="3" value="{{ $student->last_name }}" />
                 <x-form.select name="grade" colspan="2">
                     <x-slot:label>Grade</x-slot:label>
                     @php($n = $minGrade)
@@ -13,7 +22,7 @@
                         @php($n++);
                     @endwhile
                 </x-form.select>
-                <x-form.select name="school_id" colspan="12">
+                <x-form.select name="school_id" colspan="8">
                     <x-slot:label>School</x-slot:label>
                     @foreach ($schools as $school)
 
diff --git a/resources/views/admin/students/index.blade.php b/resources/views/admin/students/index.blade.php
index 1d946f6..a56a5f3 100644
--- a/resources/views/admin/students/index.blade.php
+++ b/resources/views/admin/students/index.blade.php
@@ -23,7 +23,7 @@
                         <x-table.td><a href="{{ route('admin.students.edit',$student) }}">{{ $student->full_name(true) }}</a></x-table.td>
                         <x-table.td>{{ $student->school->name }}</x-table.td>
                         <x-table.td>{{ $student->grade }}</x-table.td>
-                        <x-table.td>{{ $student->entries->count() }}</x-table.td>
+                        <x-table.td>{{ $student->entries_count }}</x-table.td>
                     </tr>
                 @endforeach
             </x-table.body>
diff --git a/resources/views/components/delete-resource-modal.blade.php b/resources/views/components/delete-resource-modal.blade.php
new file mode 100644
index 0000000..b147988
--- /dev/null
+++ b/resources/views/components/delete-resource-modal.blade.php
@@ -0,0 +1,126 @@
+@props(['size' => 20,'title','method'=>'DELETE','action'])
+
+<div
+    x-data="{ 'showModal': false }"
+    @keydown.escape="showModal = false"
+>
+    <!-- Trigger for Modal -->
+    <button type="button" @click="showModal = true" class="rounded-lg bg-red-600 p-1.5 text-white shadow-sm hover:bg-red-500 focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-red-600">
+        {{-- trash button to show modal --}}
+        <svg xmlns="http://www.w3.org/2000/svg" width="{{ $size }}" height="{{ $size }}" fill="currentColor" class="bi bi-trash" viewBox="0 0 16 16">
+            <path d="M5.5 5.5A.5.5 0 0 1 6 6v6a.5.5 0 0 1-1 0V6a.5.5 0 0 1 .5-.5m2.5 0a.5.5 0 0 1 .5.5v6a.5.5 0 0 1-1 0V6a.5.5 0 0 1 .5-.5m3 .5a.5.5 0 0 0-1 0v6a.5.5 0 0 0 1 0z"/>
+            <path d="M14.5 3a1 1 0 0 1-1 1H13v9a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V4h-.5a1 1 0 0 1-1-1V2a1 1 0 0 1 1-1H6a1 1 0 0 1 1-1h2a1 1 0 0 1 1 1h3.5a1 1 0 0 1 1 1zM4.118 4 4 4.059V13a1 1 0 0 0 1 1h6a1 1 0 0 0 1-1V4.059L11.882 4zM2.5 3h11V2h-11z"/>
+        </svg>
+
+    </button>
+
+    <!-- Modal -->
+    <div class="relative z-10"
+         aria-labelledby="modal-title"
+         role="dialog"
+         aria-modal="true"
+         x-show="showModal"
+         x-transition:enter="ease-out duration-300"
+         x-transition:enter-start="opacity-0"
+         x-transition:enter-end="opacity-100"
+         x-transition:leave="ease-in duration-200"
+         x-transition:leave-start="opacity-100"
+         x-transition:leave-end="opacity-0"
+         x-cloak>
+        <!--
+          Background backdrop, show/hide based on modal state.
+
+          Entering: "ease-out duration-300"
+            From: "opacity-0"
+            To: "opacity-100"
+          Leaving: "ease-in duration-200"
+            From: "opacity-100"
+            To: "opacity-0"
+        -->
+        <div class="fixed inset-0 bg-gray-500 bg-opacity-75 transition-opacity" aria-hidden="true"></div>
+
+        <div class="fixed inset-0 z-10 w-screen overflow-y-auto">
+            <div class="flex min-h-full items-end justify-center p-4 text-center sm:items-center sm:p-0"
+                 x-transition:enter="ease-out duration-300"
+                 x-transition:enter-start="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95"
+                 x-transition:enter-end="opacity-100 translate-y-0 sm:scale-100"
+                 x-transition:leave="ease-in duration-200"
+                 x-transition:leave-start="opacity-100 translate-y-0 sm:scale-100"
+                 x-transition:leave-end="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95"
+                 x-cloak
+                 x-show="showModal">
+                <!--
+                  Modal panel, show/hide based on modal state.
+
+                  Entering: "ease-out duration-300"
+                    From: "opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95"
+                    To: "opacity-100 translate-y-0 sm:scale-100"
+                  Leaving: "ease-in duration-200"
+                    From: "opacity-100 translate-y-0 sm:scale-100"
+                    To: "opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95"
+                -->
+                <div
+                    class="relative transform overflow-hidden rounded-lg bg-white px-4 pb-4 pt-5 text-left shadow-xl transition-all sm:my-8 sm:w-full sm:max-w-lg sm:p-6"
+                    x-transition:enter="ease-out duration-300"
+                    x-transition:enter-start="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95"
+                    x-transition:enter-end="opacity-100 translate-y-0 sm:scale-100"
+                    x-transition:leave="ease-in duration-200"
+                    x-transition:leave-start="opacity-100 translate-y-0 sm:scale-100"
+                    x-transition:leave-end="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95"
+                    x-cloak
+                    x-show="showModal"
+                    @click.away="showModal = false">
+                    <div class="absolute right-0 top-0 hidden pr-4 pt-4 sm:block">
+                        <button type="button"
+                                @click="showModal = false"
+                                class="rounded-md bg-white text-gray-400 hover:text-gray-500 focus:outline-none focus:ring-2 focus:ring-indigo-500 focus:ring-offset-2">
+                            <span class="sr-only">Close</span>
+                            <svg class="h-6 w-6" fill="none" viewBox="0 0 24 24" stroke-width="1.5"
+                                 stroke="currentColor" aria-hidden="true">
+                                <path stroke-linecap="round" stroke-linejoin="round" d="M6 18L18 6M6 6l12 12"/>
+                            </svg>
+                        </button>
+                    </div>
+                    <div class="sm:flex sm:items-start">
+                        <div
+                            class="mx-auto flex h-12 w-12 flex-shrink-0 items-center justify-center rounded-full bg-red-100 sm:mx-0 sm:h-10 sm:w-10">
+                            <svg class="h-6 w-6 text-red-600" fill="none" viewBox="0 0 24 24" stroke-width="1.5"
+                                 stroke="currentColor" aria-hidden="true">
+                                <path stroke-linecap="round" stroke-linejoin="round"
+                                      d="M12 9v3.75m-9.303 3.376c-.866 1.5.217 3.374 1.948 3.374h14.71c1.73 0 2.813-1.874 1.948-3.374L13.949 3.378c-.866-1.5-3.032-1.5-3.898 0L2.697 16.126zM12 15.75h.007v.008H12v-.008z"/>
+                            </svg>
+                        </div>
+                        <div class="mt-3 text-center sm:ml-4 sm:mt-0 sm:text-left">
+                            <h3 class="text-base font-semibold leading-6 text-gray-900" id="modal-title">
+                                {{ $title }}
+                            </h3>
+                            <div class="mt-2">
+                                <p class="text-sm text-gray-500">
+                                    {{ $slot }}
+                                </p>
+                            </div>
+                        </div>
+                    </div>
+                    <div class="mt-5 sm:mt-4 sm:flex sm:flex-row-reverse">
+                        <form method="{{ $method == 'GET' ? 'GET':'POST' }}" action="{{$action}}">
+                            @csrf
+                            @if(! in_array($method, ['POST','GET']))
+                                @method($method)
+                            @endif
+                            <button type="submit"
+                                    class="inline-flex w-full justify-center rounded-md bg-red-600 px-3 py-2 text-sm font-semibold text-white shadow-sm hover:bg-red-500 sm:ml-3 sm:w-auto">
+                                Delete
+                            </button>
+                        </form>
+                        <button type="button"
+                                @click="showModal = false"
+                                class="mt-3 inline-flex w-full justify-center rounded-md bg-white px-3 py-2 text-sm font-semibold text-gray-900 shadow-sm ring-1 ring-inset ring-gray-300 hover:bg-gray-50 sm:mt-0 sm:w-auto">
+                            Cancel
+                        </button>
+                    </div>
+                </div>
+            </div>
+        </div>
+    </div>
+
+</div>
diff --git a/resources/views/components/form/red-trash-button.blade.php b/resources/views/components/form/red-trash-button.blade.php
index 8b126d9..8b93ee1 100644
--- a/resources/views/components/form/red-trash-button.blade.php
+++ b/resources/views/components/form/red-trash-button.blade.php
@@ -10,5 +10,4 @@
         <path d="M5.5 5.5A.5.5 0 0 1 6 6v6a.5.5 0 0 1-1 0V6a.5.5 0 0 1 .5-.5m2.5 0a.5.5 0 0 1 .5.5v6a.5.5 0 0 1-1 0V6a.5.5 0 0 1 .5-.5m3 .5a.5.5 0 0 0-1 0v6a.5.5 0 0 0 1 0z"/>
         <path d="M14.5 3a1 1 0 0 1-1 1H13v9a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V4h-.5a1 1 0 0 1-1-1V2a1 1 0 0 1 1-1H6a1 1 0 0 1 1-1h2a1 1 0 0 1 1 1h3.5a1 1 0 0 1 1 1zM4.118 4 4 4.059V13a1 1 0 0 0 1 1h6a1 1 0 0 0 1-1V4.059L11.882 4zM2.5 3h11V2h-11z"/>
     </svg>
-    </svg>
 </button>
diff --git a/routes/admin.php b/routes/admin.php
index 8479387..6be959e 100644
--- a/routes/admin.php
+++ b/routes/admin.php
@@ -90,6 +90,7 @@ Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->
         Route::post('/', 'store')->name('admin.students.store');
         Route::get('/{student}/edit', 'edit')->name('admin.students.edit');
         Route::patch('/{student}', 'update')->name('admin.students.update');
+        Route::delete('/{student}', 'destroy')->name('admin.students.destroy');
     });
 
     // Admin School Routes
@@ -103,6 +104,7 @@ Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->
         Route::patch('/{school}', 'update')->name('admin.schools.update');
         Route::post('/', 'store')->name('admin.schools.store');
         Route::delete('/domain/{domain}', 'destroy_domain')->name('admin.schools.destroy_domain');
+        Route::delete('/{school}', 'destroy')->name('admin.schools.destroy');
 
     });
 
diff --git a/routes/console.php b/routes/console.php
index eff2ed2..a258d86 100644
--- a/routes/console.php
+++ b/routes/console.php
@@ -6,3 +6,9 @@ use Illuminate\Support\Facades\Artisan;
 Artisan::command('inspire', function () {
     $this->comment(Inspiring::quote());
 })->purpose('Display an inspiring quote')->hourly();
+
+Artisan::command('logs:remove', function () {
+    exec('rm -f '.storage_path('logs/*.log'));
+    exec('rm -f '.base_path('*.log'));
+    $this->comment('Logs have been removed!');
+})->describe('Remove log files');
diff --git a/storage/pail/.gitignore b/storage/pail/.gitignore
new file mode 100644
index 0000000..d6b7ef3
--- /dev/null
+++ b/storage/pail/.gitignore
@@ -0,0 +1,2 @@
+*
+!.gitignore
diff --git a/tests/Feature/Pages/Admin/SchoolsShowTest.php b/tests/Feature/Pages/Admin/SchoolsShowTest.php
index d3c42da..0c01581 100644
--- a/tests/Feature/Pages/Admin/SchoolsShowTest.php
+++ b/tests/Feature/Pages/Admin/SchoolsShowTest.php
@@ -1,7 +1,9 @@
 <?php
 
+use App\Models\Entry;
 use App\Models\School;
 use App\Models\SchoolEmailDomain;
+use App\Models\Student;
 use App\Models\User;
 use Database\Factories\SchoolEmailDomainFactory;
 use Illuminate\Foundation\Testing\RefreshDatabase;
@@ -235,3 +237,69 @@ it('allows an administrator to update a school', function () {
         ->assertOk()
         ->assertSee($newData['name']);
 });
+it('includes a form to destroy the school IF it has no students', function () {
+    // Arrange
+    $condemnedSchool = School::factory()->create();
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.schools.edit', $condemnedSchool))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'form',
+            'method',
+            'POST',
+            'action=',
+            route('admin.schools.destroy', $condemnedSchool),
+            '/form',
+        ], false)
+        ->assertSee('<input type="hidden" name="_method" value="DELETE">', false);
+});
+it('does not include the destruction form if the school has students', function () {
+    // Arrange
+    $condemnedSchool = School::factory()->create();
+    Student::factory()->create(['school_id' => $condemnedSchool->id]);
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.schools.edit', $condemnedSchool))
+        ->assertOk()
+        ->assertDontSee('<input type="hidden" name="_method" value="DELETE">', false);
+});
+it('allows an administrator to destroy a school without students', function () {
+    // Arrange
+    $condemnedSchool = School::factory()->create();
+    // Act & Assert
+    expect($condemnedSchool->exists())->toBeTrue();
+    actingAs($this->adminUser);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.schools.destroy', $condemnedSchool))
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.schools.index'));
+    expect(School::find($condemnedSchool->id))->toBeNull();
+});
+it('does not allow an administrator to destroy a student with entries', function () {
+    // Arrange
+    $condemnedSchool = School::factory()->create();
+    Student::factory()->create(['school_id' => $condemnedSchool->id]);
+    // Act & Assert
+    expect($condemnedSchool->exists())->toBeTrue();
+    actingAs($this->adminUser);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.schools.destroy', $condemnedSchool))
+        ->assertSessionHas('error', 'You cannot delete a school with students.')
+        ->assertRedirect(route('admin.schools.index'))
+        ->assertSessionHasNoErrors();
+    expect(School::find($condemnedSchool->id))->toBeInstanceOf(School::class);
+});
+it('does not allow a non administrator to delete a student', function () {
+    // Arrange
+    $condemnedSchool = School::factory()->create();
+    // Act & Assert
+    expect($condemnedSchool->exists())->toBeTrue();
+    actingAs(User::factory()->create());
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.schools.destroy', $condemnedSchool))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'You do not have admin access.')
+        ->assertRedirect(route('dashboard'));
+    expect(School::find($condemnedSchool->id))->toBeInstanceOf(School::class);
+});
diff --git a/tests/Feature/Pages/Admin/StudentEditTest.php b/tests/Feature/Pages/Admin/StudentEditTest.php
index bef15cf..e024ba5 100644
--- a/tests/Feature/Pages/Admin/StudentEditTest.php
+++ b/tests/Feature/Pages/Admin/StudentEditTest.php
@@ -1,12 +1,14 @@
 <?php
 
 use App\Models\Audition;
+use App\Models\Entry;
 use App\Models\School;
 use App\Models\Student;
 use App\Models\User;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 
 use function Pest\Laravel\actingAs;
+use function Pest\Laravel\delete;
 use function Pest\Laravel\get;
 use function Pest\Laravel\patch;
 
@@ -107,7 +109,6 @@ it('is populated with existing data', function () {
     // Arrange
     Audition::factory()->create(['minimum_grade' => 1, 'maximum_grade' => 18]); // Needed for the grade select
     actingAs($this->adminUser);
-    $fieldList = ['first_name', 'last_name', 'grade', 'school_id'];
     // Act & Assert
     $response = get(route('admin.students.edit', $this->student));
     $response->assertOk();
@@ -157,3 +158,69 @@ it('allows an administrator to edit a student', function () {
         ->assertSee($newData['grade'])
         ->assertSee($newSchool->name);
 });
+it('includes a form to destroy the student IF they have no entries', function () {
+    // Arrange
+    $condemnedStudent = Student::factory()->create();
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.students.edit', $condemnedStudent))
+        ->assertOk()
+        ->assertSeeInOrder([
+            'form',
+            'method',
+            'POST',
+            'action=',
+            route('admin.students.destroy', $condemnedStudent),
+            '/form',
+        ], false)
+        ->assertSee('<input type="hidden" name="_method" value="DELETE">', false);
+});
+it('does not include the destruction form if the student has entries', function () {
+    // Arrange
+    $condemnedStudent = Student::factory()->create();
+    Entry::factory()->create(['student_id' => $condemnedStudent->id]);
+    actingAs($this->adminUser);
+    // Act & Assert
+    get(route('admin.students.edit', $condemnedStudent))
+        ->assertOk()
+        ->assertDontSee('<input type="hidden" name="_method" value="DELETE">', false);
+});
+it('allows an administrator to destroy a student without entries', function () {
+    // Arrange
+    $condemnedStudent = Student::factory()->create();
+    // Act & Assert
+    expect($condemnedStudent->exists())->toBeTrue();
+    actingAs($this->adminUser);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.students.destroy', $condemnedStudent))
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.students.index'));
+    expect(Student::find($condemnedStudent->id))->toBeNull();
+});
+it('does not allow an administrator to destroy a student with entries', function () {
+    // Arrange
+    $condemnedStudent = Student::factory()->create();
+    Entry::factory()->create(['student_id' => $condemnedStudent->id]);
+    // Act & Assert
+    expect($condemnedStudent->exists())->toBeTrue();
+    actingAs($this->adminUser);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.students.destroy', $condemnedStudent))
+        ->assertSessionHas('error', 'You cannot delete a student with entries.')
+        ->assertRedirect(route('admin.students.index'))
+        ->assertSessionHasNoErrors();
+    expect(Student::find($condemnedStudent->id))->toBeInstanceOf(Student::class);
+});
+it('does not allow a non administrator to delete a student', function () {
+    // Arrange
+    $condemnedStudent = Student::factory()->create();
+    // Act & Assert
+    expect($condemnedStudent->exists())->toBeTrue();
+    actingAs(User::factory()->create());
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.students.destroy', $condemnedStudent))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'You do not have admin access.')
+        ->assertRedirect(route('dashboard'));
+    expect(Student::find($condemnedStudent->id))->toBeInstanceOf(Student::class);
+});
-- 
2.39.5


From ec28cffaf3cc0adfb84b9808db5fa0007de188ea Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Wed, 3 Jul 2024 22:19:20 -0500
Subject: [PATCH 44/61] AdminEntriesIndex Page Test

---
 app/Http/Controllers/FilterController.php     |   5 +-
 resources/views/admin/entries/index.blade.php |   8 +-
 routes/admin.php                              |   6 +-
 routes/web.php                                |   4 +-
 .../Pages/Admin/EntriesIndexFiltersTest.php   | 218 ++++++++++++++++++
 .../Feature/Pages/Admin/EntriesIndexTest.php  |  77 +++++++
 tests/Pest.php                                |  35 ++-
 7 files changed, 339 insertions(+), 14 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/EntriesIndexFiltersTest.php
 create mode 100644 tests/Feature/Pages/Admin/EntriesIndexTest.php

diff --git a/app/Http/Controllers/FilterController.php b/app/Http/Controllers/FilterController.php
index 00e2012..2cc06bd 100644
--- a/app/Http/Controllers/FilterController.php
+++ b/app/Http/Controllers/FilterController.php
@@ -16,14 +16,13 @@ class FilterController extends Controller
         $filters['first_name'] = request('first_name_filter') ? request('first_name_filter') : null;
         $filters['last_name'] = request('last_name_filter') ? request('last_name_filter') : null;
 
-//        session(['admin_entry_filter', $filters]);
         session(['adminEntryFilters' => $filters]);
-        return redirect('/admin/entries');
+        return redirect('/admin/entries')->with('success', 'Filters Applied');
     }
 
     public function clearAdminEntryFilter(Request $request)
     {
         session()->forget('adminEntryFilters');
-        return redirect('/admin/entries');
+        return redirect('/admin/entries')->with('success', 'Filters Cleared');
     }
 }
diff --git a/resources/views/admin/entries/index.blade.php b/resources/views/admin/entries/index.blade.php
index 71b8e3d..173899f 100644
--- a/resources/views/admin/entries/index.blade.php
+++ b/resources/views/admin/entries/index.blade.php
@@ -4,7 +4,7 @@
 {{--    Filter Control--}}
     <x-card.card>
         <x-card.heading>Set Filters</x-card.heading>
-        <x-form.form action="/filters/admin_entry_filter" method="POST">
+        <x-form.form action="{{ route('admin_entry_filter.set') }}" method="POST">
             <x-form.body-grid columns="12">
                 <x-form.field name="id_filter" label_text="Entry ID" colspan="2" value="{{ $filters['id'] ?? '' }}"/>
                 <x-form.select name="audition_filter" colspan="4">
@@ -40,7 +40,7 @@
                 <x-form.field name="last_name_filter" colspan="6" label_text="Last Name" value="{{ ($filters['last_name'] ?? null) }}"/>
             </x-form.body-grid>
             <x-form.footer class="pb-4">
-                <x-form.button-nocolor href="/filters/admin_entry_filter/clear">Clear Filters</x-form.button-nocolor>
+                <x-form.button-nocolor href="{{ route('admin_entry_filter.clear') }}">Clear Filters</x-form.button-nocolor>
                 <x-form.button>Apply Filters</x-form.button>
             </x-form.footer>
         </x-form.form>
@@ -52,7 +52,7 @@
             <x-slot:title class="ml-3">Entries</x-slot:title>
             <x-slot:subtitle class="ml-3">Double click row to edit</x-slot:subtitle>
             <x-slot:title_block_right class="mr-3">
-                <x-form.button href="/admin/entries/create">New Entry</x-form.button>
+                <x-form.button href="{{ route('admin.entries.create') }}">New Entry</x-form.button>
             </x-slot:title_block_right>
 
             <thead>
@@ -71,7 +71,7 @@
             </thead>
             <x-table.body>
                 @foreach($entries as $entry)
-                    <tr @dblclick="window.location.href='{{ route('admin.entries.edit',['entry' => $entry->id]) }}'">
+                    <tr @dblclick="window.location.href='{{ route('admin.entries.edit', ['entry' => $entry->id]) }}'">
                         <x-table.td><a href="/admin/entries/{{ $entry->id }}/edit"> {{ $entry->id }} </a></x-table.td>
                         <x-table.td>{{ $entry->audition->name }}</x-table.td>
                         <x-table.td>{{ $entry->student->full_name() }}</x-table.td>
diff --git a/routes/admin.php b/routes/admin.php
index 6be959e..53563c8 100644
--- a/routes/admin.php
+++ b/routes/admin.php
@@ -75,10 +75,10 @@ Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->
     // Admin Entries Routes
     Route::prefix('entries')->controller(\App\Http\Controllers\Admin\EntryController::class)->group(function () {
         Route::get('/', 'index')->name('admin.entries.index');
-        Route::get('/create', 'create');
-        Route::post('/', 'store');
+        Route::get('/create', 'create')->name('admin.entries.create');
+        Route::post('/', 'store')->name('admin.entries.store');
         Route::get('/{entry}/edit', 'edit')->name('admin.entries.edit');
-        Route::patch('/{entry}', 'update');
+        Route::patch('/{entry}', 'update')->name('admin.entries.update');
         Route::delete('/{entry}', 'destroy')->name('admin.entries.destroy');
 
     });
diff --git a/routes/web.php b/routes/web.php
index 246ab3e..c63f5b9 100644
--- a/routes/web.php
+++ b/routes/web.php
@@ -29,8 +29,8 @@ Route::get('/results', [App\Http\Controllers\ResultsPage::class, '__invoke'])->n
 
 // Filter Related Routes
 Route::prefix('filters')->middleware(['auth', 'verified'])->controller(FilterController::class)->group(function () {
-    Route::post('/admin_entry_filter', 'adminEntryFilter');
-    Route::get('/admin_entry_filter/clear', 'clearAdminEntryFilter');
+    Route::post('/admin_entry_filter', 'adminEntryFilter')->name('admin_entry_filter.set');
+    Route::get('/admin_entry_filter/clear', 'clearAdminEntryFilter')->name('admin_entry_filter.clear');
 });
 
 //Route::get('/my_school', [SchoolController::class, 'my_school'])->middleware('auth','verified');
diff --git a/tests/Feature/Pages/Admin/EntriesIndexFiltersTest.php b/tests/Feature/Pages/Admin/EntriesIndexFiltersTest.php
new file mode 100644
index 0000000..0c982d0
--- /dev/null
+++ b/tests/Feature/Pages/Admin/EntriesIndexFiltersTest.php
@@ -0,0 +1,218 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\School;
+use App\Models\Student;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+use function PHPUnit\Framework\assertArrayHasKey;
+use function PHPUnit\Framework\assertEquals;
+use function PHPUnit\Framework\assertIsArray;
+
+uses(RefreshDatabase::class);
+
+it('has a filters form', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    get(route('admin.entries.index'))
+        ->assertSee(route('admin_entry_filter.set'));
+});
+it('can filter by entry ID', function () {
+    // Arrange
+    $entry = Entry::factory()->create();
+    $entry2 = Entry::factory()->create();
+    actAsAdmin();
+    // Act & Assert
+    $response = post(route('admin_entry_filter.set', ['id_filter' => $entry->id]));
+    $response->assertSessionHas('adminEntryFilters');
+    $adminEntryFilters = session('adminEntryFilters');
+    assertIsArray($adminEntryFilters);
+    assertArrayHasKey('id', $adminEntryFilters);
+    assertEquals($adminEntryFilters['id'], $entry->id);
+    session([
+        'adminEntryFilters' => [
+            'id' => $entry->id,
+            'audition' => null,
+            'school' => null,
+            'grade' => null,
+            'first_name' => null,
+            'last_name' => null,
+        ],
+    ]);
+    get(route('admin.entries.index'))
+        ->assertSee($entry->student->full_name())
+        ->assertDontSee($entry2->student->full_name());
+});
+it('can filter by audition', function () {
+    // Arrange
+    $audition = Audition::factory()->create();
+    $entry = Entry::factory()->create(['audition_id' => $audition->id]);
+    $entry2 = Entry::factory()->create(['audition_id' => $audition->id]);
+    $entry3 = Entry::factory()->create();
+    actAsAdmin();
+    // Act & Assert
+    $response = post(route('admin_entry_filter.set', ['audition_filter' => $entry->audition->id]));
+    $response->assertSessionHas('adminEntryFilters');
+    $adminEntryFilters = session('adminEntryFilters');
+    assertIsArray($adminEntryFilters);
+    assertArrayHasKey('audition', $adminEntryFilters);
+    assertEquals($adminEntryFilters['audition'], $audition->id);
+    session([
+        'adminEntryFilters' => [
+            'id' => null,
+            'audition' => $entry->audition->id,
+            'school' => null,
+            'grade' => null,
+            'first_name' => null,
+            'last_name' => null,
+        ],
+    ]);
+    get(route('admin.entries.index'))
+        ->assertSee($entry->student->full_name())
+        ->assertSee($entry2->student->full_name())
+        ->assertDontSee($entry3->student->full_name());
+});
+it('can filter by school', function () {
+    // Arrange
+    $school = School::factory()->create(['id' => 1984]);
+    $student = Student::factory()->create(['id' => 375, 'school_id' => $school->id]);
+    $entry = Entry::factory()->create(['student_id' => $student->id]);
+    $entry2 = Entry::factory()->create(['student_id' => $student->id]);
+    $entry3 = Entry::factory()->create();
+    actAsAdmin();
+    // Act & Assert
+    $response = post(route('admin_entry_filter.set', ['school_filter' => $entry->school->id]));
+    $response->assertSessionHas('adminEntryFilters');
+    $adminEntryFilters = session('adminEntryFilters');
+    assertIsArray($adminEntryFilters);
+    assertArrayHasKey('school', $adminEntryFilters);
+    assertEquals($adminEntryFilters['school'], $school->id);
+    session([
+        'adminEntryFilters' => [
+            'id' => null,
+            'audition' => null,
+            'school' => $entry->school->id,
+            'grade' => null,
+            'first_name' => null,
+            'last_name' => null,
+        ],
+    ]);
+    get(route('admin.entries.index'))
+        ->assertSee($entry->student->full_name())
+        ->assertSee($entry2->student->full_name())
+        ->assertDontSee($entry3->student->full_name());
+});
+it('can filter by grade', function () {
+    // Arrange
+    $student = Student::factory()->create(['id' => 375, 'grade' => 7]);
+    $student2 = Student::factory()->create(['id' => 721, 'grade' => 11]);
+    $entry = Entry::factory()->create(['student_id' => $student->id]);
+    $entry2 = Entry::factory()->create(['student_id' => $student->id]);
+    $entry3 = Entry::factory()->create(['student_id' => $student2->id]);
+    actAsAdmin();
+    // Act & Assert
+    $response = post(route('admin_entry_filter.set', ['grade_filter' => 7]));
+    $response->assertSessionHas('adminEntryFilters');
+    $adminEntryFilters = session('adminEntryFilters');
+    assertIsArray($adminEntryFilters);
+    assertArrayHasKey('grade', $adminEntryFilters);
+    assertEquals($adminEntryFilters['grade'], $student->grade);
+    session([
+        'adminEntryFilters' => [
+            'id' => null,
+            'audition' => null,
+            'school' => null,
+            'grade' => '7',
+            'first_name' => null,
+            'last_name' => null,
+        ],
+    ]);
+    get(route('admin.entries.index'))
+        ->assertSee($entry->student->full_name())
+        ->assertSee($entry2->student->full_name())
+        ->assertDontSee($entry3->student->full_name());
+});
+it('can filter by first name', function () {
+    // Arrange
+    $student = Student::factory()->create(['id' => 375, 'first_name' => fake()->firstName]);
+    $student2 = Student::factory()->create(['id' => 721, 'first_name' => $student->first_name]);
+    $student3 = Student::factory()->create();
+    $entry = Entry::factory()->create(['student_id' => $student->id]);
+    $entry2 = Entry::factory()->create(['student_id' => $student2->id]);
+    $entry3 = Entry::factory()->create(['student_id' => $student3->id]);
+    actAsAdmin();
+    // Act & Assert
+    $response = post(route('admin_entry_filter.set', ['first_name_filter' => $student->first_name]));
+    $response->assertSessionHas('adminEntryFilters');
+    $adminEntryFilters = session('adminEntryFilters');
+    assertIsArray($adminEntryFilters);
+    assertArrayHasKey('first_name', $adminEntryFilters);
+    assertEquals($adminEntryFilters['first_name'], $student->first_name);
+    session([
+        'adminEntryFilters' => [
+            'id' => null,
+            'audition' => null,
+            'school' => null,
+            'grade' => null,
+            'first_name' => $student2->first_name,
+            'last_name' => null,
+        ],
+    ]);
+    get(route('admin.entries.index'))
+        ->assertSee($entry->student->full_name())
+        ->assertSee($entry2->student->full_name())
+        ->assertDontSee($entry3->student->full_name());
+});
+it('can filter by last name', function () {
+    // Arrange
+    $student = Student::factory()->create(['id' => 375, 'last_name' => fake()->lastName]);
+    $student2 = Student::factory()->create(['id' => 721, 'last_name' => $student->last_name]);
+    $student3 = Student::factory()->create();
+    $entry = Entry::factory()->create(['student_id' => $student->id]);
+    $entry2 = Entry::factory()->create(['student_id' => $student2->id]);
+    $entry3 = Entry::factory()->create(['student_id' => $student3->id]);
+    actAsAdmin();
+    // Act & Assert
+    $response = post(route('admin_entry_filter.set', ['last_name_filter' => $student->last_name]));
+    $response->assertSessionHas('adminEntryFilters');
+    $adminEntryFilters = session('adminEntryFilters');
+    assertIsArray($adminEntryFilters);
+    assertArrayHasKey('last_name', $adminEntryFilters);
+    assertEquals($adminEntryFilters['last_name'], $student->last_name);
+    session([
+        'adminEntryFilters' => [
+            'id' => null,
+            'audition' => null,
+            'school' => null,
+            'grade' => null,
+            'first_name' => null,
+            'last_name' => $student2->last_name,
+        ],
+    ]);
+    get(route('admin.entries.index'))
+        ->assertSee($entry->student->full_name())
+        ->assertSee($entry2->student->full_name())
+        ->assertDontSee($entry3->student->full_name());
+});
+it('allows filters to be cleared', function () {
+    // Arrange
+    actAsAdmin();
+    session([
+        'adminEntryFilters' => [
+            'id' => 815,
+            'audition' => 4,
+            'school' => 9,
+            'grade' => 8,
+            'first_name' => fake()->firstName,
+            'last_name' => fake()->lastName,
+        ],
+    ]);
+    get(route('admin_entry_filter.clear'));
+    expect(session()->has('admin_entry_filter'))->toBeFalse();
+    // Act & Assert
+
+});
diff --git a/tests/Feature/Pages/Admin/EntriesIndexTest.php b/tests/Feature/Pages/Admin/EntriesIndexTest.php
new file mode 100644
index 0000000..9cc57b0
--- /dev/null
+++ b/tests/Feature/Pages/Admin/EntriesIndexTest.php
@@ -0,0 +1,77 @@
+<?php
+
+use App\Models\Entry;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+it('admin can see an entries index page', function () {
+    actAsAdmin();
+    get(route('admin.entries.index'))
+        ->assertOk();
+});
+it('normal users cannot see entries index page', function () {
+    // Arrange
+    actAsNormal();
+    get(route('admin.entries.index'))
+        ->assertRedirect(route('dashboard'));
+    // Act & Assert
+});
+it('does not allow guests to see the entries index page', function () {
+    // Arrange
+    get(route('admin.entries.index'))
+        ->assertRedirect(route('home'));
+});
+it('shows entries on the index page', function () {
+    $entries = Entry::factory()->count(2)->create();
+    actAsAdmin();
+    $response = get(route('admin.entries.index'))
+        ->assertOk();
+    foreach ($entries as $entry) {
+        $response
+            ->assertSee($entry->id)
+            ->assertSee($entry->audition->name)
+            ->assertSee($entry->student->full_name())
+            ->assertSee($entry->student->grade)
+            ->assertSee($entry->school->name);
+    }
+});
+it('has a link to add a new entry', function () {
+    actAsAdmin();
+    get(route('admin.entries.index'))
+        ->assertSee('New Entry')
+        ->assertSee(route('admin.entries.create'));
+});
+it('has a link to edit each entry', function () {
+    $entries = Entry::factory()->count(2)->create();
+    actAsAdmin();
+    $response = get(route('admin.entries.index'))
+        ->assertOk();
+    foreach ($entries as $entry) {
+        $response
+            ->assertSee(route('admin.entries.edit', $entry));
+    }
+});
+it('has pagination after 10 entries', function () {
+    Entry::factory()->count(10)->create();
+    actAsAdmin();
+    get(route('admin.entries.index'))
+        ->assertOk()
+        ->assertDontSee('Previous')
+        ->assertDontSee('Next');
+    Entry::factory()->count(1)->create();
+    get(route('admin.entries.index'))
+        ->assertOk()
+        ->assertSee('Next');
+    get(route('admin.entries.index', ['page' => 2]))
+        ->assertOk()
+        ->assertSee('Previous')
+        ->assertDontSee('Next');
+    Entry::factory()->count(20)->create();
+    get(route('admin.entries.index', ['page' => 2]))
+        ->assertOk()
+        ->assertSee('Previous')
+        ->assertSee('Next');
+});
diff --git a/tests/Pest.php b/tests/Pest.php
index 50ab1e4..f711b53 100644
--- a/tests/Pest.php
+++ b/tests/Pest.php
@@ -11,6 +11,11 @@
 |
 */
 
+use App\Models\User;
+use App\Settings;
+use Illuminate\Foundation\Testing\TestCase;
+use function Pest\Laravel\actingAs;
+
 uses(
     Tests\TestCase::class,
     // Illuminate\Foundation\Testing\RefreshDatabase::class,
@@ -42,7 +47,33 @@ expect()->extend('toBeOne', function () {
 |
 */
 
-function something()
+function actAsAdmin()
 {
-    // ..
+    actingAs(User::factory()->admin()->create());
 }
+function actAsTab()
+{
+    actingAs(User::factory()->tab()->create());
+}
+function actAsNormal()
+{
+    actingAs(User::factory()->create());
+}
+
+uses(TestCase::class)->beforeEach(function () {
+    Settings::set('auditionName', 'Somewhere Band Directors Association');
+    Settings::set('auditionAbbreviation', 'SBDA');
+    Settings::set('registrationCode', 'secret');
+    Settings::set('advanceTo', 'OMEA');
+    Settings::set('judging_enabled', 1);
+    Settings::set('organizerName', 'John Doe');
+    Settings::set('organizerEmail', 'john@sbda.null');
+    Settings::set('fee_structure', 'onePerEntry');
+    Settings::set('late_fee', 1000);
+    Settings::set('school_fee', 2500);
+    Settings::set('payment_address', '1600 Pennsylvania Ave');
+    Settings::set('payment_city', 'Washington');
+    Settings::set('payment_state', 'DC');
+    Settings::set('payment_zip', '20500');
+});
+
-- 
2.39.5


From c3739950393f6f18568901f5d2a3414aa912cc5e Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 01:56:44 -0500
Subject: [PATCH 45/61] progress on tests

---
 .../Controllers/Admin/EntryController.php     |  38 ++++--
 resources/views/admin/entries/edit.blade.php  |  12 +-
 tests/Feature/Pages/Admin/EntriesEditTest.php | 115 ++++++++++++++++++
 tests/Pest.php                                |   4 +-
 4 files changed, 150 insertions(+), 19 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/EntriesEditTest.php

diff --git a/app/Http/Controllers/Admin/EntryController.php b/app/Http/Controllers/Admin/EntryController.php
index 529788c..d88d49d 100644
--- a/app/Http/Controllers/Admin/EntryController.php
+++ b/app/Http/Controllers/Admin/EntryController.php
@@ -12,6 +12,7 @@ use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
 
 use function compact;
+use function to_route;
 
 class EntryController extends Controller
 {
@@ -62,12 +63,14 @@ class EntryController extends Controller
 
         $entries = $entries->paginate(10);
 
-        return view('admin.entries.index', ['entries' => $entries,
+        return view('admin.entries.index', [
+            'entries' => $entries,
             'auditions' => $auditions,
             'schools' => $schools,
             'minGrade' => $minGrade,
             'maxGrade' => $maxGrade,
-            'filters' => $filters]);
+            'filters' => $filters,
+        ]);
     }
 
     public function create()
@@ -106,9 +109,16 @@ class EntryController extends Controller
 
     public function edit(Entry $entry)
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
+        if ($entry->audition->hasFlag('seats_published')) {
+            return to_route('admin.entries.index')->with('error',
+                'Entries in auditions with seats published cannot be modified');
         }
+
+        if ($entry->audition->hasFlag('advancement_published')) {
+            return to_route('admin.entries.index')->with('error',
+                'Entries in auditions with advancement results published cannot be modified');
+        }
+
         $students = Student::with('school')->orderBy('last_name')->orderBy('first_name')->get();
         $auditions = Audition::orderBy('score_order')->get();
         $scores = $entry->scoreSheets()->get();
@@ -119,8 +129,14 @@ class EntryController extends Controller
 
     public function update(Request $request, Entry $entry)
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
+        if ($entry->audition->hasFlag('seats_published')) {
+            return to_route('admin.entries.index')->with('error',
+                'Entries in auditions with seats published cannot be modified');
+        }
+
+        if ($entry->audition->hasFlag('advancement_published')) {
+            return to_route('admin.entries.index')->with('error',
+                'Entries in auditions with advancement results published cannot be modified');
         }
         $validData = request()->validate([
             'student_id' => ['required', 'exists:students,id'],
@@ -142,8 +158,14 @@ class EntryController extends Controller
 
     public function destroy(Request $request, Entry $entry)
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
+        if ($entry->audition->hasFlag('seats_published')) {
+            return to_route('admin.entries.index')->with('error',
+                'Entries in auditions with seats published cannot be deleted');
+        }
+
+        if ($entry->audition->hasFlag('advancement_published')) {
+            return to_route('admin.entries.index')->with('error',
+                'Entries in auditions with advancement results published cannot be deleted');
         }
         if (Seat::where('entry_id', $entry->id)->exists()) {
             return redirect()->route('admin.entries.index')->with('error', 'Cannot delete an entry that is seated');
diff --git a/resources/views/admin/entries/edit.blade.php b/resources/views/admin/entries/edit.blade.php
index 225b26a..9e66245 100644
--- a/resources/views/admin/entries/edit.blade.php
+++ b/resources/views/admin/entries/edit.blade.php
@@ -5,15 +5,9 @@
             Edit Entry #{{ $entry->id }}
 
             <x-slot:right_side>
-                @if(! Seat::where('entry_id', $entry->id)->exists())
-                    <form method="POST" action="{{ route('admin.entries.destroy',['entry' => $entry->id]) }}">
-                        @csrf
-                        @method('DELETE')
-                        <x-form.red-trash-button type="submit" />
-                    </form>
-                @else
-                    Seated: {{ $entry->seat->ensemble->name }} #{{ $entry->seat->seat }}
-                @endif
+                <x-delete-resource-modal action="{{route('admin.entries.destroy',$entry->id)}}" title="Delete entry #{{ $entry->id }}">
+                    Confirm you would like to delete entry #{{$entry->id}} by {{$entry->student->full_name()}} on {{$entry->audition->name}}.
+                </x-delete-resource-modal>
             </x-slot:right_side>
 
         </x-card.heading>
diff --git a/tests/Feature/Pages/Admin/EntriesEditTest.php b/tests/Feature/Pages/Admin/EntriesEditTest.php
new file mode 100644
index 0000000..f813945
--- /dev/null
+++ b/tests/Feature/Pages/Admin/EntriesEditTest.php
@@ -0,0 +1,115 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Settings;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+
+    $this->entry = Entry::factory()->create();
+});
+
+it('does not respond to an ordinary user', function () {
+    actAsNormal();
+    get(route('admin.entries.edit', $this->entry))
+        ->assertRedirect(route('dashboard'));
+});
+it('does not respond to a guest', function () {
+    // Act & Assert
+    get(route('admin.entries.edit', $this->entry))
+        ->assertRedirect(route('home'));
+});
+it('does not respond if the audition is published', function () {
+    // Arrange
+    actAsAdmin();
+    $this->entry->audition->addFlag('seats_published');
+    get(route('admin.entries.edit', $this->entry))
+        ->assertRedirect(route('admin.entries.index'))
+        ->assertSessionHas('error', 'Entries in auditions with seats published cannot be modified');
+});
+it('does not respond if advancement for the audition is published', function () {
+    // Arrange
+    actAsAdmin();
+    $this->entry->audition->addFlag('advancement_published');
+    get(route('admin.entries.edit', $this->entry))
+        ->assertRedirect(route('admin.entries.index'))
+        ->assertSessionHas('error', 'Entries in auditions with advancement results published cannot be modified');
+});
+it('has a delete link', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    get(route('admin.entries.edit', $this->entry))
+        ->assertSee('<input type="hidden" name="_method" value="DELETE">', false);
+});
+it('has a dropdown for all auditions', function () {
+    // Arrange
+    $auditions = Audition::factory()->count(5)->create();
+    actAsAdmin();
+    $response = get(route('admin.entries.edit', $this->entry));
+    foreach ($auditions as $audition) {
+        $response->assertSeeInOrder([
+            'option',
+            'value=',
+            $audition->id,
+            'option',
+        ], false);
+        $response->assertSeeInOrder([
+            'option',
+            'value=',
+            $this->entry->audition->id,
+            'selected',
+            'option',
+        ], false);
+    }
+});
+it('shows checkboxes for entry types only if advancement is enabled', function () {
+    actAsAdmin();
+    get(route('admin.entries.edit', $this->entry))
+        ->assertSee('Enter for '.auditionSetting('auditionAbbreviation'))
+        ->assertSee('Enter for '.auditionSetting('advanceTo'));
+    Settings::set('advanceTo', '');
+    get(route('admin.entries.edit', $this->entry))
+        ->assertDontSee('Enter for '.auditionSetting('auditionAbbreviation'))
+        ->assertDontSee('Enter for '.auditionSetting('advanceTo'));
+});
+it('properly checks boxes based on entries settings', function () {
+    actAsAdmin();
+    get(route('admin.entries.edit', $this->entry))
+        ->assertSeeInOrder([
+            'input',
+            'name=',
+            'for_seating',
+            'checked',
+            auditionSetting('auditionAbbreviation'),
+        ])
+        ->assertSeeInOrder([
+            'input',
+            'name=',
+            'for_advancement',
+            'checked',
+            auditionSetting('advanceTo'),
+        ]);
+    $entry2 = Entry::factory()->advanceOnly()->create();
+    get(route('admin.entries.edit', $entry2))
+        ->assertSeeInOrder([
+            'input',
+            'name=',
+            'for_seating',
+            'checked',
+            auditionSetting('auditionAbbreviation'),
+        ])
+        ->assertSeeInOrder([
+            'input',
+            'name=',
+            'for_advancement',
+            'checked',
+            auditionSetting('advanceTo'),
+        ]);
+
+});
+// Submission tests
diff --git a/tests/Pest.php b/tests/Pest.php
index f711b53..6cd9f4c 100644
--- a/tests/Pest.php
+++ b/tests/Pest.php
@@ -60,7 +60,7 @@ function actAsNormal()
     actingAs(User::factory()->create());
 }
 
-uses(TestCase::class)->beforeEach(function () {
+uses()->beforeEach(function () {
     Settings::set('auditionName', 'Somewhere Band Directors Association');
     Settings::set('auditionAbbreviation', 'SBDA');
     Settings::set('registrationCode', 'secret');
@@ -75,5 +75,5 @@ uses(TestCase::class)->beforeEach(function () {
     Settings::set('payment_city', 'Washington');
     Settings::set('payment_state', 'DC');
     Settings::set('payment_zip', '20500');
-});
+})->in('Feature');
 
-- 
2.39.5


From 3fc4d136752f9f3b2e0b4e95b3233280cfcd19c6 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 02:08:43 -0500
Subject: [PATCH 46/61] Implement sinnbeck/laravel-dom-assertions

---
 composer.json                                 |  1 +
 composer.lock                                 | 72 ++++++++++++++++++-
 tests/Feature/Pages/Admin/EntriesEditTest.php | 61 ++++++++--------
 3 files changed, 102 insertions(+), 32 deletions(-)

diff --git a/composer.json b/composer.json
index 2f4c226..853e072 100644
--- a/composer.json
+++ b/composer.json
@@ -25,6 +25,7 @@
         "nunomaduro/collision": "^8.0",
         "pestphp/pest": "^2.34",
         "pestphp/pest-plugin-laravel": "^2.4",
+        "sinnbeck/laravel-dom-assertions": "^1.5",
         "spatie/laravel-ignition": "^2.4"
     },
     "autoload": {
diff --git a/composer.lock b/composer.lock
index b27dd43..1a7527c 100644
--- a/composer.lock
+++ b/composer.lock
@@ -4,7 +4,7 @@
         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
         "This file is @generated automatically"
     ],
-    "content-hash": "a21ed75b45b3f61cbc76446701fbc3ce",
+    "content-hash": "7aab57ef52f0152526434decd76ef1e1",
     "packages": [
         {
             "name": "bacon/bacon-qr-code",
@@ -9379,6 +9379,76 @@
             ],
             "time": "2023-02-07T11:34:05+00:00"
         },
+        {
+            "name": "sinnbeck/laravel-dom-assertions",
+            "version": "v1.5.3",
+            "source": {
+                "type": "git",
+                "url": "https://github.com/sinnbeck/laravel-dom-assertions.git",
+                "reference": "a2ce7540023fac4e6e010cbe5396b7aad9d22765"
+            },
+            "dist": {
+                "type": "zip",
+                "url": "https://api.github.com/repos/sinnbeck/laravel-dom-assertions/zipball/a2ce7540023fac4e6e010cbe5396b7aad9d22765",
+                "reference": "a2ce7540023fac4e6e010cbe5396b7aad9d22765",
+                "shasum": ""
+            },
+            "require": {
+                "ext-dom": "*",
+                "ext-libxml": "*",
+                "illuminate/testing": "^9.0|^10.0|^11.0",
+                "php": "^8.0",
+                "symfony/css-selector": "^6.0|^7.0"
+            },
+            "require-dev": {
+                "laravel/pint": "^1.2",
+                "nunomaduro/larastan": "^2.2",
+                "orchestra/testbench": "^7.0|^8.0|^9.0",
+                "pestphp/pest": "^1.0|^2.34",
+                "phpstan/extension-installer": "^1.2",
+                "phpstan/phpstan-deprecation-rules": "^1.0",
+                "phpstan/phpstan-phpunit": "^1.1",
+                "vimeo/psalm": "^4.29|^5.22"
+            },
+            "type": "library",
+            "extra": {
+                "laravel": {
+                    "providers": [
+                        "Sinnbeck\\DomAssertions\\DomAssertionsServiceProvider"
+                    ]
+                }
+            },
+            "autoload": {
+                "psr-4": {
+                    "Sinnbeck\\DomAssertions\\": "src/"
+                }
+            },
+            "notification-url": "https://packagist.org/downloads/",
+            "license": [
+                "MIT"
+            ],
+            "authors": [
+                {
+                    "name": "René Sinnbeck",
+                    "email": "rene.sinnbeck@gmail.com",
+                    "homepage": "https://sinnbeck.dev",
+                    "role": "Developer"
+                }
+            ],
+            "homepage": "https://github.com/sinnbeck/laravel-dom-assertions",
+            "keywords": [
+                "assertions",
+                "blade",
+                "dom",
+                "laravel",
+                "view"
+            ],
+            "support": {
+                "issues": "https://github.com/sinnbeck/laravel-dom-assertions/issues",
+                "source": "https://github.com/sinnbeck/laravel-dom-assertions/tree/v1.5.3"
+            },
+            "time": "2024-06-17T12:30:14+00:00"
+        },
         {
             "name": "spatie/backtrace",
             "version": "1.6.1",
diff --git a/tests/Feature/Pages/Admin/EntriesEditTest.php b/tests/Feature/Pages/Admin/EntriesEditTest.php
index f813945..83b4f9a 100644
--- a/tests/Feature/Pages/Admin/EntriesEditTest.php
+++ b/tests/Feature/Pages/Admin/EntriesEditTest.php
@@ -4,6 +4,7 @@ use App\Models\Audition;
 use App\Models\Entry;
 use App\Settings;
 use Illuminate\Foundation\Testing\RefreshDatabase;
+use Sinnbeck\DomAssertions\Asserts\AssertElement;
 
 use function Pest\Laravel\get;
 
@@ -70,8 +71,8 @@ it('has a dropdown for all auditions', function () {
 it('shows checkboxes for entry types only if advancement is enabled', function () {
     actAsAdmin();
     get(route('admin.entries.edit', $this->entry))
-        ->assertSee('Enter for '.auditionSetting('auditionAbbreviation'))
-        ->assertSee('Enter for '.auditionSetting('advanceTo'));
+        ->assertElementExists('#for_seating')
+        ->assertElementExists('#for_advancement');
     Settings::set('advanceTo', '');
     get(route('admin.entries.edit', $this->entry))
         ->assertDontSee('Enter for '.auditionSetting('auditionAbbreviation'))
@@ -80,36 +81,34 @@ it('shows checkboxes for entry types only if advancement is enabled', function (
 it('properly checks boxes based on entries settings', function () {
     actAsAdmin();
     get(route('admin.entries.edit', $this->entry))
-        ->assertSeeInOrder([
-            'input',
-            'name=',
-            'for_seating',
-            'checked',
-            auditionSetting('auditionAbbreviation'),
-        ])
-        ->assertSeeInOrder([
-            'input',
-            'name=',
-            'for_advancement',
-            'checked',
-            auditionSetting('advanceTo'),
-        ]);
-    $entry2 = Entry::factory()->advanceOnly()->create();
+        ->assertElementExists('#for_seating', function (AssertElement $element) {
+            $element->is('input')
+                ->has('checked');
+        })
+        ->assertElementExists('#for_advancement', function (AssertElement $element) {
+            $element->is('input')
+                ->has('checked');
+        });
+    $entry2 = Entry::factory()->seatingOnly()->create();
     get(route('admin.entries.edit', $entry2))
-        ->assertSeeInOrder([
-            'input',
-            'name=',
-            'for_seating',
-            'checked',
-            auditionSetting('auditionAbbreviation'),
-        ])
-        ->assertSeeInOrder([
-            'input',
-            'name=',
-            'for_advancement',
-            'checked',
-            auditionSetting('advanceTo'),
-        ]);
+        ->assertElementExists('#for_seating', function (AssertElement $element) {
+            $element->is('input')
+                ->has('checked');
+        })
+        ->assertElementExists('#for_advancement', function (AssertElement $element) {
+            $element->is('input')
+                ->doesntHave('checked');
+        });
+    $entry3 = Entry::factory()->advanceOnly()->create();
+    get(route('admin.entries.edit', $entry3))
+        ->assertElementExists('#for_seating', function (AssertElement $element) {
+            $element->is('input')
+                ->doesntHave('checked');
+        })
+        ->assertElementExists('#for_advancement', function (AssertElement $element) {
+            $element->is('input')
+                ->has('checked');
+        });
 
 });
 // Submission tests
-- 
2.39.5


From 89dd6a9a0ec3245e408aa88ddd67a059d66c48cd Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 11:10:56 -0500
Subject: [PATCH 47/61] AdminEntriesEdit Page Test

---
 .../Controllers/Admin/EntryController.php     |   9 +-
 app/Http/Middleware/CheckIfAdmin.php          |   2 +-
 database/factories/AuditionFactory.php        |   2 +-
 .../factories/SchoolEmailDomainFactory.php    |   2 +-
 resources/views/admin/entries/edit.blade.php  |   2 +-
 tests/Feature/Pages/Admin/EntriesEditTest.php | 136 +++++++++++++++---
 tests/Feature/Pages/Admin/SchoolsShowTest.php |   2 +-
 tests/Feature/Pages/Admin/StudentEditTest.php |   2 +-
 8 files changed, 132 insertions(+), 25 deletions(-)

diff --git a/app/Http/Controllers/Admin/EntryController.php b/app/Http/Controllers/Admin/EntryController.php
index d88d49d..e135475 100644
--- a/app/Http/Controllers/Admin/EntryController.php
+++ b/app/Http/Controllers/Admin/EntryController.php
@@ -11,6 +11,7 @@ use App\Models\Student;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
 
+use function auditionSetting;
 use function compact;
 use function to_route;
 
@@ -139,21 +140,23 @@ class EntryController extends Controller
                 'Entries in auditions with advancement results published cannot be modified');
         }
         $validData = request()->validate([
-            'student_id' => ['required', 'exists:students,id'],
             'audition_id' => ['required', 'exists:auditions,id'],
         ]);
 
         $validData['for_seating'] = $request->get('for_seating') ? 1 : 0;
         $validData['for_advancement'] = $request->get('for_advancement') ? 1 : 0;
 
+        if (! auditionSetting('advanceTo')) {
+            $validData['for_seating'] = 1;
+        }
+
         $entry->update([
-            'student_id' => $validData['student_id'],
             'audition_id' => $validData['audition_id'],
             'for_seating' => $validData['for_seating'],
             'for_advancement' => $validData['for_advancement'],
         ]);
 
-        return redirect('/admin/entries');
+        return to_route('admin.entries.index')->with('success', 'Entry updated successfully');
     }
 
     public function destroy(Request $request, Entry $entry)
diff --git a/app/Http/Middleware/CheckIfAdmin.php b/app/Http/Middleware/CheckIfAdmin.php
index 50d63ab..71c0ceb 100644
--- a/app/Http/Middleware/CheckIfAdmin.php
+++ b/app/Http/Middleware/CheckIfAdmin.php
@@ -20,7 +20,7 @@ class CheckIfAdmin
             return $next($request);
         }
 
-        return redirect(route('dashboard'))->with('error', 'You do not have admin access.');
+        return redirect(route('dashboard'))->with('error', 'You are not authorized to perform this action');
 
     }
 }
diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index 484728f..124fd37 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -42,7 +42,7 @@ class AuditionFactory extends Factory
         return [
             'event_id' => $event->id,
             #'name' => $this->faker->randomElement($instruments).$this->faker->numberBetween(1, 1000),
-            'name' => 'New Instrument ' . $this->faker->unique()->sentence(5),
+            'name' => 'New Instrument ' . $this->faker->unique()->words(4,true),
             'score_order' => $this->faker->numberBetween(2, 50),
             'entry_deadline' => Carbon::tomorrow(),
             'entry_fee' => 1000,
diff --git a/database/factories/SchoolEmailDomainFactory.php b/database/factories/SchoolEmailDomainFactory.php
index e6f4646..5773348 100644
--- a/database/factories/SchoolEmailDomainFactory.php
+++ b/database/factories/SchoolEmailDomainFactory.php
@@ -20,7 +20,7 @@ class SchoolEmailDomainFactory extends Factory
         $school = School::factory()->create();
         return [
             'school_id' => $school->id,
-            'domain' => $this->faker->domainName,
+            'domain' => $this->faker->unique()->domainName,
         ];
     }
 }
diff --git a/resources/views/admin/entries/edit.blade.php b/resources/views/admin/entries/edit.blade.php
index 9e66245..9f37e22 100644
--- a/resources/views/admin/entries/edit.blade.php
+++ b/resources/views/admin/entries/edit.blade.php
@@ -11,7 +11,7 @@
             </x-slot:right_side>
 
         </x-card.heading>
-        <x-form.form method="PATCH" action="/admin/entries/{{ $entry->id }}">
+        <x-form.form id='entryEditForm' method="PATCH" action="/admin/entries/{{ $entry->id }}">
             <x-form.body-grid columns="6">
                 @if(! Seat::where('entry_id', $entry->id)->exists())
                     <x-form.select name="student_id" colspan="4" disabled>
diff --git a/tests/Feature/Pages/Admin/EntriesEditTest.php b/tests/Feature/Pages/Admin/EntriesEditTest.php
index 83b4f9a..5214742 100644
--- a/tests/Feature/Pages/Admin/EntriesEditTest.php
+++ b/tests/Feature/Pages/Admin/EntriesEditTest.php
@@ -2,11 +2,19 @@
 
 use App\Models\Audition;
 use App\Models\Entry;
+use App\Models\Room;
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use App\Models\User;
 use App\Settings;
 use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\Artisan;
 use Sinnbeck\DomAssertions\Asserts\AssertElement;
+use Sinnbeck\DomAssertions\Asserts\AssertForm;
+use Sinnbeck\DomAssertions\Asserts\AssertSelect;
 
 use function Pest\Laravel\get;
+use function Pest\Laravel\patch;
 
 uses(RefreshDatabase::class);
 beforeEach(function () {
@@ -47,26 +55,30 @@ it('has a delete link', function () {
     get(route('admin.entries.edit', $this->entry))
         ->assertSee('<input type="hidden" name="_method" value="DELETE">', false);
 });
-it('has a dropdown for all auditions', function () {
+it('has a dropdown for all auditions appropriate to the students grade', function () {
     // Arrange
-    $auditions = Audition::factory()->count(5)->create();
+    $auditions = Audition::factory()->count(5)->create(['minimum_grade' => 1, 'maximum_grade' => 20]);
+    $oldAudition = Audition::factory()->create(['minimum_grade' => $this->entry->grade + 1]);
+    $youngAudition = Audition::factory()->create(['maximum_grade' => $this->entry->grade - 1]);
     actAsAdmin();
-    $response = get(route('admin.entries.edit', $this->entry));
+    $auditionsArray = [];
     foreach ($auditions as $audition) {
-        $response->assertSeeInOrder([
-            'option',
-            'value=',
-            $audition->id,
-            'option',
-        ], false);
-        $response->assertSeeInOrder([
-            'option',
-            'value=',
-            $this->entry->audition->id,
-            'selected',
-            'option',
-        ], false);
+        $auditionsArray[] = ['value' => $audition->id, 'text' => $audition->name];
+        break;
     }
+    $response = get(route('admin.entries.edit', $this->entry));
+    $response->assertOk();
+    // Act & Assert
+    foreach ($auditions as $audition) {
+        $response->assertOk()
+            ->assertFormExists('#entryEditForm', function (AssertForm $form) use ($audition) {
+                $form->findSelect('', function (AssertSelect $select) use ($audition) {
+                    $select->containsOption(['value' => $audition->id, 'text' => $audition->name]);
+                });
+            });
+    }
+    $response->assertDontSee('value='.$oldAudition->id)
+        ->assertDontSee('value='.$youngAudition->id);
 });
 it('shows checkboxes for entry types only if advancement is enabled', function () {
     actAsAdmin();
@@ -112,3 +124,95 @@ it('properly checks boxes based on entries settings', function () {
 
 });
 // Submission tests
+it('does not let a normal user update an entry', function () {
+    // Arrange
+    $newAudition = Audition::factory()->create();
+    actAsNormal();
+    // Act & Assert
+    patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'You are not authorized to perform this action')
+        ->assertRedirect(route('dashboard'));
+});
+it('allows an admin to update an entry', function () {
+    // Arrange
+    $newAudition = Audition::factory()->create();
+    actAsAdmin();
+    // Act & Assert
+    patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Entry updated successfully')
+        ->assertRedirect(route('admin.entries.index'));
+    $this->entry->refresh();
+    expect($this->entry->audition_id)->toBe($newAudition->id)
+        ->and($this->entry->for_seating)->toBe(0)
+        ->and($this->entry->for_advancement)->toBe(0);
+});
+it('does not allow an administrator to update an entry in a published audition', function () {
+    // Arrange
+    $newAudition = Audition::factory()->create();
+    actAsAdmin();
+    $this->entry->audition->addFlag('seats_published');
+    // Act & Assert
+    patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'Entries in auditions with seats published cannot be modified')
+        ->assertRedirect(route('admin.entries.index'));
+    $checkEntry = $this->entry->fresh();
+    expect($checkEntry->id === $this->entry->id)->toBeTrue()
+        ->and($checkEntry->audition_id === $this->entry->audition_id)->toBeTrue()
+        ->and($checkEntry->student_id === $this->entry->student_id)->toBeTrue()
+        ->and($checkEntry->for_seating === $this->entry->for_seating)->toBeTrue()
+        ->and($checkEntry->for_advancement === $this->entry->for_advancement)->toBeTrue();
+});
+it('does not allow an administrator to update an entry in an audition with published advancement results', function () {
+    // Arrange
+    $newAudition = Audition::factory()->create();
+    actAsAdmin();
+    $this->entry->audition->addFlag('advancement_published');
+    // Act & Assert
+    patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'Entries in auditions with advancement results published cannot be modified')
+        ->assertRedirect(route('admin.entries.index'));
+    $checkEntry = $this->entry->fresh();
+    expect($checkEntry->id === $this->entry->id)->toBeTrue()
+        ->and($checkEntry->audition_id === $this->entry->audition_id)->toBeTrue()
+        ->and($checkEntry->student_id === $this->entry->student_id)->toBeTrue()
+        ->and($checkEntry->for_seating === $this->entry->for_seating)->toBeTrue()
+        ->and($checkEntry->for_advancement === $this->entry->for_advancement)->toBeTrue();
+});
+it('always sets for_seating to true if advancement is not enabled', function () {
+    //arrange
+    Settings::set('advanceTo', '');
+    $newAudition = Audition::factory()->create();
+    actAsAdmin();
+    // Act & Assert
+    patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Entry updated successfully')
+        ->assertRedirect(route('admin.entries.index'));
+    $this->entry->refresh();
+    expect($this->entry->audition_id)->toBe($newAudition->id)
+        ->and($this->entry->for_seating)->toBe(1);
+
+});
+it('displays scores', function () {
+    // Arrange
+    $sg = ScoringGuide::factory()->create();
+    SubscoreDefinition::factory()->count(5)->create(['scoring_guide_id' => $sg->id]);
+    $room = Room::factory()->create();
+    $judge = User::factory()->create();
+    $room->addJudge($judge);
+    $audition = Audition::factory()->create(['room_id' => $room->id, 'scoring_guide_id' => $sg->id]);
+    $entry = Entry::factory()->create(['audition_id' => $audition->id]);
+    // Run the ScoreAllAuditions seeder
+    Artisan::call('db:seed', ['--class' => 'ScoreAllAuditions']);
+    // Act & Assert
+    actAsAdmin();
+    $response = get(route('admin.entries.edit', $entry))
+        ->assertSee($judge->full_name());
+    foreach ($sg->subscores as $subscore) {
+        $response->assertSee($subscore->name);
+    }
+});
diff --git a/tests/Feature/Pages/Admin/SchoolsShowTest.php b/tests/Feature/Pages/Admin/SchoolsShowTest.php
index 0c01581..126b563 100644
--- a/tests/Feature/Pages/Admin/SchoolsShowTest.php
+++ b/tests/Feature/Pages/Admin/SchoolsShowTest.php
@@ -299,7 +299,7 @@ it('does not allow a non administrator to delete a student', function () {
     /** @noinspection PhpUnhandledExceptionInspection */
     delete(route('admin.schools.destroy', $condemnedSchool))
         ->assertSessionHasNoErrors()
-        ->assertSessionHas('error', 'You do not have admin access.')
+        ->assertSessionHas('error', 'You are not authorized to perform this action')
         ->assertRedirect(route('dashboard'));
     expect(School::find($condemnedSchool->id))->toBeInstanceOf(School::class);
 });
diff --git a/tests/Feature/Pages/Admin/StudentEditTest.php b/tests/Feature/Pages/Admin/StudentEditTest.php
index e024ba5..4b9c5e1 100644
--- a/tests/Feature/Pages/Admin/StudentEditTest.php
+++ b/tests/Feature/Pages/Admin/StudentEditTest.php
@@ -220,7 +220,7 @@ it('does not allow a non administrator to delete a student', function () {
     /** @noinspection PhpUnhandledExceptionInspection */
     delete(route('admin.students.destroy', $condemnedStudent))
         ->assertSessionHasNoErrors()
-        ->assertSessionHas('error', 'You do not have admin access.')
+        ->assertSessionHas('error', 'You are not authorized to perform this action')
         ->assertRedirect(route('dashboard'));
     expect(Student::find($condemnedStudent->id))->toBeInstanceOf(Student::class);
 });
-- 
2.39.5


From 8d9bbf31d53b3b81caea0253a922dc25fcf035ab Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 11:37:30 -0500
Subject: [PATCH 48/61] Fix IDE flags

---
 tests/Feature/Pages/Admin/EntriesEditTest.php | 61 +++++++++++++++++--
 1 file changed, 56 insertions(+), 5 deletions(-)

diff --git a/tests/Feature/Pages/Admin/EntriesEditTest.php b/tests/Feature/Pages/Admin/EntriesEditTest.php
index 5214742..6bbb19e 100644
--- a/tests/Feature/Pages/Admin/EntriesEditTest.php
+++ b/tests/Feature/Pages/Admin/EntriesEditTest.php
@@ -13,6 +13,7 @@ use Sinnbeck\DomAssertions\Asserts\AssertElement;
 use Sinnbeck\DomAssertions\Asserts\AssertForm;
 use Sinnbeck\DomAssertions\Asserts\AssertSelect;
 
+use function Pest\Laravel\delete;
 use function Pest\Laravel\get;
 use function Pest\Laravel\patch;
 
@@ -55,17 +56,15 @@ it('has a delete link', function () {
     get(route('admin.entries.edit', $this->entry))
         ->assertSee('<input type="hidden" name="_method" value="DELETE">', false);
 });
+
 it('has a dropdown for all auditions appropriate to the students grade', function () {
     // Arrange
     $auditions = Audition::factory()->count(5)->create(['minimum_grade' => 1, 'maximum_grade' => 20]);
+    /** @noinspection PhpPossiblePolymorphicInvocationInspection */
     $oldAudition = Audition::factory()->create(['minimum_grade' => $this->entry->grade + 1]);
+    /** @noinspection PhpPossiblePolymorphicInvocationInspection */
     $youngAudition = Audition::factory()->create(['maximum_grade' => $this->entry->grade - 1]);
     actAsAdmin();
-    $auditionsArray = [];
-    foreach ($auditions as $audition) {
-        $auditionsArray[] = ['value' => $audition->id, 'text' => $audition->name];
-        break;
-    }
     $response = get(route('admin.entries.edit', $this->entry));
     $response->assertOk();
     // Act & Assert
@@ -129,6 +128,7 @@ it('does not let a normal user update an entry', function () {
     $newAudition = Audition::factory()->create();
     actAsNormal();
     // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
     patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
         ->assertSessionHasNoErrors()
         ->assertSessionHas('error', 'You are not authorized to perform this action')
@@ -139,6 +139,7 @@ it('allows an admin to update an entry', function () {
     $newAudition = Audition::factory()->create();
     actAsAdmin();
     // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
     patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
         ->assertSessionHasNoErrors()
         ->assertSessionHas('success', 'Entry updated successfully')
@@ -154,6 +155,7 @@ it('does not allow an administrator to update an entry in a published audition',
     actAsAdmin();
     $this->entry->audition->addFlag('seats_published');
     // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
     patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
         ->assertSessionHasNoErrors()
         ->assertSessionHas('error', 'Entries in auditions with seats published cannot be modified')
@@ -171,6 +173,7 @@ it('does not allow an administrator to update an entry in an audition with publi
     actAsAdmin();
     $this->entry->audition->addFlag('advancement_published');
     // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
     patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
         ->assertSessionHasNoErrors()
         ->assertSessionHas('error', 'Entries in auditions with advancement results published cannot be modified')
@@ -188,6 +191,7 @@ it('always sets for_seating to true if advancement is not enabled', function ()
     $newAudition = Audition::factory()->create();
     actAsAdmin();
     // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
     patch(route('admin.entries.update', $this->entry), ['audition_id' => $newAudition->id])
         ->assertSessionHasNoErrors()
         ->assertSessionHas('success', 'Entry updated successfully')
@@ -216,3 +220,50 @@ it('displays scores', function () {
         $response->assertSee($subscore->name);
     }
 });
+
+// Delete tests
+it('does not allow a normal user to delete an entry', function () {
+    // Arrange
+    actAsNormal();
+    // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.entries.destroy', $this->entry), ['_method' => 'DELETE'])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'You are not authorized to perform this action')
+        ->assertRedirect(route('dashboard'));
+});
+it('allows an admin to delete an entry', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.entries.destroy', $this->entry), ['_method' => 'DELETE'])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Entry Deleted')
+        ->assertRedirect(route('admin.entries.index'));
+    expect(Entry::find($this->entry->id))->toBeNull();
+});
+it('does not allow an admin to delete an entry if that entries audition seats are published', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    $this->entry->audition->addFlag('seats_published');
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.entries.destroy', $this->entry), ['_method' => 'DELETE'])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'Entries in auditions with seats published cannot be deleted')
+        ->assertRedirect(route('admin.entries.index'));
+    expect(Entry::find($this->entry->id))->not->toBeNull();
+});
+it('does not allow an admin to delete an entry if that entries advancement is published', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    $this->entry->audition->addFlag('advancement_published');
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.entries.destroy', $this->entry), ['_method' => 'DELETE'])
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'Entries in auditions with advancement results published cannot be deleted')
+        ->assertRedirect(route('admin.entries.index'));
+    expect(Entry::find($this->entry->id))->not->toBeNull();
+});
-- 
2.39.5


From e3f102d6bd7af75cdfff6688f5eafc392bc1e6b2 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 14:27:07 -0500
Subject: [PATCH 49/61] admin entry pages tests done

---
 .../Controllers/Admin/EntryController.php     |  9 ++--
 database/factories/AuditionFactory.php        |  3 ++
 database/factories/EntryFactory.php           |  1 +
 .../views/admin/entries/create.blade.php      |  4 +-
 .../Feature/Pages/Admin/EntiesCreateTest.php  | 49 +++++++++++++++++++
 5 files changed, 60 insertions(+), 6 deletions(-)
 create mode 100644 tests/Feature/Pages/Admin/EntiesCreateTest.php

diff --git a/app/Http/Controllers/Admin/EntryController.php b/app/Http/Controllers/Admin/EntryController.php
index e135475..79e016a 100644
--- a/app/Http/Controllers/Admin/EntryController.php
+++ b/app/Http/Controllers/Admin/EntryController.php
@@ -76,11 +76,12 @@ class EntryController extends Controller
 
     public function create()
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
-        }
         $students = Student::with('school')->orderBy('last_name')->orderBy('first_name')->get();
-        $auditions = Audition::orderBy('score_order')->get();
+        $auditionsRaw = Audition::with('flags')->orderBy('score_order')->get();
+
+        $auditions = $auditionsRaw->reject(function ($audition) {
+            return $audition->hasFlag('seats_published') || $audition->hasFlag('advancement_published');
+        });
 
         return view('admin.entries.create', ['students' => $students, 'auditions' => $auditions]);
     }
diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index 124fd37..85bf5b4 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -50,6 +50,9 @@ class AuditionFactory extends Factory
             'maximum_grade' => $this->faker->numberBetween(8, 12),
             'for_seating' => 1,
             'for_advancement' => 1,
+            'room_id' => null,
+            'order_in_room' => 0,
+            'scoring_guide_id' => null,
         ];
     }
 
diff --git a/database/factories/EntryFactory.php b/database/factories/EntryFactory.php
index 5ee40fa..80cec5c 100644
--- a/database/factories/EntryFactory.php
+++ b/database/factories/EntryFactory.php
@@ -26,6 +26,7 @@ class EntryFactory extends Factory
             'draw_number' => null,
             'for_seating' => 1,
             'for_advancement' => 1,
+
         ];
     }
 
diff --git a/resources/views/admin/entries/create.blade.php b/resources/views/admin/entries/create.blade.php
index 998fa00..d1c4376 100644
--- a/resources/views/admin/entries/create.blade.php
+++ b/resources/views/admin/entries/create.blade.php
@@ -1,7 +1,7 @@
 <x-layout.app>
     <x-card.card class="mx-auto max-w-2xl">
         <x-card.heading>Create Entry</x-card.heading>
-        <x-form.form method="POST" action="/admin/entries">
+        <x-form.form id='createEntryForm' method="POST" action="/admin/entries">
             <x-form.body-grid columns="3" x-data="studentAuditionFilter()">
 
                 <x-form.select name="student_id" colspan="2" x-model="selectedStudentId" @change="filterAuditions">
@@ -35,7 +35,7 @@
                     <input type="hidden" name="for_seating" value="on">
                 @endif
             </x-form.body-grid>
-            <x-form.footer>
+            <x-form.footer class="mb-5">
                 <x-form.button>Create Entry</x-form.button>
             </x-form.footer>
         </x-form.form>
diff --git a/tests/Feature/Pages/Admin/EntiesCreateTest.php b/tests/Feature/Pages/Admin/EntiesCreateTest.php
new file mode 100644
index 0000000..dc71571
--- /dev/null
+++ b/tests/Feature/Pages/Admin/EntiesCreateTest.php
@@ -0,0 +1,49 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Student;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+use function PHPUnit\Framework\assertEquals;
+
+uses(RefreshDatabase::class);
+
+it('does not respond to an ordinary user', function () {
+    actAsNormal();
+    get(route('admin.entries.create'))
+        ->assertRedirect(route('dashboard'));
+});
+it('does not respond to a guest', function () {
+    // Act & Assert
+    get(route('admin.entries.create'))
+        ->assertRedirect(route('home'));
+});
+it('passes a collection of all students with thier schools to the view', function () {
+    // Arrange
+    Student::factory()->count(8)->create();
+    $students = Student::with('school')->orderBy('last_name')->orderBy('first_name')->get();
+    actAsAdmin();
+    // Act & Assert
+    get(route('admin.entries.create'))
+        ->assertViewHas('students', $students);
+});
+it('passes a collection of available auditions to the view', function () {
+    // Arrange
+    for ($i = 3; $i < 9; $i++) {
+        Audition::factory()->create(['score_order' => $i]);
+    }
+    Audition::factory()->count(5)->create();
+    $auditions = Audition::with('flags')->orderBy('score_order')->get();
+    $auditions = $auditions->toArray();
+    $seatedAudition = Audition::factory()->create(['score_order' => 1]);
+    $seatedAudition->addFlag('seats_published');
+    $advancedAudition = Audition::factory()->create(['score_order' => 2]);
+    $advancedAudition->addFlag('advancement_published');
+    actAsAdmin();
+    // Act & Assert
+    $response = get(route('admin.entries.create'));
+    $viewAuditions = $response->viewData('auditions')->toArray();
+    $response->assertOk();
+    assertEquals(array_values($auditions), array_values($viewAuditions));
+});
-- 
2.39.5


From 735d79210c603d3190011e6edb9624a63415d3ff Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 15:48:32 -0500
Subject: [PATCH 50/61] Test Audition Settings Page

---
 .../Controllers/Admin/AuditionSettings.php    |   3 +-
 .../views/admin/audition-settings.blade.php   |  11 +-
 tests/Feature/Pages/Setup/SettingsTest.php    | 139 ++++++++++++++++++
 3 files changed, 151 insertions(+), 2 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/SettingsTest.php

diff --git a/app/Http/Controllers/Admin/AuditionSettings.php b/app/Http/Controllers/Admin/AuditionSettings.php
index 6083f20..f879ea8 100644
--- a/app/Http/Controllers/Admin/AuditionSettings.php
+++ b/app/Http/Controllers/Admin/AuditionSettings.php
@@ -5,6 +5,7 @@ namespace App\Http\Controllers\Admin;
 use App\Http\Controllers\Controller;
 use App\Settings;
 use Illuminate\Http\Request;
+use function to_route;
 
 class AuditionSettings extends Controller
 {
@@ -35,6 +36,6 @@ class AuditionSettings extends Controller
             Settings::set($key, $value);
         }
 
-        return view('admin.audition-settings')->with('success', 'Settings Saved');
+        return to_route('audition-settings')->with('success', 'Settings Saved');
     }
 }
diff --git a/resources/views/admin/audition-settings.blade.php b/resources/views/admin/audition-settings.blade.php
index c32ad8a..17cbcf9 100644
--- a/resources/views/admin/audition-settings.blade.php
+++ b/resources/views/admin/audition-settings.blade.php
@@ -1,7 +1,7 @@
 <x-layout.app>
     <x-slot:page_title>Audition Settings</x-slot:page_title>
     <x-layout.page-section-container>
-        <x-form.form method="POST" action="{{ route('audition-settings-save') }}">
+        <x-form.form id="settingsForm" method="POST" action="{{ route('audition-settings-save') }}">
 
             <x-layout.page-section>
                 <x-slot:section_name>Group Information</x-slot:section_name>
@@ -60,6 +60,15 @@
 
                 </x-form.body-grid>
             </x-layout.page-section>
+            <x-layout.page-section>
+                <x-slot:section_name>Payment Address</x-slot:section_name>
+                <x-form.body-grid columns="12" class="m-3">
+                    <x-form.field label_text="Payment Address" name="payment_address" colspan="5" :value="auditionSetting('payment_address')"/>
+                    <x-form.field label_text="Payment City" name="payment_city" colspan="3" :value="auditionSetting('payment_city')"/>
+                    <x-form.field label_text="Payment State" name="payment_state" colspan="2" :value="auditionSetting('payment_state')"/>
+                    <x-form.field label_text="Payment Zip" type="number" name="payment_zip" colspan="2" :value="auditionSetting('payment_zip')"/>
+                </x-form.body-grid>
+            </x-layout.page-section>
 
             <div class="grid grid-cols-12">
                 <div class="col-span-2 col-start-11 my-5 mr-3">
diff --git a/tests/Feature/Pages/Setup/SettingsTest.php b/tests/Feature/Pages/Setup/SettingsTest.php
new file mode 100644
index 0000000..e53e89c
--- /dev/null
+++ b/tests/Feature/Pages/Setup/SettingsTest.php
@@ -0,0 +1,139 @@
+<?php
+
+/** @noinspection ALL */
+
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Sinnbeck\DomAssertions\Asserts\AssertForm;
+
+use Sinnbeck\DomAssertions\Asserts\AssertSelect;
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+it('allows administrators to access the settings page', function () {
+    actAsAdmin();
+    get(route('audition-settings'))
+        ->assertOk()
+        ->assertViewIs('admin.audition-settings');
+});
+it('does not allow normal users to access the settings page', function () {
+    // Arrange
+    actAsNormal();
+    // Act & Assert
+    get(route('audition-settings'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action')
+        ->assertRedirect(route('dashboard'));
+});
+it('does not allow guests to access the settings page', function () {
+    // Act & Assert
+    get(route('audition-settings'))
+        ->assertRedirect(route('home'));
+});
+it('has a field with forms for each audition setting', function () {
+    // Arrange
+    actAsAdmin();
+    // Act
+    $response = get(route('audition-settings'));
+    // Assert
+    $response->assertOk();
+    $response->assertFormExists('#settingsForm', function (AssertForm $form) {
+        $form->hasMethod('POST')
+            ->hasAction(route('audition-settings-save'))
+            ->hasCSRF()
+            ->containsInput([
+                'name' => 'auditionName',
+                'value' => auditionSetting('auditionName'),
+            ])
+            ->containsInput([
+                'name' => 'auditionAbbreviation',
+                'value' => auditionSetting('auditionAbbreviation'),
+            ])
+            ->containsInput([
+                'name' => 'registrationCode',
+                'value' => auditionSetting('registrationCode'),
+            ])
+            ->containsInput([
+                'name' => 'advanceTo',
+                'value' => auditionSetting('advanceTo'),
+            ])
+            ->containsInput([
+                'name' => 'organizerName',
+                'value' => auditionSetting('organizerName'),
+            ])
+            ->containsInput([
+                'name' => 'organizerEmail',
+                'value' => auditionSetting('organizerEmail'),
+            ])
+            ->containsInput([
+                'name' => 'late_fee',
+                'value' => number_format(auditionSetting('late_fee')/100, 2),
+            ])
+            ->containsInput([
+                'name' => 'school_fee',
+                'value' => number_format(auditionSetting('school_fee')/100, 2),
+            ])
+            ->containsInput([
+                'name' => 'payment_address',
+                'value' => auditionSetting('payment_address'),
+            ])
+            ->containsInput([
+                'name' => 'payment_city',
+                'value' => auditionSetting('payment_city'),
+            ])
+            ->containsInput([
+                'name' => 'payment_state',
+                'value' => auditionSetting('payment_state'),
+            ])
+            ->containsInput([
+                'name' => 'payment_zip',
+                'value' => auditionSetting('payment_zip'),
+                'type' => 'number',
+            ])
+            ->containsInput([
+                'name' => 'olympic_scoring',
+                'type' => 'checkbox',
+                // TODO how can I test if it is checked when necessary
+            ])
+            ->containsInput([
+                'name' => 'judging_enabled',
+                'type' => 'checkbox',
+                // TODO how can I test if it is checked when necessary
+            ])
+            ->findSelect('#fee_structure', function(AssertSelect $select) {
+                $select->containsOption([
+                    'value' => 'oneFeePerEntry',
+                    'text'=> 'One fee per entry',
+                ])
+                    ->containsOption([
+                       'value' => 'oneFeePerStudent',
+                       'text' => 'One fee per student - one late fee per student if any of their entries are late',
+                    ]);
+            });
+    });
+});
+it('can update audition settings', function () {
+    // Arrange
+    actAsAdmin();
+    $newData = [
+        'auditionName' => 'New Audition Name',
+        'auditionAbbreviation' => 'NAN',
+        'registrationCode' => 'NEWCODE',
+        'advanceTo' => 'next',
+        'organizerName' => 'New Organizer Name',
+        'organizerEmail' => 'newemail@new.com',
+        'late_fee' => 150.00,
+        'school_fee' => 200.00,
+        'payment_address' => '123 New St',
+        'payment_city' => 'New City',
+        'payment_state' => 'NS',
+        'payment_zip' => 12345,
+        'fee_structure' => 'oneFeePerEntry'
+    ];
+    // Act
+    $response = post(route('audition-settings-save'), $newData);
+    // Act & Assert
+    $response->assertRedirect(route('audition-settings'))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Settings Saved');
+});
-- 
2.39.5


From 8bf3219912266e77c50f1ea52ace4a32a427eb4d Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 16:27:41 -0500
Subject: [PATCH 51/61] Events Page Test

---
 .../Controllers/Admin/EventController.php     |   5 +-
 tests/Feature/Pages/Setup/EventsTest.php      | 153 ++++++++++++++++++
 2 files changed, 156 insertions(+), 2 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/EventsTest.php

diff --git a/app/Http/Controllers/Admin/EventController.php b/app/Http/Controllers/Admin/EventController.php
index 42a28f2..972bfe7 100644
--- a/app/Http/Controllers/Admin/EventController.php
+++ b/app/Http/Controllers/Admin/EventController.php
@@ -37,8 +37,9 @@ class EventController extends Controller
 
     public function destroy(Request $request, Event $event)
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
+        if ($event->auditions()->count() > 0) {
+            return redirect()->route('admin.events.index')->with('error',
+                'Cannot delete an event with auditions');
         }
         $event->delete();
 
diff --git a/tests/Feature/Pages/Setup/EventsTest.php b/tests/Feature/Pages/Setup/EventsTest.php
new file mode 100644
index 0000000..09f452a
--- /dev/null
+++ b/tests/Feature/Pages/Setup/EventsTest.php
@@ -0,0 +1,153 @@
+<?php
+
+use App\Models\Event;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\delete;
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+it('allows admins to manage Events', function () {
+    actAsAdmin();
+    get(route('admin.events.index'))
+        ->assertOk();
+});
+it('does not allow normal users to manage events', function () {
+    // Arrange
+    actAsNormal();
+    // Act & Assert
+    get(route('admin.events.index'))
+        ->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+});
+it('does not allow a guest to manage events', function () {
+    // Act & Assert
+    get(route('admin.events.index'))
+        ->assertRedirect(route('home'));
+});
+it('shows a line for each event', function () {
+    // Arrange
+    $events = Event::factory()->count(3)->create();
+    // Act & Assert
+    actAsAdmin();
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertSee($events[0]->name)
+        ->assertSee($events[1]->name)
+        ->assertSee($events[2]->name);
+});
+it('shows a count of auditions in each event', function () {
+    // Arrange
+    $noAuditionEvent = Event::factory()->create();
+    $fiveAuditionEvent = Event::factory()->hasAuditions(5)->create();
+    actAsAdmin();
+    // Act & Assert
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertSee($noAuditionEvent->name.', 0 Audition')
+        ->assertSee($fiveAuditionEvent->name.', 5 Audition');
+});
+it('has a delete link only for events with no auditions', function () {
+    $noAuditionEvent = Event::factory()->create();
+    $fiveAuditionEvent = Event::factory()->hasAuditions(5)->create();
+    actAsAdmin();
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertSee(route('admin.events.destroy', $noAuditionEvent))
+        ->assertDontSee(route('admin.events.destroy', $fiveAuditionEvent));
+});
+it('can delete an event', function () {
+    // Arrange
+    $noAuditionEvent = Event::factory()->create();
+    $fiveAuditionEvent = Event::factory()->hasAuditions(5)->create();
+    actAsAdmin();
+    // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.events.destroy', $noAuditionEvent))
+        ->assertRedirect(route('admin.events.index'))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Event deleted successfully');
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertDontSee($noAuditionEvent->name)
+        ->assertSee($fiveAuditionEvent->name);
+});
+it('does not allow a normal user to delete an event', function () {
+    // Arrange
+    $noAuditionEvent = Event::factory()->create();
+    actAsNormal();
+    // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.events.destroy', $noAuditionEvent))
+        ->assertRedirect(route('dashboard'))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actAsAdmin();
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertSee($noAuditionEvent->name);
+});
+it('does not allow a guest to delete an event', function () {
+    // Arrange
+    $noAuditionEvent = Event::factory()->create();
+    // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.events.destroy', $noAuditionEvent))
+        ->assertRedirect(route('home'))
+        ->assertSessionHasNoErrors();
+    actAsAdmin();
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertSee($noAuditionEvent->name);
+});
+it('cannot delete an event with auditions', function () {
+    // Arrange
+    $event = Event::factory()->hasAuditions(5)->create();
+    actAsAdmin();
+    // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    delete(route('admin.events.destroy', $event))
+        ->assertRedirect(route('admin.events.index'))
+        ->assertSessionHas('error', 'Cannot delete an event with auditions');
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertSee($event->name);
+});
+it('has a form to add an event', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertSee('Add New Event')
+        ->assertSee(route('admin.events.store'));
+});
+it('allows an admin to add an event', function () {
+    $newEvent = Event::factory()->make();
+    actAsAdmin();
+    /** @noinspection PhpUnhandledExceptionInspection */
+    post(route('admin.events.store'), ['name' => $newEvent->name])
+        ->assertRedirect(route('admin.events.index'))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Event created successfully');
+    get(route('admin.events.index'))
+        ->assertOk()
+        ->assertSee($newEvent->name);
+});
+it('does not allow a guest or normal user to add an event', function () {
+    // Arrange
+    $newEvent = Event::factory()->make();
+    // Act & Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    post(route('admin.events.store'), ['name' => $newEvent->name])
+        ->assertRedirect(route('home'))
+        ->assertSessionHasNoErrors();
+    actAsNormal();
+    /** @noinspection PhpUnhandledExceptionInspection */
+    post(route('admin.events.store'), ['name' => $newEvent->name])
+        ->assertRedirect(route('dashboard'))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+});
-- 
2.39.5


From af9bc432a3df16ccbe8290d4cf5ef3204542f5dc Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 22:04:25 -0500
Subject: [PATCH 52/61] AuditionCreate Tests

---
 .../Controllers/Admin/AuditionController.php  | 10 +--
 database/factories/AuditionFactory.php        | 13 +++
 .../views/admin/auditions/index.blade.php     |  8 +-
 .../Pages/Setup/AuditionsCreateTest.php       | 90 +++++++++++++++++++
 .../Pages/Setup/AuditionsIndexTest.php        | 49 ++++++++++
 5 files changed, 160 insertions(+), 10 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/AuditionsCreateTest.php
 create mode 100644 tests/Feature/Pages/Setup/AuditionsIndexTest.php

diff --git a/app/Http/Controllers/Admin/AuditionController.php b/app/Http/Controllers/Admin/AuditionController.php
index 86d9e12..0dd0625 100644
--- a/app/Http/Controllers/Admin/AuditionController.php
+++ b/app/Http/Controllers/Admin/AuditionController.php
@@ -14,16 +14,14 @@ use function compact;
 use function redirect;
 use function request;
 use function response;
+use function to_route;
 use function view;
 
 class AuditionController extends Controller
 {
     public function index()
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
-        }
-        $auditions = Audition::with(['event', 'entries'])->orderBy('score_order')->orderBy('created_at', 'desc')->get();
+        $auditions = Audition::with(['event'])->withCount('entries')->orderBy('score_order')->orderBy('created_at', 'desc')->get();
 
         return view('admin.auditions.index', ['auditions' => $auditions]);
     }
@@ -68,7 +66,7 @@ class AuditionController extends Controller
             'for_advancement' => $validData['for_advancement'],
         ]);
 
-        return redirect('/admin/auditions');
+        return to_route('admin.auditions.index')->with('success', 'Audition created successfully');
     }
 
     public function edit(Audition $audition)
@@ -112,7 +110,7 @@ class AuditionController extends Controller
             'for_advancement' => $validData['for_advancement'],
         ]);
 
-        return redirect('/admin/auditions');
+        return to_route('admin.auditions.index')->with('success', 'Audition updated successfully');
     }
 
     public function reorder(Request $request)
diff --git a/database/factories/AuditionFactory.php b/database/factories/AuditionFactory.php
index 85bf5b4..a7c909e 100644
--- a/database/factories/AuditionFactory.php
+++ b/database/factories/AuditionFactory.php
@@ -62,4 +62,17 @@ class AuditionFactory extends Factory
             fn (array $attributes) => ['entry_deadline' => $entryDeadline ?? Carbon::yesterday()]
         );
     }
+    public function seatingOnly(): self
+    {
+        return $this->state(
+            fn (array $attributes) => ['for_advancement' => 0]
+        );
+    }
+
+    public function advancementOnly(): self
+    {
+        return $this->state(
+            fn (array $attributes) => ['for_seating' => 0]
+        );
+    }
 }
diff --git a/resources/views/admin/auditions/index.blade.php b/resources/views/admin/auditions/index.blade.php
index 527d197..d2f8a18 100644
--- a/resources/views/admin/auditions/index.blade.php
+++ b/resources/views/admin/auditions/index.blade.php
@@ -1,11 +1,11 @@
 <x-layout.app>
     <x-slot:page_title>Audition Administration</x-slot:page_title>
     <x-card.card>
-        <x-table.table with_title_area sortable="false">
+        <x-table.table with_title_area sortable="false" id="auditions-table">
             <x-slot:title class="ml-3">Auditions</x-slot:title>
             <x-slot:subtitle class="ml-3">Drag to reorder. Double click to edit.</x-slot:subtitle>
             <x-slot:title_block_right class="mr-3">
-                <x-form.button href="/admin/auditions/create">New Audition</x-form.button>
+                <x-form.button href="{{ route('admin.auditions.create') }}">New Audition</x-form.button>
             </x-slot:title_block_right>
 
             <thead>
@@ -27,7 +27,7 @@
             <div x-data="sortableList()" x-init="init">
                 <x-table.body id="sortable-list">
                     @foreach($auditions as $audition)
-                        <tr data-id="{{ $audition->id }}"
+                        <tr data-id="{{ $audition->id }}" id="auditionRow-{{ $audition->id }}"
                             @dblclick="window.location.href='/admin/auditions/{{ $audition->id }}/edit'">
                             <x-table.td>{{ $audition->event->name }}</x-table.td>
                             <x-table.td>{{ $audition->name }}</x-table.td>
@@ -50,7 +50,7 @@
                                     @endif
                                 </x-table.td>
                             @endif
-                            <x-table.td>{{ $audition->entries->count() }}</x-table.td>
+                            <x-table.td>{{ $audition->entries_count }}</x-table.td>
                         </tr>
                     @endforeach
                 </x-table.body>
diff --git a/tests/Feature/Pages/Setup/AuditionsCreateTest.php b/tests/Feature/Pages/Setup/AuditionsCreateTest.php
new file mode 100644
index 0000000..b913fc9
--- /dev/null
+++ b/tests/Feature/Pages/Setup/AuditionsCreateTest.php
@@ -0,0 +1,90 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Event;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+it('allows only an admin to manage auditions', function () {
+    get((route('admin.auditions.create')))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    get((route('admin.auditions.create')))
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actasAdmin();
+    get((route('admin.auditions.create')))
+        ->assertOk();
+});
+it('shows necessary fields', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    get(route('admin.auditions.create'))
+        ->assertOk()
+        ->assertSee(route('admin.auditions.store'))
+        ->assertSee('name="event_id"', false)
+        ->assertSee('name="name"', false)
+        ->assertSee('name="entry_deadline"', false)
+        ->assertSee('name="entry_fee"', false)
+        ->assertSee('name="minimum_grade"', false)
+        ->assertSee('name="maximum_grade"', false)
+        ->assertSee('name="for_seating"', false)
+        ->assertSee('name="for_advancement"', false);
+});
+it('allows an administrator to create auditions', function () {
+    // Arrange
+    $newEvent = Event::factory()->create();
+    $changes = [
+        'event_id' => $newEvent->id,
+        'name' => 'New Name',
+        'entry_deadline' => '1978-01-01',
+        'entry_fee' => 10000,
+        'minimum_grade' => 3,
+        'maximum_grade' => 8,
+        'for_advancement' => 'on',
+    ];
+    actAsAdmin();
+    // Act
+    $response = post(route('admin.auditions.store'), $changes);
+    // Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.auditions.index'))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Audition created successfully');
+    $checkAudition = Audition::latest()->first();
+    expect($checkAudition->event_id)->toBe($newEvent->id)
+        ->and($checkAudition->name)->toBe($changes['name'])
+        ->and($checkAudition->entry_deadline)->toBe($changes['entry_deadline'])
+        ->and($checkAudition->entry_fee)->toBe($changes['entry_fee'] * 100)
+        ->and($checkAudition->minimum_grade)->toBe($changes['minimum_grade'])
+        ->and($checkAudition->maximum_grade)->toBe($changes['maximum_grade'])
+        ->and($checkAudition->for_seating)->toBe(0)
+        ->and($checkAudition->for_advancement)->toBe(1);
+});
+it('does not allow a normal user or guest to create an audition', function () {
+    // Arrange
+    $precount = Audition::count();
+    $newEvent = Event::factory()->create();
+    $changes = [
+        'event_id' => $newEvent->id,
+        'name' => 'New Name',
+        'entry_deadline' => '1978-01-01',
+        'entry_fee' => 10000,
+        'minimum_grade' => 3,
+        'maximum_grade' => 8,
+        'for_advancement' => 'on',
+    ];
+    // Act & Assert
+    post(route('admin.auditions.store'), $changes)
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    post(route('admin.auditions.store'), $changes)
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    expect(Audition::count())->toBe($precount);
+});
diff --git a/tests/Feature/Pages/Setup/AuditionsIndexTest.php b/tests/Feature/Pages/Setup/AuditionsIndexTest.php
new file mode 100644
index 0000000..ae18032
--- /dev/null
+++ b/tests/Feature/Pages/Setup/AuditionsIndexTest.php
@@ -0,0 +1,49 @@
+<?php
+
+use App\Models\Audition;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Sinnbeck\DomAssertions\Asserts\AssertElement;
+
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+it('allows only an admin to manage auditions', function () {
+    get((route('admin.auditions.index')))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    get((route('admin.auditions.index')))
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actasAdmin();
+    get((route('admin.auditions.index')))
+        ->assertOk();
+});
+it('has a link to add a new audition', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    get((route('admin.auditions.index')))
+        ->assertOk()
+        ->assertSee('New Audition')
+        ->assertSee(route('admin.auditions.create'));
+});
+it('shows audition data', function () {
+    // Arrange
+    $auditions = Audition::factory()->count(10)->create();
+    actAsAdmin();
+    // Act & Assert
+    $response = get((route('admin.auditions.index')));
+    $response->assertOk();
+    foreach ($auditions as $audition) {
+        $response->assertElementExists('#auditionRow-'.$audition->id,
+            function (AssertElement $element) use ($audition) {
+                $element->containsText($audition->event->name)
+                    ->containsText($audition->name)
+                    ->containsText($audition->entry_deadline)
+                    ->containsText($audition->display_fee())
+                    ->containsText($audition->minimum_grade.' - '.$audition->maximum_grade)
+                    ->containsText($audition->entries->count());
+            });
+    }
+});
-- 
2.39.5


From 916baa2c93579f7f64426cb72afb3354e224fc6e Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Thu, 4 Jul 2024 22:42:44 -0500
Subject: [PATCH 53/61] AuditionsEdit Page Tests

---
 .../Controllers/Admin/AuditionController.php  |   6 +-
 app/Services/AuditionService.php              |   3 -
 .../views/admin/auditions/edit.blade.php      |  14 ++-
 .../delete-resource-modal.blade.php           |   8 ++
 .../Feature/Pages/Setup/AuditionsEditTest.php | 118 ++++++++++++++++++
 5 files changed, 135 insertions(+), 14 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/AuditionsEditTest.php

diff --git a/app/Http/Controllers/Admin/AuditionController.php b/app/Http/Controllers/Admin/AuditionController.php
index 0dd0625..2f43b95 100644
--- a/app/Http/Controllers/Admin/AuditionController.php
+++ b/app/Http/Controllers/Admin/AuditionController.php
@@ -160,16 +160,12 @@ class AuditionController extends Controller
 
     public function destroy(Audition $audition)
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
-        }
-        //        if($audition->entries->count() > 0) abort(403, 'Cannot delete an audition with entries.'
         if ($audition->entries->count() > 0) {
             return redirect()->route('admin.auditions.index')->with('error', 'Cannot delete an audition with entries.');
         }
         $audition->delete();
 
-        return redirect('/admin/auditions');
+        return to_route('admin.auditions.index')->with('success', 'Audition deleted successfully');
     }
 
     public function prepareDraw()
diff --git a/app/Services/AuditionService.php b/app/Services/AuditionService.php
index c45e064..6e2d9a9 100644
--- a/app/Services/AuditionService.php
+++ b/app/Services/AuditionService.php
@@ -69,9 +69,6 @@ class AuditionService
 
     public function clearCache(): void
     {
-        if (App::environment('local')) {
-            Session::flash('success', 'Audition Cache Cleared');
-        }
         Cache::forget($this->cacheKey);
     }
 
diff --git a/resources/views/admin/auditions/edit.blade.php b/resources/views/admin/auditions/edit.blade.php
index 0f362ea..dc2be46 100644
--- a/resources/views/admin/auditions/edit.blade.php
+++ b/resources/views/admin/auditions/edit.blade.php
@@ -3,6 +3,13 @@
     <x-card.card class="max-w-lg mx-auto">
         <x-card.heading>
             Edit Audition
+            <x-slot:right_side>
+                @if($audition->entries->count() == 0)
+                    <x-delete-resource-modal title="Delete Audition {{ $audition->name }}" action="{{ route('admin.auditions.destroy', $audition) }}">
+                        Please confirm that you would like to delete the audition {{ $audition->name }}. This action cannot be undone.
+                    </x-delete-resource-modal>
+                @endif
+            </x-slot:right_side>
             {{-- TODO implement a way to update multiple auditions as once --}}
         </x-card.heading>
         <x-form.form method="PATCH" action="/admin/auditions/{{ $audition->id }}">
@@ -39,18 +46,13 @@
 
             </x-form.body-grid>
             <x-form.footer submit-button-text="Update Audition" class="pb-4 !justify-between">
-                <div>
-                    @if($audition->entries->count() == 0)
-                        <x-form.red-trash-button form="deleteResource" size="20"></x-form.red-trash-button>
-                    @endif
-                </div>
+                <div></div>
                 <div>
                     <x-form.button>Edit Audition</x-form.button>
                 </div>
             </x-form.footer>
 
         </x-form.form>
-        <x-form.delete-form action="/admin/auditions/{{ $audition->id }}"></x-form.delete-form>
     </x-card.card>
 </x-layout.app>
 
diff --git a/resources/views/components/delete-resource-modal.blade.php b/resources/views/components/delete-resource-modal.blade.php
index b147988..6c444ea 100644
--- a/resources/views/components/delete-resource-modal.blade.php
+++ b/resources/views/components/delete-resource-modal.blade.php
@@ -1,3 +1,11 @@
+@php
+/**
+ * @var int $size=20 Size of the icon
+ * @var string $title Title of the modal
+ * @var string $method='DELETE' method used by the form
+ * @var string $action action used for the form
+ */
+@endphp
 @props(['size' => 20,'title','method'=>'DELETE','action'])
 
 <div
diff --git a/tests/Feature/Pages/Setup/AuditionsEditTest.php b/tests/Feature/Pages/Setup/AuditionsEditTest.php
new file mode 100644
index 0000000..8629274
--- /dev/null
+++ b/tests/Feature/Pages/Setup/AuditionsEditTest.php
@@ -0,0 +1,118 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\Event;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\delete;
+use function Pest\Laravel\get;
+use function Pest\Laravel\patch;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+    $this->audition = Audition::factory()->seatingOnly()->create();
+    $this->newEvent = Event::factory()->create();
+    $this->changes = [
+        'event_id' => $this->newEvent->id,
+        'name' => 'New Name',
+        'entry_deadline' => '1978-01-01',
+        'entry_fee' => 10000,
+        'minimum_grade' => 3,
+        'maximum_grade' => 8,
+        'for_advancement' => 'on',
+    ];
+});
+
+it('allows only an admin to manage auditions', function () {
+    get(route('admin.auditions.edit', $this->audition))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    get(route('admin.auditions.edit', $this->audition))
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actasAdmin();
+    get(route('admin.auditions.edit', $this->audition))
+        ->assertOk();
+});
+it('shows necessary fields', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    get(route('admin.auditions.edit', $this->audition))
+        ->assertOk()
+        ->assertSee(route('admin.auditions.store'))
+        ->assertSee('name="event_id"', false)
+        ->assertSee('name="name"', false)
+        ->assertSee('name="entry_deadline"', false)
+        ->assertSee('name="entry_fee"', false)
+        ->assertSee('name="minimum_grade"', false)
+        ->assertSee('name="maximum_grade"', false)
+        ->assertSee('name="for_seating"', false)
+        ->assertSee('name="for_advancement"', false);
+});
+it('allows an administrator to modify auditions', function () {
+    actAsAdmin();
+    // Act
+    $response = patch(route('admin.auditions.update', $this->audition), $this->changes);
+    // Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.auditions.index'))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Audition updated successfully');
+    $checkAudition = Audition::find($this->audition->id);
+    expect($checkAudition->event_id)->toBe($this->newEvent->id)
+        ->and($checkAudition->name)->toBe($this->changes['name'])
+        ->and($checkAudition->entry_deadline)->toBe($this->changes['entry_deadline'])
+        ->and($checkAudition->entry_fee)->toBe($this->changes['entry_fee'] * 100)
+        ->and($checkAudition->minimum_grade)->toBe($this->changes['minimum_grade'])
+        ->and($checkAudition->maximum_grade)->toBe($this->changes['maximum_grade'])
+        ->and($checkAudition->for_seating)->toBe(0)
+        ->and($checkAudition->for_advancement)->toBe(1);
+});
+it('does not allow a normal user or guest to create an audition', function () {
+    $preCheck = Audition::find($this->audition->id);
+    // Act & Assert
+    patch(route('admin.auditions.update', $this->audition), $this->changes)
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    patch(route('admin.auditions.update', $this->audition), $this->changes)
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    $checkAudition = Audition::find($this->audition->id);
+    expect($checkAudition)->toEqual($preCheck);
+});
+it('has a delete function for an audition that has no entries', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    get(route('admin.auditions.edit', $this->audition))
+        ->assertOk()
+        ->assertSee(route('admin.auditions.destroy', $this->audition));
+});
+it('does not allow guests or normal users to delete an audition', function () {
+    delete(route('admin.auditions.destroy', $this->audition))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    delete(route('admin.auditions.destroy', $this->audition))
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+});
+it('does not allow the deletion of an audition with entries', function () {
+    // Arrange
+    actAsAdmin();
+    Entry::factory()->create(['audition_id' => $this->audition->id]);
+    // Act & Assert
+    delete(route('admin.auditions.destroy', $this->audition))
+        ->assertRedirect(route('admin.auditions.index'))
+        ->assertSessionHas('error', 'Cannot delete an audition with entries.');
+});
+it('allows an administrator to delete an audition that has no entries', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    delete(route('admin.auditions.destroy', $this->audition))
+        ->assertRedirect(route('admin.auditions.index'))
+        ->assertSessionHas('success', 'Audition deleted successfully');
+    expect(Audition::find($this->audition->id))->toBeNull();
+});
-- 
2.39.5


From 3a93aa0ea28f2685a5107dbbdd58616e779fabb5 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 00:12:14 -0500
Subject: [PATCH 54/61] AdminEnsembles page tests

---
 .../Controllers/Admin/EnsembleController.php  |  59 +++++---
 .../ensembles/index-event-table.blade.php     |   2 +-
 .../ensembles/index-rename-modal.blade.php    |   2 +-
 routes/admin.php                              |   2 +-
 .../Pages/Setup/EnsemblesIndexTest.php        | 134 ++++++++++++++++++
 5 files changed, 173 insertions(+), 26 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/EnsemblesIndexTest.php

diff --git a/app/Http/Controllers/Admin/EnsembleController.php b/app/Http/Controllers/Admin/EnsembleController.php
index 7574041..da056db 100644
--- a/app/Http/Controllers/Admin/EnsembleController.php
+++ b/app/Http/Controllers/Admin/EnsembleController.php
@@ -8,7 +8,7 @@ use App\Models\Event;
 use App\Models\SeatingLimit;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
-use Illuminate\Support\Facades\DB;
+
 use function redirect;
 
 class EnsembleController extends Controller
@@ -16,16 +16,19 @@ class EnsembleController extends Controller
     public function index()
     {
         $events = Event::with('ensembles')->get();
-        return view('admin.ensembles.index',compact('events'));
+
+        return view('admin.ensembles.index', compact('events'));
     }
 
     public function store(Request $request)
     {
-        if(! Auth::user()->is_admin) abort(403);
+        if (! Auth::user()->is_admin) {
+            abort(403);
+        }
         request()->validate([
             'name' => 'required',
-            'code' => ['required','max:6'],
-            'event_id' => ['required','exists:events,id']
+            'code' => ['required', 'max:6'],
+            'event_id' => ['required', 'exists:events,id'],
         ]);
 
         Ensemble::create([
@@ -34,29 +37,32 @@ class EnsembleController extends Controller
             'event_id' => request('event_id'),
         ]);
 
-        return redirect()->route('admin.ensembles.index')->with('success','Ensemble created successfully');
+        return redirect()->route('admin.ensembles.index')->with('success', 'Ensemble created successfully');
     }
 
     public function destroy(Request $request, Ensemble $ensemble)
     {
-        if(! Auth::user()->is_admin) abort(403);
+        if ($ensemble->seats->count() > 0) {
+            return redirect()->route('admin.ensembles.index')->with('error', 'Ensemble has students seated and cannot be deleted');
+        }
         $ensemble->delete();
+
         return redirect()->route('admin.ensembles.index')->with('success', 'Ensemble deleted successfully');
     }
 
     public function updateEnsemble(Request $request, Ensemble $ensemble)
     {
-        if(! Auth::user()->is_admin) abort(403);
         request()->validate([
             'name' => 'required',
-            'code' => 'required|max:6'
+            'code' => 'required|max:6',
         ]);
 
         $ensemble->update([
             'name' => request('name'),
-            'code' => request('code')
+            'code' => request('code'),
         ]);
-        return redirect()->route('admin.ensembles.index')->with('success','Ensemble updated successfully');
+
+        return redirect()->route('admin.ensembles.index')->with('success', 'Ensemble updated successfully');
     }
 
     public function seatingLimits(Ensemble $ensemble)
@@ -65,33 +71,40 @@ class EnsembleController extends Controller
         if ($ensemble->exists()) {
             $ensemble->load('seatingLimits');
         }
-        return view('admin.ensembles.seatingLimits',compact('ensemble','ensembles'));
+
+        return view('admin.ensembles.seatingLimits', compact('ensemble', 'ensembles'));
     }
 
     public function seatingLimitsSet(Request $request, Ensemble $ensemble)
     {
         $request->validate([
-           'audition' => 'required',
-           'audition.*' => ['integer','min:0']
+            'audition' => 'required',
+            'audition.*' => ['integer', 'min:0'],
         ]);
 
-        foreach($ensemble->auditions as $audition) {
+        foreach ($ensemble->auditions as $audition) {
             SeatingLimit::upsert(
-                [[
-                'ensemble_id' => $ensemble->id,
-                'audition_id' => $audition->id,
-                'maximum_accepted' => $request->audition[$audition->id]
-                ]],
-                uniqueBy: ['ensemble_id','audition_id'],
+                [
+                    [
+                        'ensemble_id' => $ensemble->id,
+                        'audition_id' => $audition->id,
+                        'maximum_accepted' => $request->audition[$audition->id],
+                    ],
+                ],
+                uniqueBy: ['ensemble_id', 'audition_id'],
                 update: ['maximum_accepted']
             );
         }
-        return redirect()->route('admin.ensembles.seatingLimits')->with('success', 'Seating limits set for ' . $ensemble->name);
+
+        return redirect()->route('admin.ensembles.seatingLimits')->with('success',
+            'Seating limits set for '.$ensemble->name);
     }
 
     public function updateEnsembleRank(Request $request)
     {
-        if(! Auth::user()->is_admin) abort(403);
+        if (! Auth::user()->is_admin) {
+            abort(403);
+        }
 
         $order = $request->input('order');
         $eventId = $request->input('event_id');
diff --git a/resources/views/admin/ensembles/index-event-table.blade.php b/resources/views/admin/ensembles/index-event-table.blade.php
index baebc90..9f337ce 100644
--- a/resources/views/admin/ensembles/index-event-table.blade.php
+++ b/resources/views/admin/ensembles/index-event-table.blade.php
@@ -15,7 +15,7 @@
         </thead>
         <x-table.body>
             @foreach($event->ensembles as $ensemble)
-                <tr data-id="{{ $ensemble->id }}">
+                <tr data-id="{{ $ensemble->id }}" id="ensembleRow-{{$ensemble->id}}">
                     <x-table.td class="handle">
                         <svg class="w-6 h-6 text-gray-800 dark:text-white" aria-hidden="true" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none" viewBox="0 0 24 24">
                             <path stroke="currentColor" stroke-linecap="round" stroke-width="2" d="M5 7h14M5 12h14M5 17h14"/>
diff --git a/resources/views/admin/ensembles/index-rename-modal.blade.php b/resources/views/admin/ensembles/index-rename-modal.blade.php
index 3ff5ba1..d840974 100644
--- a/resources/views/admin/ensembles/index-rename-modal.blade.php
+++ b/resources/views/admin/ensembles/index-rename-modal.blade.php
@@ -1,7 +1,7 @@
 <x-modal>
     <x-slot:button_text>{{ $ensemble->name }}</x-slot:button_text>
     <x-slot:title class="font-semibold">Rename Ensemble {{ $ensemble->name }}</x-slot:title>
-    <x-form.form method="PATCH" action="{{ route('admin.ensembles.updateEnsemble', ['ensemble' => $ensemble->rank]) }}">
+    <x-form.form method="PATCH" action="{{ route('admin.ensembles.update', ['ensemble' => $ensemble->rank]) }}">
         <x-form.body-grid columns="4">
             <x-form.field colspan="2" label_text="New Name" value="{{ $ensemble->name }}" name="name" />
             <x-form.field colspan="1" label_text="New Code" value="{{ $ensemble->code }}" name="code" />
diff --git a/routes/admin.php b/routes/admin.php
index 53563c8..39897c1 100644
--- a/routes/admin.php
+++ b/routes/admin.php
@@ -19,7 +19,7 @@ Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->
         Route::post('/', 'store')->name('admin.ensembles.store');
         Route::delete('/{ensemble}', 'destroy')->name('admin.ensembles.destroy');
         Route::post('/updateEnsembleRank', 'updateEnsembleRank')->name('admin.ensembles.updateEnsembleRank');
-        Route::patch('/{ensemble}', 'updateEnsemble')->name('admin.ensembles.updateEnsemble');
+        Route::patch('/{ensemble}', 'updateEnsemble')->name('admin.ensembles.update');
         Route::get('/seating-limits', 'seatingLimits')->name('admin.ensembles.seatingLimits');
         Route::get('/seating-limits/{ensemble}', 'seatingLimits')->name('admin.ensembles.seatingLimits.ensemble');
         Route::post('/seating-limits/{ensemble}', 'seatingLimitsSet')->name('admin.ensembles.seatingLimits.ensemble.set');
diff --git a/tests/Feature/Pages/Setup/EnsemblesIndexTest.php b/tests/Feature/Pages/Setup/EnsemblesIndexTest.php
new file mode 100644
index 0000000..3f52136
--- /dev/null
+++ b/tests/Feature/Pages/Setup/EnsemblesIndexTest.php
@@ -0,0 +1,134 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Ensemble;
+use App\Models\Entry;
+use App\Models\Event;
+use App\Models\Seat;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\delete;
+use function Pest\Laravel\get;
+use function Pest\Laravel\patch;
+
+uses(RefreshDatabase::class);
+
+it('allows only an admin to manage ensembles', function () {
+    get((route('admin.ensembles.index')))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    get((route('admin.ensembles.index')))
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actasAdmin();
+    get((route('admin.ensembles.index')))
+        ->assertOk();
+});
+it('has a form to create an ensemble', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    get((route('admin.ensembles.index')))
+        ->assertOk()
+        ->assertSee('action="'.route('admin.ensembles.store').'"', false)
+        ->assertSee('name="name"', false)
+        ->assertSee('name="code"', false)
+        ->assertSee('name="event_id"', false)
+        ->assertSeeInOrder(['<button', 'type="submit"', '</button>'], false);
+});
+it('shows ensemble data', function () {
+    // Arrange
+    Ensemble::factory()->count(10)->create();
+    actAsAdmin();
+    // Act & Assert
+    $response = get((route('admin.ensembles.index')));
+    $response->assertOk();
+    $events = Event::all();
+    foreach ($events as $event) {
+        foreach ($event->ensembles as $ensemble) {
+            $response->assertSeeInOrder([
+                $event->name, '<td', $ensemble->id, '</td>', '<td', e($ensemble->name), '</td>',
+            ], false);
+        }
+        $response->assertSee($event->name);
+    }
+});
+it('shows a delete option for ensembles with no students seated', function () {
+    // Arrange
+    $event = Event::factory()->create();
+    $noSeatsEnsemble = Ensemble::factory()->create(['event_id' => $event->id]);
+    $seatsEnsemble = Ensemble::factory()->create(['event_id' => $event->id]);
+    $audition = Audition::factory()->create(['event_id' => $event->id]);
+    $entry = Entry::factory()->create(['audition_id' => $audition->id]);
+    Seat::create([
+        'ensemble_id' => $seatsEnsemble->id,
+        'audition_id' => $audition->id,
+        'seat' => 1,
+        'entry_id' => $entry->id,
+    ]);
+    // Act & Assert
+    actAsAdmin();
+    $response = get((route('admin.ensembles.index')));
+    $response->assertOk();
+    $response->assertSee(route('admin.ensembles.destroy', $noSeatsEnsemble), false);
+    #$response->assertDontSee(route('admin.ensembles.destroy', $seatsEnsemble), false); // TODO figure out how to test for a delete form that does not also see an edit form
+});
+it('allows an administrator to delete an ensemble while no entries are seated', function () {
+    // Arrange
+    $event = Event::factory()->create();
+    $noSeatsEnsemble = Ensemble::factory()->create(['event_id' => $event->id]);
+    $seatsEnsemble = Ensemble::factory()->create(['event_id' => $event->id]);
+    $audition = Audition::factory()->create(['event_id' => $event->id]);
+    $entry = Entry::factory()->create(['audition_id' => $audition->id]);
+    Seat::create([
+        'ensemble_id' => $seatsEnsemble->id,
+        'audition_id' => $audition->id,
+        'seat' => 1,
+        'entry_id' => $entry->id,
+    ]);
+    // Act & Assert
+    actAsAdmin();
+    delete((route('admin.ensembles.destroy', $noSeatsEnsemble)))
+        ->assertRedirect(route('admin.ensembles.index'))
+        ->assertSessionHas('success', 'Ensemble deleted successfully');
+    expect(Ensemble::find($noSeatsEnsemble->id))->toBeNull();
+    delete((route('admin.ensembles.destroy', $seatsEnsemble)))
+        ->assertRedirect(route('admin.ensembles.index'))
+        ->assertSessionHas('error', 'Ensemble has students seated and cannot be deleted');
+});
+it('does not allow a guest or normal user to delete an ensemble', function () {
+    $ensemble = Ensemble::factory()->create();
+    delete((route('admin.ensembles.destroy', $ensemble)))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    delete((route('admin.ensembles.destroy', $ensemble)))
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+});
+it('includes a form to edit an ensemble', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    actAsAdmin();
+    // Act & Assert
+    get((route('admin.ensembles.index')))
+        ->assertOk()
+        ->assertSee('action="'.route('admin.ensembles.update', $ensemble).'"', false);
+});
+it('allows an administrator to update an ensemble', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    $newData = [
+        'name' => 'New Ensemble Name',
+        'code' => 'NEWC',
+    ];
+    // Act & Assert
+    actAsAdmin();
+    $response = patch(route('admin.ensembles.update', $ensemble), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.ensembles.index'))
+        ->assertSessionHas('success', 'Ensemble updated successfully')
+        ->assertSessionHasNoErrors();
+    $postCheck = Ensemble::find($ensemble->id);
+    expect($postCheck->name)->toBe($newData['name'])
+        ->and($postCheck->code)->toBe($newData['code']);
+});
-- 
2.39.5


From df4095d45aed6f33c6ad95afc687bfb05ba0a545 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 10:26:36 -0500
Subject: [PATCH 55/61] SeatingLImits Page Tests done

---
 .../Controllers/Admin/EnsembleController.php  |  10 +-
 .../seatingLimits-limitForm.blade.php         |   9 +-
 .../admin/ensembles/seatingLimits.blade.php   |   9 +-
 .../Feature/Pages/Setup/SeatingLimitsTest.php | 174 ++++++++++++++++++
 4 files changed, 193 insertions(+), 9 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/SeatingLimitsTest.php

diff --git a/app/Http/Controllers/Admin/EnsembleController.php b/app/Http/Controllers/Admin/EnsembleController.php
index da056db..d3a79e4 100644
--- a/app/Http/Controllers/Admin/EnsembleController.php
+++ b/app/Http/Controllers/Admin/EnsembleController.php
@@ -67,12 +67,16 @@ class EnsembleController extends Controller
 
     public function seatingLimits(Ensemble $ensemble)
     {
-        $ensembles = Ensemble::with('event')->orderBy('event_id')->get();
+        $limits = [];
+        $ensembles = Ensemble::with(['event'])->orderBy('event_id')->get();
         if ($ensemble->exists()) {
             $ensemble->load('seatingLimits');
+            foreach ($ensemble->seatingLimits as $lim) {
+                $limits[$lim->audition_id] = $lim->maximum_accepted;
+            }
         }
 
-        return view('admin.ensembles.seatingLimits', compact('ensemble', 'ensembles'));
+        return view('admin.ensembles.seatingLimits', compact('ensemble', 'ensembles', 'limits'));
     }
 
     public function seatingLimitsSet(Request $request, Ensemble $ensemble)
@@ -96,7 +100,7 @@ class EnsembleController extends Controller
             );
         }
 
-        return redirect()->route('admin.ensembles.seatingLimits')->with('success',
+        return redirect()->route('admin.ensembles.seatingLimits.ensemble', $ensemble)->with('success',
             'Seating limits set for '.$ensemble->name);
     }
 
diff --git a/resources/views/admin/ensembles/seatingLimits-limitForm.blade.php b/resources/views/admin/ensembles/seatingLimits-limitForm.blade.php
index da1f81b..21ba468 100644
--- a/resources/views/admin/ensembles/seatingLimits-limitForm.blade.php
+++ b/resources/views/admin/ensembles/seatingLimits-limitForm.blade.php
@@ -1,9 +1,8 @@
 @php
-    $limits = [];
-    foreach ($ensemble->seatingLimits as $lim) {
-        $limits[$lim->audition_id] = $lim->maximum_accepted;
-    }
-
+/**
+*  @var \App\Models\Ensemble $ensemble The ensemble for which a seating form is shown
+ * @var array $limits An array of audition_id => maximum_accepted for the ensemble
+**/
 @endphp
 <x-card.card class="mt-5 max-w-md mx-auto">
     <x-card.heading>{{ $ensemble->name }}</x-card.heading>
diff --git a/resources/views/admin/ensembles/seatingLimits.blade.php b/resources/views/admin/ensembles/seatingLimits.blade.php
index 67ad1f7..1987c93 100644
--- a/resources/views/admin/ensembles/seatingLimits.blade.php
+++ b/resources/views/admin/ensembles/seatingLimits.blade.php
@@ -11,7 +11,14 @@
                     `{{ route('admin.ensembles.seatingLimits') }}/${event.target.value}`">
                 <option value=""></option>
                 @foreach($ensembles as $optionEnsemble)
-                    <option value ="{{$optionEnsemble->id}}">{{$optionEnsemble->event->name}} - {{$optionEnsemble->name}}</option>
+                    @php
+                        if ($ensemble && $ensemble->id == $optionEnsemble->id) {
+                            $selected = 'selected';
+                        } else {
+                            $selected = '';
+                        }
+                    @endphp
+                    <option value ="{{$optionEnsemble->id}}" {{$selected}}>{{$optionEnsemble->event->name}} - {{$optionEnsemble->name}}</option>
                 @endforeach
             </x-form.select>
         </div>
diff --git a/tests/Feature/Pages/Setup/SeatingLimitsTest.php b/tests/Feature/Pages/Setup/SeatingLimitsTest.php
new file mode 100644
index 0000000..a10ff9e
--- /dev/null
+++ b/tests/Feature/Pages/Setup/SeatingLimitsTest.php
@@ -0,0 +1,174 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Ensemble;
+use App\Models\SeatingLimit;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+it('only allows admin to manage seating limits', function () {
+    get(route('admin.ensembles.seatingLimits'))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    get(route('admin.ensembles.seatingLimits'))
+        ->assertRedirect('/dashboard')
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actAsAdmin();
+    get(route('admin.ensembles.seatingLimits'))
+        ->assertOk();
+});
+it('shows a dropdown of ensembles', function () {
+    // Arrange
+    $ensembles = Ensemble::factory()->count(5)->create();
+    actAsAdmin();
+    // Act & Assert
+    $response = get(route('admin.ensembles.seatingLimits'));
+    $response->assertOk();
+    foreach ($ensembles as $ensemble) {
+        $response->assertSeeInOrder([
+            '<option', 'value="', $ensemble->id, e($ensemble->event->name), ' - ', e($ensemble->name), '</option>',
+        ], false);
+    }
+});
+it('shows a seating list from when called with an ensemble id', function () {
+    // Arrange
+    $ensembles = Ensemble::factory()->count(5)->create();
+    // Act & Assert
+    actAsAdmin();
+    foreach ($ensembles as $ensemble) {
+        $response = get(route('admin.ensembles.seatingLimits.ensemble', $ensemble));
+        $response->assertOk();
+        $response->assertSeeInOrder(['<h3', e($ensemble->name), '</h3>'], false);
+        $response->assertSee(route('admin.ensembles.seatingLimits.ensemble.set', $ensemble));
+    }
+
+});
+it('shows a field for each audition for a called ensemble', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    $auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
+    foreach ($auditions as $audition) {
+        SeatingLimit::create([
+            'ensemble_id' => $ensemble->id,
+            'audition_id' => $audition->id,
+            'maximum_accepted' => fake()->numberBetween(1, 15),
+        ]);
+    }
+    // Act & Assert
+    actAsAdmin();
+    $response = get(route('admin.ensembles.seatingLimits.ensemble', $ensemble));
+    $response->assertOk()
+        ->assertSeeInOrder(['<h3', e($ensemble->name), '</h3>'], false);
+    foreach ($auditions as $audition) {
+        $response->assertSeeInOrder([
+            '<li', '<label', 'for=', 'audition-'.$audition->id, e($audition->name), '<input', 'name=', 'audition[',
+            $audition->id, ']', '</li>',
+        ], false);
+    }
+});
+it('shows existing seating limits on the fields', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    $auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
+    foreach ($auditions as $audition) {
+        SeatingLimit::create([
+            'ensemble_id' => $ensemble->id,
+            'audition_id' => $audition->id,
+            'maximum_accepted' => fake()->numberBetween(1, 15),
+        ]);
+    }
+    // Act & Assert
+    actAsAdmin();
+    $response = get(route('admin.ensembles.seatingLimits.ensemble', $ensemble));
+    $response->assertOk();
+    foreach ($auditions as $audition) {
+        $limit = $ensemble->seatingLimits->where('audition_id', $audition->id)->first()->maximum_accepted;
+        $response->assertSeeInOrder([
+            '<input', 'name="audition['.$audition->id.']"', 'value="', $limit, '"',
+        ], false);
+    }
+});
+
+it('allows an administrator to modify seating limits', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    $auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
+    foreach ($auditions as $audition) {
+        SeatingLimit::create([
+            'ensemble_id' => $ensemble->id,
+            'audition_id' => $audition->id,
+            'maximum_accepted' => fake()->numberBetween(1, 15),
+        ]);
+    }
+    $newData = [
+        'audition' => [],
+    ];
+    foreach ($auditions as $audition) {
+        $newData['audition'][$audition->id] = 21;
+    }
+    // Act & Assert
+    actAsAdmin();
+    $response = post(route('admin.ensembles.seatingLimits.ensemble.set', $ensemble), $newData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Seating limits set for '.$ensemble->name)
+        ->assertRedirect(route('admin.ensembles.seatingLimits.ensemble', $ensemble));
+    $check = Ensemble::find($ensemble->id);
+    foreach ($check->seatingLimits as $seatingLimit) {
+        expect($seatingLimit->maximum_accepted)->toBe(21);
+    }
+});
+it('does not allow a guest to update seating limits', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    $auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
+    foreach ($auditions as $audition) {
+        SeatingLimit::create([
+            'ensemble_id' => $ensemble->id,
+            'audition_id' => $audition->id,
+            'maximum_accepted' => fake()->numberBetween(1, 15),
+        ]);
+    }
+    $newData = [
+        'audition' => [],
+    ];
+    foreach ($auditions as $audition) {
+        $newData['audition'][$audition->id] = 21;
+    }
+    $response = post(route('admin.ensembles.seatingLimits.ensemble.set', $ensemble), $newData);
+    $response->assertRedirect(route('home'));
+    $check = Ensemble::find($ensemble->id);
+    foreach ($check->seatingLimits as $seatingLimit) {
+        expect($seatingLimit->maximum_accepted)->toBeLessThan(16);
+    }
+});
+it('does not allow a normal user to update seating limits', function () {
+    // Arrange
+    $ensemble = Ensemble::factory()->create();
+    $auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
+    foreach ($auditions as $audition) {
+        SeatingLimit::create([
+            'ensemble_id' => $ensemble->id,
+            'audition_id' => $audition->id,
+            'maximum_accepted' => fake()->numberBetween(1, 15),
+        ]);
+    }
+    $newData = [
+        'audition' => [],
+    ];
+    foreach ($auditions as $audition) {
+        $newData['audition'][$audition->id] = 21;
+    }
+    actAsNormal();
+    $response = post(route('admin.ensembles.seatingLimits.ensemble.set', $ensemble), $newData);
+    $response->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    $check = Ensemble::find($ensemble->id);
+    foreach ($check->seatingLimits as $seatingLimit) {
+        expect($seatingLimit->maximum_accepted)->toBeLessThan(16);
+    }
+});
-- 
2.39.5


From df561164be6333613633198bec99dea18e1d5cfd Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 11:38:50 -0500
Subject: [PATCH 56/61] ScoringGuideIndex Tests

---
 .../Admin/ScoringGuideController.php          |  7 +-
 ...nsure_room_id_0_for_unassigned_entries.php |  7 +-
 ...ing_guide_id_column_to_auditions_table.php |  5 +-
 ...ex-scoring-guide-management-card.blade.php |  6 +-
 .../Pages/Setup/ScoringGuideIndexTest.php     | 85 +++++++++++++++++++
 5 files changed, 94 insertions(+), 16 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/ScoringGuideIndexTest.php

diff --git a/app/Http/Controllers/Admin/ScoringGuideController.php b/app/Http/Controllers/Admin/ScoringGuideController.php
index e07b1f7..0e84a5c 100644
--- a/app/Http/Controllers/Admin/ScoringGuideController.php
+++ b/app/Http/Controllers/Admin/ScoringGuideController.php
@@ -17,13 +17,10 @@ class ScoringGuideController extends Controller
 {
     public function index()
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
-        }
         DB::table('auditions')
             ->whereNull('scoring_guide_id')
             ->update(['scoring_guide_id' => 0]);
-        $guides = ScoringGuide::with('auditions')->orderBy('name')->get();
+        $guides = ScoringGuide::with(['auditions'])->withCount('subscores')->orderBy('name')->get();
 
         return view('admin.scoring.index', ['guides' => $guides]);
     }
@@ -42,7 +39,7 @@ class ScoringGuideController extends Controller
             'name' => request('name'),
         ]);
 
-        return redirect('/admin/scoring');
+        return redirect(route('admin.scoring.index'))->with('success', 'Scoring guide created');
     }
 
     public function edit(Request $request, ScoringGuide $guide)
diff --git a/database/migrations/2024_06_04_205015_ensure_room_id_0_for_unassigned_entries.php b/database/migrations/2024_06_04_205015_ensure_room_id_0_for_unassigned_entries.php
index 1c28c98..c2e0ac5 100644
--- a/database/migrations/2024_06_04_205015_ensure_room_id_0_for_unassigned_entries.php
+++ b/database/migrations/2024_06_04_205015_ensure_room_id_0_for_unassigned_entries.php
@@ -1,10 +1,7 @@
 <?php
 
 use App\Models\Room;
-use App\Models\ScoringGuide;
 use Illuminate\Database\Migrations\Migration;
-use Illuminate\Database\Schema\Blueprint;
-use Illuminate\Support\Facades\Schema;
 
 return new class extends Migration
 {
@@ -16,10 +13,10 @@ return new class extends Migration
         if (! Room::find(0)) {
             $room = Room::create([
                 'id' => 0,
-                'name' => 'No Guide Assigned'
+                'name' => 'No Guide Assigned',
             ]);
             $room->update([
-                'id' => 0
+                'id' => 0,
             ]);
         }
     }
diff --git a/database/migrations/2024_06_05_011858_add_scoring_guide_id_column_to_auditions_table.php b/database/migrations/2024_06_05_011858_add_scoring_guide_id_column_to_auditions_table.php
index c1f7640..c66e6ee 100644
--- a/database/migrations/2024_06_05_011858_add_scoring_guide_id_column_to_auditions_table.php
+++ b/database/migrations/2024_06_05_011858_add_scoring_guide_id_column_to_auditions_table.php
@@ -1,6 +1,5 @@
 <?php
 
-use App\Models\Room;
 use App\Models\ScoringGuide;
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
@@ -20,10 +19,10 @@ return new class extends Migration
         if (! ScoringGuide::find(0)) {
             $sg = ScoringGuide::create([
                 'id' => 0,
-                'name' => 'No Guide Assigned'
+                'name' => 'No Guide Assigned',
             ]);
             $sg->update([
-                'id' => 0
+                'id' => 0,
             ]);
         }
     }
diff --git a/resources/views/admin/scoring/index-scoring-guide-management-card.blade.php b/resources/views/admin/scoring/index-scoring-guide-management-card.blade.php
index 8a57ab3..851cef3 100644
--- a/resources/views/admin/scoring/index-scoring-guide-management-card.blade.php
+++ b/resources/views/admin/scoring/index-scoring-guide-management-card.blade.php
@@ -17,14 +17,14 @@
                     @continue
                 @endif
                 <tr>
-                    <x-table.td>{{ $guide->name }}  <span class="text-xs text-gray-400">{{ $guide->subscores->count() }} subscores</span></x-table.td>
-                    <x-table.td class="text-right text-indigo-600"><a href="/admin/scoring/guides/{{ $guide->id }}/edit">Edit</a></x-table.td>
+                    <x-table.td>{{ $guide->name }}  <span class="text-xs text-gray-400">{{ $guide->subscores_count }} subscores</span></x-table.td>
+                    <x-table.td class="text-right text-indigo-600"><a href="{{ route('admin.scoring.edit', $guide) }}">Edit</a></x-table.td>
                 </tr>
             @endforeach
         </x-table.body>
         <tfoot>
         <tr>
-            <x-form.form method="POST" action="/admin/scoring/guides" class="!px-0 !py-0">
+            <x-form.form method="POST" action="{{ route('admin.scoring.store') }}" class="!px-0 !py-0">
                 <x-table.td>
                     <x-form.field name="name" label_text="Add New Scoring Guide" />
                 </x-table.td>
diff --git a/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php b/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php
new file mode 100644
index 0000000..92368f2
--- /dev/null
+++ b/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php
@@ -0,0 +1,85 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Sinnbeck\DomAssertions\Asserts\AssertElement;
+
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+it('shows a scoring guide management page only to administrators', function () {
+    get(route('admin.scoring.index'))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    get(route('admin.scoring.index'))
+        ->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actAsAdmin();
+    get(route('admin.scoring.index'))
+        ->assertOk()
+        ->assertViewIs('admin.scoring.index');
+});
+it('shows a list of scoring guides and their count of subscores', function () {
+    $scoringGuide = ScoringGuide::factory()->create();
+    SubscoreDefinition::factory()->count(3)->create(['scoring_guide_id' => $scoringGuide->id]);
+    Audition::factory()->count(3)->create(['scoring_guide_id' => $scoringGuide->id]);
+    actAsAdmin();
+    $response = get(route('admin.scoring.index'));
+    $response->assertOk()
+        ->assertSeeInOrder(['<td', $scoringGuide->name, $scoringGuide->subscores()->count()], false);
+});
+it('shows a link to edit each scoring guide', function () {
+    $scoringGuide = ScoringGuide::factory()->create();
+    actAsAdmin();
+    $response = get(route('admin.scoring.index'));
+    $response->assertOk()
+        ->assertSee(route('admin.scoring.edit', $scoringGuide));
+});
+it('shows auditions in groups with their scoring guide', function () {
+    $guides = ScoringGuide::factory()->count(2)->create();
+    foreach ($guides as $guide) {
+        Audition::factory()->count(3)->create(['scoring_guide_id' => $guide->id]);
+    }
+    actAsAdmin();
+    $response = get(route('admin.scoring.index'));
+    $response->assertOk();
+    foreach (Audition::all() as $audition) {
+        $guide = $audition->scoringGuide;
+        $response->assertElementExists('#guide-'.$guide->id, function (AssertElement $element) use ($audition) {
+            $element->containsText($audition->name);
+        });
+    }
+});
+it('has a form for a new scoring guide', function () {
+    actAsAdmin();
+    $response = get(route('admin.scoring.index'));
+    $response->assertOk()
+        ->assertSeeInOrder(['<input', 'name=', 'name'], false)
+        ->assertSee(route('admin.scoring.store'));
+});
+it('creates a new scoring guide', function () {
+    $formData = ['name' => 'New Scoring Guide'];
+    actAsAdmin();
+    $response = post(route('admin.scoring.store'), $formData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response
+        ->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.scoring.index'))
+        ->assertSessionHas('success', 'Scoring guide created');
+    $this->assertDatabaseHas('scoring_guides', $formData);
+});
+it('only allows an admin to create a new scoring guide', function () {
+    // Arrange
+    $formData = ['name' => 'New Scoring Guide'];
+    // Act & Assert
+    $response = post(route('admin.scoring.store'), $formData);
+    $response->assertRedirect(route('home'));
+    actAsNormal();
+    $response = post(route('admin.scoring.store'), $formData);
+    $response->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+});
-- 
2.39.5


From fb2c5724ec23c57842e553e0e71828ab94adcf57 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 11:58:45 -0500
Subject: [PATCH 57/61] Catch up

---
 .../Controllers/Admin/AuditionController.php  | 23 ++++++++++++++----
 ...on-scoring-guide-assignment-card.blade.php |  2 +-
 routes/admin.php                              |  2 +-
 .../Pages/Setup/AuditionsCreateTest.php       | 24 +++++++++++++++++++
 .../Pages/Setup/ScoringGuideIndexTest.php     |  9 +++++++
 5 files changed, 54 insertions(+), 6 deletions(-)

diff --git a/app/Http/Controllers/Admin/AuditionController.php b/app/Http/Controllers/Admin/AuditionController.php
index 2f43b95..9025bf0 100644
--- a/app/Http/Controllers/Admin/AuditionController.php
+++ b/app/Http/Controllers/Admin/AuditionController.php
@@ -5,6 +5,7 @@ namespace App\Http\Controllers\Admin;
 use App\Http\Controllers\Controller;
 use App\Models\Audition;
 use App\Models\Event;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use Illuminate\Support\Facades\Auth;
 
@@ -21,7 +22,8 @@ class AuditionController extends Controller
 {
     public function index()
     {
-        $auditions = Audition::with(['event'])->withCount('entries')->orderBy('score_order')->orderBy('created_at', 'desc')->get();
+        $auditions = Audition::with(['event'])->withCount('entries')->orderBy('score_order')->orderBy('created_at',
+            'desc')->get();
 
         return view('admin.auditions.index', ['auditions' => $auditions]);
     }
@@ -48,12 +50,16 @@ class AuditionController extends Controller
             'entry_fee' => ['required', 'numeric'],
             'minimum_grade' => ['required', 'integer'],
             'maximum_grade' => 'required|numeric|gte:minimum_grade',
+            'scoring_guide_id' => 'nullable|exists:scoring_guides,id',
         ], [
             'maximum_grade.gte' => 'The maximum grade must be greater than the minimum grade.',
         ]);
 
         $validData['for_seating'] = $request->get('for_seating') ? 1 : 0;
         $validData['for_advancement'] = $request->get('for_advancement') ? 1 : 0;
+        if (empty($alidData['scoring_guide_id'])) {
+            $validData['scoring_guide_id'] = 0;
+        }
 
         Audition::create([
             'event_id' => $validData['event_id'],
@@ -64,6 +70,7 @@ class AuditionController extends Controller
             'maximum_grade' => $validData['maximum_grade'],
             'for_seating' => $validData['for_seating'],
             'for_advancement' => $validData['for_advancement'],
+            'scoring_guide_id' => $validData['scoring_guide_id'],
         ]);
 
         return to_route('admin.auditions.index')->with('success', 'Audition created successfully');
@@ -91,7 +98,7 @@ class AuditionController extends Controller
             'entry_deadline' => ['required', 'date'],
             'entry_fee' => ['required', 'numeric'],
             'minimum_grade' => ['required', 'integer'],
-            'maximum_grade' => 'required|numeric|gt:minimum_grade',
+            'maximum_grade' => 'required | numeric | gt:minimum_grade',
         ], [
             'maximum_grade.gt' => 'The maximum grade must be greater than the minimum grade.',
         ]);
@@ -142,6 +149,13 @@ class AuditionController extends Controller
         return response()->json(['status' => 'success']);
     }
 
+    /**
+     * Update the scoring guide for an audition
+     * Used by AJAX call on the scoring guide index page
+     * request should include scoring_guide_id and audition_id
+     *
+     * @return JsonResponse
+     */
     public function scoringGuideUpdate(Request $request)
     {
 
@@ -184,7 +198,8 @@ class AuditionController extends Controller
             return $audition->has_partial_draw();
         });
 
-        return view('admin.entries.prepare_draw', compact('nodraw_auditions', 'drawn_auditions', 'partial_draw_auditions'));
+        return view('admin.entries.prepare_draw',
+            compact('nodraw_auditions', 'drawn_auditions', 'partial_draw_auditions'));
     }
 
     public function runDraw(Request $request)
@@ -197,6 +212,6 @@ class AuditionController extends Controller
             $audition->runDraw();
         }
 
-        return redirect('/admin/auditions/run_draw');
+        return redirect(' / admin / auditions / run_draw');
     }
 }
diff --git a/resources/views/admin/scoring/index-audition-scoring-guide-assignment-card.blade.php b/resources/views/admin/scoring/index-audition-scoring-guide-assignment-card.blade.php
index 69dab01..16155a5 100644
--- a/resources/views/admin/scoring/index-audition-scoring-guide-assignment-card.blade.php
+++ b/resources/views/admin/scoring/index-audition-scoring-guide-assignment-card.blade.php
@@ -54,7 +54,7 @@
                             let auditionId = itemEl.getAttribute('data-id');
 
                             // Make an AJAX request to update the audition_guide_id
-                            fetch('/admin/scoring/assign_guide_to_audition', {
+                            fetch('{{route('ajax.assignScoringGuideToAudition')}}', {
                                 method: 'POST',
                                 headers: {
                                     'Content-Type': 'application/json',
diff --git a/routes/admin.php b/routes/admin.php
index 39897c1..4a2d5b9 100644
--- a/routes/admin.php
+++ b/routes/admin.php
@@ -8,7 +8,7 @@ Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->
     Route::view('/', 'admin.dashboard')->name('admin.dashboard');
 
     Route::post('/auditions/roomUpdate', [\App\Http\Controllers\Admin\AuditionController::class, 'roomUpdate']); // Endpoint for JS assigning auditions to rooms
-    Route::post('/scoring/assign_guide_to_audition', [\App\Http\Controllers\Admin\AuditionController::class, 'scoringGuideUpdate']); // Endpoint for JS assigning scoring guides to auditions
+    Route::post('/scoring/assign_guide_to_audition', [\App\Http\Controllers\Admin\AuditionController::class, 'scoringGuideUpdate'])->name('ajax.assignScoringGuideToAudition'); // Endpoint for JS assigning scoring guides to auditions
 
     Route::get('/settings', [\App\Http\Controllers\Admin\AuditionSettings::class, 'index'])->name('audition-settings');
     Route::post('/settings', [\App\Http\Controllers\Admin\AuditionSettings::class, 'save'])->name('audition-settings-save');
diff --git a/tests/Feature/Pages/Setup/AuditionsCreateTest.php b/tests/Feature/Pages/Setup/AuditionsCreateTest.php
index b913fc9..18b9dd3 100644
--- a/tests/Feature/Pages/Setup/AuditionsCreateTest.php
+++ b/tests/Feature/Pages/Setup/AuditionsCreateTest.php
@@ -66,6 +66,30 @@ it('allows an administrator to create auditions', function () {
         ->and($checkAudition->for_seating)->toBe(0)
         ->and($checkAudition->for_advancement)->toBe(1);
 });
+it('sets scoring_guide_id to 0 if none is set when creating an audition', function () {
+    // Arrange
+    $newEvent = Event::factory()->create();
+    $changes = [
+        'event_id' => $newEvent->id,
+        'name' => 'New Name',
+        'entry_deadline' => '1978-01-01',
+        'entry_fee' => 10000,
+        'minimum_grade' => 3,
+        'maximum_grade' => 8,
+        'for_advancement' => 'on',
+    ];
+    actAsAdmin();
+    // Act
+    $response = post(route('admin.auditions.store'), $changes);
+    // Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.auditions.index'))
+        ->assertSessionHasNoErrors()
+        ->assertSessionHas('success', 'Audition created successfully');
+    $checkAudition = Audition::latest()->first();
+    expect($checkAudition->scoring_guide_id)->toBe(0);
+
+});
 it('does not allow a normal user or guest to create an audition', function () {
     // Arrange
     $precount = Audition::count();
diff --git a/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php b/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php
index 92368f2..404c048 100644
--- a/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php
+++ b/tests/Feature/Pages/Setup/ScoringGuideIndexTest.php
@@ -83,3 +83,12 @@ it('only allows an admin to create a new scoring guide', function () {
     $response->assertRedirect(route('dashboard'))
         ->assertSessionHas('error', 'You are not authorized to perform this action');
 });
+it('can assign a scoring guide to an audition', function () {
+    // Arrange
+    $scoringGuide = ScoringGuide::factory()->create();
+    $audition = Audition::factory()->create();
+    // Act & Assert
+    expect($audition->scoring_guide_id)->toBeNull();
+    $response = post(route('ajax.assignScoringGuideToAudition'),
+        ['audition_id' => $audition->id, 'new_guide_id' => $scoringGuide->id]);
+});
-- 
2.39.5


From d21324b71b716bd4957876357b7ca6314a14b7e7 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 14:30:57 -0500
Subject: [PATCH 58/61] ScoringGuidePage Tests

---
 .../Admin/ScoringGuideController.php          |  21 ++-
 .../views/admin/scoring/edit-tabs.blade.php   |   7 +-
 routes/admin.php                              |   2 +-
 .../Setup/ScoringGuideEditDetailsTest.php     | 155 ++++++++++++++++++
 .../Pages/Setup/ScoringGuideOrderTabsTest.php |  54 ++++++
 5 files changed, 226 insertions(+), 13 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/ScoringGuideEditDetailsTest.php
 create mode 100644 tests/Feature/Pages/Setup/ScoringGuideOrderTabsTest.php

diff --git a/app/Http/Controllers/Admin/ScoringGuideController.php b/app/Http/Controllers/Admin/ScoringGuideController.php
index 0e84a5c..efbf8aa 100644
--- a/app/Http/Controllers/Admin/ScoringGuideController.php
+++ b/app/Http/Controllers/Admin/ScoringGuideController.php
@@ -10,6 +10,7 @@ use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\DB;
 
 use function abort;
+use function auditionSetting;
 use function request;
 use function response;
 
@@ -42,12 +43,11 @@ class ScoringGuideController extends Controller
         return redirect(route('admin.scoring.index'))->with('success', 'Scoring guide created');
     }
 
-    public function edit(Request $request, ScoringGuide $guide)
+    public function edit(Request $request, ScoringGuide $guide, string $tab = 'detail')
     {
         if (! Auth::user()->is_admin) {
             abort(403);
         }
-        $tab = $request->query('tab') ?? 'detail';
         if ($tab == 'tiebreakOrder') {
             $subscores = SubscoreDefinition::where('scoring_guide_id', $guide->id)->orderBy('tiebreak_order')->get();
         } else {
@@ -90,9 +90,6 @@ class ScoringGuideController extends Controller
 
     public function subscore_store(Request $request, ScoringGuide $guide)
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
-        }
         if (! $guide->exists()) {
             abort(409);
         }
@@ -106,6 +103,9 @@ class ScoringGuideController extends Controller
 
         $for_seating = $request->has('for_seating') ? (bool) $request->input('for_seating') : false;
         $for_advance = $request->has('for_advance') ? (bool) $request->input('for_advance') : false;
+        if (! auditionSetting('advanceTo')) {
+            $for_seating = true;
+        }
 
         $display_order = SubscoreDefinition::where('scoring_guide_id', '=', $guide->id)->max('display_order') + 1;
         $tiebreak_order = SubscoreDefinition::where('scoring_guide_id', '=', $guide->id)->max('tiebreak_order') + 1;
@@ -121,7 +121,7 @@ class ScoringGuideController extends Controller
             'for_advance' => $for_advance,
         ]);
 
-        return redirect('/admin/scoring/guides/'.$guide->id.'/edit')->with('success', 'Subscore added');
+        return redirect(route('admin.scoring.edit', $guide))->with('success', 'Subscore added');
     }
 
     public function subscore_update(ScoringGuide $guide, SubscoreDefinition $subscore)
@@ -146,6 +146,10 @@ class ScoringGuideController extends Controller
         $for_seating = request()->has('for_seating') ? (bool) request()->input('for_seating') : false;
         $for_advance = request()->has('for_advance') ? (bool) request()->input('for_advance') : false;
 
+        if (! auditionSetting('advanceTo')) {
+            $for_seating = true;
+        }
+
         $subscore->update([
             'name' => $validateData['name'],
             'max_score' => $validateData['max_score'],
@@ -175,7 +179,6 @@ class ScoringGuideController extends Controller
 
     }
 
-
     public function reorder_display(Request $request)
     {
         if (! Auth::user()->is_admin) {
@@ -184,7 +187,7 @@ class ScoringGuideController extends Controller
         $order = $request->order;
         foreach ($order as $index => $id) {
             $subscore = SubscoreDefinition::find($id);
-            $subscore->update(['display_order' => $index]);
+            $subscore->update(['display_order' => $index + 1]);
         }
 
         return response()->json(['status' => 'success']);
@@ -199,7 +202,7 @@ class ScoringGuideController extends Controller
         $order = $request->order;
         foreach ($order as $index => $id) {
             $subscore = SubscoreDefinition::find($id);
-            $subscore->update(['tiebreak_order' => $index]);
+            $subscore->update(['tiebreak_order' => $index + 1]);
         }
 
         return response()->json(['status' => 'success']);
diff --git a/resources/views/admin/scoring/edit-tabs.blade.php b/resources/views/admin/scoring/edit-tabs.blade.php
index 20ae7ba..dcd74b5 100644
--- a/resources/views/admin/scoring/edit-tabs.blade.php
+++ b/resources/views/admin/scoring/edit-tabs.blade.php
@@ -18,9 +18,10 @@
         <div class="border-b border-gray-200">
             <nav class="-mb-px flex" aria-label="Tabs">
                 <!-- Current: "border-indigo-500 text-indigo-600", Default: "border-transparent text-gray-500 hover:border-gray-300 hover:text-gray-700" -->
-                <a href="{{ request()->getPathInfo() }}?tab=detail" class="{{ $tab == 'detail' ? $active_classes : $normal_classes }}">Details</a>
-                <a href="{{ request()->getPathInfo() }}?tab=displayOrder" class="{{ $tab == 'displayOrder' ? $active_classes : $normal_classes }}">Display Order</a>
-                <a href="{{ request()->getPathInfo() }}?tab=tiebreakOrder" class="{{ $tab == 'tiebreakOrder' ? $active_classes : $normal_classes }}">Tiebreak Order</a>
+                <a href="{{ route('admin.scoring.edit',['guide'=>$guide, 'tab'=>'detail']) }}" class="{{ $tab == 'detail' ? $active_classes : $normal_classes }}">Details</a>
+                <a href="{{ route('admin.scoring.edit',['guide'=>$guide, 'tab'=>'displayOrder']) }}" class="{{ $tab == 'displayOrder' ? $active_classes : $normal_classes }}">Display Order</a>
+{{--                <a href="{{ request()->getPathInfo() }}?tab=tiebreakOrder" class="{{ $tab == 'tiebreakOrder' ? $active_classes : $normal_classes }}">Tiebreak Order</a>--}}
+                <a href="{{ route('admin.scoring.edit',['guide'=>$guide, 'tab'=>'tiebreakOrder']) }}" class="{{ $tab == 'tiebreakOrder' ? $active_classes : $normal_classes }}">Tiebreak Order</a>
             </nav>
         </div>
     </div>
diff --git a/routes/admin.php b/routes/admin.php
index 4a2d5b9..aae16f1 100644
--- a/routes/admin.php
+++ b/routes/admin.php
@@ -49,7 +49,7 @@ Route::middleware(['auth', 'verified', CheckIfAdmin::class])->prefix('admin/')->
     Route::prefix('scoring')->controller(\App\Http\Controllers\Admin\ScoringGuideController::class)->group(function () {
         Route::get('/', 'index')->name('admin.scoring.index'); // Scoring Setup Homepage
         Route::post('/guides', 'store')->name('admin.scoring.store'); // Save a new scoring guide
-        Route::get('/guides/{guide}/edit', 'edit')->name('admin.scoring.edit'); // Edit scoring guide
+        Route::get('/guides/{guide}/edit/{tab?}', 'edit')->name('admin.scoring.edit'); // Edit scoring guide
         Route::patch('/guides/{guide}/edit', 'update')->name('admin.scoring.update'); // Save changes to audition guide (rename)
         Route::post('/guides/{guide}/subscore', 'subscore_store')->name('admin.scoring.subscore_store');  // Save a new subscore
         Route::patch('/guides/{guide}/subscore/{subscore}', 'subscore_update')->name('admin.scoring.subscore_update');  // Modify a subscore
diff --git a/tests/Feature/Pages/Setup/ScoringGuideEditDetailsTest.php b/tests/Feature/Pages/Setup/ScoringGuideEditDetailsTest.php
new file mode 100644
index 0000000..a53cb82
--- /dev/null
+++ b/tests/Feature/Pages/Setup/ScoringGuideEditDetailsTest.php
@@ -0,0 +1,155 @@
+<?php
+
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use App\Settings;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+use function Pest\Laravel\post;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+    $this->scoringGuide = ScoringGuide::factory()->create();
+    $this->subscores = SubscoreDefinition::factory()->count(3)->create([
+        'scoring_guide_id' => $this->scoringGuide->id,
+    ]);
+});
+it('shows the details of a scoring guide', function () {
+    actAsAdmin();
+    $response = get(route('admin.scoring.edit', $this->scoringGuide));
+    $response->assertOk();
+    $response->assertSee($this->scoringGuide->name);
+    foreach ($this->subscores as $subscore) {
+        $response->assertSeeInOrder([
+            '<tr',
+            '<td', $subscore->name, '</td>',
+            '<td', $subscore->max_score, '</td>',
+            '<td', $subscore->weight, '</td>',
+            '<td', ($subscore->for_seating) ? 'Yes' : 'No', '</td>',
+            '<td', ($subscore->for_advance) ? 'Yes' : 'No', '</td>',
+        ], false);
+    }
+    Settings::set('advanceTo', '');
+    $response = get(route('admin.scoring.edit', $this->scoringGuide));
+    $response->assertOk();
+    $response->assertSee($this->scoringGuide->name);
+    foreach ($this->subscores as $subscore) {
+        $response->assertSeeInOrder([
+            '<tr',
+            '<td', $subscore->name, '</td>',
+            '<td', $subscore->max_score, '</td>',
+            '<td', $subscore->weight, '</td>',
+        ], false);
+        $response->assertDontSee('Yes</td>', false);
+        $response->assertDontSee('No</td>', false);
+    }
+});
+it('includes a form to add a subscore', function () {
+    // Arrange
+    actAsAdmin();
+    // Act & Assert
+    $response = get(route('admin.scoring.edit', $this->scoringGuide));
+    $response->assertOk();
+    $response->assertSee(route('admin.scoring.subscore_store', $this->scoringGuide));
+});
+it('can create a subscore', function () {
+    // Arrange
+    actAsAdmin();
+    $formData = [
+        'name' => 'New Subscore',
+        'max_score' => 32,
+        'weight' => 1,
+        'for_seating' => 1,
+    ];
+    // Act
+    $response = $this->post(route('admin.scoring.subscore_store', $this->scoringGuide), $formData);
+    // Assert
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.scoring.edit', $this->scoringGuide));
+    $this->assertDatabaseHas('subscore_definitions', $formData);
+
+});
+it('sets for_seating true for new subscores when advancement is not enabled', function () {
+    Settings::set('advanceTo', '');
+    actAsAdmin();
+    $formData = [
+        'name' => 'New Subscore',
+        'max_score' => 32,
+        'weight' => 1,
+    ];
+    $response = $this->post(route('admin.scoring.subscore_store', $this->scoringGuide), $formData);
+    $response->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.scoring.edit', $this->scoringGuide));
+    $this->assertDatabaseHas('subscore_definitions', $formData);
+    $newSubscore = SubscoreDefinition::where('name', 'New Subscore')->first();
+    expect($newSubscore->for_seating)->toBeTruthy();
+});
+it('only allows an admin to create a subscore', function () {
+    // Arrange
+    $formData = [
+        'name' => 'New Subscore',
+        'max_score' => 32,
+        'weight' => 1,
+        'for_seating' => 1,
+    ];
+    // Act & Assert
+    $response = post(route('admin.scoring.subscore_store', $this->scoringGuide), $formData);
+    $response->assertRedirect(route('home'));
+    actAsNormal();
+    $response = $this->post(route('admin.scoring.subscore_store', $this->scoringGuide), $formData);
+    $response->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+});
+it('allows a subscore to be modified', function () {
+    // Arrange
+    $subscore = SubscoreDefinition::factory()->create([
+        'scoring_guide_id' => $this->scoringGuide->id,
+    ]);
+    $formData = [
+        'name' => 'Changed Name',
+        'max_score' => 32,
+        'weight' => 1,
+        'for_seating' => 1,
+    ];
+    // Act & Assert
+    actAsAdmin();
+    $response = $this->patch(route('admin.scoring.subscore_update', [$this->scoringGuide, $subscore]), $formData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.scoring.edit', $this->scoringGuide))
+        ->assertSessionHas('success', 'Subscore updated');
+    $subscore = SubscoreDefinition::find($subscore->id);
+    expect($subscore->name)->toBe('Changed Name')
+        ->and($subscore->max_score)->toBe(32)
+        ->and($subscore->weight)->toBe(1)
+        ->and($subscore->for_seating)->toBeTruthy()
+        ->and($subscore->for_advance)->toBeFalsy();
+});
+it('sets for_seating true if advance is not enabled when modifying a subscore', function () {
+    // Arrange
+    Settings::set('advanceTo', '');
+    $subscore = SubscoreDefinition::factory()->create([
+        'scoring_guide_id' => $this->scoringGuide->id,
+    ]);
+    $formData = [
+        'name' => 'Changed Name',
+        'max_score' => 32,
+        'weight' => 1,
+    ];
+    // Act & Assert
+    actAsAdmin();
+    $response = $this->patch(route('admin.scoring.subscore_update', [$this->scoringGuide, $subscore]), $formData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertSessionHasNoErrors()
+        ->assertRedirect(route('admin.scoring.edit', $this->scoringGuide))
+        ->assertSessionHas('success', 'Subscore updated');
+    $subscore = SubscoreDefinition::find($subscore->id);
+    expect($subscore->name)->toBe('Changed Name')
+        ->and($subscore->max_score)->toBe(32)
+        ->and($subscore->weight)->toBe(1)
+        ->and($subscore->for_seating)->toBeTruthy()
+        ->and($subscore->for_advance)->toBeFalsy();
+});
diff --git a/tests/Feature/Pages/Setup/ScoringGuideOrderTabsTest.php b/tests/Feature/Pages/Setup/ScoringGuideOrderTabsTest.php
new file mode 100644
index 0000000..fb0ee46
--- /dev/null
+++ b/tests/Feature/Pages/Setup/ScoringGuideOrderTabsTest.php
@@ -0,0 +1,54 @@
+<?php
+
+use App\Models\ScoringGuide;
+use App\Models\SubscoreDefinition;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+beforeEach(function () {
+    $this->scoringGuide = ScoringGuide::factory()->create();
+    $this->subscores = SubscoreDefinition::factory()->count(6)->create([
+        'scoring_guide_id' => $this->scoringGuide->id,
+    ]);
+});
+
+it('shows subscores in display or tiebreak order', function () {
+    $scoringGuide = ScoringGuide::factory()->create();
+    $fourthSubscore = SubscoreDefinition::factory()->create([
+        'scoring_guide_id' => $scoringGuide->id,
+        'display_order' => 4,
+        'tiebreak_order' => 3,
+    ]);
+    $firstSubscore = SubscoreDefinition::factory()->create([
+        'scoring_guide_id' => $scoringGuide->id,
+        'display_order' => 1,
+        'tiebreak_order' => 4,
+    ]);
+    $thirdSubscore = SubscoreDefinition::factory()->create([
+        'scoring_guide_id' => $scoringGuide->id,
+        'display_order' => 3,
+        'tiebreak_order' => 2,
+    ]);
+    $secondSubscore = SubscoreDefinition::factory()->create([
+        'scoring_guide_id' => $scoringGuide->id,
+        'display_order' => 2,
+        'tiebreak_order' => 1,
+    ]);
+    actAsAdmin();
+    $response = get(route('admin.scoring.edit', ['guide' => $scoringGuide, 'tab' => 'displayOrder']));
+    $response->assertOk()->assertSee('Subscore Display Order')->assertSeeInOrder([
+        $firstSubscore->name,
+        $secondSubscore->name,
+        $thirdSubscore->name,
+        $fourthSubscore->name,
+    ]);
+    $response = get(route('admin.scoring.edit', ['guide' => $scoringGuide, 'tab' => 'tiebreakOrder']));
+    $response->assertOk()->assertSee('Subscore Display Order')->assertSeeInOrder([
+        $secondSubscore->name,
+        $thirdSubscore->name,
+        $fourthSubscore->name,
+        $firstSubscore->name,
+    ]);
+});
-- 
2.39.5


From cde4925368a4db70e20a4060b51521ba5a8ff3d8 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 15:17:08 -0500
Subject: [PATCH 59/61] AdminRooms Page Tests

---
 app/Http/Controllers/Admin/RoomController.php |   2 +-
 .../admin/rooms/index-room-card.blade.php     |   6 +-
 resources/views/admin/rooms/index.blade.php   |   2 +-
 tests/Feature/Pages/Setup/RoomsIndexTest.php  | 125 ++++++++++++++++++
 4 files changed, 131 insertions(+), 4 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/RoomsIndexTest.php

diff --git a/app/Http/Controllers/Admin/RoomController.php b/app/Http/Controllers/Admin/RoomController.php
index 9de1eed..a4be3cd 100644
--- a/app/Http/Controllers/Admin/RoomController.php
+++ b/app/Http/Controllers/Admin/RoomController.php
@@ -100,7 +100,7 @@ class RoomController extends Controller
         $room->description = $validData['description'];
         $room->save();
 
-        return redirect()->route('admin.rooms.index')->with('success', 'Room updated.');
+        return redirect()->route('admin.rooms.index')->with('success', 'Room updated successfully');
     }
 
     public function destroy(Room $room)
diff --git a/resources/views/admin/rooms/index-room-card.blade.php b/resources/views/admin/rooms/index-room-card.blade.php
index 624c8ef..c543b04 100644
--- a/resources/views/admin/rooms/index-room-card.blade.php
+++ b/resources/views/admin/rooms/index-room-card.blade.php
@@ -1,10 +1,12 @@
 <x-card.card x-data="{ showModal: false }" class="relative">
-    @include('admin.rooms.index-edit-room-modal')
+    @if($room->id != '0')
+        @include('admin.rooms.index-edit-room-modal')
+    @endif
     <x-card.heading @click=" showModal = ! showModal">
         {{ $room->name }}
         <x-slot:subheading>{{ $room->description }}</x-slot:subheading>
         <x-slot:right_side>
-            @if($room->entries->count() === 0 and $room->id != '0')
+            @if($room->auditions->count() === 0 and $room->id != '0')
                 <div class="flex justify-end">
                     <x-form.form method="DELETE"
                                  action="{{ route('admin.rooms.destroy', ['room'=>$room->id]) }}"
diff --git a/resources/views/admin/rooms/index.blade.php b/resources/views/admin/rooms/index.blade.php
index dd5c4b6..02ddc49 100644
--- a/resources/views/admin/rooms/index.blade.php
+++ b/resources/views/admin/rooms/index.blade.php
@@ -1,6 +1,6 @@
 <x-layout.app>
     <x-slot:page_title>Rooms</x-slot:page_title>
-    <x-slot:title_bar_right><x-form.button href="/admin/rooms/create">New Room</x-form.button></x-slot:title_bar_right>
+    <x-slot:title_bar_right><x-form.button href="{{route('admin.rooms.create')}}">New Room</x-form.button></x-slot:title_bar_right>
     <!--suppress JSUnresolvedReference -->
     <div class="grid md:grid-cols-4 gap-5" x-data="roomManager()">
 
diff --git a/tests/Feature/Pages/Setup/RoomsIndexTest.php b/tests/Feature/Pages/Setup/RoomsIndexTest.php
new file mode 100644
index 0000000..7343fbd
--- /dev/null
+++ b/tests/Feature/Pages/Setup/RoomsIndexTest.php
@@ -0,0 +1,125 @@
+<?php
+
+use App\Models\Audition;
+use App\Models\Entry;
+use App\Models\Room;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+use function Pest\Laravel\get;
+
+uses(RefreshDatabase::class);
+
+function roomTestSetup(): void
+{
+    $rooms = Room::factory()->count(3)->create();
+    foreach ($rooms as $room) {
+        Audition::factory()->count(3)->create(['room_id' => $room->id]);
+    }
+    $auditions = Audition::all();
+    foreach ($auditions as $audition) {
+        $n = fake()->numberBetween(1, 4);
+        Entry::factory()->count($n)->create(['audition_id' => $audition->id]);
+    }
+}
+
+it('only allows an admin to manage rooms', function () {
+    get(route('admin.rooms.index'))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    get(route('admin.rooms.index'))
+        ->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actAsAdmin();
+    get(route('admin.rooms.index'))
+        ->assertOk();
+});
+it('has a link to create a new room', function () {
+    actAsAdmin();
+    get(route('admin.rooms.index'))
+        ->assertSee('New Room')
+        ->assertSee(route('admin.rooms.create'));
+});
+it('has a card for each room, including the total number of entries in that room', function () {
+    // Arrange
+    roomTestSetup();
+    // Act & Assert
+    actAsAdmin();
+    $response = get(route('admin.rooms.index'));
+    $response->assertOk();
+    foreach (Room::all() as $room) {
+        $roomEntryCount = $room->entries()->count();
+        $response->assertSeeInOrder(['<h3', e($room->name), '</h3>', $roomEntryCount], false);
+    }
+});
+it('has a form for editing each room', function () {
+    // Arrange
+    roomTestSetup();
+    // Act & Assert
+    actAsAdmin();
+    $response = get(route('admin.rooms.index'));
+    $response->assertOk();
+    foreach (Room::all() as $room) {
+        if ($room->id === 0) {
+            continue;
+        }
+        $response->assertSeeInOrder([
+            route('admin.rooms.update', $room),
+            '<input',
+            'name=', 'name',
+            '<input',
+            'name=',
+            'description',
+        ], false);
+    }
+});
+it('can edit a room', function () {
+    $room = Room::factory()->create();
+    $formData = [
+        'name' => 'New Room Name',
+        'description' => 'New Room Description',
+    ];
+    actAsAdmin();
+    $response = $this->patch(route('admin.rooms.update', $room), $formData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.rooms.index'))
+        ->assertSessionHas('success', 'Room updated successfully')
+        ->assertSessionHasNoErrors();
+    $this->assertDatabaseHas('rooms', $formData);
+});
+it('can create a room', function () {
+    $formData = [
+        'name' => 'New Room Name',
+        'description' => 'New Room Description',
+    ];
+    actAsAdmin();
+    $response = $this->post(route('admin.rooms.store'), $formData);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.rooms.index'))
+        ->assertSessionHas('success', 'Room created.')
+        ->assertSessionHasNoErrors();
+    $this->assertDatabaseHas('rooms', $formData);
+});
+
+it('can delete a room', function () {
+    // Arrange
+    $room = Room::factory()->create();
+    // Act & Assert
+    actAsAdmin();
+    $response = $this->delete(route('admin.rooms.destroy', $room));
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.rooms.index'))
+        ->assertSessionHas('success', 'Room deleted.')
+        ->assertSessionHasNoErrors();
+    $this->assertDatabaseMissing('rooms', ['id' => $room->id]);
+});
+it('will not delete a room with auditions', function () {
+    $room = Room::factory()->create();
+    Audition::factory()->create(['room_id' => $room->id]);
+    actAsAdmin();
+    $response = $this->delete(route('admin.rooms.destroy', $room));
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.rooms.index'))
+        ->assertSessionHas('error',
+            'Cannot delete room with auditions. First move the auditions to unassigned or another room')
+        ->assertSessionHasNoErrors();
+});
-- 
2.39.5


From 33d0b6ca55fb7ba5d4b1488a5d631d2683487c78 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 15:21:54 -0500
Subject: [PATCH 60/61] Require unique room name on factory

---
 database/factories/RoomFactory.php       | 2 +-
 tests/Feature/Pages/EntriesIndexTest.php | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/database/factories/RoomFactory.php b/database/factories/RoomFactory.php
index 46acabf..f20bf5a 100644
--- a/database/factories/RoomFactory.php
+++ b/database/factories/RoomFactory.php
@@ -17,7 +17,7 @@ class RoomFactory extends Factory
     public function definition(): array
     {
         return [
-            'name' => 'Room '.fake()->numberBetween(7, 500),
+            'name' => 'Room '.fake()->unique()->numberBetween(7, 500),
             'description' => fake()->sentence(),
         ];
     }
diff --git a/tests/Feature/Pages/EntriesIndexTest.php b/tests/Feature/Pages/EntriesIndexTest.php
index e633133..e8b2d20 100644
--- a/tests/Feature/Pages/EntriesIndexTest.php
+++ b/tests/Feature/Pages/EntriesIndexTest.php
@@ -90,9 +90,9 @@ it('shows existing entries in a table', function () {
         $response->
         assertSeeInOrder([
             '<td',
-            $entry->student->full_name(true),
+            e($entry->student->full_name(true)),
             $entry->student->grade,
-            $entry->audition->name,
+            e($entry->audition->name),
             '</td>',
         ], false);
     }
-- 
2.39.5


From 252c7e758a2b139739e4851e18a13912325922a9 Mon Sep 17 00:00:00 2001
From: Matt Young <matt@mattyoung.us>
Date: Fri, 5 Jul 2024 16:07:35 -0500
Subject: [PATCH 61/61] AdminJudging Page

---
 app/Http/Controllers/Admin/RoomController.php |  3 -
 .../admin/rooms/judge_assignments.blade.php   |  6 +-
 .../Feature/Pages/Setup/JudgingIndexTest.php  | 74 +++++++++++++++++++
 3 files changed, 77 insertions(+), 6 deletions(-)
 create mode 100644 tests/Feature/Pages/Setup/JudgingIndexTest.php

diff --git a/app/Http/Controllers/Admin/RoomController.php b/app/Http/Controllers/Admin/RoomController.php
index a4be3cd..4f1cee1 100644
--- a/app/Http/Controllers/Admin/RoomController.php
+++ b/app/Http/Controllers/Admin/RoomController.php
@@ -24,9 +24,6 @@ class RoomController extends Controller
 
     public function judgingAssignment() // Show form for assigning judges
     {
-        if (! Auth::user()->is_admin) {
-            abort(403);
-        }
         $usersWithoutRooms = User::doesntHave('rooms')->orderBy('last_name')->orderBy('first_name')->get();
         $usersWithRooms = User::has('rooms')->orderBy('last_name')->orderBy('first_name')->get();
         $rooms = Room::with(['judges.school', 'auditions'])->get();
diff --git a/resources/views/admin/rooms/judge_assignments.blade.php b/resources/views/admin/rooms/judge_assignments.blade.php
index a42f3d3..6ae2aec 100644
--- a/resources/views/admin/rooms/judge_assignments.blade.php
+++ b/resources/views/admin/rooms/judge_assignments.blade.php
@@ -5,7 +5,7 @@
             @if($room->id == 0)
                 @continue
             @endif
-            <li class=" rounded-xl border border-gray-200 bg-gray-50 "> {{-- card wrapper --}}
+            <li id="room-{{$room->id}}-card" class=" rounded-xl border border-gray-200 bg-gray-50 "> {{-- card wrapper --}}
                 <div class="flex items-center gap-x-4 border-b border-gray-900/5 bg-white pt-2 pb-6 px-6"> {{-- card header --}}
                     <div class="text-sm font-medium leading-6 text-gray-900">
                         <p class="text-sm font-medium leading-6 text-gray-900">{{ $room->name }}</p>
@@ -60,8 +60,8 @@
                         <div class="flex justify-between items-center gap-x-4 py-1"> {{-- Judge Line --}}
                             <dt>
                                 <p>
-                                    <span class="text-gray-700">{{ $judge->full_name() }}, </span>
-                                    <span class="text-gray-500 text-xs">{{ $judge->school->name }}</span>
+                                    <span class="text-gray-700">{{ $judge->full_name() }} </span>
+                                    <span class="text-gray-500 text-xs">{{ $judge->school->name ?? '' }}</span>
                                 </p>
                                 <p class="text-gray-500 text-xs">{{ $judge->judging_preference }}</p>
                             </dt>
diff --git a/tests/Feature/Pages/Setup/JudgingIndexTest.php b/tests/Feature/Pages/Setup/JudgingIndexTest.php
new file mode 100644
index 0000000..13bf112
--- /dev/null
+++ b/tests/Feature/Pages/Setup/JudgingIndexTest.php
@@ -0,0 +1,74 @@
+<?php
+
+use App\Models\Room;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Sinnbeck\DomAssertions\Asserts\AssertElement;
+
+uses(RefreshDatabase::class);
+
+it('only allows admin users to manage judging assignments', function () {
+    $this->get(route('admin.rooms.judgingAssignment'))
+        ->assertRedirect(route('home'));
+    actAsNormal();
+    $this->get(route('admin.rooms.judgingAssignment'))
+        ->assertRedirect(route('dashboard'))
+        ->assertSessionHas('error', 'You are not authorized to perform this action');
+    actAsAdmin();
+    $this->get(route('admin.rooms.judgingAssignment'))
+        ->assertOk();
+});
+it('shows a card for each room with its judges', function () {
+    // Arrange
+    $rooms = Room::factory()->count(3)->create();
+    foreach ($rooms as $room) {
+        $users = User::factory()->count(3)->create();
+        foreach ($users as $user) {
+            $room->addJudge($user->id);
+        }
+    }
+    // Act & Assert
+    actAsAdmin();
+    $response = $this->get(route('admin.rooms.judgingAssignment'));
+    $response->assertOk();
+    foreach ($rooms as $room) {
+        $response->assertElementExists('#room-'.$room->id.'-card', function (AssertElement $element) use ($room) {
+            $element->is('li');
+            $element->containsText($room->name);
+            foreach ($room->judges as $judge) {
+                $element->containsText($judge->full_name());
+            }
+        });
+    }
+});
+it('can assign a judge', function () {
+    // Arrange
+    $room = Room::factory()->create();
+    $judge = User::factory()->create();
+    // Act & Assert
+    expect($room->judges->contains($judge))->toBeFalse();
+    actAsAdmin();
+    $response = $this->post(route('admin.rooms.updateJudgeAssignment', $room), ['judge' => $judge->id]);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.rooms.judgingAssignment'))
+        ->assertSessionHas('success', 'Assigned '.$judge->full_name().' to '.$room->name)
+        ->assertSessionHasNoErrors();
+    $checkRoom = Room::find($room->id);
+    expect($checkRoom->judges->contains($judge))->toBeTrue();
+});
+it('can remove a judge', function () {
+    // Arrange
+    $room = Room::factory()->create();
+    $judge = User::factory()->create();
+    $room->addJudge($judge->id);
+    expect($room->judges->contains($judge))->toBeTrue();
+    actAsAdmin();
+    // Act & Assert
+    $response = $this->delete(route('admin.rooms.updateJudgeAssignment', $room), ['judge' => $judge->id]);
+    /** @noinspection PhpUnhandledExceptionInspection */
+    $response->assertRedirect(route('admin.rooms.judgingAssignment'))
+        ->assertSessionHas('success', 'Removed '.$judge->full_name().' from '.$room->name)
+        ->assertSessionHasNoErrors();
+    $checkRoom = Room::find($room->id);
+    expect($checkRoom->judges->contains($judge))->toBeFalse();
+});
-- 
2.39.5