Write tests - Write tests for what was done to this point that will be kept #11

Merged
okorpheus merged 61 commits from write-tests into master 2024-07-05 21:21:32 +00:00
4 changed files with 193 additions and 9 deletions
Showing only changes of commit df4095d45a - Show all commits

View File

@ -67,12 +67,16 @@ class EnsembleController extends Controller
public function seatingLimits(Ensemble $ensemble)
{
$ensembles = Ensemble::with('event')->orderBy('event_id')->get();
$limits = [];
$ensembles = Ensemble::with(['event'])->orderBy('event_id')->get();
if ($ensemble->exists()) {
$ensemble->load('seatingLimits');
foreach ($ensemble->seatingLimits as $lim) {
$limits[$lim->audition_id] = $lim->maximum_accepted;
}
}
return view('admin.ensembles.seatingLimits', compact('ensemble', 'ensembles'));
return view('admin.ensembles.seatingLimits', compact('ensemble', 'ensembles', 'limits'));
}
public function seatingLimitsSet(Request $request, Ensemble $ensemble)
@ -96,7 +100,7 @@ class EnsembleController extends Controller
);
}
return redirect()->route('admin.ensembles.seatingLimits')->with('success',
return redirect()->route('admin.ensembles.seatingLimits.ensemble', $ensemble)->with('success',
'Seating limits set for '.$ensemble->name);
}

View File

@ -1,9 +1,8 @@
@php
$limits = [];
foreach ($ensemble->seatingLimits as $lim) {
$limits[$lim->audition_id] = $lim->maximum_accepted;
}
/**
* @var \App\Models\Ensemble $ensemble The ensemble for which a seating form is shown
* @var array $limits An array of audition_id => maximum_accepted for the ensemble
**/
@endphp
<x-card.card class="mt-5 max-w-md mx-auto">
<x-card.heading>{{ $ensemble->name }}</x-card.heading>

View File

@ -11,7 +11,14 @@
`{{ route('admin.ensembles.seatingLimits') }}/${event.target.value}`">
<option value=""></option>
@foreach($ensembles as $optionEnsemble)
<option value ="{{$optionEnsemble->id}}">{{$optionEnsemble->event->name}} - {{$optionEnsemble->name}}</option>
@php
if ($ensemble && $ensemble->id == $optionEnsemble->id) {
$selected = 'selected';
} else {
$selected = '';
}
@endphp
<option value ="{{$optionEnsemble->id}}" {{$selected}}>{{$optionEnsemble->event->name}} - {{$optionEnsemble->name}}</option>
@endforeach
</x-form.select>
</div>

View File

@ -0,0 +1,174 @@
<?php
use App\Models\Audition;
use App\Models\Ensemble;
use App\Models\SeatingLimit;
use Illuminate\Foundation\Testing\RefreshDatabase;
use function Pest\Laravel\get;
use function Pest\Laravel\post;
uses(RefreshDatabase::class);
it('only allows admin to manage seating limits', function () {
get(route('admin.ensembles.seatingLimits'))
->assertRedirect(route('home'));
actAsNormal();
get(route('admin.ensembles.seatingLimits'))
->assertRedirect('/dashboard')
->assertSessionHas('error', 'You are not authorized to perform this action');
actAsAdmin();
get(route('admin.ensembles.seatingLimits'))
->assertOk();
});
it('shows a dropdown of ensembles', function () {
// Arrange
$ensembles = Ensemble::factory()->count(5)->create();
actAsAdmin();
// Act & Assert
$response = get(route('admin.ensembles.seatingLimits'));
$response->assertOk();
foreach ($ensembles as $ensemble) {
$response->assertSeeInOrder([
'<option', 'value="', $ensemble->id, e($ensemble->event->name), ' - ', e($ensemble->name), '</option>',
], false);
}
});
it('shows a seating list from when called with an ensemble id', function () {
// Arrange
$ensembles = Ensemble::factory()->count(5)->create();
// Act & Assert
actAsAdmin();
foreach ($ensembles as $ensemble) {
$response = get(route('admin.ensembles.seatingLimits.ensemble', $ensemble));
$response->assertOk();
$response->assertSeeInOrder(['<h3', e($ensemble->name), '</h3>'], false);
$response->assertSee(route('admin.ensembles.seatingLimits.ensemble.set', $ensemble));
}
});
it('shows a field for each audition for a called ensemble', function () {
// Arrange
$ensemble = Ensemble::factory()->create();
$auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
foreach ($auditions as $audition) {
SeatingLimit::create([
'ensemble_id' => $ensemble->id,
'audition_id' => $audition->id,
'maximum_accepted' => fake()->numberBetween(1, 15),
]);
}
// Act & Assert
actAsAdmin();
$response = get(route('admin.ensembles.seatingLimits.ensemble', $ensemble));
$response->assertOk()
->assertSeeInOrder(['<h3', e($ensemble->name), '</h3>'], false);
foreach ($auditions as $audition) {
$response->assertSeeInOrder([
'<li', '<label', 'for=', 'audition-'.$audition->id, e($audition->name), '<input', 'name=', 'audition[',
$audition->id, ']', '</li>',
], false);
}
});
it('shows existing seating limits on the fields', function () {
// Arrange
$ensemble = Ensemble::factory()->create();
$auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
foreach ($auditions as $audition) {
SeatingLimit::create([
'ensemble_id' => $ensemble->id,
'audition_id' => $audition->id,
'maximum_accepted' => fake()->numberBetween(1, 15),
]);
}
// Act & Assert
actAsAdmin();
$response = get(route('admin.ensembles.seatingLimits.ensemble', $ensemble));
$response->assertOk();
foreach ($auditions as $audition) {
$limit = $ensemble->seatingLimits->where('audition_id', $audition->id)->first()->maximum_accepted;
$response->assertSeeInOrder([
'<input', 'name="audition['.$audition->id.']"', 'value="', $limit, '"',
], false);
}
});
it('allows an administrator to modify seating limits', function () {
// Arrange
$ensemble = Ensemble::factory()->create();
$auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
foreach ($auditions as $audition) {
SeatingLimit::create([
'ensemble_id' => $ensemble->id,
'audition_id' => $audition->id,
'maximum_accepted' => fake()->numberBetween(1, 15),
]);
}
$newData = [
'audition' => [],
];
foreach ($auditions as $audition) {
$newData['audition'][$audition->id] = 21;
}
// Act & Assert
actAsAdmin();
$response = post(route('admin.ensembles.seatingLimits.ensemble.set', $ensemble), $newData);
/** @noinspection PhpUnhandledExceptionInspection */
$response->assertSessionHasNoErrors()
->assertSessionHas('success', 'Seating limits set for '.$ensemble->name)
->assertRedirect(route('admin.ensembles.seatingLimits.ensemble', $ensemble));
$check = Ensemble::find($ensemble->id);
foreach ($check->seatingLimits as $seatingLimit) {
expect($seatingLimit->maximum_accepted)->toBe(21);
}
});
it('does not allow a guest to update seating limits', function () {
// Arrange
$ensemble = Ensemble::factory()->create();
$auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
foreach ($auditions as $audition) {
SeatingLimit::create([
'ensemble_id' => $ensemble->id,
'audition_id' => $audition->id,
'maximum_accepted' => fake()->numberBetween(1, 15),
]);
}
$newData = [
'audition' => [],
];
foreach ($auditions as $audition) {
$newData['audition'][$audition->id] = 21;
}
$response = post(route('admin.ensembles.seatingLimits.ensemble.set', $ensemble), $newData);
$response->assertRedirect(route('home'));
$check = Ensemble::find($ensemble->id);
foreach ($check->seatingLimits as $seatingLimit) {
expect($seatingLimit->maximum_accepted)->toBeLessThan(16);
}
});
it('does not allow a normal user to update seating limits', function () {
// Arrange
$ensemble = Ensemble::factory()->create();
$auditions = Audition::factory()->count(5)->create(['event_id' => $ensemble->event_id]);
foreach ($auditions as $audition) {
SeatingLimit::create([
'ensemble_id' => $ensemble->id,
'audition_id' => $audition->id,
'maximum_accepted' => fake()->numberBetween(1, 15),
]);
}
$newData = [
'audition' => [],
];
foreach ($auditions as $audition) {
$newData['audition'][$audition->id] = 21;
}
actAsNormal();
$response = post(route('admin.ensembles.seatingLimits.ensemble.set', $ensemble), $newData);
$response->assertRedirect(route('dashboard'))
->assertSessionHas('error', 'You are not authorized to perform this action');
$check = Ensemble::find($ensemble->id);
foreach ($check->seatingLimits as $seatingLimit) {
expect($seatingLimit->maximum_accepted)->toBeLessThan(16);
}
});